From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1032A2EEB for ; Mon, 7 Oct 2019 03:27:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3CEA51D166; Mon, 7 Oct 2019 03:27:55 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 57C821D14F for ; Mon, 7 Oct 2019 03:27:53 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x971KhIA026575; Sun, 6 Oct 2019 18:27:51 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=9liclB0RE2kYc0VvpyDpOsFBeCd5GhmZC6MOTqlDSwY=; b=fJGiBNbskSCVw0VYHr6nbSWjzUR9PQtl+YTz3z+bP1P8ZGVib8G0emAleRSRlvrgy7dD rdaWkeY7co0k7ZaZENoLb/Z122cjTYrYwOzCXnm2mz6Lp9173FkXg6otPy+b+AvuSfFF pd+ozBixHXR4B5EEKEyiW8mz0hdF4XZxstwYm2Sv9Jm1EwDJyXhjdlRvD5t+lhM3HKY4 oDD2OAWcBGXM3HvOaei9Sn3/BQqK3k7SzJCtWg7YYFtojDvEB12xRkX0+QYW306ZImQs pe8v5du8qzJQjdnZlPg4SIU/fNRAaS4t2mtcVRn6CSHDH2BUnH5P2zCICBRsEJS2tzmd qw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2verhrcsak-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Sun, 06 Oct 2019 18:27:51 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sun, 6 Oct 2019 18:27:50 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.55) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sun, 6 Oct 2019 18:27:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=If5wWQXhx4aUbbh7gMYMAdjwthv3M5q2/9VPGyK+Ejr44YoT+dF4QuUt66H1iQ2V7KH+82jD9qv/4bPktQ07opY7Y5pd71KjQhuVo2DXGtAaiMhYVfEtKaZ6P9MLZOQEP6Sco9A6TsTuK/3QKcNam9HSRJz+2T1/TAcSQdkOwh5Qw+ZYfZdneXcBWfzBpil1/4y4HqI28zWec6fulZ11y1AWLwaoTpb5lsud/GTY0mMQm1Fp1/0Mc+ESr8owre/F/LqQbFhuDJxAdZgUe3OexYyoj0AL9hIM8qk/H4PrjciTtlwLL1BMigIhTtrd667tPVJiM16AtREVAEM3tpN78A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9liclB0RE2kYc0VvpyDpOsFBeCd5GhmZC6MOTqlDSwY=; b=EqlzE4fEw+MSWEvb7jeg5yvpVWsj69v2El6/UUrZ5SGQ9Yv3wiJiBqsGGthLivkl4l7o+mcXYZSd12ZWccKLRNoXt33Vku9rvmkJweH/FBC0xAbPIGreogr5zIBPK1TLvjz3+6PHW/dVqsYNaFyvzSejWmCauIkTibLrnXRZOmqDTiQdAEk0Q4JI2kmDkB1W9lb26UtkX5nSzmZ7fxs9kylVSxCa8v8Lq1X1/VsdsVSsm3f7bSNGnEr1CHtLPmEeS+fP3OeOG6H3p1NxGxsd0b5gu14rcHr54Dbuzixdi/jg9ZTWVN/1Q6hJrmNUBQafcaw6poavVJ6/3acKmxw/Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9liclB0RE2kYc0VvpyDpOsFBeCd5GhmZC6MOTqlDSwY=; b=UPw5OeTb898/VBMzY4AymXTYVd2HOlVS985GmyWYezOLtaKQWNqHHKNcfxpdKWIE5F5PYiprV+vvjiNmI6TGGwyQcAWpqf6f54wZK1DH03Yqli246xRbc27dIe2V3es5cGtfKeDtf7i3+vmn4KiQeiOMbBzDrPG1jwi7y+Zwujk= Received: from BN6PR18MB1634.namprd18.prod.outlook.com (10.175.194.139) by BN6PR18MB1604.namprd18.prod.outlook.com (10.175.195.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Mon, 7 Oct 2019 01:27:48 +0000 Received: from BN6PR18MB1634.namprd18.prod.outlook.com ([fe80::fdf2:a67c:ebf4:c89]) by BN6PR18MB1634.namprd18.prod.outlook.com ([fe80::fdf2:a67c:ebf4:c89%8]) with mapi id 15.20.2305.023; Mon, 7 Oct 2019 01:27:48 +0000 From: Vamsi Krishna Attunuru To: Gaetan Rivet , "dev@dpdk.org" CC: Ferruh Yigit , Anatoly Burakov , Thomas Monjalon , "Jerin Jacob Kollanukkaran" , David Marchand Thread-Topic: [dpdk-dev] [PATCH v3] eal: add manual probing option Thread-Index: AQHVerL+9r63gEcpPUOb/iFW5N4Ba6dOXfFg Date: Mon, 7 Oct 2019 01:27:48 +0000 Message-ID: References: <6fff088fbca661b574b5cf27ebb924a690ed7d51.1570089310.git.gaetan.rivet@6wind.com> <5b8ee6827c26356cc009b0b3ff5b8d142b009fa7.1570193349.git.gaetan.rivet@6wind.com> In-Reply-To: <5b8ee6827c26356cc009b0b3ff5b8d142b009fa7.1570193349.git.gaetan.rivet@6wind.com> Accept-Language: en-US Content-Language: en-US X-Mentions: gaetan.rivet@6wind.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.44.10.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebb2c556-81b0-440d-5201-08d74ac59031 x-ms-traffictypediagnostic: BN6PR18MB1604: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:155; x-forefront-prvs: 01834E39B7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39850400004)(346002)(136003)(376002)(396003)(366004)(199004)(189003)(13464003)(5660300002)(86362001)(14444005)(5024004)(256004)(7696005)(52536014)(66476007)(66556008)(66946007)(66446008)(71190400001)(64756008)(71200400001)(53546011)(229853002)(8676002)(6506007)(76116006)(6436002)(99286004)(55016002)(478600001)(14454004)(76176011)(9686003)(6246003)(66066001)(476003)(26005)(30864003)(110136005)(316002)(446003)(486006)(102836004)(8936002)(4326008)(305945005)(81156014)(7736002)(11346002)(74316002)(81166006)(2906002)(54906003)(25786009)(3846002)(6116002)(33656002)(186003)(2501003)(309714004); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR18MB1604; H:BN6PR18MB1634.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CncDHJjjlt6dlT4vy41G04Pbiwdacetf0wUVYxi8rDxuliq8njeRE7Gg7k+paroTO5C7ahd+IW7Bv1SlXtm7qndee3ivPm3dj1LSEY7l2D9/ujgbWiRsmmxHE8C9xplUIk1LYRB16Nn/VzF+/4mnIF5ZZDkRGGhD4zPydnX4+6nmLd7kMvG9iAtQhuv3xKRNg+UQKzH3PNyJblnlqrbnhVr8XsnTCWR74ZD0RRCmOBp2br6r6yAABE/dRBckvDwT0+JzLOeHWGafh6u119I57Q503bhxRFMVIHUejapzyvXZolyYfUmeZ1WZMLpdI5oM0hv4hXQYu/ljPcQ+yMWyKU/bT6xF4U/i62CHyLY4BNn/0A56VrurqS3IyOLk02UdH8ml5wTBUIxV8cqK4L1Qu7vg5YvJPwi7yKoo93Dxd0w= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ebb2c556-81b0-440d-5201-08d74ac59031 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2019 01:27:48.3089 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mx9qTV6hGiLLnEuozrRd2er86QS+CLmB00cazQptmHnNGUzNdK+vOPrkpkoG7YZoNVKEwNWF13LbXYKKbHG9NQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1604 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,1.0.8 definitions=2019-10-06_08:2019-10-03,2019-10-06 signatures=0 Subject: Re: [dpdk-dev] [PATCH v3] eal: add manual probing option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Gaetan Rivet > Sent: Friday, October 4, 2019 6:25 PM > To: dev@dpdk.org; Vamsi Krishna Attunuru > Cc: Gaetan Rivet ; Ferruh Yigit > ; Anatoly Burakov ; > Thomas Monjalon ; Jerin Jacob Kollanukkaran > ; David Marchand > Subject: [dpdk-dev] [PATCH v3] eal: add manual probing option >=20 > Add a new EAL option enabling manual probing in the EAL. > This command line option will configure the EAL so that buses will not tr= igger > their probe step on their own. >=20 > Applications are then expected to hotplug devices as they see fit. >=20 > Devices declared on the command line by the user (using -w and --vdev), w= ill > be probed using the hotplug API, in the order they are declared. >=20 > This has the effect of offering a way for users to control probe order of= their > devices, for drivers requiring it. >=20 > Signed-off-by: Gaetan Rivet > --- >=20 > I haven't heard many opinions on the matter, please shout if you see an > issue with this approach. >=20 > @Slava: I have tested rather quickly that it does not break anything, > and that it works as intended for basic cases. > Can you test it further for your use-case and tell me if it works= fine? >=20 > Beyond the obvious difference between both probe mode, something to > keep in mind: > while using -w on invalid devices would not block (PCI) bus probing, it w= ill > stop manual probing in its track. All devices need to exist and be valid = device > IDs. >=20 > v2: fixed a few typos, map file (and used Travis to validate). >=20 > Slava, are you able to test this patch? >=20 > v3: properly fixed the map file (herited 19.08 instead of 19.05). >=20 > Added a function to set the probe manual from the application, > without having the user do it from the command line. >=20 > Stopped spamming Slava about it, Vamsi was actually the one intereste= d in > it! @Gaetan: Thanks a lot for providing this patch. I have tested it in our use= cases and it works as expected, also verified multiple combinations by passing whitelisted pdevs, vdevs and mix of both. Probing sequence happens as requi= red. Acked-by : Vamsi Attunuru < vattunuru@marvell.com > Tested-by: Vamsi Attunuru < vattunuru@marvell.com > >=20 > Standing issue worth chiming in: >=20 > Currently manual-probe will cut off probing from all buses. > It could be interesting to be able to only cut buses supporting hotplug= , > given that they are the one able to probe devices afterward. >=20 > No real use-case for this right now, so leaving as-is. Might be worth > considering in the future. >=20 > doc/guides/rel_notes/release_19_11.rst | 9 +++++++ > lib/librte_eal/common/eal_common_bus.c | 6 +++++ > lib/librte_eal/common/eal_common_dev.c | 41 > ++++++++++++++++++++++++++++++ > lib/librte_eal/common/eal_common_options.c | 8 ++++++ > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_options.h | 2 ++ > lib/librte_eal/common/eal_private.h | 9 +++++++ > lib/librte_eal/common/include/rte_eal.h | 34 > +++++++++++++++++++++++++ > lib/librte_eal/freebsd/eal/eal.c | 10 ++++++++ > lib/librte_eal/linux/eal/eal.c | 10 ++++++++ > lib/librte_eal/rte_eal_version.map | 8 ++++++ > 11 files changed, 138 insertions(+) >=20 > diff --git a/doc/guides/rel_notes/release_19_11.rst > b/doc/guides/rel_notes/release_19_11.rst > index 27cfbd9e3..700f9a726 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -56,6 +56,15 @@ New Features > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* **EAL will now allow manual probing devices.** > + > + Previously, a user could not force an order when probing declared devi= ces. > + This could cause issues for drivers depending on another device being > present. > + A new option ``--manual-probe`` is now available to do just that. > + This new option relies on the device bus supporting hotplug. It can > + also be used to disable automatic probing from the ``PCI`` bus without > + having to disable the whole bus. > + >=20 > Removed Items > ------------- > diff --git a/lib/librte_eal/common/eal_common_bus.c > b/lib/librte_eal/common/eal_common_bus.c > index baa5b532a..145a96812 100644 > --- a/lib/librte_eal/common/eal_common_bus.c > +++ b/lib/librte_eal/common/eal_common_bus.c > @@ -6,6 +6,7 @@ > #include > #include >=20 > +#include > #include > #include > #include > @@ -63,6 +64,11 @@ rte_bus_probe(void) > int ret; > struct rte_bus *bus, *vbus =3D NULL; >=20 > + if (rte_eal_manual_probe()) { > + RTE_LOG(DEBUG, EAL, "Manual probing enabled.\n"); > + return rte_dev_probe_devargs_list(); > + } > + > TAILQ_FOREACH(bus, &rte_bus_list, next) { > if (!strcmp(bus->name, "vdev")) { > vbus =3D bus; > diff --git a/lib/librte_eal/common/eal_common_dev.c > b/lib/librte_eal/common/eal_common_dev.c > index 9e4f09d83..f4ce1c56c 100644 > --- a/lib/librte_eal/common/eal_common_dev.c > +++ b/lib/librte_eal/common/eal_common_dev.c > @@ -109,6 +109,47 @@ build_devargs(const char *busname, const char > *devname, } >=20 > int > +rte_dev_probe_devargs_list(void) > +{ > + struct rte_device *dev; > + struct rte_devargs *da; > + int ret; > + > + RTE_EAL_DEVARGS_FOREACH(NULL, da) { > + dev =3D da->bus->find_device(NULL, cmp_dev_name, da- > >name); > + if (dev =3D=3D NULL) { > + RTE_LOG(ERR, EAL, "Unable to find device %s on bus > %s\n", > + da->name, da->bus->name); > + continue; > + } > + > + if (rte_dev_is_probed(dev)) > + continue; > + > + if (dev->bus->plug =3D=3D NULL) { > + RTE_LOG(ERR, EAL, "Manual probing (hotplug) not > supported by bus %s, " > + "required by device %s\n", > + dev->bus->name, dev->name); > + continue; > + } > + > + ret =3D dev->bus->plug(dev); > + /* Ignore positive return values, they are possibly > + * triggered by blacklisted devices on the PCI bus. Probing > + * should then continue. > + */ > + if (ret < 0) { > + RTE_LOG(ERR, EAL, "Driver cannot attach device > %s\n", > + dev->name); > + /* Fail on first real probe error. */ > + return ret; > + } > + } > + > + return 0; > +} > + > +int > rte_eal_hotplug_add(const char *busname, const char *devname, > const char *drvargs) > { > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 05cae5f75..66c232b14 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -81,6 +81,7 @@ eal_long_options[] =3D { > {OPT_LEGACY_MEM, 0, NULL, OPT_LEGACY_MEM_NUM }, > {OPT_SINGLE_FILE_SEGMENTS, 0, NULL, > OPT_SINGLE_FILE_SEGMENTS_NUM}, > {OPT_MATCH_ALLOCATIONS, 0, NULL, > OPT_MATCH_ALLOCATIONS_NUM}, > + {OPT_MANUAL_PROBE, 0, NULL, OPT_MANUAL_PROBE_NUM }, > {0, 0, NULL, 0 } > }; >=20 > @@ -1408,6 +1409,9 @@ eal_parse_common_option(int opt, const char > *optarg, > return -1; > } > break; > + case OPT_MANUAL_PROBE_NUM: > + conf->manual_probe =3D 1; > + break; >=20 > /* don't know what to do, leave this to caller */ > default: > @@ -1634,6 +1638,10 @@ eal_common_usage(void) > " --"OPT_VDEV" Add a virtual device.\n" > " The argument format is [,key= =3Dval,...]\n" > " (ex: --vdev=3Dnet_pcap0,iface=3Deth2).\n" > + " --"OPT_MANUAL_PROBE" Enable manual probing.\n" > + " Disable probe step for all buses.\n" > + " Devices will need to be probed using the = hotplug > API.\n" > + " PCI and vdev declarations will be treated= in order as > hotplug commands.\n" > " --"OPT_IOVA_MODE" Set IOVA mode. 'pa' for IOVA_PA\n" > " 'va' for IOVA_VA\n" > " -d LIB.so|DIR Add a driver or driver directory\n" > diff --git a/lib/librte_eal/common/eal_internal_cfg.h > b/lib/librte_eal/common/eal_internal_cfg.h > index a42f34923..0006f903f 100644 > --- a/lib/librte_eal/common/eal_internal_cfg.h > +++ b/lib/librte_eal/common/eal_internal_cfg.h > @@ -44,6 +44,7 @@ struct internal_config { > unsigned hugepage_unlink; /**< true to unlink backing files */ > volatile unsigned no_pci; /**< true to disable PCI */ > volatile unsigned no_hpet; /**< true to disable HPET */ > + volatile unsigned manual_probe; /**< true to enable manual device > probing. */ > volatile unsigned vmware_tsc_map; /**< true to use VMware TSC > mapping >=20 > * instead of native TSC */ > volatile unsigned no_shconf; /**< true if there is no shared confi= g > */ > diff --git a/lib/librte_eal/common/eal_options.h > b/lib/librte_eal/common/eal_options.h > index 9855429e5..588fa32a6 100644 > --- a/lib/librte_eal/common/eal_options.h > +++ b/lib/librte_eal/common/eal_options.h > @@ -69,6 +69,8 @@ enum { > OPT_IOVA_MODE_NUM, > #define OPT_MATCH_ALLOCATIONS "match-allocations" > OPT_MATCH_ALLOCATIONS_NUM, > +#define OPT_MANUAL_PROBE "manual-probe" > + OPT_MANUAL_PROBE_NUM, > OPT_LONG_MAX_NUM > }; >=20 > diff --git a/lib/librte_eal/common/eal_private.h > b/lib/librte_eal/common/eal_private.h > index 798ede553..fd7ac8e37 100644 > --- a/lib/librte_eal/common/eal_private.h > +++ b/lib/librte_eal/common/eal_private.h > @@ -381,4 +381,13 @@ rte_option_init(void); void rte_option_usage(void)= ; >=20 > +/** > + * Go through the devargs list and probe everything in order. > + * > + * @return > + * 0 on success, negative on error. > + */ > +int > +rte_dev_probe_devargs_list(void); > + > #endif /* _EAL_PRIVATE_H_ */ > diff --git a/lib/librte_eal/common/include/rte_eal.h > b/lib/librte_eal/common/include/rte_eal.h > index b7cf91214..da86fdb6b 100644 > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -465,6 +465,40 @@ int rte_eal_has_hugepages(void); int > rte_eal_has_pci(void); >=20 > /** > + * Whether EAL probe is manual. > + * Enabled by the --manual-probe option or by > + * using rte_eal_manual_probe_set(). > + * > + * When manual probing is enabled, batched bus probe of > + * their devices is disabled. All devices need to be probed > + * using the proper rte_dev API. > + * > + * In this mode, devices declared on the command line will > + * be probed using the bus hotplug API. It is used to enforce > + * a specific probe order. > + * > + * @return > + * Nonzero if manual device probing is enabled. > + * > + * @see rte_eal_manual_probe_set > + */ > +int rte_eal_manual_probe(void); > + > +/** > + * Configure EAL probe mode -- manual or automatic. > + * > + * Enable or disable manual probe mode in EAL. > + * This function can be called at any time, but must be used > + * before calling rte_eal_init() to have any effect. > + * > + * @param enabled > + * zero to disable manual probe, non-zero to enable it. > + * > + * @see rte_eal_manual_probe > + */ > +void rte_eal_manual_probe_set(int enabled); > + > +/** > * Whether the EAL was asked to create UIO device. > * > * @return > diff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/ea= l/eal.c > index d53f0fe69..cc6d846bd 100644 > --- a/lib/librte_eal/freebsd/eal/eal.c > +++ b/lib/librte_eal/freebsd/eal/eal.c > @@ -972,6 +972,16 @@ rte_eal_vfio_intr_mode(void) > return RTE_INTR_MODE_NONE; > } >=20 > +int rte_eal_manual_probe(void) > +{ > + return internal_config.manual_probe; > +} > + > +void rte_eal_manual_probe_set(int enabled) { > + internal_config.manual_probe =3D !!enabled; } > + > int rte_vfio_setup_device(__rte_unused const char *sysfs_base, > __rte_unused const char *dev_addr, > __rte_unused int *vfio_dev_fd, > diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/ea= l.c index > 946222ccd..da00eb14d 100644 > --- a/lib/librte_eal/linux/eal/eal.c > +++ b/lib/librte_eal/linux/eal/eal.c > @@ -1382,6 +1382,16 @@ rte_eal_vfio_intr_mode(void) > return internal_config.vfio_intr_mode; } >=20 > +int rte_eal_manual_probe(void) > +{ > + return internal_config.manual_probe; > +} > + > +void rte_eal_manual_probe_set(int enabled) { > + internal_config.manual_probe =3D !!enabled; } > + > int > rte_eal_check_module(const char *module_name) { diff --git > a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map > index 7cbf82d37..ccc4ffb21 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -312,6 +312,14 @@ DPDK_19.08 { >=20 > } DPDK_19.05; >=20 > +DPDK_19.11 { > + global: > + > + rte_eal_manual_probe; > + rte_eal_manual_probe_set; > + > +} DPDK_19.08; > + > EXPERIMENTAL { > global: >=20 > -- > 2.11.0