From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65CBEA0C41; Tue, 5 Oct 2021 09:39:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2BD49412A9; Tue, 5 Oct 2021 09:39:50 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 13AE3412A6 for ; Tue, 5 Oct 2021 09:39:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="212609928" X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="212609928" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 00:39:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,348,1624345200"; d="scan'208";a="713975077" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 05 Oct 2021 00:39:45 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 00:39:44 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 00:39:44 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 5 Oct 2021 00:39:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EIjt0s6FN03pHUI06eFYXtuDB847BfddG3oMEQVosOcKh07cIWBElHlP9Y7/cesW78TV/hsCmMu957upEPEdtptAsL9o1OLpx9N7VbiVjmdMLQrd6hRD31Q6H3v7bTImiq+RJZ12RaEsRCa6EECFGHPJ7HyTIjWe81Ljk1g8Y6QYl5uPZuNUN1D6TXOqCIluEH1wMSLzHhC+R1kXGesTKJ5Om2eh0hIOdb8agANrxF38N/GhjVLKt/TLIW1fzGVDxPS5lSvpV+hXph5k0xeqIuQOQo9JlBAa4fv1iyMczsQIOboVYj7Ni/4qic7gcNIJQ7Zo0/ORp9qQSfHjyExVrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RnbcHd8boNbBYb0Uug81gbzIyAq7+IVniquPrtULAMk=; b=T9luDxIwrBUpyxVNsWOk787GfStew8JFaiaMgmbekDdhis7BxWb9qvCn4Ng+yPcfbHKC+XDRk6OOjy9yXLcUAMdoxeE8Mp6IhrCc2ay+umnWbDwADmYRw1S/4v/a6tyi84xFCpP3Peoiq6E4nSF0JGVinjf+JSDg+4LHNDxm+LGl/9+swOVdMWsswhUioAYuLVSRv0E/FxFdIuM/EtakK5UxOji6AXA+XABF/NIgksvYnKyqnXB8uouhNsjUuUK305slfHzdAgdJiEkO02piGg56ugXgieP5398ajAUHKyb3zeR81aucwOGABpaXLrMdA1s+M4LgStY3YYgriJD6Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RnbcHd8boNbBYb0Uug81gbzIyAq7+IVniquPrtULAMk=; b=X297fu6DV5Tu5jTo4y8kNG05SMrT7sPaTa75+fJ9uXrSjH52lcPSzESlGmcZP3z82w1JIWHsoh7jWOtv6/nZ2iYeVWhEfO3R7cX1uCJKO/Fbfn16g0MH4VmJ67Xvk9uqoznwblzkCnOK0sL/vHtY6Dg7C51vhOrUvQ7TQSBz7FI= Received: from BN6SPR00MB239.namprd11.prod.outlook.com (2603:10b6:405:11::23) by BN6PR11MB4132.namprd11.prod.outlook.com (2603:10b6:405:81::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct 2021 07:39:43 +0000 Received: from BN6SPR00MB239.namprd11.prod.outlook.com ([fe80::ccd0:582d:7ffc:6102]) by BN6SPR00MB239.namprd11.prod.outlook.com ([fe80::ccd0:582d:7ffc:6102%6]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 07:39:43 +0000 From: "Jayatheerthan, Jay" To: "Naga Harish K, S V" , "jerinj@marvell.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH v5 3/5] eventdev/rx_adapter: introduce per queue event buffer Thread-Index: AQHXuOJ8yd7JfJJ9vUKTL0Yq3fOduavEBcWw Date: Tue, 5 Oct 2021 07:39:43 +0000 Message-ID: References: <20210930082901.293541-1-s.v.naga.harish.k@intel.com> <20211004054108.3890018-1-s.v.naga.harish.k@intel.com> <20211004054108.3890018-3-s.v.naga.harish.k@intel.com> In-Reply-To: <20211004054108.3890018-3-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0154b3aa-da8a-4b5d-55de-08d987d34c3c x-ms-traffictypediagnostic: BN6PR11MB4132: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:580; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OtN8SiDS3UUAiXMuR9eTKapJ+KQYJ8qco6+roihbViB4cB6No0O0ZYNK/HUCiDZFPPfUn52rgMvlLiYcyJnHQN/4SZJoGlDut4F52BAwww8W1yEltuGsMTSrOG8eR9iiPpaoh1ie6m4RNVt1DJlSseLozdYPFHG+lTUXb6Y89FvCWkUVva/cdUts+V95BS39npyuqfWdBmksTkJkmjRyKTn6RbuJkJEwpsGluT3j2OoGu7/CwTnDpaSBtny+eByhWmAo52czSs00tEsq+WmBvBPP3UvmhdjoxqejxTOaVB/XC7vJr0cX1T04Mv/bg3l4ZeqXAJJbzMQdjeYODNkE7lbKxzEOjgLer6iWrx95Qq5SAeai6Vkop8FrXNXB9z4IKbS+6j7Qi5tEDi5ahZ4M9cKAtDSFOixewz11wZ5As5k9Vui8unMBgad9ZvBQjRWQgJ7i810V5R+ZzjnAX7MWeu3ZNZX8uYtP+V9nscdO8qfWDHsvVLvDYrRikDWAfmVbmUthMYgpHBdm/Pdp5ORhl4WNZwZR18yzR5rL8df2pf2XgawQ2Nxhtn8eP31u8ijzYv58AZn2HUrsHw+Hq5W+/4EBaQBkj4iNWK0KWkF1mY0Zn332lVUaJbfaIev1P2EALdc1CSjAicInJuGeaLkWRXYCZUi54b329iFlDo4jMNmkIZwIatoJrDkVYdkhcmELrVT9za+gZK1U4HwGCAsY3A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6SPR00MB239.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(55016002)(86362001)(71200400001)(508600001)(7696005)(83380400001)(26005)(186003)(6506007)(9686003)(53546011)(110136005)(316002)(66446008)(38100700002)(66556008)(122000001)(66476007)(5660300002)(52536014)(33656002)(64756008)(4326008)(8936002)(2906002)(8676002)(38070700005)(76116006)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AlSHw9q/4cVo/Mr0wvR7hw0a+mBqQ2MkDPEdeCF/ENmuNWPhKf9gcDdrxHEI?= =?us-ascii?Q?xRXrgd6XWB3yl1S/YEZJWNZk5IKpv4XVxorpHzuY0pWEoz632PDdEqi4+ktv?= =?us-ascii?Q?WOHBSKMjJCZnY9ol+qJ8D4IJAI5N6uY5Fpyh2G1rMWOYClIQl3sW4JK57i9Y?= =?us-ascii?Q?o6LgUQn+3REWDEhr2wNjcZgsd4GUbPGTPrBi63B2aJD+dAAzXOePZ1ABYk2o?= =?us-ascii?Q?/K2zn7aIHaqsDgsW0ZUyD9gKsIWy16TuLe0WF2RYoWxbrmJanZdPXQJ6RJ4N?= =?us-ascii?Q?LabYjKJ8oZeDU60/AjwcAXefL+qZAQL/j22vcjFhN1bf3tz2rt1hhqMHlSgF?= =?us-ascii?Q?WyyoEplTV9gChCQwJQAUKVcc85pmEs9LGSceKIbMlhkUBIKm7bo7D3PtsdrS?= =?us-ascii?Q?GcfuPx0PfG/317f2IOkjj+FzyxjRQF6SoCz5MmtuRbbTXZ+290a5wepx3TQO?= =?us-ascii?Q?Mn9h1CJLLlC7AekhOkOiFKY2l92ru7MNvlTTh/oAc5+fJXTFkXCMx9Bl+SQQ?= =?us-ascii?Q?a3clzkm//ajdhJC3P3QDzMdkTpS2kZiwSM1dzDe/1sngu0ebkWwPu9JUZjTT?= =?us-ascii?Q?9ragywBm4r6jycH+IQTDpKgT0gXO0KvDoGBXAA7AYhNVHTFriZHg+vHSBpXP?= =?us-ascii?Q?zKGPNQtHXW8kgQOMGo1Hc3gdWKJTNbtF6ETn4+yYxOaZAWBR3W45fqScxJTK?= =?us-ascii?Q?IZpt5eDw9d+wHhYmcPRTsBclygncg+jzK2D5KuXsBLmMRWjpd9OZzNy3UfWU?= =?us-ascii?Q?NBQ4DhYMTM9oShBK7eK6Q6Yr+Z79TYK1VVWGq5ypXCXQ2hpPdy1uOtTMYg5h?= =?us-ascii?Q?HNrm5ZmyHh8obWX4+OsYmftYqx0DzUzzO6c05VVzvOD5mEWbE4saGPzDLyft?= =?us-ascii?Q?bGJ8le6PVTB4vM23fjiydNQiCaZZaHbsiRzpoHr9AyIb2rv4zcOrTTS9qOgC?= =?us-ascii?Q?HhCmBhyMiFH80nhWvLYcPt7TfkPmX6v3f6HbjYg8aTZe+OqYWsHVU5e5lu1/?= =?us-ascii?Q?1MiXlubEFbkIAwwxftI4/VdVmIbKmwi+UQoT7i07lx3RgCKW9uZrnmYyqIxE?= =?us-ascii?Q?dISpdBGuRoW6RIgLIflxc8+flVxQvvIZ9KN8jFuwATUzOOR1f52m0fXqv9Jy?= =?us-ascii?Q?vuvEHn32+cxPukkbaSp8pwcn/1cXFdmQQPeQ25G1FPMEQNMYzzYKdKUL/Fus?= =?us-ascii?Q?DrlVpgpBf8kSGbFroPFAhjpKes7oWdr1WbfR7txVEovFtR+OFV3mluYHa4iM?= =?us-ascii?Q?Sn4BXos8OOmOjbEZEOklHKFIUfDouQzbse9NR0ClkdDLXZthpOyWU+MQN+Cv?= =?us-ascii?Q?QJ3ZE49N6d8doH0JojyITEGC?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN6SPR00MB239.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0154b3aa-da8a-4b5d-55de-08d987d34c3c X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2021 07:39:43.5178 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Hy64BTdgDVHzzLjNzLr3cdBatppDdoKvdGfY1vEjwpQY6ZP+MRsRbDj5b7uC495JlzPVnUFFjS5Yisqy4P49oyWpOiFkmEMjZahiinr+RM0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4132 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 3/5] eventdev/rx_adapter: introduce per queue event buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Naga Harish K, S V > Sent: Monday, October 4, 2021 11:11 AM > To: jerinj@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org > Subject: [PATCH v5 3/5] eventdev/rx_adapter: introduce per queue event bu= ffer >=20 > To configure per queue event buffer size, application sets > ``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag > as true and is passed to ``rte_event_eth_rx_adapter_create_with_params`` > api. >=20 > The per queue event buffer size is populated in > ``rte_event_eth_rx_adapter_queue_conf::event_buf_size`` and passed > to ``rte_event_eth_rx_adapter_queue_add`` api. >=20 > Signed-off-by: Naga Harish K S V > --- > .../prog_guide/event_ethernet_rx_adapter.rst | 19 ++++++++++++------- > lib/eventdev/rte_event_eth_rx_adapter.h | 4 ++++ > 2 files changed, 16 insertions(+), 7 deletions(-) >=20 > diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/gu= ides/prog_guide/event_ethernet_rx_adapter.rst > index 8526aecf57..8b58130fc5 100644 > --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > @@ -62,12 +62,14 @@ service function and needs to create an event port fo= r it. The callback is > expected to fill the ``struct rte_event_eth_rx_adapter_conf structure`` > passed to it. >=20 > -If the application desires to control the event buffer size, it can use = the > -``rte_event_eth_rx_adapter_create_with_params()`` api. The event buffer = size is > -specified using ``struct rte_event_eth_rx_adapter_params::event_buf_size= ``. > -The function is passed the event device to be associated with the adapte= r > -and port configuration for the adapter to setup an event port if the > -adapter needs to use a service function. > +If the application desires to control the event buffer size at adapter l= evel, > +it can use the ``rte_event_eth_rx_adapter_create_with_params()`` api. Th= e event > +buffer size is specified using ``struct rte_event_eth_rx_adapter_params:= : > +event_buf_size``. To configure the event buffer size at queue level, the= boolean > +flag ``struct rte_event_eth_rx_adapter_params::use_queue_event_buf`` nee= d to be > +set to true. The function is passed the event device to be associated wi= th > +the adapter and port configuration for the adapter to setup an event por= t > +if the adapter needs to use a service function. >=20 > Adding Rx Queues to the Adapter Instance > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > @@ -79,7 +81,9 @@ parameter. Event information for packets from this Rx q= ueue is encoded in the > ``ev`` field of ``struct rte_event_eth_rx_adapter_queue_conf``. The > servicing_weight member of the struct rte_event_eth_rx_adapter_queue_co= nf > is the relative polling frequency of the Rx queue and is applicable when= the > -adapter uses a service core function. > +adapter uses a service core function. The applications can configure que= ue > +event buffer size in ``struct rte_event_eth_rx_adapter_queue_conf::event= _buf_size`` > +parameter. >=20 > .. code-block:: c >=20 > @@ -90,6 +94,7 @@ adapter uses a service core function. > queue_config.rx_queue_flags =3D 0; > queue_config.ev =3D ev; > queue_config.servicing_weight =3D 1; > + queue_config.event_buf_size =3D 1024; >=20 > err =3D rte_event_eth_rx_adapter_queue_add(id, > eth_dev_id, > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_e= vent_eth_rx_adapter.h > index 846ca569e9..70ca427d66 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.h > +++ b/lib/eventdev/rte_event_eth_rx_adapter.h > @@ -200,6 +200,8 @@ struct rte_event_eth_rx_adapter_queue_conf { > * Valid when RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set i= n > * @see rte_event_eth_rx_adapter_queue_conf::rx_queue_flags. > */ > + uint16_t event_buf_size; > + /**< event buffer size for this queue */ > }; >=20 > /** > @@ -267,6 +269,8 @@ struct rte_event_eth_rx_adapter_params { > * This value is rounded up for better buffer utilization > * and performance. > */ > + bool use_queue_event_buf; > + /**< flag to indicate that event buffer is separate for each queue */ > }; >=20 > /** > -- > 2.25.1 Acked-by: Jay Jayatheerthan