From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D42AA04F1; Sun, 8 Dec 2019 19:03:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C362D1BEC4; Sun, 8 Dec 2019 19:03:02 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D7DB31BE9D for ; Sun, 8 Dec 2019 19:03:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2019 10:02:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,292,1571727600"; d="scan'208";a="362718882" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 08 Dec 2019 10:02:59 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Dec 2019 10:02:59 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 8 Dec 2019 10:02:56 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 8 Dec 2019 10:02:56 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.59) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Dec 2019 10:02:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a+mD8DiXkX9OznkV3ojyvMQEfZ2h1uuEYikxwBqSxDhp3ML6MZgVPVMV5fBh9Jhblq58cOfQCAJeP/eDKpUPPXBrXqU+k9wxpsRL6uzSjob6He6WewO5/Y+3WSTArGImNoa7m08AQ8sW1XCmrWDYA5S3N+fR74FF510l5B+G24o2FLkM+c6CvUFpGhGBIk7spUUshM+sN7y1tv98Fwo1BhxJX9UWTs0Cxo8Ep5MLDAR+PTKxb7GIx8caMNXn72SYGdGibx+33yG/Xnu6aiT27Dpe/Ls3saz5TUnbxyMAxmZ/ALKO96LT0BaEuSv1moeFsyXLcJxD05mnj/hzz4QSvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWjGtgFKrks18CgSvnJV9NEszp7szIlCdw36lZB97fY=; b=O8RlpwT/sVSy9tksxpeV20nfiLLtqxxBP3kiA6baylEUYKf+mKWDM8GBf3DMBRkSqZeOgBZIuPVevDzBRyRhYoRi2+ESg1uOPqKp75K0BLZSNzWVxJn1BEwZ8UOpFyQOzpZCRjIxBH11YgTEtezFr0GksQqXDMTqore26AyrY+QKM7z6wN17fHZ3iizyMeRw6wfRVwyUHRpzHMT28xCPTidibwq0DXgryNO0MrjCB01JlkbXeGjXnHOfbUI2vLcYKIdiL62/SB3856u+tEA8EKv9ieAHVNrmLMc7dI6GOp/iOdyAc9Z32wbCXhduJH0z2Oof2w7yWCh8jcG4KMzgdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWjGtgFKrks18CgSvnJV9NEszp7szIlCdw36lZB97fY=; b=uOpX23LYgTjKLnLKgBAw36UfzRAuWoeL87wCBDxcD8y97py1RE0fUm3qR7bvaZbKc5cu+d2j8rrSA6T+Th4VQVDzlfKnEpSwPYOKQ4tkVlyMpdxjWgp6zn/MvsQdXeIreHyzVKgOTbAWsF9jK695uToBWriH5IJ5OiqOXfxLjCo= Received: from BN7PR11MB2547.namprd11.prod.outlook.com (52.135.255.146) by BN7PR11MB2563.namprd11.prod.outlook.com (52.135.244.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Sun, 8 Dec 2019 18:02:53 +0000 Received: from BN7PR11MB2547.namprd11.prod.outlook.com ([fe80::5c82:bb6a:d0f0:b802]) by BN7PR11MB2547.namprd11.prod.outlook.com ([fe80::5c82:bb6a:d0f0:b802%6]) with mapi id 15.20.2516.018; Sun, 8 Dec 2019 18:02:53 +0000 From: "Ananyev, Konstantin" To: Ajit Khaparde , "dev@dpdk.org" CC: "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH 1/3] ethdev: add RSS hash level Thread-Index: AQHVrJmvQ1rbuJ2tTkGzx6+hCcepiqewiAcg Date: Sun, 8 Dec 2019 18:02:53 +0000 Message-ID: References: <20191207005919.10962-1-ajit.khaparde@broadcom.com> <20191207005919.10962-2-ajit.khaparde@broadcom.com> In-Reply-To: <20191207005919.10962-2-ajit.khaparde@broadcom.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjk2ZWQyYTUtZGRiMS00ODQ4LThjYWQtMjJkZGY3NzRhNDIwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiWURLbmhcL1lWRE1oRXhzWEFwclNZblUrbDZYUGpseW0xMTJBNzBMQVVkd2RucElVQ3dZRFRvNWN1Vms4TG0xYWkifQ== dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.174] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 032b60e3-2b27-4455-2185-08d77c08d8ee x-ms-traffictypediagnostic: BN7PR11MB2563: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0245702D7B x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(366004)(39850400004)(136003)(376002)(396003)(189003)(199004)(33656002)(4326008)(2906002)(478600001)(71190400001)(71200400001)(305945005)(229853002)(81166006)(8676002)(55016002)(74316002)(8936002)(107886003)(9686003)(81156014)(76116006)(66556008)(66476007)(99286004)(86362001)(66946007)(26005)(66446008)(64756008)(7696005)(186003)(52536014)(110136005)(76176011)(6506007)(5660300002)(102836004)(316002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN7PR11MB2563; H:BN7PR11MB2547.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tuQbuWWGD0Ci0CqKof/SCrZON678mBjdhljh1iryvG7QYZpKpdtMsbel9vo30HhSMrA3XdJgSrbJWdOoBROzlnCyzrsglf3iSORUA14mtR3zRahuHzuR6Q9HglhRozOQHmo4KZbHi/a9dpgSb6gomhKJxY+Y294P0KrsxvOeq3tUA4n3TFjZOYkZEOCiWbbIBdo70sdcr1zDLsHtpVfEYyvom5YA2KDXHxN2DU5LaAJ2vxPq6D92mpQB2BvK3GH8gmDk9ihaPc4qtLFcaTffdnLEaw3qa7KfbkvBG6s5F36rJXn5MplrsveFDzdgVBmRDpbJV2WnSbSFb2n05lpldItlkey7gllbwytMv9EqTGogUFZDFpAsCjJLOC9g5K0tD2cztRRgvXfSBxIbPHJKyjJRJlbKKgSwp/7BIKfoLmZmZ/HhBzsKTkMhaoJONcCG Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 032b60e3-2b27-4455-2185-08d77c08d8ee X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Dec 2019 18:02:53.6322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +KcJ/ChB9YVdn7V/6i6OKFRlVLUGS56AEseWOK142jnPSOqmKUvF/2OVQXNmwglGltt36Zuy/+eC6LRz+EMVBX65eGTx/4D7VvgksGPRF5s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2563 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: add RSS hash level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ajit, > This patch adds ability to configure RSS hash level in hardware. > This feature will allow an application to select RSS hash calculation > on outer or inner headers for tunneled packets. >=20 > Signed-off-by: Ajit Khaparde > --- > lib/librte_ethdev/rte_ethdev.h | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) >=20 > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethde= v.h > index 18a9defc2..5189bdbab 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -444,11 +444,35 @@ struct rte_vlan_filter_conf { > * The *rss_hf* field of the *rss_conf* structure indicates the differen= t > * types of IPv4/IPv6 packets to which the RSS hashing must be applied. > * Supplying an *rss_hf* equal to zero disables the RSS feature. > + * > + * The *rss_level* field of the *rss_conf* structure indicates the > + * Packet encapsulation level RSS hash @p types apply to. > + * > + * - @p 0 requests the default behavior. Depending on the packet > + * type, it can mean outermost, innermost, anything in between or > + * even no RSS. > + * > + * It basically stands for the innermost encapsulation level RSS > + * can be performed on according to PMD and device capabilities. > + * > + * - @p 1 requests RSS to be performed on the outermost packet > + * encapsulation level. > + * > + * - @p 2 and subsequent values request RSS to be performed on the > + * specified inner packet encapsulation level, from outermost to > + * innermost (lower to higher values). If it is just to add ability to do rss over inner header, then do we really= need all this concept of 'levels'? Might be just: #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 +#define DEV_RX_OFFLOAD_RSS_HASH_INNER 0x00100000=20 and uint8_t in rte_eth_rss_conf (between key_len and rss_hf) to indicate inner/outer? > + * > + * Support for values other than @p 0 is dependent on the underlying > + * hardware in use. > + * > + * Requesting a specific RSS level on unrecognized traffic results > + * in undefined behavior. > */ > struct rte_eth_rss_conf { > uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ > uint8_t rss_key_len; /**< hash key length in bytes. */ > uint64_t rss_hf; /**< Hash functions to apply - see below. */ > + uint32_t rss_level; /**< RSS hash level */ > }; >=20 > /* > @@ -599,6 +623,8 @@ rte_eth_rss_hf_refine(uint64_t rss_hf) > ETH_RSS_GENEVE | \ > ETH_RSS_NVGRE) >=20 > +#define ETH_RSS_LEVEL_DEFAULT 0 > + > /* > * Definitions used for redirection table entry size. > * Some RSS RETA sizes may not be supported by some drivers, check the > @@ -1103,6 +1129,7 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 > #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 > #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 > +#define DEV_RX_OFFLOAD_RSS_LEVEL 0x00100000 >=20 > #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \ > DEV_RX_OFFLOAD_UDP_CKSUM | \ > -- > 2.21.0 (Apple Git-122.2)