From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61A0EA052A; Tue, 26 Jan 2021 06:21:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDC5B141203; Tue, 26 Jan 2021 06:21:35 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by mails.dpdk.org (Postfix) with ESMTP id 465961411FD for ; Tue, 26 Jan 2021 06:21:34 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 25 Jan 2021 21:21:33 -0800 Received: from HQMAIL105.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 25 Jan 2021 21:21:33 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 25 Jan 2021 21:21:33 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 26 Jan 2021 05:21:32 +0000 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 26 Jan 2021 05:21:25 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 26 Jan 2021 05:21:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LyqSNJFyCG9/T2Lf7S0RKaTaVH3PaaUyGLvKHN4I7jx7g0fNAns85p8ygHiHlBvqzOcimvA0s07e/G/Lags2vgBRukLdTuRxnEyOuTG8Q8QjHsXDjajCBX3FGyRwxNGBKC/xpjSowPU8hFHaxtLrRL+AtVNnPUw7KyHZK8aljienun3kldA6PYW0IP8LpcgG+F4aXwC8MS7USshJ/EpRdI2d0U4kc35IqWn1ygI8MaiapTuNHJJmx9TCnjRr8LI6j8Ukg5BZYsLsXhMb67168TxtzXMVYny4kg9w3NLcJTA+X3eiyuu8V6xspQy/RbB8OBxD/gMYXjOXCFzIfNc1Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eqKSgIua0S1b2EKcKpKRX0LqBHECcPFjE+XP6OKZra0=; b=IzvF2wio9W9OY5GH9oVkcGa25IoS+Gvx+FJWFlElqG8p/ohCjaRUFQWf5KStyARutjfKG0H/wo0xmf2A2KJZ/w+mvSrfGYVTTNNr6KNS0nV7bIDt+xLR+aw2wkf+MEnxcoY7x4z+3dy/cjaej6eASYwwVQF4QfR8jdik/DuA1JBmUZEuB+35vOix4AEa6qn0jSk3BFf/CxRifpCstf+9jAMh4il09sDhCdtW8ISesbrJLnbKlb+Y1v3Jw+1FlRr4xM0Ue5BkhFlWDSphZQAmMdh0UW3MEu4jG/0vFaJ6xYhfOKKifelP78zxXqiwrd6Cre7ZwVjgsojfVbzMFpJ4fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from BN7PR12MB2707.namprd12.prod.outlook.com (2603:10b6:408:2f::29) by BN6PR1201MB2529.namprd12.prod.outlook.com (2603:10b6:404:b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.15; Tue, 26 Jan 2021 05:21:23 +0000 Received: from BN7PR12MB2707.namprd12.prod.outlook.com ([fe80::90fa:92a9:d189:53c]) by BN7PR12MB2707.namprd12.prod.outlook.com ([fe80::90fa:92a9:d189:53c%3]) with mapi id 15.20.3784.017; Tue, 26 Jan 2021 05:21:23 +0000 From: Alexander Kozyrev To: Stephen Hemminger CC: "dev@dpdk.org" , Slava Ovsiienko , Ori Kam , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "jerinjacobk@gmail.com" , "ajit.khaparde@broadcom.com" Thread-Topic: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action Thread-Index: AQHW85S71biPi8X+WUyfPWxQbPCzc6o5Q8YAgAAapjA= Date: Tue, 26 Jan 2021 05:21:23 +0000 Message-ID: References: <20210126033824.29175-1-akozyrev@nvidia.com> <20210125194354.5b2fccdc@hermes.local> In-Reply-To: <20210125194354.5b2fccdc@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [2607:fea8:e380:d8e0:49ad:ee00:bfe4:9fd3] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39c99f38-94de-4683-dc8f-08d8c1ba38f3 x-ms-traffictypediagnostic: BN6PR1201MB2529: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Kyc94h5NQj4SICYGgCnfd4q7AsNF4JRLT2bhACxupORO+N8hVcn8FDFyrGHBxXy1OoxU4SzrpZboU4T1rt19OGbnhMdN62Og/wiV6yJoYRT8fMac/+FxMSMvuu4o56w4It8Y57vQrbigePsKMXZRiIKfqg5fab7IYBn0gfF9EU8T0q106Xb78sWQ/AA4zV3OqMf+f3FyZ6sv5+icAoA5mCz4M9NT2+uiZ/xIU4BBensdboyhtnDnf15qq9Gk3fPsSZNb0zEUnx5v2Bkt1TZ5F0RIOdKyed9wlnEmzAC2+KUY9JtIGJlSyt4GcyeDyzINo/nNyiPe9WuABwY8dXDmc9KICFTA4pKlTySMLdkJhbZPMCz7hy7CmRy5ALgBV7rXWEXW1Pl76D8zZn6vFQD4uA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR12MB2707.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(366004)(376002)(39860400002)(136003)(478600001)(316002)(7696005)(33656002)(52536014)(2906002)(8936002)(76116006)(54906003)(66476007)(8676002)(5660300002)(66446008)(64756008)(66556008)(4326008)(186003)(83380400001)(6916009)(9686003)(71200400001)(55016002)(86362001)(6506007)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?HEKGedVMhK5baS9VzG4xrlomT02inmf1qCIXY298xWGpmxaMuFe66jZyax+C?= =?us-ascii?Q?aI9i1UELnwfAaP55enJ1kYOBdDrAX0uzSms/HnHP6jRfL81vsjf8oKX+lcQR?= =?us-ascii?Q?c3QDBXQNAs548kto5sdirXDvN1jCCfx8agbD43MC94NWuJnjwnqMyF94teSb?= =?us-ascii?Q?g3NYfoTS98t/LzI6rjlWNUOGUR6k3BSG0wD1KByB8SzA5q++1UPYyct05XlB?= =?us-ascii?Q?x5Ua1kNoOwzKNa7pkV4DU6YoE1Wz9AfG+3iRFBv3hlpKnZeoGJxsIWI6mzm2?= =?us-ascii?Q?RapH/IwpnsqtQJtd4tkuXkz2MuZdrb4EACAvpt8dV7nZS0fujsu59k34fqdJ?= =?us-ascii?Q?d/Smsqy+JvQGDpdbJkPzWwHk9HTW/e8w0fMo0Az1eTtxB32r7EhJC2zbcsLu?= =?us-ascii?Q?KBdjZ8I8+axQNH/ORqIgNRZ3gJMDI0PwA1quobm9GjvhffrrCkxJYNd1a/+K?= =?us-ascii?Q?0aLXmCUhC1fZ6H7PgEeI62F4BPuUAO8Bp+lHuk0eXP8xhqv9YlNKP6t4UbyX?= =?us-ascii?Q?MsM7nxRkotQcAdPexCbKQUDukf4wEZ0Y5QZkdEFlOJYC4NsM49Fd9SLLtK2e?= =?us-ascii?Q?OHR7uZK3hyo+xodOdDUUSAq31p9UA8fnghYDeUfOm4ew9EX3/G4m3pnLPVpx?= =?us-ascii?Q?hWSeNKxGSXtqgpuL/WRBVj/O8WiIJdLwG4aReIm9rDPdZomli6joCKJO+Och?= =?us-ascii?Q?1uOWELbjaz/R5OFctwZLIq9JQpqwBPu+8fcGUeRu3mIRoza0AusWMI75PrSB?= =?us-ascii?Q?kmqN8orJkQ/wW7mX2pQCpYX8BBieDmlt/Feo2aQl6OEowTSDGcqyZ5CvQLH6?= =?us-ascii?Q?prYx0FRy4SQos+ke8xZIJI8xXok4he9wvx1Mtj/UPuze82Buw8I3vSDooBTG?= =?us-ascii?Q?bmfOd9zyf4zKASm/jHdn6ex5pysl6wQGnwx/BLTC3qTTIDjq0f50XZCd+ogG?= =?us-ascii?Q?8M2fJDdkqeGIa9AHiS3SZWo6FEuTv8YW2wqALFCQdF/ETl/p+w0dAqAhMAhU?= =?us-ascii?Q?C2bBwdUW7r5x1WBYlYtdp2RcVy7fPvrIjhJNVfASoheFaJYJH8Eb+SennBQB?= =?us-ascii?Q?lqYewj5fD+abtWasELYeLjBlp+3x5DLT9N55YHEfxUpZlpjWU73ktzFO3eIX?= =?us-ascii?Q?49NF4sHBEmbG?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR12MB2707.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39c99f38-94de-4683-dc8f-08d8c1ba38f3 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2021 05:21:23.5159 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Llm+GCICDVlq83r88kNU5Gs290Y4g9JWC/2LA8+ZyHXZEyJq56VFsrqGCvwjyT4Mp8Sumvn/C5ApvFHTp/QWTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB2529 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611638493; bh=eqKSgIua0S1b2EKcKpKRX0LqBHECcPFjE+XP6OKZra0=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=hwX9Bea/lRA7RWt9721tUJ4+0weApkUXfcaepp7+e309ac6L67LKbcgucOIrdb5VW yzDRIJUNexzQ6h/YXf8eV3XckMcHZNpq924GRLosguHe/+2obEh0L2O+kyweUtb2ul Kope+UVKyjIch93DH9IIyFdlPpYaPXInMLYUzJN9oSizHPBY/xuaTiQd1NR76h6QMW vPDH0qO/NtwA90+WANKaK0ZAFoifWovSs5OdkWrg/JvnSvn6ee4bIpTpFke7o4sCB5 ZrlpIJ1GZ2/x9DtHz+qvP+h9lX8GXJih4caMvoNLQSCQXoCrR93G4pNR08eq+vWv0D mN/bDguZumD5w== Subject: Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Stephen Hemminger on Monday, January 2= 5, 2021 22:44 >=20 > On Tue, 26 Jan 2021 03:38:24 +0000 > Alexander Kozyrev wrote: >=20 > > IPv6 DSCP field ID is missing from the original list of Field IDs > > for MODIFY_FIELD action. Add it to support IPv6 header fully. > > > > Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action") > > > > Signed-off-by: Alexander Kozyrev > > --- > > lib/librte_ethdev/rte_flow.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.= h > > index 46e8ee70ab..68c68cdd6c 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -2842,6 +2842,7 @@ enum rte_flow_field_id { > > RTE_FLOW_FIELD_IPV4_TTL, > > RTE_FLOW_FIELD_IPV4_SRC, > > RTE_FLOW_FIELD_IPV4_DST, > > + RTE_FLOW_FIELD_IPV6_DSCP, > > RTE_FLOW_FIELD_IPV6_HOPLIMIT, > > RTE_FLOW_FIELD_IPV6_SRC, > > RTE_FLOW_FIELD_IPV6_DST, >=20 > Adding field in middle of enum will break ABI. I added the rte_flow_field_id enum a week ago into 20.11-rc1. I believe it is not too late to make it right without breaking ABI, don't y= ou think so?