* [dpdk-dev] [PATCH] common/mlx5: fix glue library name
2020-10-26 9:20 [dpdk-dev] [PATCH] net/mlx4: fix glue library name Ali Alnubani
@ 2020-10-26 9:20 ` Ali Alnubani
2020-11-01 10:35 ` Matan Azrad
2020-11-01 13:07 ` Raslan Darawsheh
2020-10-28 7:42 ` [dpdk-dev] [PATCH] net/mlx4: " Matan Azrad
` (2 subsequent siblings)
3 siblings, 2 replies; 9+ messages in thread
From: Ali Alnubani @ 2020-10-26 9:20 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson
The MLX5 glue library wasn't following the standard
'librte_<class>_<name>.so' naming.
Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
Cc: bruce.richardson@intel.com
Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
drivers/common/mlx5/linux/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/mlx5/linux/meson.build b/drivers/common/mlx5/linux/meson.build
index 9ef8e181d..0d437f8fb 100644
--- a/drivers/common/mlx5/linux/meson.build
+++ b/drivers/common/mlx5/linux/meson.build
@@ -5,7 +5,7 @@ includes += include_directories('.')
static_ibverbs = (get_option('ibverbs_link') == 'static')
dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
-LIB_GLUE_BASE = 'librte_pmd_mlx5_glue.so'
+LIB_GLUE_BASE = 'librte_common_mlx5_glue.so'
LIB_GLUE_VERSION = '20.02.0'
LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
if dlopen_ibverbs
@@ -195,7 +195,7 @@ configure_file(output : 'mlx5_autoconf.h', configuration : config)
# Build Glue Library
if dlopen_ibverbs
dlopen_name = 'mlx5_glue'
- dlopen_lib_name = 'rte_pmd_@0@'.format(dlopen_name)
+ dlopen_lib_name = 'rte_common_' + dlopen_name
dlopen_so_version = LIB_GLUE_VERSION
dlopen_sources = files('mlx5_glue.c')
dlopen_install_dir = [ eal_pmd_path + '-glue' ]
--
2.28.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] common/mlx5: fix glue library name
2020-10-26 9:20 ` [dpdk-dev] [PATCH] common/mlx5: " Ali Alnubani
@ 2020-11-01 10:35 ` Matan Azrad
2020-11-01 13:07 ` Raslan Darawsheh
1 sibling, 0 replies; 9+ messages in thread
From: Matan Azrad @ 2020-11-01 10:35 UTC (permalink / raw)
To: Ali Alnubani, dev; +Cc: bruce.richardson
From: Ali Alnubani
> The MLX5 glue library wasn't following the standard
> 'librte_<class>_<name>.so' naming.
>
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] common/mlx5: fix glue library name
2020-10-26 9:20 ` [dpdk-dev] [PATCH] common/mlx5: " Ali Alnubani
2020-11-01 10:35 ` Matan Azrad
@ 2020-11-01 13:07 ` Raslan Darawsheh
1 sibling, 0 replies; 9+ messages in thread
From: Raslan Darawsheh @ 2020-11-01 13:07 UTC (permalink / raw)
To: Ali Alnubani, dev; +Cc: bruce.richardson
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ali Alnubani
> Sent: Monday, October 26, 2020 11:21 AM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com
> Subject: [dpdk-dev] [PATCH] common/mlx5: fix glue library name
>
> The MLX5 glue library wasn't following the standard
> 'librte_<class>_<name>.so' naming.
>
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
> drivers/common/mlx5/linux/meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/mlx5/linux/meson.build
> b/drivers/common/mlx5/linux/meson.build
> index 9ef8e181d..0d437f8fb 100644
> --- a/drivers/common/mlx5/linux/meson.build
> +++ b/drivers/common/mlx5/linux/meson.build
> @@ -5,7 +5,7 @@ includes += include_directories('.')
> 2.28.0
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
2020-10-26 9:20 [dpdk-dev] [PATCH] net/mlx4: fix glue library name Ali Alnubani
2020-10-26 9:20 ` [dpdk-dev] [PATCH] common/mlx5: " Ali Alnubani
@ 2020-10-28 7:42 ` Matan Azrad
2020-11-01 11:49 ` Raslan Darawsheh
2020-11-02 13:01 ` Ferruh Yigit
3 siblings, 0 replies; 9+ messages in thread
From: Matan Azrad @ 2020-10-28 7:42 UTC (permalink / raw)
To: Ali Alnubani, dev; +Cc: bruce.richardson
From: Ali Alnubani
> The MLX4 library wasn't being successfully initialized with -
> Dibverbs_link=dlopen because it expected a shared object file with a
> different name.
>
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
2020-10-26 9:20 [dpdk-dev] [PATCH] net/mlx4: fix glue library name Ali Alnubani
2020-10-26 9:20 ` [dpdk-dev] [PATCH] common/mlx5: " Ali Alnubani
2020-10-28 7:42 ` [dpdk-dev] [PATCH] net/mlx4: " Matan Azrad
@ 2020-11-01 11:49 ` Raslan Darawsheh
2020-11-02 13:01 ` Ferruh Yigit
3 siblings, 0 replies; 9+ messages in thread
From: Raslan Darawsheh @ 2020-11-01 11:49 UTC (permalink / raw)
To: Ali Alnubani, dev; +Cc: bruce.richardson
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ali Alnubani
> Sent: Monday, October 26, 2020 11:21 AM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com
> Subject: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
>
> The MLX4 library wasn't being successfully initialized with
> -Dibverbs_link=dlopen because it expected a shared object file
> with a different name.
>
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
> drivers/net/mlx4/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
2020-10-26 9:20 [dpdk-dev] [PATCH] net/mlx4: fix glue library name Ali Alnubani
` (2 preceding siblings ...)
2020-11-01 11:49 ` Raslan Darawsheh
@ 2020-11-02 13:01 ` Ferruh Yigit
2020-11-02 13:04 ` Ferruh Yigit
2020-11-02 13:04 ` Ali Alnubani
3 siblings, 2 replies; 9+ messages in thread
From: Ferruh Yigit @ 2020-11-02 13:01 UTC (permalink / raw)
To: Ali Alnubani, Viacheslav Ovsiienko
Cc: bruce.richardson, dev, Matan Azrad, Shahaf Shuler
On 10/26/2020 9:20 AM, Ali Alnubani wrote:
> The MLX4 library wasn't being successfully initialized with
> -Dibverbs_link=dlopen because it expected a shared object file
> with a different name.
>
The mlx4 glue library name seems changed in the patch pointed by Fixes line, but
mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you
please fix that too in a separate patch?
> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
> Cc: bruce.richardson@intel.com
>
> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
> ---
> drivers/net/mlx4/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
> index 404006515..c22a88875 100644
> --- a/drivers/net/mlx4/meson.build
> +++ b/drivers/net/mlx4/meson.build
> @@ -10,7 +10,7 @@ endif
>
> static_ibverbs = (get_option('ibverbs_link') == 'static')
> dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
> -LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
> +LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
> LIB_GLUE_VERSION = '18.02.0'
> LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
> if dlopen_ibverbs
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
2020-11-02 13:01 ` Ferruh Yigit
@ 2020-11-02 13:04 ` Ferruh Yigit
2020-11-02 13:04 ` Ali Alnubani
1 sibling, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2020-11-02 13:04 UTC (permalink / raw)
To: Ali Alnubani, Viacheslav Ovsiienko
Cc: bruce.richardson, dev, Matan Azrad, Shahaf Shuler
On 11/2/2020 1:01 PM, Ferruh Yigit wrote:
> On 10/26/2020 9:20 AM, Ali Alnubani wrote:
>> The MLX4 library wasn't being successfully initialized with
>> -Dibverbs_link=dlopen because it expected a shared object file
>> with a different name.
>>
>
> The mlx4 glue library name seems changed in the patch pointed by Fixes line, but
> mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you
> please fix that too in a separate patch?
>
I should be a little more patient, the fix is already in the same thread ;) Thanks.
https://patches.dpdk.org/patch/82174/
>> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
>> Cc: bruce.richardson@intel.com
>>
>> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
>> ---
>> drivers/net/mlx4/meson.build | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
>> index 404006515..c22a88875 100644
>> --- a/drivers/net/mlx4/meson.build
>> +++ b/drivers/net/mlx4/meson.build
>> @@ -10,7 +10,7 @@ endif
>> static_ibverbs = (get_option('ibverbs_link') == 'static')
>> dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
>> -LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
>> +LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
>> LIB_GLUE_VERSION = '18.02.0'
>> LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
>> if dlopen_ibverbs
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
2020-11-02 13:01 ` Ferruh Yigit
2020-11-02 13:04 ` Ferruh Yigit
@ 2020-11-02 13:04 ` Ali Alnubani
1 sibling, 0 replies; 9+ messages in thread
From: Ali Alnubani @ 2020-11-02 13:04 UTC (permalink / raw)
To: Ferruh Yigit, Slava Ovsiienko
Cc: bruce.richardson, dev, Matan Azrad, Shahaf Shuler
Hi Ferruh,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, November 2, 2020 3:01 PM
> To: Ali Alnubani <alialnu@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: bruce.richardson@intel.com; dev@dpdk.org; Matan Azrad
> <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
>
> On 10/26/2020 9:20 AM, Ali Alnubani wrote:
> > The MLX4 library wasn't being successfully initialized with
> > -Dibverbs_link=dlopen because it expected a shared object file with a
> > different name.
> >
>
> The mlx4 glue library name seems changed in the patch pointed by Fixes line,
> but
> mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you
> please fix that too in a separate patch?
>
This was done in http://patches.dpdk.org/patch/82174/. Is it what you meant?
Thanks,
Ali
^ permalink raw reply [flat|nested] 9+ messages in thread