From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43C81A04F9; Wed, 18 Dec 2019 09:43:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 775E82BF9; Wed, 18 Dec 2019 09:43:38 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 91FC72C17 for ; Tue, 17 Dec 2019 11:39:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 02:39:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,325,1571727600"; d="scan'208";a="266538122" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by FMSMGA003.fm.intel.com with ESMTP; 17 Dec 2019 02:39:48 -0800 Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 02:39:48 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX126.amr.corp.intel.com (10.22.240.126) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 02:39:47 -0800 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.54) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 02:39:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SIsGsInfqcaYtoTkGNl/ywVi5lXFsQjul0fvKf/L0nE8ERLInslrip++snePyuodJ78GYbBqA7mYo9H7J+Wh1xVNN3zuf6Fzg4wK788cWqASnIUgdMBfbzEpZ/4dTe/2BfTX0tKU5isC5Db2co9WLyWIr+rFy14EGt/G2AJX/Sa6hXBu+/qnvp6voNEePr3BYjBR5KEAcBbVHZzTLIuWBQ8LRG5Te4JcM+UrqMIk3QhZU9FP88648XMKvfOL2NIfw+iFM3Tc8T8ySPUd1iMzI5rNQIyOlm3crmICD0G/nktqTlFQOu8a+N9dT2PpSIxpaOSE2Ui2ngLGJH7tYrwIOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tsf3k8cd3q8Ck9tgUVdcqAp8B/gbK0icQvyFBqCo4Mk=; b=ZocC93gxy/P+oGPdbq46ctoHii+lr5Sezf9f8Wfp0VW5VNIpRKpIx67iawuot/9fCXVI9onXJTjnm5xcEcWmV7MDz3sJHeChKbZwZMFtHxR4+uPrGdLY+GGWKt21RQPg3gqPDYIZrglC+F1BPaDZF41Fqjh5qsRoSWruMa+u+xJSHHmlSsWKe7ddSSAA3E7yXGM/ULsADHiveSm6c9IKmDej6JsszXFoaYsCGHHcwYSk1+CkPeR6KZJDn9vpUycE6pT5pcqbOFKw8NM/epTzRD4kMnIskddldSbqZxyUJ13s7KgyisXwx9DmhhhABkCJdYyW29kbaQ3LzDE70frrNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tsf3k8cd3q8Ck9tgUVdcqAp8B/gbK0icQvyFBqCo4Mk=; b=HRKLRzVeyczkbEdc3cbFKSGhdBWlEeLPPXxwk8Q78Ht0UtyUhQIEcrc6B/rwmlKYK3WjxJ1cAnDbqNwWGe8hoqOiSY47goA6y+kVbgaT3LE92jATzdwYB0m3TAx0u++I2bmVhI3xXAtZfwrD+F26bmLJqNpnulw1paZ8AzzRWoU= Received: from BN8PR11MB3571.namprd11.prod.outlook.com (20.178.221.206) by BN8PR11MB3572.namprd11.prod.outlook.com (20.178.218.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.14; Tue, 17 Dec 2019 10:39:45 +0000 Received: from BN8PR11MB3571.namprd11.prod.outlook.com ([fe80::804f:1ff6:1c88:52e7]) by BN8PR11MB3571.namprd11.prod.outlook.com ([fe80::804f:1ff6:1c88:52e7%3]) with mapi id 15.20.2538.019; Tue, 17 Dec 2019 10:39:45 +0000 From: "Kwapulinski, Piotr" To: "Ye, Xiaolong" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH v3 24/36] net/i40e/base: make i40e_set_mac_type() public Thread-Index: AQHVs7uMomQNuiaBr0ibi2waWmMMq6e+JRCA Date: Tue, 17 Dec 2019 10:39:45 +0000 Message-ID: References: <20191202074935.97629-1-xiaolong.ye@intel.com> <20191216024336.174318-1-xiaolong.ye@intel.com> <20191216024336.174318-25-xiaolong.ye@intel.com> In-Reply-To: <20191216024336.174318-25-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzM3YzU0MDgtZGY4ZC00NzZiLTk1ODktNDczNjIxZWQ4MDY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRWlmUk5cL0ZIVWlTNzhKR3JTYnZkVUtZNDM0aHVXVUE4TU5oVkd2TEwzTFpOakRXUk1CdHkxR2p6OTNHa21VbFUifQ== dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=piotr.kwapulinski@intel.com; x-originating-ip: [134.191.221.107] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08d43153-df33-405a-ab79-08d782dd6ec1 x-ms-traffictypediagnostic: BN8PR11MB3572: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 02543CD7CD x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(346002)(396003)(366004)(39860400002)(376002)(189003)(199004)(13464003)(9686003)(110136005)(66946007)(66476007)(53546011)(8676002)(66556008)(2906002)(76116006)(54906003)(64756008)(66446008)(107886003)(4326008)(26005)(71200400001)(186003)(5660300002)(7696005)(6636002)(81156014)(81166006)(86362001)(478600001)(8936002)(6506007)(33656002)(55016002)(52536014)(316002); DIR:OUT; SFP:1102; SCL:1; SRVR:BN8PR11MB3572; H:BN8PR11MB3571.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zyvjQd1nUixwrt4ka7hwqpP7a74Ou7yJQJmPtkRqqpgg4i9ar9CBTL4P6QiHoKaCwwzIzHEQu+QPX49IdiJnQTdEeSUXf6LTAQKcQUXwQNzuEuP12p/KDrDNCbxAjQt8JLMtdTlxZTIrjXBuS3YRyAmL1MeXPaRjuXV+Gk53z+1V7hrRApFFAeZ3NeeQ4RHWTSNojZnlss3O0r4Bn24AELn178g8/a4nKj1Uw3kEKHp1IT9YvU+WQ9JzwW6Mysxa44NfmXG0jXv6EwSkxRteQV6r5kg6eQi08drc/6o1uyYa7ThnRsbRaGuf0XI3ifyaPJpekVq+h3znEW5S6rwbJXQ+uKKi+HntkY9rM4PHjNbm2ZpEDyfJOpT/WQsVT9LneeJnct3oG5SQOmN7m9xMiOJ7BtyPYhywSxOdTNeyvALIF0mRZzGxLvAjeMofZ4NsL+DxXMLP5oTVPI36KNyzZ02a5jXEDFcK7F7IRUexpH6HRGAco76jmVjUhViO06Js Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 08d43153-df33-405a-ab79-08d782dd6ec1 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2019 10:39:45.1695 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bxvQyrSBWWOz2fSsnVA0oYkvaXRdUpB/ZsdTu4OfM2cI1dwQFL9iudtiJmcfegSGtnomkgJy4DndjZF5ANtVKj4ozMnv49IMbB905jfVSmM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3572 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 18 Dec 2019 09:43:37 +0100 Subject: Re: [dpdk-dev] [PATCH v3 24/36] net/i40e/base: make i40e_set_mac_type() public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ACK -----Original Message----- From: Ye, Xiaolong = Sent: Monday, December 16, 2019 3:43 AM To: Xing, Beilei ; Zhang, Qi Z Cc: dev@dpdk.org; Stillwell Jr, Paul M ; Ye,= Xiaolong ; Kwapulinski, Piotr Subject: [PATCH v3 24/36] net/i40e/base: make i40e_set_mac_type() public Make i40e_set_mac_type() public. i40e driver requires i40e_set_mac_type() t= o be public. It is required for recovery mode handling. Without this patch = recovery mode could not be detected at probe() function. Signed-off-by: Piotr Kwapulinski Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/i40e_common.c | 4 ---- drivers/net/i40e/base/i40e_prototype.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i4= 0e_common.c index eddc91e36..4f87ec9fa 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -14,11 +14,7 @@ * This function sets the mac type of the adapter based on the * vendor ID and device ID stored in the hw structure. **/ -#if defined(INTEGRATED_VF) || defined(VF_DRIVER) enum i40e_status_code i4= 0e_set_mac_type(struct i40e_hw *hw) -#else -STATIC enum i40e_status_code i4= 0e_set_mac_type(struct i40e_hw *hw) -#endif { enum i40e_status_code status =3D I40E_SUCCESS; = diff --git a/drivers/net/i40e/base/i40e_prototype.h b/drivers/net/i40e/base= /i40e_prototype.h index afebf441d..2b6198985 100644 --- a/drivers/net/i40e/base/i40e_prototype.h +++ b/drivers/net/i40e/base/i40e_prototype.h @@ -472,10 +472,8 @@ void i40e_set_pci_config_data(struct i40e_hw *hw, u16 = link_status); #endif /* PF_DRIVER */ enum i40e_status_code i40e_enable_ee= e(struct i40e_hw *hw, bool enable); = -#if defined(I40E_QV) || defined(VF_DRIVER) enum i40e_status_code i40e_set= _mac_type(struct i40e_hw *hw); = -#endif extern struct i40e_rx_ptype_decoded i40e_ptype_lookup[]; = STATIC INLINE struct i40e_rx_ptype_decoded decode_rx_desc_ptype(u8 ptype) -- 2.17.1 -------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydz= ial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-31= 6 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata= i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wi= adomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiek= olwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the s= ole use of the intended recipient(s). If you are not the intended recipient= , please contact the sender and delete all copies; any review or distributi= on by others is strictly prohibited.