From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CDF9FA04BC; Fri, 9 Oct 2020 13:25:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCEC31D53A; Fri, 9 Oct 2020 13:23:59 +0200 (CEST) Received: from alln-iport-1.cisco.com (alln-iport-1.cisco.com [173.37.142.88]) by dpdk.org (Postfix) with ESMTP id E850F1D446; Fri, 9 Oct 2020 13:23:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1055; q=dns/txt; s=iport; t=1602242638; x=1603452238; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OG+lOF1j95KzFp94ouas7Q6iQjXJRQoVtQ5XxhumtZo=; b=YRB1klsgA90QHVd7cDIAiDMziqjYyaqxkibY3eizXltZlRJMvsL6yUG3 GV/BiKzne6u/xsgm82Gok4V9ZfOeJCIak5dHlawUgG7zKAycChyulslkl K8QhYsV7Ufk+DgPpJUhnDLry7U/ggojhly0/kupNbfxSvotXUusK77Tnf c=; IronPort-PHdr: =?us-ascii?q?9a23=3AqnmScxXrlMpfeZ9y1esU3RgmcqPV8LGuZFwc94?= =?us-ascii?q?YnhrRSc6+q45XlOgnF6O5wiEPSBNyDuftejqzdtKWzEWAD4JPUtncEfdQMUh?= =?us-ascii?q?IekswZkkQmB9LNEkz0KvPmLklYVMRPXVNo5Te3ZE5SHsutbkfX5Ha16G1aFh?= =?us-ascii?q?D2LwEgIOPzF8bbhNi20Obn/ZrVbk1IiTOxbKk0Ig+xqFDat9Idhs1pLaNixw?= =?us-ascii?q?=3D=3D?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CYCQBqR4Bf/5ldJa1ggQmDIVEHgUk?= =?us-ascii?q?vLAqHeQONUph7glMDVQsBAQENAQEtAgQBAYRKAoIRAiU4EwIDAQELAQEFAQE?= =?us-ascii?q?BAgEGBG2FXAyFcgEBAQEDEhUTBgEBNwELBAIBCBEEAQEfEDIdCAIEAQ0FCBq?= =?us-ascii?q?FUAMuAQOeDAKBOYhhdIEBM4MBAQEFhSoYghAJgTiCcoYxhBIbggCBVIJNPoQ?= =?us-ascii?q?/BYNDgi23XgoggkibCYMTniOTHIF6nicCBAIEBQIOAQEFgWsjgVdwFYMkUBc?= =?us-ascii?q?CDZIQilZ0NwIGCgEBAwl8jDsBgRABAQ?= X-IronPort-AV: E=Sophos;i="5.77,354,1596499200"; d="scan'208";a="557786061" Received: from rcdn-core-2.cisco.com ([173.37.93.153]) by alln-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 09 Oct 2020 11:23:55 +0000 Received: from XCH-ALN-004.cisco.com (xch-aln-004.cisco.com [173.36.7.14]) by rcdn-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id 099BNsX5002545 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 9 Oct 2020 11:23:54 GMT Received: from xhs-rcd-002.cisco.com (173.37.227.247) by XCH-ALN-004.cisco.com (173.36.7.14) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Oct 2020 06:23:54 -0500 Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-rcd-002.cisco.com (173.37.227.247) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 9 Oct 2020 06:23:53 -0500 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 9 Oct 2020 07:23:53 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iD0EwfnkhvShEnWROasG6JcW2nYPypn9C6xcP0GX76H1LvhXRIy+HKT6lyMwrC5+sdZraNgyB9Zk/9XZHTWZU7r5/xwSzvFoH8KXLFNonjpdVWwqlTim6288jNrovDrrIJBkrOM/dDbYEB/wnObLY3NL8ZLIJutYBvvXC/N+/XfqgKyhnUG+JBn2s/DHtMmZwL8h613DBcYy5SaUkZ/kI+1dZjYbKma2+M/qtlE2FRmb2qZR8h49t/i1fZ5UP50fonIsykiptlROv1MicEmB6b+eac7O+rAXQT6XjiOWZ+0MwtZLbdxXSe6jCwSatMknc+VAUzdq3wMImet3xBshew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OG+lOF1j95KzFp94ouas7Q6iQjXJRQoVtQ5XxhumtZo=; b=K8CNcqUGZtCKgZuhk4ZN/IA0XWmvmevX+Sn5mnltUFcG7IzzLQeNPvxyLdEb4Eu1KcfdGF0mkV7wbKD8NhteyfbdN+bt6CiD6gRsikQW0YZtvXRGJwOkXZ+91b4dM3xzcLQXt6HzkG0aFiU27uSH3rL10O68UeiaO5oUaJpNgF9b4Qe2VIuN4Mv/N3tmWNuwSedj7Mg1bqx8hZDnKKBzpSBmZ6fkoPDV/E+4gZvCZM6LYAwj3t/O9Uq1a0+ZXfeDFQ9UE5dvh4/5ADGEedC/gpa2uAEqZUjywKRoHwD9TCF+hm45TztmxqeebQ59nBg0tjuA3zlzHhSKsuG3KPryNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OG+lOF1j95KzFp94ouas7Q6iQjXJRQoVtQ5XxhumtZo=; b=iGkaVtrKqD8YOr8lqJ2btXEEg6hAre0FOBJE5myNOS3RfJkHJEMFkMAPnc7ml0b5i5lTdZoadR3IojCY7ivmMLKuTMbB5KXJOUW2P06+AxA39Nf6E24zhe0FsMON1X4ppAgqy81BXdcruokKDLy+NSoE/44gm9d1BEe3C68/NzU= Received: from BN8PR11MB3572.namprd11.prod.outlook.com (2603:10b6:408:82::32) by BN6PR11MB1396.namprd11.prod.outlook.com (2603:10b6:404:4a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Fri, 9 Oct 2020 11:23:51 +0000 Received: from BN8PR11MB3572.namprd11.prod.outlook.com ([fe80::689a:c07:354d:b2a5]) by BN8PR11MB3572.namprd11.prod.outlook.com ([fe80::689a:c07:354d:b2a5%7]) with mapi id 15.20.3433.046; Fri, 9 Oct 2020 11:23:51 +0000 From: "Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)" To: Honnappa Nagarahalli , "dev@dpdk.org" , Phil Yang , "ferruh.yigit@intel.com" CC: nd , "stable@dpdk.org" , nd Thread-Topic: [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Thread-Index: AQHWlcom3/LY3elA4EeYTU4y0WCunKmMbVSAgALD6qA= Date: Fri, 9 Oct 2020 11:23:51 +0000 Message-ID: References: <20200921192254.20560-1-honnappa.nagarahalli@arm.com> <20200928190334.40624-1-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=cisco.com; x-originating-ip: [213.81.223.163] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9b61cf8d-3dd2-4f33-41ad-08d86c45ccb1 x-ms-traffictypediagnostic: BN6PR11MB1396: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WRpeceEkwzYDsS6N8Fegf2iP6pc6f5sp3gN7gMSAaYo64hK+/r4IjIcgUi3GWmdKi/sujLOse1nCzTfhxwQYjRbkaDRd3FZGbDNPI4CwE4UwZIdirV7NMW7Mz0ZifxSeMxQvRkwK3aAKfX3YUJ4iGuINSRmga1nJrVuvlBr3C1YX+Np3Pf74KqpYzgMBR4Z4+dHXDeq80jQt8PEG1N6V8KjliKvXCJrDoczTivSxBHDlE8Ry7QnNbVWWYcBfggF+AEKgwMRkULzQgws+denfSKfqw6P4tf15jQlCE43NKTUw9l+6vHaIT2Qn92zegIZSIhBRT0IICTXcuDXqSEwh1Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3572.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(136003)(39860400002)(366004)(376002)(64756008)(8676002)(186003)(33656002)(9686003)(86362001)(66476007)(66946007)(8936002)(66556008)(76116006)(2906002)(4326008)(55016002)(110136005)(52536014)(15650500001)(53546011)(66446008)(6506007)(316002)(478600001)(54906003)(5660300002)(71200400001)(7696005)(26005)(83380400001)(4744005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: j0NVwLw+y/F+PgkRaK+D4vgNLh3QfliCel58mN0vUujSI7w0PbVZv/Gm7amkGFDJMKta/3xV/mZjOae7PrQ0CPd157AYPnAKtjSRRU5aa3ZEUxpZFJWaXY5MhtQtq+1lfZK52Vn+q2ARrIw3YabXyRfpJ10nzQrfgJrk9ZWEky+zuJPU1nvnfGHGn79xhPwDsBvJw0mqoVgXnh3EcDAuEDaa4RadbXUpKTVQs40Gw4aPDeCydJPLhsjkowSVln3yBWwWED8KFZ9BCZ2LjC85OKmMwP5AAyMCOBOhk/T9QjSmndAl7LZxyP4KIax1NKCLM8L+oTanogViJ8OF4zg6OAEQgMHewCJgcHS03SZC/rTnGc4FZGLpYuNmHIt/F3tbFElO8Uc8ECA16tVAaGHmZY4UW3TtrIbcliWN5wD3856CbiyKwQL1ZvbL3akxw3mq02m8SkYw6oPim8BdvoK+VR0QHx0GXQEaJdF/IfsR7lSZzREBNj9tlGa9y8SL5ah/Bh2L1lkFjpkCSmp1Q51y6kaGZPDsbQYhJ79+bugUlb581WQjHwrO5QHdf85C1h7rF30S93ESzCHv88AXTDB/StcNPOTu9Z+A0dIdgJ1lGv9xcrXYBHZrs8/opy7drkSDBvh9lt2+7MmF3QwCapMhoA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3572.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b61cf8d-3dd2-4f33-41ad-08d86c45ccb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 11:23:51.3788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q9cJOhrE5NPC8tgOxyYExowuiIB7hgF3+5s01s13uFSfn6D1tW/zIr7z7mzEIwheoeqSaHVYnxYumnmZBwdB7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1396 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.36.7.14, xch-aln-004.cisco.com X-Outbound-Node: rcdn-core-2.cisco.com Subject: Re: [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > -----Original Message----- > > From: Honnappa Nagarahalli > > Sent: Monday, September 28, 2020 2:03 PM > > To: dev@dpdk.org; Honnappa Nagarahalli > ; > > Phil Yang ; jgrajcia@cisco.com; > > ferruh.yigit@intel.com > > Cc: nd ; stable@dpdk.org > > Subject: [PATCH v2 1/8] net/memif: do not update local copy of tail in > > tx function > > > > In the case of S2M queues, the receiver synchronizes with the sender (i= .e. > > informs of the packets it has received) using ring->tail. > > Hence, the sender does not need to update last_tail. > > > > In the case of M2S queues, the receiver uses last_tail to keep track > > of the descriptors it has received. The sender is not required to updat= e the > last_tail. > > Updating the last_tail makes it a shared variable between the > > transmitter and receiver affecting the performance. Hi Honnappa, The patch series is looking good. Reviewed-by: Jakub Grajciar