From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C8DFFA04AC; Tue, 1 Sep 2020 07:18:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C04D2B89; Tue, 1 Sep 2020 07:18:52 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 862FD1DBD for ; Tue, 1 Sep 2020 07:18:49 +0200 (CEST) IronPort-SDR: qCMZGckyPS/+gKRbX/sSuD2xxmH2RVp/7pR5LgxN2l+i+mAuA3IvozEHseEB/qq9N9IPdPeBLX do2CMJxoFZPw== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="221336350" X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="221336350" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 22:18:47 -0700 IronPort-SDR: FM3cLtfYr3YbmoOCdPrSuNVOr6tcJNWbE59wcpqbx0v0GhBvyrtmJLPl4hNRtNH4KB0ETkNBD+ 1HXZDuHIUp/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="340904222" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 31 Aug 2020 22:18:47 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 31 Aug 2020 22:18:00 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 31 Aug 2020 22:18:00 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 31 Aug 2020 22:17:59 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 31 Aug 2020 22:17:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LN0Q35L27jwLbPj9A+oCTCdfm8M3CigLEbxsl+/V0otwQbmA1sducWkoVbI0qR6vP3Tqkm76y9HWL4SphuatXBQtcNFKevicNSAPUj+7DveK5+kcg08eekB2vGbV5yxd2r13HfqAl4UHintDeEVBdaXWNZmQLGvpsjdofeobsUbVq0MRA5ICHjl49wn1Yd7RoAdTlEbu5W0xKAduPOPJjnC0OzMr6fBDN+yAwxplSFTnYlcO4jzYmBd1k+4hdzQbrxZ9z3dKXBBlkh4abW5aS17up457AwPwBTFrzwCV4K36E0KgptvyMwciEgisxb3BSTVOjeoKJtFOpQzXBE76kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GerEXwZ8EYYaNPoiS1kZwucthwxGLYIDcYcCKBK5wxA=; b=bDbmOnrLLp+nXaWSlDF4f5zFRyjTZJPI72qvUGsqABdzN3TmDH/jAnpWNpcytYme+U092fhegHCnwPNHeXFXof7tjlW7wte54DYjmIR21R39deQNMiRPWpU3xtGfqCySxxmm8CjOapHTtEwuveebohkf2qIhWsuNcnxyKnRrnIlNZoI9BtxVxz6xkW6Ok5Y+aTuWovojVTgeYgjggUTJIwRnIBYDSw1t2y7WYkqvSjxBIGDk4splyl/mdr8gqLFFxlrpqD68vXLf8Ki/nARInhATJAYchOwNICTp7PTvPW3+e6TIev+KnEUBx0T3tmlnPWEnBZq0dGRSa70jdgeYyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GerEXwZ8EYYaNPoiS1kZwucthwxGLYIDcYcCKBK5wxA=; b=fndVsmfgrWncgOTCgM37vOZcMi1jBuqTfMXPn2lt2cVS11dda3DroAgi6OaoN2QlGCzoZli+Jz0ZnE8wiGSHaJtWv0Gmpof6YDOucgrqGwph5vPP27GS1GJox1FGMnozH8655Pfmym0xlJ76HoAvSz6m8sAE1Vwcj5CN89WIhmM= Received: from BN8PR11MB3715.namprd11.prod.outlook.com (2603:10b6:408:85::13) by BN6PR11MB1649.namprd11.prod.outlook.com (2603:10b6:405:f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Tue, 1 Sep 2020 05:17:57 +0000 Received: from BN8PR11MB3715.namprd11.prod.outlook.com ([fe80::45c2:fb36:838e:6d28]) by BN8PR11MB3715.namprd11.prod.outlook.com ([fe80::45c2:fb36:838e:6d28%7]) with mapi id 15.20.3326.025; Tue, 1 Sep 2020 05:17:57 +0000 From: "Ma, LihongX" To: "Richardson, Bruce" , "dev@dpdk.org" CC: "bluca@debian.org" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults Thread-Index: AQHWetWHMeAgcdlEnke3SQv7BxGJdKlTR2Mw Date: Tue, 1 Sep 2020 05:17:57 +0000 Message-ID: References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200825114447.135030-2-bruce.richardson@intel.com> In-Reply-To: <20200825114447.135030-2-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1cac484-d739-4fe2-f5c0-08d84e366393 x-ms-traffictypediagnostic: BN6PR11MB1649: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1L2IAsdqKvZiR9nm57CsXcKir77hsCtZ+luFd6eXJ66UhjnSDoGmZHHzRFHkoSiqeEE9m/5q8YLCZU7oq0BfqV8FbTW8itIXUsUHpSb7S2qvOXlr3g9LBcE7m56nhuayqcqbq1sff1lXuWLLFr3HbkyJNgoOqeSc1cWNXb2t6S+I0kwacFNEyVzheNtpEScURrAuSaWjuAB54Cix00nX5CKxi/igQmOb5J6KlKeEwURlqtrM9MGOrj0w5hloCuz/RNEZGSVIJvGhBMM6T6vu1xbciTUdV+Mj2+zx7X6SuroqqXn6nDgOxoOHSGWIkOTkKxahFEosV4Ml8MMj+sMnEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3715.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(4326008)(54906003)(5660300002)(6506007)(86362001)(53546011)(52536014)(2906002)(26005)(71200400001)(8936002)(9686003)(107886003)(76116006)(64756008)(66476007)(66556008)(478600001)(66946007)(66446008)(186003)(316002)(83380400001)(33656002)(8676002)(55016002)(7696005)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: m6ZXQzqWNt55g7SMCeagHIbz+1qAqJ7c8bJDhTX2LOMv9Q6wZ+Ydu0HPB7KRRUnhpNRAui+MDUTJbgvEO0YGQuv/8fMH6JxNL81F0VysXlwEJrLmmWSat2zqas/ZIglOTB8CQmILtft9PUwggFqLjw18Yht0L/TNd8l/t87ADnWwStO6P0dLaUkWgeyX9WIfmOZ0+zbnR9MnigE11HXQVR9MOdrF3qgFYCbclVtOiq65CKussGJe+nrzVjLvrEmUOIGiwLujqhdrOPF7WQojICuOHV86p0BPRG/qnhLMtNgDue3tzltLg87I7raCqzSzad/MQ6arZ4LroDcvQLYjlTabPSHN+gBsl8r8SNGE811erHo5JlgZKRRyCdcBIHqVKW116dVBE4+Vm/rPdSQjCVt6qnU7jSAMBy8Hn8GE6upo4NHICY3HxJ63ygSSX9gkROtTvA4cUMG6XqCw37EcxtQUrilYYLCi5y3yLT/1Q2BuOaF5JEIsc6EQWkeC1R9uOyiFQaGZcYdAg/ukmLQtAQNuVbrwdnbNvjFxaHK45aUFjhcWdu2prffBGKXy+xVz+69K75ktGGPcE8oPxgcqTlMFmHtkXKn7xL3W4zpCgX/IVNLBL5kbfz1I4FU9vYxq8x8ffR77SjBYIG80GkE1+w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3715.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1cac484-d739-4fe2-f5c0-08d84e366393 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 05:17:57.8337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0kZ/j8PXdT5R5DVcBVQBihIq+NflbJF2dgBfETlPIT991g1bdLt1VI3gG+PxG6657SmOzuE4Ay5F7KjQ5KOOuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1649 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] config: allow overriding some build defaults X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: lihongx Ma Before apply this patchset, set config like DRTE_LIBRTE_I40E_QUEUE_NUM_PER_= VM=3D8 will failed, After apply this patchset, the the meson build can work find. Cmd like below: meson -Denable_kmods=3DTrue -Dlibdir=3Dlib --default-library=3Dstatic -Dexa= mples=3Dvmdq_dcb -Dc_args=3D'-DRTE_LIBRTE_I40E_QUEUE_NUM_PER_VM=3D8' config= -test1 ninja -C config-test1 Regards, Ma,lihong > -----Original Message----- > From: dev On Behalf Of Bruce Richardson > Sent: Tuesday, August 25, 2020 7:45 PM > To: dev@dpdk.org > Cc: bluca@debian.org; Richardson, Bruce > Subject: [dpdk-dev] [PATCH 2/2] config: allow overriding some build > defaults >=20 > In case a developer uses CFLAGS to set different default values for the > defines in the rte_config.h file, use #ifndef / #endif guards around the > setting of those values. For those lines just "defining" a macro without > assigning it a value to be used by code, drop the value argument (where > possible) to make it clearer that that is what is happening, since those > don't need the #ifdef guard. >=20 > Signed-off-by: Bruce Richardson > --- > config/rte_config.h | 110 +++++++++++++++++++++++++++++++++++++++----- > 1 file changed, 99 insertions(+), 11 deletions(-) >=20 > diff --git a/config/rte_config.h b/config/rte_config.h index