From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 789C2A04BA;
Wed, 7 Oct 2020 07:01:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 6650029AC;
Wed, 7 Oct 2020 07:01:47 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 888C829AC
for <dev@dpdk.org>; Wed, 7 Oct 2020 07:01:45 +0200 (CEST)
IronPort-SDR: ymdqws4v3ywVbVKrUeRU4vOi1RqgT4iC1n9h+EAp64x7CdOJRBijaUlHei0VdO3Hn0IMwMczCI
H88peGHe6uIA==
X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="249532008"
X-IronPort-AV: E=Sophos;i="5.77,345,1596524400"; d="scan'208";a="249532008"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga007.fm.intel.com ([10.253.24.52])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
06 Oct 2020 22:01:43 -0700
IronPort-SDR: SCDgfbzIOK4z8Ul0XyYLZ6F3YMv5ezEptRnN8tp+c6ExNAuZrnfRlIvRtcKWB+Cl/INkJVootI
1i3LODu/5pCw==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,345,1596524400"; d="scan'208";a="297315757"
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
by fmsmga007.fm.intel.com with ESMTP; 06 Oct 2020 22:01:43 -0700
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Tue, 6 Oct 2020 22:01:43 -0700
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
via Frontend Transport; Tue, 6 Oct 2020 22:01:43 -0700
Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by
edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.1713.5; Tue, 6 Oct 2020 22:01:42 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=U21uBWcJ5fd+F6zpNgVCTvS4C2ZJUoC5Vm9C1zjqq+VMLYNLyO1nSIlN7dtCZlR54ntYwcHKCv0t1JyFM3QfwdiKMYDLe06E4jZu6C7jDOJ9bza5855r5FEPvX4CEo4z/9l9D9BxWyBqoLdhaq662Zqe60Pk6ucT6fuilDVKdimIzoyQF+If9TVcgf40YsnwocU1TTla6nViAGhnFKQShrGHW4DOqwBeLQTxLR9gAdyCfF3Wpbb1YTNmK8iuZ10KhARL5L35mKye9riURvHdPZEN38g5J04AVslgTAzGJRt310mR5HrcU1R5nxKWvBiuojk0ALk8K3Xsyv4OG9SR1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=6Ho0h7pH0aYR3TRqTYJe5XRm3Vo36yMX6SILYv19tOE=;
b=GWdgsJN3uWm0ZAL8c3Yc+GKrZQyaJoS4TOQvY3bF6uO5lNzTFgUaYTCH4SLvztimBK1NwVe5coL3LAjQODxbK3BkYCKpI4IiovZDSI0CSxv0YJkHeD4EUS6xpC3fFPCHPoDmiN5LFmFMaod6fYD5rPKv/MAHpIZ3W5p9rrOcHNI2R/I8udVnLmINCyeYni+IqoG3FfsxSRucYTf/rw3/1tqACDWkd7rGEeilaq6lIZxXDZhTJ6I7VRMWyTh7Z/UxbCQ67nf1R7SRY+HWIJ3HDNVz5+Tyy8nqjWU5yJyolwQcv6EzyP9fOeMYB9EsE1wvpZYjivEe6KP1bwivn4wuIA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=6Ho0h7pH0aYR3TRqTYJe5XRm3Vo36yMX6SILYv19tOE=;
b=rHroKcytBleFDOJ86SVQKOmd2xglYCepeGI5Og+guEDwAM62v8ZRNqFyYibZxZR6i9obTQmg4IeoiFfr8el/o6aiy1lvjsp2zHv0bBKp3Dh0PCPNsx0AsDPSlHTiwT5hr3oMN2viDSZ4TnvA4//lfkT4dyD3TbdocORBp+uhyzw=
Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31)
by BN6PR11MB3971.namprd11.prod.outlook.com (2603:10b6:405:7d::17)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Wed, 7 Oct
2020 05:01:39 +0000
Received: from BN8PR11MB3795.namprd11.prod.outlook.com
([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com
([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3455.021; Wed, 7 Oct 2020
05:01:39 +0000
From: "Wang, Xiao W" <xiao.w.wang@intel.com>
To: "Power, Ciara" <ciara.power@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Thread-Topic: [PATCH v2 08/17] net/fm10k: add checks for max SIMD bitwidth
Thread-Index: AQHWfI17WYayJN2i6EqbUoErgVA7lqmL1JTQ
Date: Wed, 7 Oct 2020 05:01:39 +0000
Message-ID: <BN8PR11MB3795007B3AAD9B9C494C664EB80A0@BN8PR11MB3795.namprd11.prod.outlook.com>
References: <20200807155859.63888-1-ciara.power@intel.com>
<20200827161304.32300-1-ciara.power@intel.com>
<20200827161304.32300-9-ciara.power@intel.com>
In-Reply-To: <20200827161304.32300-9-ciara.power@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-reaction: no-action
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [112.65.8.219]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 29d43ec3-a769-4fc2-57fd-08d86a7e1366
x-ms-traffictypediagnostic: BN6PR11MB3971:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BN6PR11MB397135BC17940C10713342F5B80A0@BN6PR11MB3971.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2803;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 7h4Z8LRUmdtEi/6J/R+zlWu2mPgiRktp6oMUCNGBWOb8KlfxeEHtyBt0aNofmdqPaMHaEnAhya2u03ZtXqwGWvvc0ml9nR6+leNjZyKLxnpsR2kE9BTx89HsWxmat3EyIDekQmA2neU8rkrreJ25Z4VCUYR+E43IIpX/lxZ/562RN8qTyPVyvY/sw7otMr7IfwYLgn+hOyZRGeQTqlJAbstxvuxwA/8s58Eoe6xNjWigYaV/L5ClfNqU5JRAEnsQa7yH7Fv+/UlEwB7a1s7ePsB+SSObN7P5celBnOEX+q7z5EiEFjDTs8ntew26ThYEfkkZboicpWsHUejpyHgVSw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(8936002)(66446008)(107886003)(86362001)(316002)(9686003)(83380400001)(4326008)(478600001)(8676002)(2906002)(71200400001)(55016002)(110136005)(33656002)(66556008)(66476007)(64756008)(66946007)(76116006)(53546011)(52536014)(5660300002)(6506007)(186003)(26005)(7696005);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: OUwR5Vh8EjT1fVmYBWA6IZwO1kn1xpL3645IV6tcCn80WpFlir3xrxd+ddZNp+u9HkAP73rUQOSRTNO3jirTb/ZQnZ5IKsyBcmMc51SbO3E/c0EwwCRh4lnSZlo1LjW0RTOm4dFVvMQAHgfmA9XM/GLqOmadrmspV+6XvubZ7W3VXBkM8BrJGCFTotEUWg3l+uF1xvFkc+HW8e+vD7s4seM4caGp0rWXqJTCBbWnMzf3TonquQqacPQotAHaiI8H/ZzzIBqaMnptLRPz6UeSJK2vFUDFML0007xTSAfiX1HXjY92VQnSoogkUDyLFlcrLojR8cOaXKPTtMmR2ib4iF/KF8DryzT0+sMDWaX4+MGW93bUrCa1TCUR0gkF2BnR3nd7KJUqLP/x9RvNYTK1ItucouhMbNBmh0SWKgDHl9khCTcosn9AVJFflee4DHTuhsusLpvbpJfAlybQzNQBghSwVcz2V5Lv2hR9fJ4fiXNp07dMxp9koIR/XewTLCrVTM15igoPqP9ZZQFTivJERtgXp8HLgAmmsvrFPAioA2c+IuFeDPS2yoby+jx30XTzM4GcQ+hzlAh+qfqbCwp3wV5qG3Q8BnNmNPvezKUNSbTUd0GK6ggVIE9Je8bFZqVhH1uTtM89Wz37WaVEs1bkIQ==
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 29d43ec3-a769-4fc2-57fd-08d86a7e1366
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 05:01:39.4774 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ndwTPtehZ7Q5qqAbv2CykvbtSa9VETDc8I0HhwpWN//QKcaFeeWUBL3NieOCNW+RI1t0kfvBxL309C1aGeSaRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3971
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v2 08/17] net/fm10k: add checks for max SIMD
bitwidth
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi Ciara,
BRs,
Xiao
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Friday, August 28, 2020 12:13 AM
> To: dev@dpdk.org
> Cc: Power, Ciara <ciara.power@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>
> Subject: [PATCH v2 08/17] net/fm10k: add checks for max SIMD bitwidth
>=20
> When choosing a vector path to take, an extra condition must be
> satisfied to ensure the max SIMD bitwidth allows for the CPU enabled
> path.
>=20
> Cc: Qi Zhang <qi.z.zhang@intel.com>
> Cc: Xiao Wang <xiao.w.wang@intel.com>
>=20
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> drivers/net/fm10k/fm10k_ethdev.c | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
> b/drivers/net/fm10k/fm10k_ethdev.c
> index b574693bca..f7c41d4377 100644
> --- a/drivers/net/fm10k/fm10k_ethdev.c
> +++ b/drivers/net/fm10k/fm10k_ethdev.c
> @@ -2937,7 +2937,9 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
> if (rte_eal_process_type() !=3D RTE_PROC_PRIMARY) {
> /* primary process has set the ftag flag and offloads */
> txq =3D dev->data->tx_queues[0];
> - if (fm10k_tx_vec_condition_check(txq)) {
> + if (fm10k_tx_vec_condition_check(txq) ||
> + rte_get_max_simd_bitwidth()
> + < RTE_MAX_128_SIMD) {
> dev->tx_pkt_burst =3D fm10k_xmit_pkts;
> dev->tx_pkt_prepare =3D fm10k_prep_pkts;
> PMD_INIT_LOG(DEBUG, "Use regular Tx func");
> @@ -2956,7 +2958,8 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
> txq =3D dev->data->tx_queues[i];
> txq->tx_ftag_en =3D tx_ftag_en;
> /* Check if Vector Tx is satisfied */
> - if (fm10k_tx_vec_condition_check(txq))
> + if (fm10k_tx_vec_condition_check(txq) ||
> + rte_get_max_simd_bitwidth() <
> RTE_MAX_128_SIMD)
> use_sse =3D 0;
> }
>=20
> @@ -2990,7 +2993,9 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
> * conditions to be met.
> */
> if (!fm10k_rx_vec_condition_check(dev) &&
> - dev_info->rx_vec_allowed && !rx_ftag_en) {
> + dev_info->rx_vec_allowed && !rx_ftag_en &&
> + rte_get_max_simd_bitwidth()
> + >=3D RTE_MAX_128_SIMD) {
> if (dev->data->scattered_rx)
> dev->rx_pkt_burst =3D fm10k_recv_scattered_pkts_vec;
> else
> --
> 2.17.1
Acked-by: Xiao Wang <xiao.w.wang@intel.com>
Thanks~