From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96CE0A04AB; Mon, 31 Aug 2020 07:35:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D0B6137D; Mon, 31 Aug 2020 07:35:48 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id DEAE3DE0 for ; Mon, 31 Aug 2020 07:35:46 +0200 (CEST) IronPort-SDR: +ay9++qRsV3/zaN4FF/FYLAJJsaPd1KWHLo0eDXZQVdzuM4tU4x4BUWAaF3Mp49mFPAmPvhhYh AVL8aggG/Leg== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="218461826" X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="218461826" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2020 22:35:45 -0700 IronPort-SDR: NZ4hDFsG8kha+Lhanf1uMN59KnCIvCuPwnicebp+rzWxw4GxCQ/ATiBpqzwhq9tQ0eS0DjOc8x TYQPCkhae3fg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="314238626" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 30 Aug 2020 22:35:44 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 30 Aug 2020 22:33:41 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 30 Aug 2020 22:33:41 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Aug 2020 22:33:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mPlOw7RgqJ8aNcsp9DPxi7B/pCvza95Jmk+fnioUZND0BLhu0SRww+mgt0ibLvBD9jgoseECBnSOX1K1E66uEhawHq9ot7pIdgzYHrNhZkf/4b5BrKBXyPWv7RoEuahWQJIUbsXG7xPiqlxbwGJ8cQ7sSzd3si8+KXWetR25MfRgdPVRJYnBfp6oVjrRUEG0bYthOWnbLOQG1doxtDYjKJIhGyVk0BRFfD5oSSNWcIwHeVZLBFl9PVKGqpwrW2AVnjyDFvxFA72/rz5C3cFNqxJ/7Bq45/Ks4/pIBN6wzgrpf7GgFNiOOzJZcB0hIVGsMhVe+/dZjPqCcS2XesP10Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxmwH8kKViMwBIJT5qWS9awpZ85v/fUNUk/eahTrYQg=; b=b2Uk6THsvyukzhywMMo2En/Aig8gwHdbvnW/QoeNMURyLylOVxgaBZFpZ/Hqjwg5Hs6A6A60YioYMvCT3SaehZUwBTOTh08vLIh4OwP/3A3QgMQgeaF1S6ImuAIkZHMCg3uAcL4N4yBdI0151aq6R7kZRSIji+o6QuylpnU3yimzhYhXqHuREtfSh0nTQ+ZFHkZDlASllenSNGJVxiu7ZU0ecceqTgYrTNCHj58e5FrnftGcfdJ21UIEOCXcwuQH0OI3njfAjPqpX0iYI0jOMmz6I756HmRS6ntYrtzb/CbsnETvH4ER0nVSB9VSD8AEPMQKIQSitQkQAMSaEN3T/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxmwH8kKViMwBIJT5qWS9awpZ85v/fUNUk/eahTrYQg=; b=CC5FHHYBRASbGCxMCZODCn1YlWisPiNFn5eshCj185322qmAJQxNva+a8oWpVWiOmyqbgE/KmiJj5rrGLyf9QuiKbxE+MH4ttPo8N8Osd7PGTM1cDjWSbtYTtBXowta/HnUN4nXbGWJr5HQutnBe+GG/wwo6IBwf5+Xk0vyEvyE= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1971.namprd11.prod.outlook.com (2603:10b6:404:ff::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.21; Mon, 31 Aug 2020 05:33:37 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dd0f:7f49:bc5f:2fde]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dd0f:7f49:bc5f:2fde%5]) with mapi id 15.20.3326.025; Mon, 31 Aug 2020 05:33:37 +0000 From: "Wang, Haiyue" To: "Guo, Junfeng" , "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor Thread-Index: AQHWe1hYGITpmLwYl0y7S/RYP1bjcKlRuNYg Date: Mon, 31 Aug 2020 05:33:37 +0000 Message-ID: References: <20200826032141.333400-1-junfeng.guo@intel.com> In-Reply-To: <20200826032141.333400-1-junfeng.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aeeb5f3f-116d-4a2c-426f-08d84d6f6929 x-ms-traffictypediagnostic: BN6PR11MB1971: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:497; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r/90Da+fYPkAbjCYyz/hzcH99BKNs+kUCGEIGqD19JUGvWGyfBOWnVMX2mNGFS4JBYGG816Gm805+EL/K6lHsYGnVvNXhhrKds42Ouef/q4vK3ZkL0CVs35j2ZlFacdJ0JR7Sp0MQEPjxVdgJjhS4KdpjXlNImCefsAB08Pmb834Hb5bhD3BW4ChvUcWBBTxRX40S192W0a2gA7FQfPXX5FBTxfuI+sR8doNJNmphg4DRVMn0KkAWuk1foagCl1rFDvwwbBjBE0kM8qGIyHicl/V97zxsIvhpsvYBLQ05If51tS28U73ZZkcAyOqNqoa x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(2906002)(186003)(86362001)(4326008)(6636002)(8676002)(8936002)(52536014)(7696005)(53546011)(33656002)(71200400001)(5660300002)(6506007)(478600001)(83380400001)(316002)(66556008)(55016002)(9686003)(110136005)(66946007)(66476007)(66446008)(64756008)(76116006)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: iYiJxUSgC6PIAup02+k5CnYkbuTPbCUQXV0aXi+yAWbFBHDiq+f3FDz7FHbTw7JeA7vx0puko+cGoleoQKZ1dHGKmlYOpjWw5DxXt2IfpVRlvSlPxr8Yh2GzLn2dwnAGs4HK8BZeeT7XpecwmJ7xfX40o8UmakpD8cZzeo58kLqiSUKEZRvREX4wVRAy1YpbgjbJqlxkpbdcPTjcyvnXLoh6C+GgSNcZwXVFjHZK5J4uudmvSAlfE2Vz4n8tFAzpoAzVc6b2ICXWr+d/PXd/cVbVuvspO7Rj6DWzJW4/RiVJKeDibnWxQSfVpkB1cyHfYnnSbclrLP0KAaffjl8PNf6D6fLpFgebMnPrCMRt+NG/1Y9umQmUs6v0MHWoTzskSazpfz+uApxdNrHX4FhtmpHugRcC+wzOtorkYvKYfjZDPc3nL8f16VwOfjgD6MgDphZUCU8tuNwu13CZVhvCIdCJ471PCwO9lGlCiMLCua311uSbemx5jTr9NsIJ3exm/mFPrZ9MYjelQM6Xc8XyT/xoocksfSw6fi9M9zQn5apNKUfcz4Ze5Ex37zSR9F7BH4oRnZOrCa/j7g3ADXXtSNl50zOxkUR4FErlYmZmxv0wy93TNTBf8BuFl81OrWfxWpicH9JnUF9PyUI7d/4+CA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aeeb5f3f-116d-4a2c-426f-08d84d6f6929 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2020 05:33:37.1736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VmBPQXSAaUfyOWZhBYrqukFpXJauI+JAJKyun7Yot7QOGjl53eS8OJWeEUga8n7wO59MhODobu1BcM7rGBGGVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1971 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice: add support for Auxiliary IP Offset Rx descriptor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Guo, Junfeng > Sent: Wednesday, August 26, 2020 11:22 > To: Zhang, Qi Z ; Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Wang, Haiyue ; Guo, Junfeng > Subject: [PATCH] net/ice: add support for Auxiliary IP Offset Rx descript= or >=20 > Add RXDID #25 to support Auxiliary IP Offset Rx descriptor, including > FlexiMD.4: Outer/Single IPv4 Header offset > FlexiMD.5: Outer/Single IPv6 Header offset > And parse the valid IP Offset into mbuf by flexible descriptor > section via devargs "proto_xtr" with "proto_xtr=3Dip_offset". >=20 > This patch depends on: > commit e0c8ed904083 (net/ice: optimize the FlexiMD hardware check) >=20 > Signed-off-by: Junfeng Guo > --- > doc/guides/nics/ice.rst | 14 ++++- > drivers/net/ice/base/ice_lan_tx_rx.h | 1 + > drivers/net/ice/ice_ethdev.c | 10 +++- > drivers/net/ice/ice_ethdev.h | 1 + > drivers/net/ice/ice_rxtx.c | 77 +++++++++++++++++-------- > drivers/net/ice/rte_pmd_ice.h | 13 +++++ > drivers/net/ice/rte_pmd_ice_version.map | 1 + > 7 files changed, 90 insertions(+), 27 deletions(-) >=20 [...] > + /** > + * No need to check XTR_MD.#_VLD bit in Status/Error fields for > + * Protocol Offset according to CPK HAS 7.9.8. > + */ These comments are no need, since HAS doc session is internal information, = and the code is clean enough: if (chk_valid) ... else... > + if (rte_le_to_cpu_16(desc->flex_ts.flex.aux0) !=3D 0xFFFF) > + metadata =3D rte_le_to_cpu_16(desc->flex_ts.flex.aux0); > + else if (rte_le_to_cpu_16(desc->flex_ts.flex.aux1) !=3D 0xFFFF) > + metadata =3D rte_le_to_cpu_16(desc->flex_ts.flex.aux1); Others, Acked-by: Haiyue Wang > 2.25.1