From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B207A04B7; Wed, 14 Oct 2020 10:40:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 779521DCAE; Wed, 14 Oct 2020 10:40:19 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7856E1DCAC for ; Wed, 14 Oct 2020 10:40:18 +0200 (CEST) IronPort-SDR: p+GThSPL/u0DWAHk95Rne6WH9cLKWI96BTfoq0JuZTVnlFHoUR1vD/mmfiH9QhModwUSbq3oWf HJXmc+OzPa3w== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="250763443" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="250763443" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 01:40:16 -0700 IronPort-SDR: yHhbKJiWc8nyjRYsPR3hnvrobDGzssiOw38Ui097Fi2BWCY9ZYYQjtPYb4s9fGSQOcQYJC3fye jcOLmvykJPOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208";a="299887488" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga007.fm.intel.com with ESMTP; 14 Oct 2020 01:40:16 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 14 Oct 2020 01:40:16 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 14 Oct 2020 01:40:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 14 Oct 2020 01:40:15 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 14 Oct 2020 01:40:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HKFORA2Yw/pSc2JLldhMHyKIr07mWp0ppT1/0EBKQlDD0HXWhrN+OCWYhKAU3WLuHjZB5muygM5/hNdenGrfjBbDNLOuGXhjVXix/6wuzvN3KQ8kf+XBARnGJbVzAEV4kIKmjOz5KoNVWjYs67tWVoxQKJKEgU8Snjjd4V+zqreozmhXFESGFXCUuT4KeiOCcZE/uYIwMND3nmBbw5bDVfrkmmYADVK3dgNXn/E43mMgO85OjYa27l4w18BIH2VCUdSXObMvNAWMGYfVBtJeKeC9cDx1XMXjew8qWZn9ZoHq+fEG9KBwhS/jooEo2bPd/gbR3XGZYWoJoPJcSDZmGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7wm2i7/rTBY02rM6S5eDyirOXwK+65KN4YmGjOp2xcQ=; b=AenWkAZfyLL6MwfT3lNek//gEvxSkVwwgWeP9+tClWBXD50Y8W3Y8M9PA7BN4g3cXhb3BtmVMpvJIXZbHyc3u1ciwsNhtIz9iHB2UpzRB0wo5w1SUc9BWXnjLf3yCq0E3zUipVKyJ5s83Uw9k7PcbF1dMjo2YbmDSZSKlhuBMdYX2APKC6F9msgHQr/B/jjSA2V/BIFVvm9qdx/48dTPhq3DeaCkTvoeB8QYKEHzuRykIr3OwXg/FcnaaPwLxkqD/NFi4gJSP+57ywl4sqU7Ja5yXe4G0sK0+eYwdDLJa87JPfiX70IKk7NKtViqZAcA5xL82wQkoVs/JLvyRvC7ZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7wm2i7/rTBY02rM6S5eDyirOXwK+65KN4YmGjOp2xcQ=; b=My7sRPYhGsRuIbW4bB9vgr3yGD0l46afodTu/24+9kmunNrEDGm9wn/HR9YvC1qdMzMl0pQu3Y3Nw5xcsVbFAafSNc2gmbptDL3CMIqGKx+xjX6VMKpaptSkAjKfbt49mY2F32QXY/TA/KRuljzfjR4iRp4SjWaucgPJ30PuKwE= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR1101MB2114.namprd11.prod.outlook.com (2603:10b6:405:57::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.23; Wed, 14 Oct 2020 08:40:11 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3477.021; Wed, 14 Oct 2020 08:40:11 +0000 From: "Wang, Haiyue" To: "Yigit, Ferruh" , "John W. Linville" , "Loftus, Ciara" , "Zhang, Qi Z" , Shepard Siegel , Ed Czeck , "John Miller" , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , "Rasesh Mody" , Shahed Shaikh , "Ajit Khaparde" , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , "Guo, Jia" , Marcin Wojtas , Michal Krawczyk , "Guy Tzalik" , Evgeny Schemeilin , "Igor Chauskin" , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , "Wang, Xiao W" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Wei Hu (Xavier)" , Yisen Zhuang , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , Alfredo Cardigliano , "Xu, Rosen" , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , "Long Li" , Martin Spinler , Heinrich Kuhn , Tetsuya Mukawa , "Harman Kalra" , Jerin Jacob , "Nithin Dabilpuram" , Kiran Kumar K , Akhil Goyal , "Richardson, Bruce" , Andrew Rybchenko , "Wiles, Keith" , Maciej Czekaj , Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" , Yong Wang , "Thomas Monjalon" CC: "dev@dpdk.org" Thread-Topic: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats Thread-Index: AQHWodGQdS4LKLb0bUitOw4x4iBCxKmWwXpw Date: Wed, 14 Oct 2020 08:40:10 +0000 Message-ID: References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <20201014022649.2165524-1-ferruh.yigit@intel.com> In-Reply-To: <20201014022649.2165524-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2af592c8-488f-4dd0-2bc4-08d8701cc354 x-ms-traffictypediagnostic: BN6PR1101MB2114: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iXGQp4x0gPnaoGB6l6ptFFxEzmEVqbkDlu57/KReLNTXmYrwxotS3ZGsxGE+RWiY7WKj5DXkdsNxXZc+clnV5eDg3JpOqSl3GqQtXvGgxEfXD9IC2BOAgea+ByjmpB/fLk+Uz60CYquVx3UHAJPQfz3L0eJKNIu5ZGxS40yjSbkcPD4jTVHQEGX1TH40ha5zAyVgXKXmOUc+/A2YqZaSldMrMXI1LurRPVxV7uF5zNk+DpmhHGMqUYUy/PXXD8pKB47hjDe/s5KdWJ3wCpmOKKMW5VN4Jl9GIcjXaej+VyzJITzUfqxxS9evRJ2itTp65ahvZZUw2F66dL4E1Uh6WVAOYj1pbjV+SP/wWXkRK0K47SRjlY9+vttpV8H6NT1d x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(86362001)(186003)(9686003)(64756008)(478600001)(7696005)(66476007)(66946007)(52536014)(1191002)(33656002)(66556008)(7366002)(76116006)(110136005)(316002)(4326008)(7406005)(66446008)(5660300002)(7416002)(71200400001)(8676002)(26005)(6506007)(53546011)(83380400001)(8936002)(2906002)(55016002)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: eNyt41GpHMhtEzhN6f2ndownqPxEMOhYQ2ls8ekv5LFCGQNl7e7qNZRWoQl/BOjiVoka4ZESBl4Zo/NP31+I1l1CTZm43uV48/ZBxPMNlATs1EskFItIRpHGeieKM0F9VoX25G6yeYKSeYo5ZAcGUbDU/znSVDp+c/eD1xU/iaJ5XO0sBddA3yIrs92GmvtL/WF28bZk/RPeW382o6J/K5XTLf+6bPT5o2VhJDyPqA24hbxSH1g1EW01B7Ygv3P6N6+GFvY7RUYpWXgHOKoAncqnN17B8huP5912iPHFPkyruz2DhoKI9Tam+7WoZPQbgJ1ed/4z+E68lbxmAmV24XHbEYqPG9Ac1+zMQT/X37z6U+feraT1xHIdSJJzwZY68rC+d9/bOvcyYWejpXmz7js63lVu+18X6W/l8R/Ox5davSThhDWgdLCXToylT3SZHGUDn/I/p6YEtaOcZ4sL2aAiuDue++sdwRSStpkiQr1VffrNmnmVLu3OtLJGU549MqziyKfDqW8L+NuMuNFpNnEkHQY0tcq0++bFobC2FKc6qCc/Xu4DQxUe1Brkv5KPQML2r2gkVT8F4bvIqezEd7RcvLcvNgBQ/TdhtvGTN3BOuZwtcP7adeBFuihrBLpfbCxtHxuhDvIiNZvT6pZMxw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2af592c8-488f-4dd0-2bc4-08d8701cc354 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2020 08:40:10.5107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sbL93pp4NhW8pPn9Vx/Mw81D1X3ZPzngvk2SD6NJZ+85xrX9knoBYHON79cq2zF8aMfFg7adwOKA2VRfRgeSZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2114 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, October 14, 2020 10:27 > To: Yigit, Ferruh ; John W. Linville ; Loftus, Ciara > ; Zhang, Qi Z ; Shepard Sie= gel > ; Ed Czeck ; Jo= hn Miller > ; Igor Russkikh = ; Pavel Belous > ; Steven Webster ; Matt Peters > ; Somalapuram Amaranath ; Ra= sesh Mody ; > Shahed Shaikh ; Ajit Khaparde ; Somnath Kotur > ; Chas Williams ; Min Hu (Conn= or) ; > Rahul Lakkireddy ; Hemant Agrawal ; Sachin > Saxena ; Guo, Jia ; Wang, H= aiyue ; > Marcin Wojtas ; Michal Krawczyk ; Guy T= zalik ; > Evgeny Schemeilin ; Igor Chauskin = ; Gagandeep Singh > ; John Daley ; Hyong Youb Kim ; Gaetan Rivet > ; Wang, Xiao W ; Ziyang Xuan ; Xiaoyun > Wang ; Guoyang Zhou ; Wei Hu (Xavier) > ; Yisen Zhuang ; Xing, = Beilei > ; Wu, Jingjing ; Yang, Qimi= ng ; > Alfredo Cardigliano ; Xu, Rosen ; Shijith Thotton > ; Srisivasubramanian Srinivasan ; Jakub Grajciar > ; Matan Azrad ; Shahaf Shuler ; Viacheslav > Ovsiienko ; Zyta Szpak ; Liron H= imi ; > Stephen Hemminger ; K. Y. Srinivasan ; Haiyang Zhang > ; Long Li ; Martin Spinler = ; Heinrich > Kuhn ; Tetsuya Mukawa ;= Harman Kalra > ; Jerin Jacob ; Nithin Dabilpuram= ; > Kiran Kumar K ; Akhil Goyal ; Richardson, Bruce > ; Andrew Rybchenko ; Wiles, Keith > ; Maciej Czekaj ; Maxime Coqu= elin > ; Xia, Chenbo ; Wang, Z= hihong > ; Yong Wang ; Thomas Monjalo= n > Cc: dev@dpdk.org > Subject: [RFC v2 1/2] ethdev: provide device flag to bypass ethdev queue = xstats >=20 > Queue stats are stored in 'struct rte_eth_stats' as array and array size > is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >=20 > As a result of technical board discussion, decided to remove the queue > statistics from 'struct rte_eth_stats' in the long term. >=20 > Instead PMDs should represent the queue statistics via xstats, this > gives more flexibility on the number of the queues supported. >=20 > Currently queue stats in the xstats are filled by ethdev layer, using > some basic stats, when queue stats removed from basic stats the > responsibility to fill the relevant xstats will be pushed to the PMDs. >=20 > During the switch period, temporary 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' > device flag is created. Initially all PMDs using xstats set this flag. > The PMDs implemented queue stats in the xstats should clear the flag. >=20 > When all PMDs switch to the xstats for the queue stats, queue stats > related fields from 'struct rte_eth_stats' will be removed, as well as > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > Later 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag also can be > removed. >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/net/e1000/em_ethdev.c | 1 + > drivers/net/e1000/igb_ethdev.c | 2 ++ > drivers/net/igc/igc_ethdev.c | 1 + > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ For e1000, igc, ixgbe PMDs, Acked-by: Haiyue Wang > /** > * Iterates over valid ethdev ports owned by a specific owner. > -- > 2.26.2