From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix memzone leak when firmware is missing
Date: Tue, 6 Jul 2021 15:07:20 +0000 [thread overview]
Message-ID: <BN8PR11MB37953BA5F5695B83E2551D6DF71B9@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210706141237.30492-1-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, July 6, 2021 22:13
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> Subject: [PATCH v2] net/ice: fix memzone leak when firmware is missing
>
> Caught by our QE.
> When the firmware is missing, memzones were not released.
>
> $ dpdk-testpmd -c 0x1f -a 0:0:0.0 -- -i
> ...
>
> testpmd> dump_memzone
> ...
> Zone 6: name:<RTE_METRICS>, len:0x15040, virt:0x1661b24c0, socket_id:0,
> flags:0
> physical segments used:
> addr: 0x140000000 iova: 0x140000000 len: 0x40000000 pagesz: 0x40000000
>
> testpmd> port attach 0000:5e:00.0
> Attaching a new port...
> EAL: Using IOMMU type 1 (Type 1)
> EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:5e:00.0 (socket 0)
> ice_load_pkg(): failed to open file: /lib/firmware/intel/ice/ddp/ice.pkg
>
> ice_dev_init(): Failed to load the DDP package,Use safe-mode-support=1 to
> enter Safe Mode
> EAL: Releasing PCI mapped resource for 0000:5e:00.0
> EAL: Calling pci_unmap_resource for 0000:5e:00.0 at 0x2200000000
> EAL: Calling pci_unmap_resource for 0000:5e:00.0 at 0x2202000000
> EAL: Driver cannot attach the device (0000:5e:00.0)
> EAL: Failed to attach device on primary process
> testpmd: Failed to attach port 0000:5e:00.0
>
> testpmd> dump_memzone
> ...
> Zone 139: name:<ice_dma_17168374657430093156>, len:0x1000,
> virt:0x1660ed800, socket_id:0, flags:0 physical segments used:
> addr: 0x140000000 iova: 0x140000000 len: 0x40000000 pagesz: 0x40000000
>
> With 20 tries attaching a net/ice port, we would end up with:
>
> EAL: Probe PCI driver: net_ice (8086:159b) device: 0000:5e:00.0 (socket 0)
> EAL: memzone_reserve_aligned_thread_unsafe(): Number of requested memzone
> segments exceeds RTE_MAX_MEMZONE
> ice_dev_init(): Failed to initialize HW
>
> Fixes: a4c8c48fe3f4 ("net/ice: load OS default package")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v1:
> - switch to ice_deinit_hw() helper,
> - fix build for Windows,
>
> ---
> drivers/net/ice/ice_ethdev.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Acked-by: Haiyue Wang <haiyue.wang@intel.com>
> --
> 2.23.0
next prev parent reply other threads:[~2021-07-06 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 8:56 [dpdk-dev] [PATCH] " David Marchand
2021-07-06 12:40 ` Wang, Haiyue
2021-07-06 12:47 ` David Marchand
2021-07-06 12:53 ` Wang, Haiyue
2021-07-06 13:27 ` David Marchand
2021-07-06 13:36 ` Wang, Haiyue
2021-07-06 13:50 ` David Marchand
2021-07-06 14:12 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-07-06 15:07 ` Wang, Haiyue [this message]
2021-07-07 0:35 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB37953BA5F5695B83E2551D6DF71B9@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=paul.m.stillwell.jr@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).