Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error

["Wang, Haiyue" <haiyue.wang@intel.com>]

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Tuesday, April 27, 2021 16:51
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>
> Subject: [PATCH] net/e1000: fix param misusage when set rte flow error
> 
> This patch fixes parameter misusage when set rte flow action error.
> 
> Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>  drivers/net/e1000/igb_flow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Haiyue Wang <haiyue.wang@intel.com>


> diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
> index 33f6b1d..e72376f 100644
> --- a/drivers/net/e1000/igb_flow.c
> +++ b/drivers/net/e1000/igb_flow.c
> @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
>  		memset(filter, 0, sizeof(struct rte_eth_ntuple_filter));
>  		rte_flow_error_set(error, EINVAL,
>  			RTE_FLOW_ERROR_TYPE_ACTION,
> -			item, "Not supported action.");
> +			act, "Not supported action.");

Thanks, Connor.

Just wonder how do you get this error ? With some code scan tool ? ;-)

>  		return -rte_errno;
>  	}
>  	filter->queue =
> --
> 2.7.4