From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C7E4A0A02; Tue, 27 Apr 2021 15:22:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 178CF40150; Tue, 27 Apr 2021 15:22:39 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 73E644014E for ; Tue, 27 Apr 2021 15:22:37 +0200 (CEST) IronPort-SDR: QDomBL5E/OvxloKr9E5VyXMM5HgBknkqPQBdhYFojBFEOU/1sRfbWmuD1V58WUv0djfh856REI 7TVWZJkUGk3g== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="281839104" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="281839104" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 06:22:36 -0700 IronPort-SDR: QLtnjDRej2MTWVgMB1PbRReTA1yBYQ1gDTeXilYoDD8x+YcaN1ztyiRazgsKHovpJAIXE9l5KY Vy511HodAA9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457640865" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2021 06:22:36 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 06:22:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 27 Apr 2021 06:22:35 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.55) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 27 Apr 2021 06:22:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QC/00JRuHRskV7rH0g6qWWdg1dvUaLu5/No1skip9Kf2Z1jM0pZNL83eAVNYymSIsxWxXYZtSjbObwqU8/5+ng0aF0IdPjWBFYR6p2SiiYE38TlSm4FzcJCMCl1M9+m77Yy4/tb+dXU3E56wviZYvWMAlEt5fj25lv2tFdiYF/NDwEafkf8s9NZdKAzzbo3jZ0h5Lq38p/GZpA/YY6D/9Pb/3GLzSVxj3PC0Ckj+WvX24kCmEGcTiXBIIBzBx6cpc+/mVi+Tv5bryQ1yjZO9fC2W4lnXnLpfKJE/oo47D2glBUsFrOfv2XO6gQ+OgEOaOIUVcPJ/GUCZLpgcYsxiDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=erWCzfvk11ON6imbKMuknoeK3r5eOw9EFH737j1L1Do=; b=BPPJwT32f66pjY2hsyNpStFamCjM3ufM5RNuHBa3tbtn9bmUwsBukIB0ylky1nACZM3P1dNb0OJj3pTyEZ1yL0XdPYsQGp6EnUl/hnrfIlvGayPQZzwEl40h4il8BCZs0DtW49M8vh3zsPCLVFe7ixKq3gX3tFvJOx4rmIVY/kDjbYfOIs9Zan0EQWVjA/Dj/8UoyG4fpaKjgiusAhwVsTL77pTHKJXg6L2u+t/sJr0xoLOT59jpSMjMI9VVfpePWauYLV5/UQZlCwWvrjRfuk+jlQVBHHJ8o3l0jzPp+EXpzJNtBN6r3+7kEH/mZpIUqoaR4X0hv46fmABhyzmigg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=erWCzfvk11ON6imbKMuknoeK3r5eOw9EFH737j1L1Do=; b=E2O7tKL6qpETArXWvvxykhcwSdNBL73RtlUcF1Ki+ZnVsHSnvydUlvJl13rXyVmZDty355TPezdaQF3t64FokYqujaq+vxya5SiHXPSMkotHv2j35/8Am/zjq2elFRKKOnwxLyEbfh+YxC59iCDKFXXrk6TWqU/jbMmrDLXTmWg= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN9PR11MB5387.namprd11.prod.outlook.com (2603:10b6:408:11c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25; Tue, 27 Apr 2021 13:22:32 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 13:22:31 +0000 From: "Wang, Haiyue" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Guo, Jia" Thread-Topic: [PATCH] net/e1000: fix param misusage when set rte flow error Thread-Index: AQHXO0KHEfgRWO9o9ECQvoRQdxZdyarIWbrQ Date: Tue, 27 Apr 2021 13:22:31 +0000 Message-ID: References: <1619513481-15370-1-git-send-email-humin29@huawei.com> In-Reply-To: <1619513481-15370-1-git-send-email-humin29@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.196] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5e9dd6fb-55e0-41f2-f0a4-08d9097f833a x-ms-traffictypediagnostic: BN9PR11MB5387: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:335; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NV2I0A08vzUr106QmyEjpX7EeZEVuIKHyJgBTDg2a0id/ClW+8cLwf07KYabV4sbSe0xFgpL1gFTAI8UGdPkoh3Bqg2FgYroM0vex6+x0iOjTt3TgnnRA4ADnBOKdx+AundvhgK75Tv4KGrNR8daHkc+8oZB3rdDr5TTFWwfnbehZW46h2juFFODFArxbLkgXtxDLz21J2JcfXbbqCL7m9qTcI+Feqjtpj+yeNVPOHSKLQXngV30Oj8wftdzj7b0Gg4i5my8TZZuVeZWu75l3mTVpuiLV8MGuWV0oW9fvVvginoybpIB8tPZuTA2rmHybhvHgXpvj9lMpUjproLv3p5FrrLEdqCXAnUHGBbPaChAgHxGFZ07jTTm5F6IhAJKau7J6K4R8xYS7+RRy7AORK0KIZCHvk5OwqUzmb1ErVD+ro2XL26YS324YjBmhkeuaAWyW644jhkRqfKWyFBMx5KNcJw7gUJhoaqEfecLTOVBFmQmKUICONe1d4EGAh+yRaUdSoSYUXXBh8nZDtMuhxT5/47O7Q8uzYFu4FbwZ1L+LU3vXiEdKWz3U0utgePu0xDlN2FXtcZAPmHuIEiA2DM3k9Mw89lFzke6AXxFPu0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(366004)(396003)(39860400002)(376002)(346002)(33656002)(4326008)(54906003)(26005)(110136005)(6506007)(53546011)(52536014)(5660300002)(9686003)(7696005)(71200400001)(55016002)(38100700002)(316002)(2906002)(478600001)(76116006)(122000001)(86362001)(66446008)(8676002)(64756008)(66476007)(66946007)(66556008)(8936002)(83380400001)(107886003)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?AmqECdTf5EtxM38HT4c15INwCZdvei3pWJ0cwBjP7N/yshBmIYyQ5Zo1UpEd?= =?us-ascii?Q?QajB08BakjmQbf8SariCA0CZmm14LTdQG1oKb/y6RgVYcjMEQOr0euGCxxRB?= =?us-ascii?Q?BKCgTfvCnF5/9tRB4X+2CVkpAFeElYBJCYWEwHJCQlxM/xVbjqh7/n9OaAI/?= =?us-ascii?Q?EFSJa2ju7X0TlqywaoQgmxYV5IHIECZTr2eqBNhaZrljC5J4Ex104qDJaNMN?= =?us-ascii?Q?ra3Hg03PHTtyl7R2PH98tZbffUTJV4AmVYz/xsmFk0h3+JEQHIddkL+zw3ta?= =?us-ascii?Q?rA6O18bpQzmwMujlALR4/Vb0IRSRMKWcuGHYWdIW2PLfDRf2VoWKYjdfIa5R?= =?us-ascii?Q?dAGBJk+VbGRcdNLA+gx4QLt8CA5R6MVcthfH74wVeNbAOb4A4K/4PDHfKpkT?= =?us-ascii?Q?fHjgYbzBY+yKCCIMCgLOTfu6NGnDBNCCrIqOL8StKgbKJ3lXONd2FKQotd4l?= =?us-ascii?Q?cxBiWv5BRlx5A+K20HSgfU98waNZ+8OUBo2auJAeIpjsq+tS2ky2cdeYN3Kk?= =?us-ascii?Q?0eMujDhYBrVTxH7f5h1bJ5PxGqzIgvohkGWfRH1Um15AFzaThICbFOdYi8UI?= =?us-ascii?Q?ZBqK54jBappuzeAxNN3YwQipV2TsFmpS11LwmGY+hLCtv6Wbv+BspwykRkrZ?= =?us-ascii?Q?vdtXqtpXIdDVKV2tXAzd2489iCSmdZvGieCi4mlGWX+RCuKBNbyIKdbzcM8y?= =?us-ascii?Q?QLTYdsrBJHDVSsef77oB1bKxsR/R8Oq8+V1K2VLgesRny1FaaWqfmCFswqxG?= =?us-ascii?Q?EIWL4XNxFoabyOQs1IEQPGCBzMlGkzaomOUnvCNg1AUP7+ysp47EWvklqNy8?= =?us-ascii?Q?GNSStr7B18FmNO+fjaXg2iHdYqWOJuknzDbKC3IswAaJXvK8H28OpdlxWdKb?= =?us-ascii?Q?zug/xNBBwKDz9o8FtPyXFVDvN4y0l7BVFno0OHuPo8ipB1yQ3QQhqRaejE3q?= =?us-ascii?Q?8TZXsLm1CBJXvR4EEKF2q03aQVfFoXDVzE2iwy5PYPqOS/mktdx9k4jqmHAV?= =?us-ascii?Q?AFabVsRpRH4LG4uJy/6biR3n5ZtYFmkVKRl8XX/O+ury6+xCzhzSipQJ/1cw?= =?us-ascii?Q?Zb3lPWDWRluuVKX1LXGcDDKKH7YKaieczt/Fgs9c8F1lT4TuXtdlclNZgSrw?= =?us-ascii?Q?xgZ10KEV9HOBFVLS24NPdO6cJcCy0JymAw7T9OXBALOaHmoO5qtEOG3HzOi3?= =?us-ascii?Q?yQVO3dI06PNrVnkQfr7XBIMKYP1gt1GfJ+6TOuSGtc08acGlrlnz6FMKsUjn?= =?us-ascii?Q?dd26LSm7CLErLpYM1dsxWqpdaUDaZq8XNk/uRICP70v7a2Ep4QSpcnrlmTLd?= =?us-ascii?Q?XHHt7Z/dCyEhtccXFcjBKTCt?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e9dd6fb-55e0-41f2-f0a4-08d9097f833a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 13:22:31.5431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: i5ESgpz9gKs+JzKSKZ5IXOsBqCGgfxMtjoqvAJAs859fjb5PHOjbFXZUBoEv1qM1KHD3exiuTjTBkG6JA0FX8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5387 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > Sent: Tuesday, April 27, 2021 16:51 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Guo, Jia ;= Wang, Haiyue > > Subject: [PATCH] net/e1000: fix param misusage when set rte flow error >=20 > This patch fixes parameter misusage when set rte flow action error. >=20 > Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") > Cc: stable@dpdk.org >=20 > Signed-off-by: Min Hu (Connor) > --- > drivers/net/e1000/igb_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 Acked-by: Haiyue Wang > diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c > index 33f6b1d..e72376f 100644 > --- a/drivers/net/e1000/igb_flow.c > +++ b/drivers/net/e1000/igb_flow.c > @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *= attr, > memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > - item, "Not supported action."); > + act, "Not supported action."); Thanks, Connor. Just wonder how do you get this error ? With some code scan tool ? ;-) > return -rte_errno; > } > filter->queue =3D > -- > 2.7.4