From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2FA8DA04B5; Tue, 27 Oct 2020 14:12:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E89FD4F9C; Tue, 27 Oct 2020 14:12:30 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 31C424F90 for ; Tue, 27 Oct 2020 14:12:27 +0100 (CET) IronPort-SDR: mzcxiSez4QOgiWcxA4bR+/aL5qPf3R8EapxLOqnEHiF3Z53o2c62poE03MG+vRvkGeqMtXdtUH NQExTzBA1GVA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="147360441" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="147360441" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 06:12:25 -0700 IronPort-SDR: iPfjy4sYeKHtLHeQn1CW1933l6gd7RawycymEoeHYrGqdG4a8hlz4+VILX3AE/z2XRrc1s4IaB 1M8onv+1DdkA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="322926913" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga006.jf.intel.com with ESMTP; 27 Oct 2020 06:12:24 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 06:12:24 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 06:12:23 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 06:12:23 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.57) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 06:12:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k1EnQhsaBFIeTz78HB/4oYHkT8GXsY9mOMlzNA74Gyjv9/H0ztmQJfHdjl4omA3EyN8GrqsmPrhiicxzP95k9Y4kmKtySMQXoJV9+ESUXMCf3ekND+VyXT/BPbd/op+J1yRnP9E9zur43u/RwZM15URYX1EyNgahSP96zvz5qTZORyPmRezNGbMg6tkgAxZ+HtOgPAIGuxtNWpVuwDxRxYI0wfqrU+cGdHCg2PeNid9uORhi4hc536RKRAOuxOD+bKAno/cha6wreKaBE0MXAM1G4ML3Tkv/b91/PWQEH+5WJ9sBF/lClw1FyzRry1lk153xExXbglgSJ31gu6UpYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k5BCLwSzUMorXWlfotmRS56ijCDYNSMHn1kLEVEMeAs=; b=Wcufx68G6zzBBCdNcEPEMjRuuTsH0cEJFudkXo1ECX0hzG0sruoJJNEkGh0W2MMyJkJWSdXt0rZnsCAED1w/CEZMMcXR5LmZChH+/h+WCbF9dJkdRhVP8c52eEwRKOU0xGG7holNlEmzyjsO/9EI+8LvTCiXRmYeSLXs/Mf5hrk59ghML+Fe0bxv0EUktK1gCNj14muVtLy/X5o2d0yptgTI0cQeLq0BhlBHtPM63m634zAYml9ur7/KCcBzwjYPH9lfrfaO3oBXQGMkx3t0vbiEFXc3r5EK2Tf3taZCRMIc40bIXlEFNnZr4X3jqHBK8e0K3DqgAbUZQ//f2HO11g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k5BCLwSzUMorXWlfotmRS56ijCDYNSMHn1kLEVEMeAs=; b=iaeOkQBFA+Hn6Pi3oe3Is+YbVocQvgDa96WdhX7cGlAAvJegvjYX7oS6HmLHnMTadVCZYfNRU02QxEE+RLAuYLdzxRljzMk5PTEE0mCrgpPTOyaHtz+vv2b0zO7CqhUKmWvrVWyu3x5aE13mmUYYEJfqJlap9ncyQuoTKYCjjMI= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3732.namprd11.prod.outlook.com (2603:10b6:408:83::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Tue, 27 Oct 2020 13:12:20 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3477.029; Tue, 27 Oct 2020 13:12:20 +0000 From: "Wang, Haiyue" To: Thomas Monjalon CC: "dev@dpdk.org" , "Yigit, Ferruh" , "david.marchand@redhat.com" , "Richardson, Bruce" , "olivier.matz@6wind.com" , "andrew.rybchenko@oktetlabs.ru" , "akhil.goyal@nxp.com" , "Doherty, Declan" , Ankur Dwivedi , Anoob Joseph , "Guo, Jia" , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Nicolau, Radu" , Ray Kinsella , Neil Horman Thread-Topic: [PATCH v2 05/15] security: switch metadata to dynamic mbuf field Thread-Index: AQHWq+ZImlxBQhGGUkGJDv0f+hRbXamqrvPQgAB2IgCAAEfg8A== Date: Tue, 27 Oct 2020 13:12:20 +0000 Message-ID: References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-6-thomas@monjalon.net> <6914016.8XNVhmot91@thomas> In-Reply-To: <6914016.8XNVhmot91@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.213] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e5069d77-90fb-42cb-0538-08d87a79efae x-ms-traffictypediagnostic: BN8PR11MB3732: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +biJtj0pSPf8KPaa9i5KkDzd2N584MIxcWIHvLC7D+dpHuhKkAP/H01cUPIzz/U6AwL8R59euA8GvbczKXruaPETkkl0y1Tr4H7bPCUw0r02t6mHAOfOa4t+9uXXDH9QPhzSnPdVL1yE7oxoH23ZQff3N9PaFvU28Fw0gzKeZfW8KunDXKShBCGQAfJq6CeCwxQtTrcVS/Q649OeJJAGfsh23xGkBjhsFW+gScHuOEsbPWJUrN1mB9JZZJZkoS0JBmkCNx1qliok2Cu/E55OIBgVz5KgzmTOThUIRIBC1HU6gXun6XzlEgQZw2C/G8dAeKnNqqZUX3Ip/0V48wyVvA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39860400002)(396003)(376002)(346002)(8676002)(66446008)(2906002)(64756008)(66476007)(66946007)(186003)(7416002)(52536014)(83380400001)(9686003)(8936002)(5660300002)(478600001)(26005)(33656002)(6916009)(86362001)(7696005)(55016002)(53546011)(76116006)(6506007)(66556008)(4326008)(54906003)(71200400001)(316002)(15650500001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 4uRZo1K1/kRjD04veJ2AE7aOw/+KZf9xsIKc5ainJ5kPEZw18MQEiLB5J9Fpvbs0PQnM5ZolkjaEGTuwR3h9ez8fjeCq/pCUnFAOCOJTSu84yfqQZ4+A0qm3tQ/9GfAi3W3NvIflDWSdCRTE8+LI5zXmZOTQduoGo2H/7mJdp8gcvwyTT+QZuU0fppxbkIe2mUoo5VZEm3JSL4R2XcFt0xrK8VjAiGdpk7s+MLDiz8YYuWffWg+EElxb1FyybQm3nNWx5mUOMegJEbu7rpR/JRYJtpFL4knqGwJnqQYc0jmwzqEWv9uqW47WuYNZ3qmNqBiEmti2UROD8RadJaIwK2vZCKmdMXmgV15ODaTZojjb4g6fQ3o/4xz6+fzDIdtANvjMTHIKsAnz7dG8DQWUuu3hxIO/ddzdC9sywAraa+s5MbyfwiQy/1ELMbNZXq6y29UiEqJh6gzjkJHhKAvCwKaANaT6uz9BgvkSYmslY5Ynu5oEkxbZ0FQ2l52KiIhqyJ95t4fKITsgzZUdo6Bra/07u21LvH1BBeEHROZW9wxDn+JHU9bSbk8gmIbqspTeH71pTe7uZE/+k+F6EYlFFki8ZgWpp4pCcHAru+tQQ15pthjlG8B+YctLQaGnalb+bpJFSUI+9hD4WJd8ha4uoA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5069d77-90fb-42cb-0538-08d87a79efae X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 13:12:20.3166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PCKlHhlcNwVoj4r0q38/L6iI6iTeo+AO5W1oDd4kyNtVv5z5Vp6LomV8hmAm5ghvMLkVHzQl78dUdb+BQ5yxNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3732 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 05/15] security: switch metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, October 27, 2020 16:52 > To: Wang, Haiyue > Cc: dev@dpdk.org; Yigit, Ferruh ; david.marchand@= redhat.com; Richardson, Bruce > ; olivier.matz@6wind.com; andrew.rybchenko@ok= tetlabs.ru; > akhil.goyal@nxp.com; Doherty, Declan ; Ankur Dw= ivedi ; > Anoob Joseph ; Guo, Jia ; Jerin Ja= cob ; > Nithin Dabilpuram ; Kiran Kumar K ; Nicolau, Radu > ; Ray Kinsella ; Neil Horman > Subject: Re: [PATCH v2 05/15] security: switch metadata to dynamic mbuf f= ield >=20 > 27/10/2020 03:01, Wang, Haiyue: > > From: Thomas Monjalon > > For ixgbe PMD, > > > > Acked-by: Haiyue Wang > > > > But I feel that 'rte_security_dynfield' name is too generic, can it be > > more specific about what the field is used for ? > > > > Like below ;-) > > > > #define RTE_SECURITY_DEV_METADATA(m) \ > > RTE_MBUF_DYNFIELD((m), \ > > rte_security_dev_metadata_offset, \ > > RTE_SECURITY_DEV_METADATA_TYPE *) >=20 > Yes rte_security_dynfield is too much generic, > as well as RTE_SECURITY_DEV_METADATA. > It seems there are different data stored in this field. > We should have different fields for different data. > But such cleanup is another step for someone else. Understood, thanks, then 'DEV_METADATA' is also generic. >=20 >=20