From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E8EDA0C4D; Mon, 6 Sep 2021 03:25:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D099F40E32; Mon, 6 Sep 2021 03:25:13 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 37C1F40C35; Mon, 6 Sep 2021 03:25:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="216698964" X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="216698964" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:25:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="512300912" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 05 Sep 2021 18:25:11 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 5 Sep 2021 18:25:10 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 5 Sep 2021 18:25:10 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 5 Sep 2021 18:25:10 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 5 Sep 2021 18:25:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ocIcQ3MGbXLAnctXjS85ECKjr2GF6MsJe8cQ5Q1pKeyF3TIj4jyrpbk6EDfEIaADQQwwi0qVvSP6L15YOuRVxhXnWbE8wcJcJ6Ny6Dfr1NNiTP0C1ruGccbeK2p3llCODiZy55kXadrfb2GuhXLCatnfStpWoC3GuhOM3IavgPl+RALJl6hw2J0CyXO+0z8TR168h/xYb2IEMOFzJfv5PGSRNzHvsFdUaur5qfpzfZmk/RuNPcxJ0PxPpOyXrKBWcXlpiMfH2pu8tQPDyuJp5le6jkTEbTrgdGHc0A1Veq3z6PpFS60ag3FjJ/vwBPFMXEEKfgIx35FQYI6o6ENQXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pnhiE00rSROjHFS83ZdviQ0Hwieey+AUXeFfkVDaX60=; b=C5+8KvVpE063S2eWRsajxcKhgzbB6zuLpSyQUhAbOxBx6xYNgyIF3k+jfN4t+1Ivj3C4ozac1QIHbES1a1+7rx8pWzZz31F2PlRulQCIaHABa60jZwZE0j4MRfKR3hwsmEFoVoiyUsyq8jw9ewpEauIkzKKjMoz8XAeLEmvKFwhLuH8uuVru8rHVg+3T/dd003UIQ9sBLPWfpq7vJe4LG5rmv8NwPnlg5u85evIh4ag+TCHMmrnZn4YcQvrZlyRa4HhemPEvx4J34T3jrIkZpKB6MjWq+BIahRErAAKFKgAC0j3atgMvNcGBcHn27uQyz8K9zC2BPYE1DTGEuqV5gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pnhiE00rSROjHFS83ZdviQ0Hwieey+AUXeFfkVDaX60=; b=iRiiXimxQ83zbTzDjIbGP0C14w1YWXP+yQYX4LXfkhx0pwfsP4U8vJbXmWlyMZ6mZc5cfheXC3GB77cCSSv5h8hxver+p8VddVKyOrIkXeJDT8A3X91L6DIKm+v2Pgp1MFehCG5kh8qShlXt/z0KSORElZnjp1DX9edJUqrehK4= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR1101MB2177.namprd11.prod.outlook.com (2603:10b6:405:50::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 01:25:07 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dcf0:d9f6:8024:1879]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dcf0:d9f6:8024:1879%6]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 01:25:07 +0000 From: "Wang, Haiyue" To: Qiming Chen , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v3] net/ixgbe: fix mac resourece leak Thread-Index: AQHXnwDRGkXbddL5l0OOe4OSVuiUk6uWPfkw Date: Mon, 6 Sep 2021 01:25:07 +0000 Message-ID: References: <20210831142131.9295-1-chenqiming_huawei@163.com> <20210901071207.9379-1-chenqiming_huawei@163.com> In-Reply-To: <20210901071207.9379-1-chenqiming_huawei@163.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9558cbf2-1f73-41ca-6789-08d970d52933 x-ms-traffictypediagnostic: BN6PR1101MB2177: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:262; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DAGM3pi+gycfQ2GF/9xAowB7d7SU+xIcpNbd5PaGX/XKyh7S4w/O7DaLptOagOpKPldcNVXr94KqQpb8dxim1370HLiymxacW/nyW63fGHASNLnBpYaVL/ngmijiE2OOxBRkPmtnEVrkqD1ReN7cUUseSUAd5pAOJH1gLTZHuXT1K3PkDc4gcxWCYHSJjAcoKfAPu/z/sKU3BNAPLT+A4/P/XRI0rs1blogZLV5ePlbfJSYHJjeZwm7mK/eXLxS9bXdKPCFFFDtqUb+zN+MiKQcpa2bDG6hcGzvAGOp2DG3LJaIpCcGQ4S9YdT89TZlaWtSoiwGarOZgxbRJQ3M/xPLptB2yR9EgRabaSx8toJpJoVIXg2rJIWn8vXnpJPfjn0uhJ+MuzcUeJXUPfuAGJWWYdmmgg7NIGa32OdBz4VLf23RNMKZM43IyBNHqCBc64I+Ue2FQyyEOXEU46/UQ3zVtsZuG8DTSk0+mqrmqy0zmBm1aHVc7ONAs00OdzilfnrC6C1HrRFPGp0hw2hSC8i+vAjp9DS52TbUNi0pCWpzQkFtnmyl/o1H3LFrR0++XU9LyvKWwX67kK/3Mf0qUsIAsoICg+oDxDg++yytVuHBtldttOGeg5IvcVw6+WXtAGYrD76tZCFiExznZPdtiF3sTX0MtzfRZX95kDfGdE8Mr9xfaaAnqGateFAHck2cL6AqhOfNs91zkRttRK8oMOA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66556008)(66476007)(9686003)(64756008)(66446008)(38100700002)(316002)(4744005)(4326008)(86362001)(110136005)(55016002)(38070700005)(26005)(53546011)(5660300002)(8676002)(71200400001)(6506007)(8936002)(52536014)(83380400001)(2906002)(122000001)(7696005)(186003)(66946007)(76116006)(508600001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gG2oCpN45qbbaNSQeVwMHufr8n5c4oiosrz7chJol25a0Ah0PIjaESJgWTem?= =?us-ascii?Q?UCTBTcIrzxZ4aCaTPLGV3WT17IiHpouLU5dki6zliu+Sv7vdw5EiXl1rjPIZ?= =?us-ascii?Q?Sd9pKpQgcLOKBy8DGrV7HHhiprkHPqzEz9G1byV3MgbqkeORZjbPkZXYg5Kb?= =?us-ascii?Q?ElMPgFY0rW5BQwCMstbnAyHA7gUTdzVxAvW9OGw2/8ZWwUoNZzVbZJnwYpnc?= =?us-ascii?Q?9jmAfY66wDLLat9dB370zFcf+V5qEV4p+bb9vZL8xwg5fOPTNmzyDcK91Yv6?= =?us-ascii?Q?CIX2zme3clVYiueS0baZ1uCNxdT1aHVLFrAxh/XK7HdAZXSJslEqdHOstBH0?= =?us-ascii?Q?VuAbuSIuWTb18XOnsBB2Zfz5VaICpSYfmCJzoketMkAkAW5taaCg+wMcm4Hh?= =?us-ascii?Q?/dV4z1i/bpXgj8WH4IOuWEMUUrfH7ZZAdPQi+9kPUBq38fgz0klL4MeLP38w?= =?us-ascii?Q?fI/HG7gWQiMDZ+rEoQFwQB4sg49IXUr3TLh3+L2Pvr+EcrLBm8LpX/LCb4xE?= =?us-ascii?Q?05pufqT214Y6ksP2hgEzuHe1CQUTBegmnetTkrU4JT4u9fpgECr/QAVHm2Mq?= =?us-ascii?Q?dfDw1G0T19rW5a7IFAFfXg5tBencfZocSWbWEDP4FptMSqFslYKOdekAwmIc?= =?us-ascii?Q?rT9EddJvJZaeYxdRm6ABOrpSHddpRtsqW94X+dkI2wm3izp+g7jrCwObVhwQ?= =?us-ascii?Q?ALoQMEM9fhteEy/TmSManyr/EvfTqRNxzwPgfNg3d9FMDNXDCwn0N2FIFdBO?= =?us-ascii?Q?bjjnw9zfsBtOD03MVxgLMgTqYpCgDM7joGN3tj+yr5agRI3PDqsAPI6SmETS?= =?us-ascii?Q?rykY8o4xVkyA+GwcboGYtJHWXbhZ7DSuUkWG7RwmlK6A9vbnlPwxrklBwE+N?= =?us-ascii?Q?ihoOrXPv7xvkcPzF++s3KWaktkpCF0LIlaSsp4ZPmlERRbf3p1YN/sFoKdfA?= =?us-ascii?Q?HzS1GC/g9CsOI4ENUCnKw3b0x7HC5ZRzkLpu+Pl02HLLJNWFAjIXO+DhdpMN?= =?us-ascii?Q?7yMqZfD4fUEGVxA24zqgO1Rj3UD5rz0RtC3VI32/osDiR7UPxAkG1m56tey6?= =?us-ascii?Q?cG2SpiLZmNRfR1lt04VJkZRamo6haHF+HeCcv0JannF69SCAuBzsuwKSzplu?= =?us-ascii?Q?6baXTTXEpn3klY+UpPqkJDHSUVRHsMT+HF7D+KfVtvrpP2ilPuPD5dj+ek2u?= =?us-ascii?Q?J6OSRtI0aDPCEKbgVBSgHrzIS1PZt8onEZ7kzCr4288LwUsGU6mUbAzKW1a4?= =?us-ascii?Q?ZFJmer+vdAKroZhNRHSKAQOqJ4ciokOV04OI7LLFTV6FJvuhknEivY5QvKol?= =?us-ascii?Q?wxPGdbYZVzLhpcnotfxqWjN/?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9558cbf2-1f73-41ca-6789-08d970d52933 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 01:25:07.0236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: j4EtKCCxIdqLildQ0yHc+/Lfrn4MSlWTc/ZUKT/+18o5ecd/OMe1Pw5oDFRYIl3G3SNhWycw/5+mA8t+MUcWvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2177 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix mac resourece leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Qiming Chen > Sent: Wednesday, September 1, 2021 15:12 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen ; stable@dpdk.org > Subject: [PATCH v3] net/ixgbe: fix mac resourece leak >=20 > In the eth_ixgbevf_dev_init and eth_ixgbe_dev_init functions, memory is > allocated for the MAC address, and the address is stored in the > eth_dev->data->mac_addrs member variable. If the subsequent function is > abnormal, you need to use the rte_free function to release the MAC > address memory. >=20 > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Chen > --- > v2: > Clear coding style warning. > v3: > Modify fixes commit. > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 Acked-by: Haiyue Wang >=20 > -- > 2.30.1.windows.1