From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DF62A04DD; Tue, 20 Oct 2020 19:05:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8B39A9E4; Tue, 20 Oct 2020 19:05:49 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 554D8A9B5; Tue, 20 Oct 2020 19:05:47 +0200 (CEST) IronPort-SDR: WT6VweSn99WFO+7YVaCPpx+2MnKFhETouUUM92bghR9mIttdlivX0Hf+kyPHrVkWvWDH8Rkz3s 54m/DimFdK7g== X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="167335670" X-IronPort-AV: E=Sophos;i="5.77,398,1596524400"; d="scan'208";a="167335670" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 10:05:44 -0700 IronPort-SDR: 9BKbijzAEPq/sAVYdEcUtXRUxZD//zgLB13iiF6PxefTe0+TcUFRbywvFyVUEFVSPw63eLFeT7 NuER5Dwnb+Mg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,398,1596524400"; d="scan'208";a="422565248" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 20 Oct 2020 10:05:44 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 10:05:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Oct 2020 10:05:43 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 20 Oct 2020 10:05:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZL/ueWz4AyzeELmWhnPRN41rvfxqD1RSdDRdaQMgb+z0s0JL8fjEnG4HO6RliccVnuA0+aTd73r1Vqb3EMKnRJOLgKlcOdQ24duhLp4vOPJ43NgzMqEIuKWNNkfHV7HYYvJAbMd8svajm1RB65ZK4dPEpIlcQANpDVmfSAg7eggR1fkiwdSgzDQIiQIkKoohRngoOsVI7Q74V6l3SUE78ixRpZs05D9J3NC+tpU4vVgpccSk4LXjy0SH6t9q3+46ljDvw3MVLdnp17rCZzrvIJWyWDpAeuKxNREMlyIM6f+l5FNbwkDyxo/+lF8mbt+JjD1Bka9YQUI9gDvGbgH6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UDjesW+2LVpDJH+yutiaUuTPzM4JhSh6tLSPMKl4YG0=; b=k7jBnD6e77qKP4ISnyPybEP4yG//J2LmN2Q9lI8pUX8IwNdjA1DPV8lYe76rS/g4SGqNM8IOAzA4IWYzuOU5qDVtfUzkUpIHF5YuU14R7j6It+CPJaKBeVPSrPB1GF/JMx+insX2Z1nK+TIv3Z200NWl2kOpDmBBNOy82mkw16/+irCUmMBbGQUDohx29i0VePCtPbnjru4m2plpwRqdwgK8ACVWCxDU4jhdLkQoO/+7hd2Z2IUo95tBu1JSRnQBsbLLBlLDcSSuGpB2tVLeOMLxOXrF8p+yx5E470BXQ2RU+EThDP8gTGuVhH/fc/LLTDopk9jv2NQJkmWWKWri0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UDjesW+2LVpDJH+yutiaUuTPzM4JhSh6tLSPMKl4YG0=; b=LSeEXPqVy0Jy/rGA1bxch5IYqynHvlK1CnjaxAJe2rV0pvLw/4iuR4PZsHlIX+rcr2B/kLEEprEN/z3XV368foX5q7JDNG/8QHYZbZG+DALbmXVx1VTFg5IScRKUGBFH1AgNLbBiUvLEUdksa+uCAj1Hb8FLegWzmAqQYBnsoC4= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB4116.namprd11.prod.outlook.com (2603:10b6:405:83::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 20 Oct 2020 17:05:39 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020 17:05:39 +0000 From: "Wang, Haiyue" To: "Walsh, Conor" , "Guo, Jia" , "Yigit, Ferruh" , "Awal, Mohammad Abdul" , "Doherty, Declan" , "stable@dpdk.org" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/2] net/ixgbe: fix unchecked return value Thread-Index: AQHWpsg+ErMBqDr+jU6hpY4CqBLnmamguB/w Date: Tue, 20 Oct 2020 17:05:39 +0000 Message-ID: References: <20201019122620.749625-1-conor.walsh@intel.com> <20201020100248.761693-1-conor.walsh@intel.com> <20201020100248.761693-2-conor.walsh@intel.com> In-Reply-To: <20201020100248.761693-2-conor.walsh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.219] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f7cce014-507a-4e77-84e1-08d8751a5f24 x-ms-traffictypediagnostic: BN6PR11MB4116: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3d/5AgcBm6CKiYgWWVxvNFVrEOCz8inIjwLdmGe+32cUjd3cNK4CENuFOey3Zf9bieTgEMZpU2v1CXsZYIwILoC2+SvnNw4jqS0z0TSa2S87rIbxAvL2oxq5eLojHZiFc4aIP3GYSZzxlPlSDnO3k2yuq1dbDiMBoWrscuCwZ/VxJiT1vC0sFMCwggoBx58vRP6s8kI9zlxQYS3InTc7hOptFzOyp8L0zacyCIlfRHLPlSxjmVDfiPs+49GHM5J49xUVAan94qWJJV1FiBpU//5clWVLUiz2er5sIxnwJto3d3btL1oIlzcoDPuTMSwvr2cacn4kXPgG/6bthi1najLQVTsI67G1Yx+Q99LsdKuaYeg0U8RoU9ONIert/d4v x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(4744005)(478600001)(26005)(316002)(83380400001)(9686003)(33656002)(8936002)(186003)(450100002)(8676002)(71200400001)(52536014)(6506007)(66946007)(55016002)(2906002)(53546011)(66446008)(64756008)(66556008)(4326008)(110136005)(5660300002)(7696005)(86362001)(76116006)(66476007)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: q6QIBAm9unyVht0Rj1oY/zZJpC2UPMPWxjjGqlYp+piz9od9ey/he7tXvaBkRLl4Ow46CuvjcHzfsXIgsi+ZQIGnQqjoHIaMUJHGRDu9oKboeaAr16Sr3gJF3PynIMf16qYrQ641MdO9Rv/DlH348lSqLVYcRYEO0G0yVJ4eMxNgLzMbQ/DomyFS4r+aBDssKO8yNWzz5GNI8whvofNBDI+WTH//UnUn7vzjMr1zs2rYDSfr7XLQq0D1tqhRdMD4u/V+Wqry4jk+3/1VxpflHUEsM2v9qVACCfrW5FIhpzO4gyO7khe1G+zMPK4EdCaOll8qQevcgRpqxkjxYKSjgZzIDYSgu+CmNo4TtR0GnyFdbLLbY9G8ounFhwTxgDY/KttP0OF/dK9O7d3OgfdyeEvrWEsTUaHAXGVgb71rheTPyAQOOekMvP8OR+b5o0xf40NpMs/Rh0FEX3tiklzW/+zesP8bsBhm/T7VFCe9o3htukts6z35e6jDaOscaFN0yKVi5cvjXiSIKuYw48va9a9SE9s7hPyYR0wbavBKc0sdw4RlLsuBvHn16xf1De0BuOe4v9qsS68wamCNsZBwojHNkoF/7X+Vt6yi0XiYXfSCDK5NSM0gx2jbNds54k2jeutm1YjkwpPtSEupBZwXUQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7cce014-507a-4e77-84e1-08d8751a5f24 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 17:05:39.7094 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RLAfss9tUX21Na93dk2lZE173XgZLZYcR95c9Ox6JUySn1AYiCvLTUw+WuR5dKdDTRJg2f7rO809R5k89UEQBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4116 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Walsh, Conor > Sent: Tuesday, October 20, 2020 18:03 > To: Guo, Jia ; Wang, Haiyue ; Y= igit, Ferruh > ; Awal, Mohammad Abdul ; Doherty, Declan > ; stable@dpdk.org > Cc: dev@dpdk.org; Walsh, Conor > Subject: [PATCH v2 1/2] net/ixgbe: fix unchecked return value >=20 > The return value of rte_eth_switch_domain_alloc() was not being checked > within ixgbe_pf_host_init() which caused a coverity issue. If the call > fails a warning is logged using PMD_INIT_LOG() and *vfinfo is free'd. > ixgbe_pf_host_init() now has a return value which is checked in > eth_ixgbe_dev_init() >=20 > Coverity issue: 362795 > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") >=20 > Signed-off-by: Conor Walsh > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++++-- > drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- > drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- > 3 files changed, 23 insertions(+), 6 deletions(-) Acked-by: Haiyue Wang > -- > 2.25.1