From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DF4DA04DD; Tue, 20 Oct 2020 10:34:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD57ABAE8; Tue, 20 Oct 2020 10:34:10 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id A1502AC71 for ; Tue, 20 Oct 2020 10:34:08 +0200 (CEST) IronPort-SDR: DX7/OogPqo/ajeVYAzqgHNq/z8OaRJju5zDpZzuVGJ7yexCS9e5O6fCofEgtnMXShQZIDKSMMK b+1GekF/WBKA== X-IronPort-AV: E=McAfee;i="6000,8403,9779"; a="228807281" X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="228807281" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2020 01:34:03 -0700 IronPort-SDR: QtBgn1HHK/j212TngY/YWmzBZuGBxGK/322kCgLOToNoystkWCcjgu+5O4QB8oR2TSJFWzTPqt 5PmCtGXPxz6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,396,1596524400"; d="scan'208";a="301624979" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 20 Oct 2020 01:34:02 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 20 Oct 2020 01:34:01 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 20 Oct 2020 01:34:01 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.51) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 20 Oct 2020 01:33:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z7XmzrB8AqJ+0kB5uiUuvo37KNRIz7VXqYo93lxU/af/As3cwZSJvgogdM41BjCJBftrN3BDPlidUC7X+7403MQpAjvV1NQVnEDOi2oWi+ZlC7KjNt1ynuA7lwjOb2zfAD5tiH4F78Zh87vJ3SGuw1fwrwuMSdcloW56lgWT1KWaTBcQBt8oAAb21omqrQpt99qmL/xqCW/Tp8mq5cYcAQZ9h4kol33TGXQGl3Z5T405F/xyH0Py+CI7G3BISTzXhoISRTFYwyXDyG9+5s/WJcG2nVDO8WOEslhuiSmoRjhS5W54hMe0XIkC6+h5YRvYJuhC9N9UDSywpgZJSrRxNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i++u/sATwk4KxKX+EnfBXyoTbDYjCOQ6Cg2yGby8l6c=; b=QG7Lz1OnLFv8f9MOW7waRQdVF+r9tX1Rxgkr00fsxJunnUy3mBUeXqpBHmGKE8ehc2srMpu5fFrHkqPysKhZl1/22TWE50ysQue0HIe+Ieoy8hdY+CzWrYoehKR0FILEfBzNpzkgtrRr++GtPRzZXNmSLLkhgdQv+lY90qTT07M1965/iVotVhRnWzt/8t+hc5lhCkUjHrAqA9j/aUKOjnIr0In8JBrwFQaP/WNrTNk5DbDMPIUC+V6HiXnSuRLi0KUuLse2ejowDz0J/qaYCimSMNuL3VFGMDHkUeH8vShAdEmp+DgvDbu4D9uEnq4E0oLeyAbbZ7gTZM+lJiz3vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i++u/sATwk4KxKX+EnfBXyoTbDYjCOQ6Cg2yGby8l6c=; b=Z+qmZFdvOdNVrBv1JzhsEmWNkXryjrWHODpM3RxI3LsRfsZxpLaRcxFGFhOcDmjID/Txu9TxUxPzPCHIcC0isktsjvCBzYg56Q1O8K5STpivM0/5nBwMF6f0b82UxeRiPe3TfcTPuGfTwAqZaks2clqhJ2eNsbSpGqMaK+ubDBY= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR1101MB2260.namprd11.prod.outlook.com (2603:10b6:405:53::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.25; Tue, 20 Oct 2020 08:33:54 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020 08:33:54 +0000 From: "Wang, Haiyue" To: "Walsh, Conor" , "Guo, Jia" , "Yigit, Ferruh" , "Awal, Mohammad Abdul" , "Doherty, Declan" CC: "dev@dpdk.org" Thread-Topic: [PATCH 1/2] net/ixgbe: fix unchecked return value Thread-Index: AQHWphMaQhnzHtUSjkSElugZBqTh2amgKN5Q Date: Tue, 20 Oct 2020 08:33:54 +0000 Message-ID: References: <20201019122620.749625-1-conor.walsh@intel.com> <20201019122620.749625-2-conor.walsh@intel.com> In-Reply-To: <20201019122620.749625-2-conor.walsh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5dc15eca-e394-4533-498c-08d874d2e167 x-ms-traffictypediagnostic: BN6PR1101MB2260: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XdXfwNFYZm1Ehc7Pq2TK1A5AOFEEdqidkf+LtYLo5FS+wgC6WRPHWP8/jIMXEA7vl4biBXFASpFMisx4olImyxuFJw0YdcJ8ugb1A1ebC+hGgeMHD6/rmKP/BRH/GRxRMRhxJ8H+MYus/p/nT+8xw2E9Zzn0HvJsAAHa5cMNbi73h+3pkWC+Rou+m2DET1Vs+kw9quaSoThxK1jDX64QOYITz6CNiOyBgf9wCM6ueEkOM3fPSCh0vLi4Mi7yvo0SKDDCBvU7dHDBAjAnyfPEyBQezeAajldhCdB7bvdbMapwYi2fqvPD5fApGO33C8T9Ac++W3Chj/2BVJUb2ZHBhrOZ8IYn8VAghe+09zAFSRGC3gtDX4hk45ySdB50Qs4W x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(136003)(39860400002)(396003)(71200400001)(52536014)(8676002)(186003)(6636002)(316002)(478600001)(55016002)(86362001)(7696005)(53546011)(6506007)(9686003)(33656002)(110136005)(2906002)(8936002)(83380400001)(26005)(4326008)(5660300002)(66446008)(66946007)(64756008)(66476007)(76116006)(66556008)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: wUQB+00BmWI1eRVRcFljDgnZbt6iQRLN/9QluNeQaZYDZhzWfwdbkbVo4aRUyIAeAWqaglsFpiZqZrATZWouUwBtJDV/pOJxopatRfhUMRlJddebnzY70qWUrsHclZWVhFDtbDJ/ahf+Y0iVTyjmMQ5dInf6NcMFXAn7CQkD5HvMd9LnRcnGfEc+3O24bnDdkEvLw7DBbCELD8AJ3sC8359/nBB88+ZEJnfr2Dzgn621gS7Jk/wWsupr+oNS2P39fdU7mSm2TnV5kT7/l+xnOubBQXSvz7LkrXF/A4JV6LjAWDdb1KIG/sTXLTDShCS3Wv2A1n7YAQNEk0Hqe1LftV2LSVbBwfgP2y4lRH+BECoOuVTLNltwzNQXo6TyIhv323czO+yDtxLHCb8dMeUiv8lIXXeViOHB/VY+nsPJvlj77198dgy8rcHggtnwh/z+7zqw7qURdqngevsIO0Xd8mi1rEYKKuJQyyb/ivQhk03qXHT0KBQ+Kc5NCkSJXu9tlMwCrwQ1FnfNMDIoPtwQqPiPbTZktZaoiw3lvWhNeEjuDCjbHXoHTK3OEc58ZGwysTlegh0VSakBgcJz2oRlxo/hWQO+Ps8MKLQTbhtQ0uyVBW8+7ZV17KMZndoTQXLMn7HnQVYK7mo1yEcJQ2mbQw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc15eca-e394-4533-498c-08d874d2e167 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 08:33:54.4153 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CqdiyzLOrPuW2nwO7cf4JJdHeWB9ryFjMrc03EMBGKx0e+oxxDXyl/V6onDWzmlsw9p7g0sB8SmYeGeBG75Cmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2260 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Walsh, Conor > Sent: Monday, October 19, 2020 20:26 > To: Guo, Jia ; Wang, Haiyue ; Y= igit, Ferruh > ; Awal, Mohammad Abdul ; Doherty, Declan > > Cc: dev@dpdk.org; Walsh, Conor > Subject: [PATCH 1/2] net/ixgbe: fix unchecked return value >=20 > The return value of rte_eth_switch_domain_alloc() was not being checked > within ixgbe_pf_host_init() which caused a coverity issue. If the call > fails a warning is logged using PMD_INIT_LOG() and *vfinfo is free'd. > ixgbe_pf_host_init() now has a return value which is checked in > eth_ixgbe_dev_init() >=20 > Coverity issue: 362795 > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") >=20 > Signed-off-by: Conor Walsh > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++-- > drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- > drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- > 3 files changed, 18 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_e= thdev.c > index 14a254ab74..49ff523ea8 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -1077,7 +1077,7 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, voi= d *init_params __rte_unused) > IXGBE_DEV_PRIVATE_TO_BW_CONF(eth_dev->data->dev_private); > uint32_t ctrl_ext; > uint16_t csum; > - int diag, i; > + int diag, i, ret; >=20 > PMD_INIT_FUNC_TRACE(); >=20 > @@ -1256,7 +1256,9 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, voi= d *init_params __rte_unused) > memset(hwstrip, 0, sizeof(*hwstrip)); >=20 > /* initialize PF if max_vfs not zero */ > - ixgbe_pf_host_init(eth_dev); > + ret =3D ixgbe_pf_host_init(eth_dev); > + if (ret) > + return ret; >=20 Seems that just return is not enough, the eth_dev->data->mac_addrs and eth_= dev->data->hash_mac_addrs also needs to be freed, please refer to ' ice_dev_init': static int ice_dev_init(struct rte_eth_dev *dev) rte_free(dev->data->mac_addrs); dev->data->mac_addrs =3D NULL; > -- > 2.25.1