From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7015A0524; Wed, 14 Apr 2021 10:31:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADC0816180F; Wed, 14 Apr 2021 10:31:09 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id D69AC161808 for ; Wed, 14 Apr 2021 10:31:07 +0200 (CEST) IronPort-SDR: R1OMOn5X21gq2VSePGgriU79JycQo+nXRgRrpTL/OQxWS8+ayT37YvErdwVA8VovjvFrp4BbrI Db7fWE26HlYQ== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="182100807" X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="182100807" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2021 01:30:58 -0700 IronPort-SDR: KGfWqVOo820F/sEyzN+JiFOH+3mGY1WsgnGm3LIleAQlW7Aad+mDCwjHFcAdW6sofchd4SaIlI kotRa9AfOZXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,221,1613462400"; d="scan'208";a="418235882" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 14 Apr 2021 01:30:58 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 14 Apr 2021 01:30:57 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 14 Apr 2021 01:30:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 14 Apr 2021 01:30:57 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 14 Apr 2021 01:30:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m8fLevxx+54tieOdCCv+EKJYeMrpJN2ngU457TUPuURiTdnTSv45MK1iwzbJm3VHMBGS2H9yS6hRjxmqyVoYe8zp/gk5BgZCuA4y8DypMv0Sxx5YPPK7Q4/NYSxAXtNPhbyekZwo5zeQEHeDvNhxroGnHPkWAKhJXXTmVpi6Z7q/KsgnwSkGAvsmZId48gkvW5rOpk/jlKwie31PrgvPScveAncdKTvL+xGYB9/6wHoCnw+q5R0H2TUCjqcwp9XnI+WlOq8JnUyPcfIKvPkaZfoA7i36yIBpx9LB+WvSggeKfGuI2z+8cGvEaQKgxArHwx52xBSz3q5/TbgsKhgpVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VAWU8c4SpSoJIf8MYqFaaPJey7rJPP+PCXan7wYcoE0=; b=UZCptuuh1STUpfrgD1Tgnj1tO4N/7A88p99kIKyJ7TVbGHRaWH2okYrzY312gbrgqij71IIgRSL2uUIXxBotJVWoQcihT34GxuDKS3YQytZHmqiZOsDZTX6pRIrTBggklQGVnLAcRSdJNSiLlyrwOl9WDzmpEP/zicq86966vTtqxKefeDv6nPERcY0rypebomfvgLhOWHuNQaejUmb9EcybadKZ8azcn2bHigGX+6+0BnzudVaOAKkihZER93khgP3QvGq3xKhCtWdD7H+KG7ahDr5SPz8KqmGI0hdxj6q5/tPzMAouy7enink+/reNjvF+UCqNsjVbYa4Lb+lfNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VAWU8c4SpSoJIf8MYqFaaPJey7rJPP+PCXan7wYcoE0=; b=AMvTtZqPc+KV92b3rXeu4UAh64VwqNIwPEKKb1bZ00EC5qjO59IyYoWTU6EYZs+ybJ9vDaueMjkAr3/e5LJdBlY+FjRK+ZxtXA3JmVjL//gHwXVw09BeBAkiTkcGMs4FCK2NA0CpBZnAKhTUjt24nfu7GzjJrnXV5gLVfXmPmos= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN9PR11MB5308.namprd11.prod.outlook.com (2603:10b6:408:119::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Wed, 14 Apr 2021 08:30:47 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.4020.023; Wed, 14 Apr 2021 08:30:47 +0000 From: "Wang, Haiyue" To: Thomas Monjalon , Xueming Li CC: "dev@dpdk.org" , Asaf Penso , Parav Pandit , Ray Kinsella Thread-Topic: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus Thread-Index: AQHXMBSKvCrREl25EkK71KLI/BpYYKqzTRNAgABgCICAAALWUA== Date: Wed, 14 Apr 2021 08:30:47 +0000 Message-ID: References: <20210311130113.31382-1-xuemingl@nvidia.com> <20210413032329.25551-1-xuemingl@nvidia.com> <1710155.qeZJibJ7ot@thomas> In-Reply-To: <1710155.qeZJibJ7ot@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.52] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 19717557-a2d6-4fcf-d0f1-08d8ff1f9ab8 x-ms-traffictypediagnostic: BN9PR11MB5308: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Aii/g1WaTkyCU8bfMLI/GaWSSY8pblmAC4HtB3UJ8gyyCX4AMziK511LJZ1jTay+Gm8IMU0O773MqzH9AIEw+0ETWJmFersJ9XKvXHA5CsEIgSiPuYvUPH4VxsilyFlDjtm0Jky0BqbpaJHYw2OI5RDtFPruQJbQbflC9W1iWIj7TCMO2Gm4AfE/LObMBDrCbeXaKCGTFNroH4sLVHOf6wguLrgK6V3u/MWK53rpdqVwLalVS0bqPz3wc0cxyk9h+jLS9d2Qx1ArEifuaeQVlPHBFVmKQKHPdAkm1u0XVf/cpTca8EumT1XI7Bd7z8EyphiiL0pkqQ4UEjhXmjud8hdBgduRIhvdenra5gNiaor9MtcL2pnkpgvC2cQeUAypmqtCqwMWZQNTzmdLZAC7ex3SmRbiIRfGt+kDuOFyfLfkc4Zrkpq0F8LuMkfPT79dU3ZLppYH4pj2mStNWdXxDMuYYeDl0x4NEU6VK7lmREzjdwdKnvUj6ehNrz17Zba9QhAUXM0ANCadymEXFwnEx1tV0tsb2Q/EfIOVBW/3PqYsm89x510NXdN6+BA6tXJqenviFjmdxQ5p8EnKR3CHSUPATBus/WaAsmaLr8XZ/bU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(346002)(136003)(366004)(376002)(396003)(66446008)(53546011)(8676002)(186003)(66946007)(8936002)(110136005)(76116006)(54906003)(122000001)(4326008)(55016002)(66476007)(86362001)(83380400001)(26005)(64756008)(71200400001)(66556008)(33656002)(6506007)(52536014)(9686003)(7696005)(478600001)(316002)(5660300002)(2906002)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?1Z/mUCXvJ21AZxykDwIku7UponOB/kgjyszVKfgezxZcHIpYm8Dur/0F5eei?= =?us-ascii?Q?fPyZBOaMID4wBjIUav3VNAfgc6jvNIkr8qq4yF1E7Zm9wyZHMyjvbDv41ZX2?= =?us-ascii?Q?nsUzbLS5oZNMHEhjB51pCI6oXEBVXH+jQvR2n70HSDTjU8/cZQXshestGvyO?= =?us-ascii?Q?vgG5xpTwSdWv4p7nS7J5gGfo/PLK0Mh3fk82TU7iN6BDK+a/Css/tGWseTQf?= =?us-ascii?Q?tyf+FPUz8S0u6cehPAMMClQ1iwpXGlA96mQABOx5oTY6e74PTyDrGLnMY6wr?= =?us-ascii?Q?vMxzXptTCpvOStqzTPabi7sxrN8RiDeTpDNa35W4nKPt9K5H2h3Z8vmIY5z+?= =?us-ascii?Q?Tgf8ONUeWFoZEhdOv0Yi8p7hgAYqIkVvkSswvlnlLc05JT5qwlE3ZXhRz5n3?= =?us-ascii?Q?7kJdTW972hNiC82hCQL2M1cwGKsZPw1x+sSguikGzlNxACoamSrRQj6nROuh?= =?us-ascii?Q?Hi2NdxfSgp4Fyb0D1StoszjreYXDFSamQBvSlCgCdl6z22TuY9UlyRiXNl3e?= =?us-ascii?Q?+bMolmmxqVJEaRSWs9Hq/TYY5eQJtPalwI1B5olDfbQRCZ/vjLIB4q/H850e?= =?us-ascii?Q?/vJqoKNxrqqjxOKmPUGGsPqbNseA/2dRR7HMHg52L3d/4nRq687E81Ju3FCW?= =?us-ascii?Q?xAUQov7jjkhsXI+oFWyGpD1c2TDDDcZT9NsH8E6NuMlq0/615J0XFVtr33at?= =?us-ascii?Q?/QdcsHuR0U1hcQ6v4CVcWsco6CsEsP6lfQ7IVB7HGtyikvzqWLCYZ1GZurRp?= =?us-ascii?Q?bc0QNlHHUOhyNsMkVCsNknQuh2R+UgbhxNY2Bkxet9+5DJZrARDnz8tjGEMQ?= =?us-ascii?Q?UohfMn0V4ZmuE5BmzlLmCPz+9mBpMtb1QpZ4TCR2hv2gQiHcO5sBiSn7Ti/d?= =?us-ascii?Q?BnM+3ov3CR1CZ98DPM3Xgbr/i7uUWlamCofbHMhW38urxcgtpXi7JAgSiRcd?= =?us-ascii?Q?ocVxlIIyb7lTlmzqbRZzp5td52iNz4yUX1IcmOU+8ir5rzhedsFaf7zqtByZ?= =?us-ascii?Q?hPbfmBMEvie8t1LOCPmlST3DLEtCEZSTnWh7LGc0o7tcUiGmVknx3VRMslYn?= =?us-ascii?Q?bsV9ROTFs1jWjcH3NyQ4syIYtMJLD8a1o/0yDLMOHMrU54cqKeisHQ7MSj1F?= =?us-ascii?Q?XYM1bZcli5Bgg+O9v/9HradgP6/kZLBKZoqmblLyCXUX1PxKffL2zBZLcitu?= =?us-ascii?Q?kb8nXUg5mxu/xPyDtL5QaME5FsuheIHW7xSSm8OhmUGu0jU0T8bxeUdXFTvU?= =?us-ascii?Q?ynBlhrEiXv3wv2R0gkPWaxHXd5cCFiY9sdtruIrNkOzcUmie7jLQbVKpCdmj?= =?us-ascii?Q?Nk0=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19717557-a2d6-4fcf-d0f1-08d8ff1f9ab8 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2021 08:30:47.6928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lms7Pe22jkUF91EZX5CKcSYSVnV1qyQA+vCCsTJeT/fF9ME4HdLJbCWnB74RvnfgV1AlEAMBOsWT/wLPTPWQCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5308 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, April 14, 2021 16:18 > To: Xueming Li ; Wang, Haiyue > Cc: dev@dpdk.org; Asaf Penso ; Parav Pandit ; Ray Kinsella > > Subject: Re: [dpdk-dev] [PATCH v1] bus/auxiliary: introduce auxiliary bus >=20 > 14/04/2021 04:59, Wang, Haiyue: > > From: Xueming Li >=20 > [...] > > > +static int > > > +rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *dr, > > > + struct rte_auxiliary_device *dev) > > > +{ > > > + int ret; > > > + enum rte_iova_mode iova_mode; > > > + > > > > RCT style ? > > enum rte_iova_mode iova_mode; > > int ret; >=20 > I don't see the benefit of reverse christmas tree. >=20 I'm impacted by kernel code style ;-) > > > + if ((dr->drv_flags & RTE_AUXILIARY_DRV_NEED_IOVA_AS_VA) > 0 && > [...] > > > --- /dev/null > > > +++ b/drivers/bus/auxiliary/linux/auxiliary.c > > ^ > > | > > Seems no need to add one more directory 'linux' layer, as the meson sai= d "linux only". >=20 > I disagree. > Linux sub-directory is more explicit. > And who knows? There could be an implementation on other OSes in future. Make sense. >=20 >=20