From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCD2AA04C0; Tue, 29 Sep 2020 04:34:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 00FB91D6A7; Tue, 29 Sep 2020 04:34:57 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0F39A1D6A5 for ; Tue, 29 Sep 2020 04:34:54 +0200 (CEST) IronPort-SDR: gp4DgFi8e7Mti2R+Ft4pd1XmiW6YK4KMIs9J6AU19uUcztJv0W4DtNsdnKMvyM6ukRyP8k1e6n XOs39m6mZXdQ== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="149877844" X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="149877844" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 19:34:51 -0700 IronPort-SDR: U7wHwrD9sHNAPV1Aht7O3Yf7MU6/iYnCHSOGdoECCGSHzO6hyZfI/RfmvzqEgpuq2/8xt1xCO+ Q2+LqCp1acdg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,316,1596524400"; d="scan'208";a="338428236" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP; 28 Sep 2020 19:34:50 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 19:34:50 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 19:34:49 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Sep 2020 19:34:49 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 28 Sep 2020 19:34:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kqFQbHyxR91hEvll6g+t27Fr9orqQBp9zltJaT0PSgn1KrGNMl+IVc9AHzvXfxbMT5WU/Z3aZ3Z8f7o4/l7CgmrhFWEnO/793N5RPI2G6IAP8LVSuPsUpIa/ZnV6ArKWaan3gPmDecnQndIBlMCa0dXrSmdIDW3XFKILzTOc4mxDn/oAzdpjxRd/YjENt93A2S0npjPy+TV0qtY0ECPJZJjGU5TGNGWDz9/fLHvc1Ekismo/oAVdCrOEO3M/SZFZDdnQsx5R804jKK6wQBAP1WapMmcyEUUbDWAeziA53BmS/Y7LTriAkrVTEYa8f/wQeab1rkQ36UlJviFnffBcyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TzZw0qW/eNaPDxTyc5LNsD5Iei895gUb+yXsVaiCjTI=; b=RfGhswEccgS/lq++IowdgfB2ckcKexCw2YrXRjV8sinUiS66Jb69WhZC0a5/LZ6FZ3LbXQiR3rqE/ASelYOU86LsHr9n0WWlGVHpPViC2lOemQv8SXqb29v5Sn4Cys+f72JAAjqcGIh3CA3KrC6CDJEaco7OwIEUqTik40B7fGXRH2rEr1Qs12ziIrbs9oO29HAQxBV6JQEw44iokyXxn3NAzd4yKQkHhNTCSe31bAbNHGrZ6q2F8g08vJY/PuVEeP2kfvS8mQ6KSRAABRCcK5u+xClncKWrwWzdgpYDRuYRxJ4dZyP0qVgehajKunG0NniwexuArdy00pL9SXFJAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TzZw0qW/eNaPDxTyc5LNsD5Iei895gUb+yXsVaiCjTI=; b=tXPoqImLaJA7zKqqokMdtyOAxeOY9fGBMFDsr6CyTUiqg/ZKSljeaUcWRypKMzwxUwgHWrPXGNzByxSHs/m/gUnXRfRgDy9DGoRBuAfz1fLfrViZ9PdRFqyVa6GBjvXGLgWymndNmCPMIFmRecey+wV5RpgN3BNjedXtfzE5wIA= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3556.namprd11.prod.outlook.com (2603:10b6:408:8d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.24; Tue, 29 Sep 2020 02:34:43 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 02:34:43 +0000 From: "Wang, Haiyue" To: Thomas Monjalon , "dev@dpdk.org" CC: "Yigit, Ferruh" , "arybchenko@solarflare.com" , Shepard Siegel , Ed Czeck , John Miller , Igor Russkikh , Pavel Belous , Somalapuram Amaranath , Ajit Khaparde , Somnath Kotur , Chas Williams , "Wei Hu (Xavier)" , Hemant Agrawal , Sachin Saxena , "Guo, Jia" , Marcin Wojtas , Michal Krawczyk , "Guy Tzalik" , Evgeny Schemeilin , "Igor Chauskin" , "Zhang, Qi Z" , "Wang, Xiao W" , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , "Min Hu (Connor)" , "Yisen Zhuang" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , Alfredo Cardigliano , "Shijith Thotton" , Srisivasubramanian Srinivasan , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , "Long Li" , Harman Kalra , Rasesh Mody , Shahed Shaikh , "Wiles, Keith" , Maxime Coquelin , "Xia, Chenbo" , "Wang, Zhihong" , Yong Wang Thread-Topic: [PATCH v3 28/29] ethdev: reset all when releasing a port Thread-Index: AQHWle1hwMmktRydX0Ww2yZ88Lrhn6l+5G5Q Date: Tue, 29 Sep 2020 02:34:43 +0000 Message-ID: References: <20200913220711.3768597-1-thomas@monjalon.net> <20200928231437.414489-1-thomas@monjalon.net> <20200928231437.414489-29-thomas@monjalon.net> In-Reply-To: <20200928231437.414489-29-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5afba07-a21c-41ee-a537-08d864203962 x-ms-traffictypediagnostic: BN8PR11MB3556: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AbPhwZ4i4Wdx+AlnAKNhb93xBwlX4roXz7WUNC2fjO4PSPjBNJRmREIP2lRyFYgWxNxMtUVRgptXw8exQZZVd5RXAFE9zqrZcXk1QIzpRD+FqQmUcnOb+MIB1W0WBqxt5d3hmVCQs1Hn6FJ6NGTfCZLqVNX0gU3gsRpult4pNmuPR++smFrh19A1c5SpXpxn16bFKzEeV1ELmIPaY+Vy4xUS21z6B8/QSM3O75VmTqQwLClQahVIh2tJYX4cjeOtaq1UzZ2aEkAl2Yh+NGsh9yuatBnlKeG6PDXKzmKIui/Ckt6XgNL3trCFryC2l/IfeGa1IqveWpyC3bIX7KaGj5Qij/XbyJHL6gYOktU4TpWgGPr1EbxXYL6nJn/LUNgP x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(66446008)(64756008)(4326008)(55016002)(5660300002)(8936002)(8676002)(186003)(7696005)(53546011)(6506007)(83380400001)(9686003)(26005)(7406005)(110136005)(478600001)(7416002)(54906003)(316002)(33656002)(66476007)(66946007)(66556008)(71200400001)(76116006)(2906002)(52536014)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 4Z10ItKCZ87pvBLPR/INsiuzzBzxAmuTZ4Lhurw4KnkDpRg/HJJpANEEaQuUMgOfiWyF1UMrn4O//uxxRkp2Jc4RUbeSzOKOfyH9JBWx1N/4D+uhsk9dnAiptldTnbxsIzrIBX+h0rnDfmEedF393ZM6AOuQggSzJ12d5yv8m/2rH954KE+5YFJbnhRIruCy84HEs8rYOgnJyttg/uel0/YzMzordJAn21lUoYGFCyQQPj+H3FfPNV1ZYBRWFZLz/arciHB7i9MDWb0mnee55yxI04Rwg+ZQFIyc0w02ZojFJAxv6hwtOEULCbEvbu/t9+wK8vrZGGJUAnWQMTwtNbB/5R/2KRZinRKvBYh4y1XjEkAkQq14++4AgffZsjx+imB8i6fef+Q53XjuAR8CWISQX8gTKsCctDU/8ZQ/Z3Ot7zhgGE7yxeoK8PLPP/YC9N0d+t41BaFPQdvPhnBTGTbeeGlQesHaD2GRmsPwv2V6ZLbIscyn8ywJgZ3BQxYvegdvVdDNsNHhVg2lBd6UkVvqvFyE96d39Pnn/HZZERhaNZkZVXPCPywM8ZfmGU4BDR5hs0cECcCoh2CAfQJJtHDSy9dS7Zsw5Td8zvveyLFN8axqq1LWHJFbr+/oLBFvjeWTVQJc5RGo3zLsJwEu5Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5afba07-a21c-41ee-a537-08d864203962 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Sep 2020 02:34:43.3364 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e/02iRUsCbbq4aJskW94mbgUbMog7+Fft+ZhF6FxavRg7vznuFTv83GQoyXT947vKaGUajuheWW7lS3b9I7t/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3556 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 28/29] ethdev: reset all when releasing a port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, September 29, 2020 07:15 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; arybchenko@solarflare.com; Sh= epard Siegel > ; Ed Czeck ; Jo= hn Miller > ; Igor Russkikh = ; Pavel Belous > ; Somalapuram Amaranath ; Aj= it Khaparde > ; Somnath Kotur ;= Chas Williams > ; Wei Hu (Xavier) ; Hemant Agrawa= l ; > Sachin Saxena ; Guo, Jia ; = Wang, Haiyue > ; Marcin Wojtas ; Michal Krawczyk= ; Guy > Tzalik ; Evgeny Schemeilin ; Igor= Chauskin ; > Zhang, Qi Z ; Wang, Xiao W ;= Ziyang Xuan > ; Xiaoyun Wang ; Gu= oyang Zhou > ; Min Hu (Connor) ; Yisen Zhu= ang ; > Xing, Beilei ; Wu, Jingjing ; Yang, Qiming > ; Alfredo Cardigliano ; Shij= ith Thotton > ; Srisivasubramanian Srinivasan ; Stephen Hemminger > ; K. Y. Srinivasan ; Haiyang Z= hang ; > Long Li ; Harman Kalra ; Rasesh= Mody ; > Shahed Shaikh ; Wiles, Keith ; Maxime Coquelin > ; Xia, Chenbo ; Wang, Z= hihong > ; Yong Wang > Subject: [PATCH v3 28/29] ethdev: reset all when releasing a port >=20 > The function rte_eth_dev_release_port() was resetting partially > the struct rte_eth_dev. The drivers were completing it > with more pointers set to NULL in the close or remove operations. >=20 > A full memset is done so most of those assignments become useless. >=20 > Signed-off-by: Thomas Monjalon > --- > drivers/net/e1000/em_ethdev.c | 4 ---- > drivers/net/e1000/igb_ethdev.c | 8 -------- > drivers/net/ixgbe/ixgbe_ethdev.c | 8 -------- For e1000/ixgbe Reviewed-by: Haiyue Wang > -- > 2.28.0