From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Qiming Chen <chenqiming_huawei@163.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/iavf: fix arq resource leak
Date: Fri, 10 Sep 2021 03:29:06 +0000 [thread overview]
Message-ID: <BN8PR11MB37959823200E767D6F9DC049F7D69@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210910031249.11534-1-chenqiming_huawei@163.com>
> -----Original Message-----
> From: stable <stable-bounces@dpdk.org> On Behalf Of Qiming Chen
> Sent: Friday, September 10, 2021 11:13
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Qiming Chen
> <chenqiming_huawei@163.com>; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH] common/iavf: fix arq resource leak
>
> In the iavf_init_arq function, if an exception occurs in the
> iavf_config_arq_regs function, and the previously applied arq bufs
> resource is released. This patch maintains the same modification
> as the iavf_init_asq function to roll back resources.
>
> Fixes: 87aca6d8d8a4 ("net/iavf/base: fix command buffer memory leak")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qiming Chen <chenqiming_huawei@163.com>
> ---
> drivers/common/iavf/iavf_adminq.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Can't image that you ARE superman to cover ixgbe,ixgbevf, i40e, now iavf.
It MUST BE done by some code scan tool, I don't believe you have real time to
read the whole code. Right ?
Sometimes, Defensive programming is good, but ... I prefer to the PMD
can run well every time, if failed, it must have some bugs.
> --
> 2.30.1.windows.1
next prev parent reply other threads:[~2021-09-10 3:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 3:12 [dpdk-dev] " Qiming Chen
2021-09-10 3:29 ` Wang, Haiyue [this message]
2021-09-10 6:26 ` [dpdk-dev] [dpdk-stable] " Qiming Chen
2021-09-10 6:35 ` Wang, Haiyue
2021-09-10 7:07 ` Qiming Chen
2021-09-27 7:12 ` [dpdk-dev] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR11MB37959823200E767D6F9DC049F7D69@BN8PR11MB3795.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=beilei.xing@intel.com \
--cc=chenqiming_huawei@163.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).