From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70A8DA0548; Fri, 10 Sep 2021 05:29:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E570D4003F; Fri, 10 Sep 2021 05:29:11 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 003154003E; Fri, 10 Sep 2021 05:29:09 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="221033964" X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="221033964" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2021 20:29:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="581184081" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga004.jf.intel.com with ESMTP; 09 Sep 2021 20:29:08 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 20:29:08 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 20:29:07 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 20:29:07 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 9 Sep 2021 20:29:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PCNuW8cU7VmE2oEtKb9ZSQ+61TZqYWmV4/qtTuGfzY8YTlX76AA4MtxqK+IvBZv688pzhuApAXxJ6G4d7CtgIHCdzW7zp7EK0vyDdFHYiviDiPDgVZsG9Zk74q+N90qfqxBrCKm/3zcxVTKTmE8vvsJPIVDwL1tXEujdBxgad0MkFI8OeCRzBMHznYOFJEQyw/T1VesZbmjnLEFnK4XMaJ9kS/uzbQ0iDeG4bpN1OLowQC5QRNsFj9RBTZ/RRQwJVRJuFBkaFMUq7Dfj6HhqnRoXE6fJLtM2gj1C1z908J1zJ5te2pnZ9c+3GVOTq+m2WNqLx21G/DyoAjwMOH98uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=bD7oWvvA3hN+nFWSAX7XD+KYJbierBVdxEc12Tuc3PU=; b=SNkZvDiDDWGNkxL2MldEdUIGbJVmrVLM0M6QghmUFVwTG9zwVCy3kIafI3CPuPgDTmkikBo3u+4qXwl1P9jo8zz6QJww8BmhiaVbYLMERgiIHjDlgwGU8+aTC8QPhpQg/wx1X9GnD0l9889vdbJgSkr07kfgY5GzfAnUiTQDd4xb/z/QV7f3xd1mrXd525sy4psDhyeZPiTFLOzlRfjQLWna1u9BmHkcRP36jdvYgdH7hNf8LlXErFQgkpfxumE6V757/yrETkwbNfyUQT/+Vn/fiiXeJ/lPJ2wvh1TCHSbaL2oY332QnJOc5Ty1wz+M9rjCJ7Es7BRusfLczYu2tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bD7oWvvA3hN+nFWSAX7XD+KYJbierBVdxEc12Tuc3PU=; b=VwSpUgk5k17E5e0tV/dc9wmgspUVtctPL+7cE2PNJa58xxrqsLe7PFWdfN591MWk/R6vZaHUZJD6sdDSHlOT9EhBO38723uBBCEgJ2ykn1D3KfS7SKehMY7SFtf8F50/0YPESACwCXuuROO/De76oE+j1AmMOEnWwwhcKy0639M= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR1101MB2177.namprd11.prod.outlook.com (2603:10b6:405:50::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Fri, 10 Sep 2021 03:29:06 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::a437:5cee:7df:1fa7%3]) with mapi id 15.20.4500.017; Fri, 10 Sep 2021 03:29:06 +0000 From: "Wang, Haiyue" To: Qiming Chen , "dev@dpdk.org" CC: "Xing, Beilei" , "Wu, Jingjing" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [PATCH] common/iavf: fix arq resource leak Thread-Index: AQHXpfIKYbJsyZi9gEi6hgHlohYpLaucm0cw Date: Fri, 10 Sep 2021 03:29:06 +0000 Message-ID: References: <20210910031249.11534-1-chenqiming_huawei@163.com> In-Reply-To: <20210910031249.11534-1-chenqiming_huawei@163.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5dd51b96-1f78-4dce-0d7e-08d9740b2513 x-ms-traffictypediagnostic: BN6PR1101MB2177: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /pqZZmYUDnuW0+8M6JHn/7n6W/Ak4lEwuaq+GR3dj13EG9QPzi/OeTGU9p9GXsC9wF0mXPA680qY81uxH1UgkwsEaTb6nS2SYDhoVrdrDMPhTh0D37QK/KglIlVNQtAV50As3+mR2tLMhsjzyYptIfwS2PGaV6pOECoO96iU+xtP1sfeiv9ZK4wSn9zoDm6XBLW4BlH6qWMnERphc9gjK4fVio2EhrX7cDXB2I5fnM/TQU8AUwbfy6pjzwvNEi8tAIMT/lk0rFEb4uDsTNweI380lLADDVAtyalGYzSHYHm8t+H46iHF1BbBgiERyqcqMAPUen8QSkDDyC8bLG3vOwDcjbuTcxH2Te15QrfjAYyYdvmCS0WuTl4ufc6+qkiM8wFoL+i5mIWqMZax9794Bba/Etj7fz3m/XxQ+FUfv5IjZqhDW4Guz8Avf/U0i1EP1Kki3YtSUzCm8WHOwHEHQKq+uCa0DLdnNsLvjFP7Ko8bAGadHHjB9EmDowcQmzJVVAujKpdjARACRiZhiRc1IDpiMWdjAEfpNSzyz8ZxM3xUqSfeVKJj/T6Klho0dH8JyGgO1VWpilt7aanHFsUE/l5QQbSDbc16mFyHXVcXWjTvT5vRzj665CUsT7zRoALQS72K/BCKDNaXiWJ3tmOx66Y9vKwjZ15N5bHtN/kHfL2UNLrfHf7/R5NEXEX1C81FZ6//Ma7+bIWzwbgot94gEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(110136005)(5660300002)(122000001)(54906003)(86362001)(38100700002)(508600001)(76116006)(4326008)(8676002)(71200400001)(6506007)(55016002)(66946007)(186003)(33656002)(26005)(66476007)(9686003)(66556008)(64756008)(38070700005)(66446008)(53546011)(7696005)(52536014)(316002)(83380400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2xdR+CfT5EV5TRev4eKr7kGxOMF4R+OXWCmyL0LC5faRAgl3ry0qbp8WB7mx?= =?us-ascii?Q?/Ml6bcpw+MBDRAfntZpDrF8brut/71lplcFw/XYXRRXqKsydUI6Zxr57NDWW?= =?us-ascii?Q?H1ozb2YOlrKbw6KLmBxtmI6ne7JOL097hHvrqbjAgLtGf1UzEqvPou37cGq4?= =?us-ascii?Q?4VMjnYC0njve43Ny5yc/Q6emElo8W/IAbV2dzHzTYqlbLLPSCOejDtXcNqRj?= =?us-ascii?Q?btsDWAWtUfaxKVvF/dxVeZ8RCqGkok90R3/7gs/vx6lIxj8ynv13ubMgLE0W?= =?us-ascii?Q?/CaGh8uJ2qv30iezFC2OYifGK3ZHY/3EATnCdb5lVWkiwyjnobzSSujNVIiF?= =?us-ascii?Q?HWjUbucT3psG90fddFvjh85oX557Hx591s6uZXCjOGC2DNgbDGXZSQwRoLes?= =?us-ascii?Q?0xaI+DUONrmMvExplNcNHASbjgkuNOdKYI0sqZbbaROe4FuWPqa04J9Ozji5?= =?us-ascii?Q?aln5jzYWYUtyOKKWiN1m7f8657puywfKPR6D+W4Y6/juW2CUodsJGnqn1CAf?= =?us-ascii?Q?3PlkNf4QMURQjnX7Bb3WdI1gak0REx++aBxcYGBs8FOz72M4x7jP3LcdL5Ng?= =?us-ascii?Q?tWOqMTakjTR2uqOJwuVoKxJs2FC0v6k64S1ZiIKjwS7hAne1wFZV0UaG9Czn?= =?us-ascii?Q?vAzQllyNitLI61RLZQ0jNplc6OsGQFDu/+wltaO639QbOPV1mvKJcxZayLz+?= =?us-ascii?Q?TZbaaHQXskUjgwCrPpy9/+eo/k18sbJcSQ+vul84PvA6hCnda7AQGhv3ovds?= =?us-ascii?Q?ST/Gh5Q33DUly1HMpZYsfkRmXJZ3RxQYJx3AiprGoH9b3UrmfaRhoNdVjPxT?= =?us-ascii?Q?qdeM0DWdFs0IW6Bu0/LOLCOluD3/vnErLZsW3e75w35CqfvezDYsiHGj9YRm?= =?us-ascii?Q?HurJQY+2bg9DN20qzhmgCdCdN+deujBhOEFK3Fz3BlsLa0biMGqxMEU6CFdf?= =?us-ascii?Q?yVcHj7WbbiCkDEL8HA/ojVehc4QcBOpF4rS+z4QMEWwRlugK88fIPFGICDXz?= =?us-ascii?Q?xv8DA68MVUax4g80Bo8RNGtCNvaDPKdJHZn3Bn3aorDR9YtKk1Z7Q6QpKiHO?= =?us-ascii?Q?9btrXqwpnLwihyjZ6uSgf/y93dsKSfxG1rJSvpL/EEwotCUrhI6nbGGCJIMQ?= =?us-ascii?Q?gAlqqN7MeqAhpdEn662wLlwqs+MR32I86SLDVfCSiM/N08pN4jKO11xD0CnW?= =?us-ascii?Q?VxghVuWgK/KZDgAAklq++l81PZvy+KAnHnUPKqGjt1f5s3Qzby5Ogkg1Ht5f?= =?us-ascii?Q?6HGLx2kxHyuXxYCkpuObTEA6LjvLCD/JG5GuiMmfpUODtLPG6gac9UfYsYyB?= =?us-ascii?Q?UguD+6J4vH5MTAHtXcAehzOD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5dd51b96-1f78-4dce-0d7e-08d9740b2513 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Sep 2021 03:29:06.3444 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U/t5d24OyzJFI1QYn5f1DyQoAg5IT2p3C4q5xUJfuGtFaU3t/RfoOeIteVnIqW9rEVGH+k9Vt9e0en71AEm+ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2177 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/iavf: fix arq resource leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: stable On Behalf Of Qiming Chen > Sent: Friday, September 10, 2021 11:13 > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing ; Qiming Chen > ; stable@dpdk.org > Subject: [dpdk-stable] [PATCH] common/iavf: fix arq resource leak >=20 > In the iavf_init_arq function, if an exception occurs in the > iavf_config_arq_regs function, and the previously applied arq bufs > resource is released. This patch maintains the same modification > as the iavf_init_asq function to roll back resources. >=20 > Fixes: 87aca6d8d8a4 ("net/iavf/base: fix command buffer memory leak") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Chen > --- > drivers/common/iavf/iavf_adminq.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 Can't image that you ARE superman to cover ixgbe,ixgbevf, i40e, now iavf. It MUST BE done by some code scan tool, I don't believe you have real time = to read the whole code. Right ? Sometimes, Defensive programming is good, but ... I prefer to the PMD can run well every time, if failed, it must have some bugs. > -- > 2.30.1.windows.1