From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F499A0C4E; Mon, 6 Sep 2021 03:49:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3682A410F8; Mon, 6 Sep 2021 03:49:26 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id B743540E32; Mon, 6 Sep 2021 03:49:24 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10098"; a="216701718" X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="216701718" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2021 18:49:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,271,1624345200"; d="scan'208";a="604413811" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 05 Sep 2021 18:49:23 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sun, 5 Sep 2021 18:49:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sun, 5 Sep 2021 18:49:23 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 5 Sep 2021 18:49:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YOPoozpsfc08Bf4XrXHNzFanRy3awUx6SfPIj/1RNVYq62WfLfzWW3TduVJ64V2V5SJRIEtc9bvMa/2eGteeWkHzTRLOI0++DrE7d4uMIEhfhxum4M6zeNGUmqlgSVYEsXrVugNrSX1NhXO1J5M0Omo5ww69+6tFe0Sx3RK/43e1wIUDj320s22NWoGbY/9E2r5wUvV32TewdZGqHgjSr+9kooBRazXp5I/NlodAvQEux+zPW7PuqtqZ+Sd97TpDBSsyb68S+KgUwWpT4DXIeDIMM2kOfgP5r4P6Hqq9kx+NLGEufbeXcoJE3KxUNGDXW+ySVlSOIpeDSCTSZxPtXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=fuqhd34RzWoFcv6wIdYiVMp/AttVWNtpskkxONKChIs=; b=HaC6x4J+s+Cuf79TGNRFk3RV2yMO9+GzeK9FgaAGwdja7ze8/b4HntuFtzs3rbsy0XvKmLRDPEug5aCJdlj+sqgpWBWiPyRELvzKyPSSTiGJAI9u5Y8GXFT1kuBUBIrRr1fezkm38w8yBqtZX4CGyUK/3C21wgcQcKIFn50eZpVvzhgUkG89mq//ZYPev1iyZVVodjUKOla6Waah78ZnRXXy1GrEQVkOyZOvkNKEIYhPMTwRuMC8l9EY8QXXU7OCp/r01h0FUu7g18gacxhy4T5OqYDf7dd+DFrGZ+Oy+x5Sx7UsnIOpWyNMCRjfsuPMyEFRoyGeIVNDU/mWe2swWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fuqhd34RzWoFcv6wIdYiVMp/AttVWNtpskkxONKChIs=; b=rdQPjpRp6AcjLf/u70cShFUUX8n/09Jt+HevFhvke/FOXbPxQN5RjgwxKRtM6thWMH6m1t5uVOZwgxZ0YZ0MEgsW62asymYe5cij8WVJNxUnjJ0cboTWX2i6wpaC5P5uCAYUDzjyMuMdkZriHtrMMIz7TaQ4/pjJZQW1OeW5F50= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN8PR11MB3730.namprd11.prod.outlook.com (2603:10b6:408:84::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.21; Mon, 6 Sep 2021 01:49:22 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dcf0:d9f6:8024:1879]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::dcf0:d9f6:8024:1879%6]) with mapi id 15.20.4478.025; Mon, 6 Sep 2021 01:49:22 +0000 From: "Wang, Haiyue" To: Qiming Chen , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/ixgbe: fix vf mac remains Thread-Index: AQHXnnMMlQY7k54mZkG/PBTmKP1qz6uWRdrQ Date: Mon, 6 Sep 2021 01:49:22 +0000 Message-ID: References: <20210831141713.9225-1-chenqiming_huawei@163.com> In-Reply-To: <20210831141713.9225-1-chenqiming_huawei@163.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: 163.com; dkim=none (message not signed) header.d=none;163.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0b08d06-2044-4471-4bbb-08d970d88c77 x-ms-traffictypediagnostic: BN8PR11MB3730: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tCdPhnpY9gqJ4Ie1oa3xF8erWMMWBruqURaq5rEcVlyIjmth1SBLf4gljGBprnBwiJQi2Os4SIpBpchhINQvsYqINIDbEH3QTbev+bnNKplHLXpjeGp/j4HSwEP3WgpLRU973t0v5T53vwQVpwtknOztcjdlrShm1Pr/Eno9wVLM2Q64rnH7q2R+ah1uBT02HrOwwBNy+y57j3g3ZHfWLulgs4FRh3nY//+RoXxN/hraw2A4r87whrU1zlMsMU2hQhLDAKRGU28nDWFczzyY63zPIA8lSOTzF326NKYCUFlPsjO0S/Xw3iSFA7DWjFkPj40WN7v0Kpd4zRnQlXvWoIePczN8dnpSqYsYRAuJOsw3YqSV+QQOPnyq/VEaYhHHTRANJClURgxfFVBik494+AO69WhHCpzXqHu0I+g9aSPsTLh5/cbn9qRYG8Sm7iLBVhym8FkODs9YQ/LJgotAo/sPEms0efxSHPn+O1zZSIEBD1WZGgGvMvqRg+ZmriMHRhK7+Z5O8EaiSPbJARWv8u84Htm84/OdnX432r5gvJo6T33EaV3lG9d2dEzHxr5MC+Sy+uqdVVgFIiWMZAhQiY+9OXJdILdfAh5hCYQ7/TfVUgAAcE67dUxIJylRc2/GpsjrpuonSEV8u/NjZm72he0kmox+XmpxCcsOlJkGR+bG0t8hvn8wXTHHxOqU23gUUS6WKI5MOJf3FcoJ9JFtyw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66946007)(76116006)(2906002)(122000001)(71200400001)(55016002)(9686003)(83380400001)(66476007)(6506007)(53546011)(8936002)(38070700005)(26005)(110136005)(186003)(8676002)(7696005)(316002)(38100700002)(52536014)(64756008)(508600001)(66556008)(5660300002)(4326008)(66446008)(33656002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7ljuQZvVFWegnlRPvcHAcPdGQ6MndcgP1D+nvAZsvO35+QTCNVTLzsSsv+BO?= =?us-ascii?Q?Ea50V2jb7yWzchtmBjqfrzitWpKQnJlUJR6VFa+xgiDcuzrp2fOXDjEeFJQl?= =?us-ascii?Q?IbybSGhG8x3YKswncWv0u4wll+Yvo4CxmEtcru7dDGVI0kNygiW85rjz2Dfp?= =?us-ascii?Q?d7iWGkrnxIxZCYiXd1rcHY3QaNugffksuzjKzztLwnPkkawHIf9M+Ddu5lEz?= =?us-ascii?Q?NXdX/oDbhXBBFpmggX1NKkOQDM2xikebvqbdso+Oqte4l4xdVHUlvO2eoVb/?= =?us-ascii?Q?UrrR6Z3ZEcSvOPfcwyLdjNUuBLdzhxLCaJYGJGqK3VDkBlKwgwq3X6t6TbCd?= =?us-ascii?Q?LEPI9AF9oJVRgnoKSBc/2j7MVOAeOfV+N+6JnbLJFUwHoYzOb+iBpTBJ+yh3?= =?us-ascii?Q?TiHpfZMJ9llVXLC9eH4gqoCEsu+QFTPAnqAfY29BlPlmIwaVjfOC4maqjmVl?= =?us-ascii?Q?8Psr2js+hCsPs1enqTJWeEfSZTETD6anGCZQTzuQj5XIiCHCwe5Pwm5MgvVy?= =?us-ascii?Q?nzztfA7UPXu4BAJGljVEIFupp5ku0O9bZhGVEVcuCs+/uJ13mz+Rgid96pBi?= =?us-ascii?Q?VP0P+9Fkig0PlMlBCaMPrc1Cs8g+lT36vlxpYkREboEN8ljzZUC1/+3Pd6g0?= =?us-ascii?Q?C/IqYu5mxDGRZykDsZPL9Zf5IyqquYnzOdIKMKIMM6zvzqWv9mIKmbEALQQb?= =?us-ascii?Q?aLztUCCHFtmoDIUhlnPEhPAtrZRNiXx88l/8Ql+5ePe8Gw6tplUvkYjcK591?= =?us-ascii?Q?DLoClaV5W1SKLAZyLqMqMZUxropS1a+BjuWJQj4dASiSJMRvsOYR0H+UuXKf?= =?us-ascii?Q?4rjr7mef0mclcvJ1SqCg5s9AUraLDr8X93FgPfPzfFu9a1DThzTPCMOcIwpG?= =?us-ascii?Q?tDklAlHMwXe5puMnsCbQRPZ1wFVBvpMo/ENay+2uSc9gPzCyJbPKnoMGpe6H?= =?us-ascii?Q?keS6Jp3l5bawgGY5tpYjpAQnBO13YDh6wOYiSG2z0Ai81QSedSVskir6I8yu?= =?us-ascii?Q?R2vqmdjKIhalq7MkgHJ1HyTfveS/TuwOSx4Ah+v+OjIxBF+ds5COSNOKgrcM?= =?us-ascii?Q?EVIBKDvxAbKb403/ZQVKXF5sILWBfZgnUw36crRHexy5nwUdPwy+Okup2njK?= =?us-ascii?Q?ULGJiWrPdPPJWgI4qTQIUvc61fVBNvNYxSaCFqUlYjrt5VDycvsyEUMTomt+?= =?us-ascii?Q?D1VV7/nWMtz0+XALplSVm/4MLXaLGYJWqST0eZVz4CbQWQIEuQoDCfWHQu/i?= =?us-ascii?Q?7+IDeCl1by6wf80f0c8FQc3Kc4I5tCnDEFtk6AbYlA2BVZmzrGEUPBcRzec9?= =?us-ascii?Q?9xBC3x1srxLgVAGhtPyXbjrS?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0b08d06-2044-4471-4bbb-08d970d88c77 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2021 01:49:22.0391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XDK0W68ydW+tY1W8/2sMXHQlirnoGxXtQCcUDZ2NvfBj46CJKXZmuGzcClNcuUQ2zuq2ibXIK6ap5K3mtzx/FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3730 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix vf mac remains X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Qiming Chen > Sent: Tuesday, August 31, 2021 22:17 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Qiming Chen ; stable@dpdk.org > Subject: [PATCH] net/ixgbe: fix vf mac remains >=20 > In the following two scenarios, the mac address residual problem > will occur: > 1) In the VF hard pass-through environment, after adding the mac > address, the process restarts, and the previously added mac is > still valid; > 2) In the vf hard pass-through environment, after the mac address > is issued, the port will start/stop, and the previously added mac > is still valid; >=20 > The patch clears the mac address at the start and stop of the vf > port. After the start is cleared, the rte framework will restore > the mac addition to solve the problem of residual mac addresses. >=20 > Fixes: abf7275bbaa2 ("ixgbe: move to drivers/net/") Should be: Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qiming Chen > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_e= thdev.c > index 6a91f104e1..e40350d86e 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -5410,6 +5410,9 @@ ixgbevf_dev_start(struct rte_eth_dev *dev) > */ > ixgbevf_dev_link_update(dev, 0); >=20 > + /* Clear the mac address, the rte frame will be restored */ > + ixgbevf_set_uc_addr_vf(hw, 0, NULL); > + > hw->adapter_stopped =3D false; >=20 > return 0; > @@ -5454,6 +5457,9 @@ ixgbevf_dev_stop(struct rte_eth_dev *dev) > intr_handle->intr_vec =3D NULL; > } >=20 > + /* Clear the mac address */ > + ixgbevf_set_uc_addr_vf(hw, 0, NULL); > + > adapter->rss_reta_updated =3D 0; >=20 > return 0; > -- > 2.30.1.windows.1