DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Yu, DapengX" <dapengx.yu@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: retry getting VF VSI map after it fails
Date: Fri, 24 Sep 2021 05:43:59 +0000	[thread overview]
Message-ID: <BN8PR11MB3795B2B9928B44DE7AEA9996F7A49@BN8PR11MB3795.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210914030858.202578-1-dapengx.yu@intel.com>

> -----Original Message-----
> From: Yu, DapengX <dapengx.yu@intel.com>
> Sent: Tuesday, September 14, 2021 11:09
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Wang, Haiyue <haiyue.wang@intel.com>; Yu, DapengX <dapengx.yu@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/ice: retry getting VF VSI map after it fails
> 
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> The request of getting VF VSI map request may fail when DCF is busy,
> this patch adds retry mechanism to make it able to succeed.
> 
> Fixes: b09d34ac8584 ("net/ice: fix flow redirector")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
>  drivers/net/ice/ice_dcf.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c
> index 38e9a84698..043bd48192 100644
> --- a/drivers/net/ice/ice_dcf.c
> +++ b/drivers/net/ice/ice_dcf.c
> @@ -534,6 +534,7 @@ int
>  ice_dcf_handle_vsi_update_event(struct ice_dcf_hw *hw)
>  {
>  	struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(hw->eth_dev);
> +	int i = 0;
>  	int err = 0;
> 
>  	rte_spinlock_lock(&hw->vc_cmd_send_lock);
> @@ -541,8 +542,18 @@ ice_dcf_handle_vsi_update_event(struct ice_dcf_hw *hw)
>  	rte_intr_disable(&pci_dev->intr_handle);
>  	ice_dcf_disable_irq0(hw);
> 
> -	if (ice_dcf_get_vf_resource(hw) || ice_dcf_get_vf_vsi_map(hw) < 0)
> -		err = -1;
> +	do {
> +		if (ice_dcf_get_vf_resource(hw) ||
> +		    ice_dcf_get_vf_vsi_map(hw) < 0) {
> +			err = -1;
> +			goto again;
> +		} else {
> +			err = 0;
> +			break;
> +		}
> +again:
> +		rte_delay_ms(ICE_DCF_ARQ_CHECK_TIME);
> +	} while (i++ < ICE_DCF_ARQ_MAX_RETRIES);
> 

I think we can remove the 'goto', and sleep if we can (like < MAX_RERRIES),
like:

	int err = -1;
	int i = 0;

	for (;;) {
		if (ice_dcf_get_vf_resource(hw) == 0 &&
		    ice_dcf_get_vf_vsi_map(hw) >= 0) {
			err = 0;
			break;
		}

		if (++i < ICE_DCF_ARQ_MAX_RETRIES)
			break;

		rte_delay_ms(ICE_DCF_ARQ_CHECK_TIME);
	}

>  	rte_intr_enable(&pci_dev->intr_handle);
>  	ice_dcf_enable_irq0(hw);
> --
> 2.27.0


  reply	other threads:[~2021-09-24  5:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-14  3:08 dapengx.yu
2021-09-24  5:43 ` Wang, Haiyue [this message]
2021-09-24  8:08 ` [dpdk-dev] [PATCH v2] " dapengx.yu
2021-09-24  8:23   ` Wang, Haiyue
2021-09-28  4:58     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR11MB3795B2B9928B44DE7AEA9996F7A49@BN8PR11MB3795.namprd11.prod.outlook.com \
    --to=haiyue.wang@intel.com \
    --cc=dapengx.yu@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).