From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8283A0A0F; Mon, 5 Jul 2021 15:18:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8866A40040; Mon, 5 Jul 2021 15:18:14 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 8B39A4003C for ; Mon, 5 Jul 2021 15:18:12 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10035"; a="270099680" X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="270099680" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jul 2021 06:18:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,325,1616482800"; d="scan'208";a="427270231" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga002.jf.intel.com with ESMTP; 05 Jul 2021 06:18:10 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 5 Jul 2021 06:18:10 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 5 Jul 2021 06:18:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 5 Jul 2021 06:18:06 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 5 Jul 2021 06:18:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XkJErV/p93/rvW+UH38X2Xpgy+oQKGdmaXNCe8ehletKqLYa6SV0oKALc/THi896daUuqcaBlmEoNKz8vG2Vhf1sLhtnF5YWKdmXjfvT1DKzr1X7Iz6RHcnDRhNTgSAEAGWhEweRCqvJYgnv7um0sKXQqQGowpxxR+xz7leRe7hHDwpIxgkThpTNOTxsEH62UJF2TBROUzRi6yoztMZ1aViKcK8VYAXGi9szrdvKyRPty9XTkra8w4kl8Yxqakh99VDHt5xoLO58bxo4mBFwszR7x/i8EPBY7R5o5xUQt4nAzoUc+oJCEQYhkesQtNz4aJbnnmQzsMUv7jw2JKMUeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/IK9R1lFAuuw0gLgrz6kFVNXm5kYzHnQIMf3RvN1F0c=; b=GgWEtQvLbfmxWF02pKQcS3himpdnjtU/6+GOPExd6lYXlp+cqF+CQRqmWy/VdN1J1kwXIAC4vQ3qvp4GjkIL5gV/G4Mc6ugNfUw3sNX5ELiILvtZ/aEZpBPfVLRZx7MQXDdsRH7DgrmiRqfrfKqCSK7mite1WvJj1LylFv4QzTmPhzNhzivX6ln5l6mzKxGCW4zkzafddfcGu2Q7y2Ou/S6A7ZPj3ysBC2CgIjB25WNLI9nJIIG5ftZFiwzbWFGOenVSyFzrsqMiqTDJR/LkG+AkqO0FnOe9uuyJbxWUSIHYTgjzfqcp7HoCaur7bWf3Km+FQ/TKTooq3Ls/kqPKcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/IK9R1lFAuuw0gLgrz6kFVNXm5kYzHnQIMf3RvN1F0c=; b=Rm0Y8dR5VLHIZWcSTbd+n/Cz0QwQdijLz38etLfVI03sP/jj3Y/CLOH5TGO/KdgntFNi3IRpZbqs8IkyXSnhO88i+eWtHtCCGlut+kF/XuHSdE8eeXMe3owAp9okdEydoRppGQua2TF3noYs1Hp8BuiwaHd/Oi90UfRyEBGqW/k= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1441.namprd11.prod.outlook.com (2603:10b6:405:b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.24; Mon, 5 Jul 2021 13:18:04 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::8807:6661:e425:102]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::8807:6661:e425:102%7]) with mapi id 15.20.4287.033; Mon, 5 Jul 2021 13:18:04 +0000 From: "Wang, Haiyue" To: David Marchand , "dev@dpdk.org" CC: "Yang, Qiming" , "Zhang, Qi Z" Thread-Topic: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading Thread-Index: AQHXbL3LHM6wvHCgqECmshcrHyKK1Ks0ZdnA Date: Mon, 5 Jul 2021 13:18:04 +0000 Message-ID: References: <20210602095836.24901-1-david.marchand@redhat.com> <20210629080632.30964-1-david.marchand@redhat.com> <20210629080632.30964-2-david.marchand@redhat.com> In-Reply-To: <20210629080632.30964-2-david.marchand@redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.0.76 authentication-results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.143.19] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4430f31d-a93f-427c-c597-08d93fb75266 x-ms-traffictypediagnostic: BN6PR11MB1441: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LSRqenfjAqbEd/8LzwuVK7aTMlm3tel90Z2F3gi3HpyXm6ll/JLbzMGLB94DLMeSRp1Q3iIaYPdsClTGVLfybhBGE3NWdOCal7TJnnHtN2Eu/byewBOfEWwEgYah7eO/R4/HtlxjwdP8RY0mymOsbgnXm8ShCstuo16nTcIpg9KtQbzwiox5btBv51FgeaGl2hWLZuzD0Ce7eDycIv7reyn9XYOx9m6fRe03pY+vCuMeJJW44LF1bZcFJOX7RRvJuwh+iOoDBWQFX6TgLpCLiv54Fq/W+p64+kdHjbgecZXBYH6bEOpkJwYOHxiihM3XBg1KtQzuor7hWSUFkT15wiotV/ldopAJKKJ9d4UEbh6hF0n0CNp0OPgfp46djEKbm5K9+r9CQw9LJHJhpUz4Hb/T6iWeOKUwsXkn6FrRiQp1vwjg3Sk/hazlCNc1moSrygTfRHkJSqny3x6y1wK+f1IAO5z1jnF4n89Ij/xGpaIrTcWrZNoxieLc7ApNxc2+sSQlYg5frq6gP2wXycwZx2jxbipKECmGgr9g9CYwjf8dDXm119pg4N/3DlY1Csiq87Bz8Lpdv9MHH76+gsgdo/koTvalJWu5/H0QK8HUa1s7wmGq8jWBXqxz9KltUDiDm4Ev0XxxfPJhIorSvhW8Xg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(376002)(396003)(39860400002)(136003)(366004)(8676002)(76116006)(66946007)(55016002)(8936002)(2906002)(478600001)(66476007)(4326008)(5660300002)(186003)(53546011)(110136005)(6506007)(26005)(83380400001)(316002)(33656002)(64756008)(66446008)(86362001)(38100700002)(71200400001)(122000001)(9686003)(66556008)(54906003)(107886003)(7696005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?imoF5FlDbQAiK/fjYcQMBkbiAU93yJkKK/6Udacik/8u/8Byn9RRZvhF1oy6?= =?us-ascii?Q?ruWQQtqFf7RaZVZc2JaIXN32GoflRkCl3dGynJt7TFQMhF/aEu1vvEzihlxE?= =?us-ascii?Q?np1k4NZTc+J/Sj/7ZwM1Y7pAwE4/MgwV/3CvmsWrpy+rb4sYkdk9rAUpr/72?= =?us-ascii?Q?6TMphL8l0i6MkthUjk/YeYBS4pmRukC0yVMaFuHGOb97Q7aPxjKjZZuhbC5H?= =?us-ascii?Q?Sc71vRJNWeSsUtie4xyyoc0G28SupPlq4EfnLBMl0/DTKgAQkomBFOa9JlK5?= =?us-ascii?Q?RmCpKqaKKT9Gve7p9Xx/Hz1tRBMPc+YAx8cIqD6rsh4umTksvlyCXMjI0gEm?= =?us-ascii?Q?4/oP7ECwJXusw+A198CedytZlwXb3hVjPGK7ybhypNfdNxszZFa+ONjYfeM+?= =?us-ascii?Q?+e3HshPvHX+o6Jm8bXzepcBDAC41h1asGlM3oW5/MZqEimhQHkUvoUxUctdQ?= =?us-ascii?Q?Qielhd17tPlhMSSCHEWZqFByS307GviJoznZrBFbAjrLGbQYAYUiVOUndALm?= =?us-ascii?Q?3PwDNRBYpQnC5GD/66CSsM/peE+b64rjSRzQbkKo0Y5TE1xuLGA09lF2IGD+?= =?us-ascii?Q?WcQu2e9e800T5xFu7EEDMNoWt+rEMfsyTrdd6bt72KtE+SC2JRND/jlAYpdI?= =?us-ascii?Q?Jy6Mud2zKGilzdtEW4ynYgAzYFKo+m0/MbDA8DxG/g/NNqAUd2fOz4LKMEbX?= =?us-ascii?Q?mQspFS/IR2tY2HvNRSg5Ctxf0rjuJv+KDC9OH7CvX8CZGTltaazou9xNnybk?= =?us-ascii?Q?nrXMjp/2c2wJUt9D4bb8ViesRuMbWek+FyV7n5KXjk25x7FGYV1Y+HY2qvvW?= =?us-ascii?Q?sTloo1lU7/CN5Zc96GrvsXjImfQAFfMckEAbK50J0lZPQlHHL8JKPIt1Sjmm?= =?us-ascii?Q?Ywe/LMjcQQBObGLHmpkZuJnX40sZtYWPOWqz+A2kNkI3F9fQsnuxpsKb7v7t?= =?us-ascii?Q?8LwzLhhupIDaI77tUbw5iFrtb8Q5F3gFiAeCJIIAklBT98xKey+105iXdv5B?= =?us-ascii?Q?vm9I/vnE6ptNh91vzGGy4+lS2OJ6Id+dXuyYqWiEvzu2tDbyDgtv4K0YHZK9?= =?us-ascii?Q?+XtAkZ9jRpYsGdVxh1W82A8j/ED9gAz+iZzJdosyqHee1FceSnhFi+lUJ8V4?= =?us-ascii?Q?PmeXlTEk8Q7QW+bHf+22evJmSqH9wP/jHj68+iq425BPy6ChhnSPN1Q39kFg?= =?us-ascii?Q?0kyEByLup0onWNDTMXiNTeabfo7djEQb6iP6X8w56dz6Yf7PuLdtlDVIbZPr?= =?us-ascii?Q?aJ+utqqV1BgRMKhjHue92SEtRIsKzuJ4NsXcCPQHbSgzCH+hIglofBId33cK?= =?us-ascii?Q?ZfIaEmCLEhfVtIW5qlmXGU9c?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4430f31d-a93f-427c-c597-08d93fb75266 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2021 13:18:04.2258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q7pNGOI9KZRRlpnSzys9MG5yW2/45K9qgWmL23ot0gtyIwN7FeSppcoikhhNWZyXJCcT+SePaomHwGHizZtWgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1441 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of David Marchand > Sent: Tuesday, June 29, 2021 16:07 > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > Subject: [dpdk-dev] [PATCH v3 1/2] net/ice: factorize firmware loading >=20 > Both "normal" and "dcf" inits have their copy of some firmware loading > code. >=20 > The DSN query is moved in specific parts for the "normal" and "dcf" init. >=20 > A common helper ice_load_pkg is then introduced and takes an adapter > pointer as its main input. >=20 > This helper takes care of finding the right firmware file and loading > it. > The adapter active_pkg_type field is set by this helper. >=20 > The ice_access macro is removed from the osdep.h header: osdep.h should > only hosts wrappers for base driver code. >=20 > Signed-off-by: David Marchand > --- > drivers/net/ice/base/ice_osdep.h | 6 -- > drivers/net/ice/ice_dcf_parent.c | 97 ++----------------- > drivers/net/ice/ice_ethdev.c | 161 +++++++++++++++---------------- > drivers/net/ice/ice_ethdev.h | 3 +- > 4 files changed, 88 insertions(+), 179 deletions(-) >=20 Squash into a single patch seems great help to understand the compress firm= ware context. ;-) But it's OK as two patches. Acked-by: Haiyue Wang > -- > 2.23.0