From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0E7BA0546; Wed, 7 Apr 2021 02:50:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 589E9407FF; Wed, 7 Apr 2021 02:50:05 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 762F04069F for ; Wed, 7 Apr 2021 02:50:03 +0200 (CEST) IronPort-SDR: R2JbeD0UCtYvpp0R6XYnla/pNN1FtgxPfgR92TE4sd/l0ao+4ezHbz1FKI7bRl8H8sy5bXg1MU 0C3SE0tKOlVA== X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="213567109" X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="213567109" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 17:50:02 -0700 IronPort-SDR: a98TRwBCq/Bc1XY//q9aVl9UjJ5GPZzoqO83KkhFu8JrvxSJOVpwzeEE2l++qwMROjgiHvmtT/ ADMOx+lm8jqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="418559341" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga007.jf.intel.com with ESMTP; 06 Apr 2021 17:50:02 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 17:50:02 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 17:50:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 6 Apr 2021 17:50:01 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.55) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 6 Apr 2021 17:50:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CebkKWtL7cuNcehtEVDceoEws7OJchK/zkfThtPMsF2S+zT8ZfQ2dRgg6ci1Dq4E7cR7/TVIa3+gmD7RvrfMt+cxwBoEcOKa2CwWmFdPJZGnLMbfc6pYkHIlUCWNXk9bajpSN8Enqj6f4yjVBUszwm8TB4IT9sa5hrRpsP5cWgSUK02hxe2j1ck6h3UDD1X0Xhm9nDd3QFUMKLpm9uuee4RAjh5xYaA7F+KQEamv5h9NiNhn6Wxbaj562lbqx6khxk/gmy7779AEiolEMxHFIo0saMj81M+yD2lAN8AKzaLcEKzQUDEyqF+kNzSXRr1KM3xXx7WqNO91ee2UPylqdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KDV3ommyr4vVjGK0eGEXKgbtm0p67Ryyc7ghk6/FAuo=; b=I4jgS2VxozqRjpnWKqgjm8zlL0C3zePoyW+dwHt4LMJfuaSyCwYJnHvLnWwbvMQ25whr4jhBNAEH2Clvmi0wZZBsnj3dXVqPkdHM+vJKvgJV53TEMCOPyHjgCl9wqxsiPhjjIuBHPA3yUUJYOGxXsw8mnDDGHm1uZ2oLfvMGMk6S9jCeXnfqHQpi1weW0qJTROqTiOTfLmu/0jOzDw9das0W4++BjYo3oJ/kTJ4R2+fr9WAlUGkQMQFZ0L8tQgjpxanUfzjfIMu04ep4JOv+ySEhyO7CxNIycIxuTKSWSIhpI10hKRveaiIXpSDmhLI/EUK20JiKB9PTS4CxjbP17w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KDV3ommyr4vVjGK0eGEXKgbtm0p67Ryyc7ghk6/FAuo=; b=SW+uL8jWX19nOB+L7qHujKGxhZXDdCOkCeCdtRJR4hk0lJzpqakBUu9j15TUX+AYIItr7R6QUKD0rjdcwxrJVJVGzygFR4n9k137amYSol8TTGA2tFBrJo0epjOd6NZoSud0JG4q26LsB+TV9yZ7CAtVhUxtiAKb1uHmfWINfdQ= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN9PR11MB5243.namprd11.prod.outlook.com (2603:10b6:408:134::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Wed, 7 Apr 2021 00:49:58 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::2dfc:3be2:c305:6346%6]) with mapi id 15.20.3999.032; Wed, 7 Apr 2021 00:49:58 +0000 From: "Wang, Xiao W" To: "Xu, Rosen" , Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , Hemant Agrawal , "Ajit Khaparde" , "Griffin, John" , "Trahe, Fiona" , "Jain, Deepak K" , Raveendra Padasalagi , Vikas Gupta , "John W. Linville" , Chas Williams , "Min Hu (Connor)" , "Zhang, Tianfei" , Nipun Gupta , "david.marchand@redhat.com" Thread-Topic: [PATCH v2 3/3] drivers: align log names Thread-Index: AQHXKgLt9lLj7K0WyUSnJ8g78rmchKqm9ycAgABD8ICAAATfgIAA+o2A Date: Wed, 7 Apr 2021 00:49:58 +0000 Message-ID: References: <20210310140107.2730088-1-thomas@monjalon.net> <20210405100301.657768-4-thomas@monjalon.net> <25679079.2jXQ2v77ot@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [183.195.27.13] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3dc4deac-84c9-497f-0962-08d8f95f118d x-ms-traffictypediagnostic: BN9PR11MB5243: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6pjvKtAM4k82V2zRPruncFqAClsEVuPZ+1WSp+697tUEbmTx/W8+KxmyVjP5Z3JnrUNsP97O1liBZrvX9rVqMJkutIk1O2koCQS2H0ECoknCNyYmsocVDGv0gaxmq3IgdF0QARR/rrPACEfEclP+u15eO9U/6IB9//68iRaQmPztdBWx04ee/DKMFp0fZ9mvy5rZr1Hlf/+RVVYDlTK9ft4APMvuRkpn+QxrsjRqkldTEGYRxzrPJXlz6j/LA4E4lEqHw5GGQFcxbE4M6QY8TPrV6XTjEVmQ9flJoKghHwgDQJzF/m5opmEtzVb+hEqQAL+/2l6sK4FFsOrQy+BuaNYLrC31gfBaCXWxHJEpvAnLA8TwRzVx18t953d9JUAevoHS4/WsY8NQl4Gl0rmENJpSgdmqRe/cOe8TPHpfFavAQY7dftrLT0CwJNkuKwVb58ZYEBoc87UpMvECd2vE9OkushWPr3l+URWjvz/JVju9eu9+9JXMK0AJkhUoQaZmW4kKPjjZHCBb4s2ka6LSLaVyhp7Fgl9PG8LrrsxlFcVa7o+muN5/sdvtek27t5+8PzZ686P808Jb03KtjnuhbkIkQ2T771Szm1Mlcy8iI3+MPBOtC1Hj9lgPt8iYwRxHSX2TS58vdpp6AWGWUYftS111UhsOgiPSPfCraXGe/0I= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(136003)(396003)(39860400002)(346002)(110136005)(71200400001)(66476007)(64756008)(66556008)(7416002)(66946007)(26005)(66446008)(5660300002)(54906003)(186003)(4326008)(8936002)(76116006)(52536014)(53546011)(6506007)(2906002)(55016002)(33656002)(478600001)(8676002)(316002)(7696005)(9686003)(86362001)(38100700001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?Windows-1252?Q?fyB5+DyMagW3o+IOBxI+Sy389TJjWjgj+b3dCcFAD7jetc1mTK9ecq5E?= =?Windows-1252?Q?i12WLsRFYVLFlRSETqbw7+iq+lb01UtroBmDRcGHr57op3V0BBR8SA3Y?= =?Windows-1252?Q?39JnCs3XMtYct9qV/di6OQLweJ72cogZXM+B6/gP7vXmisSBMkPvBaE9?= =?Windows-1252?Q?OtFLngdH9hl1RdwNKW6Cosz7Bhee4NERi6yRz0DZIjB3l+2uYOzRemzR?= =?Windows-1252?Q?PCH+X1MEVGUdrKEojAEa2c4ErW/488VIaZUghBWSKBWjaPTh7ozQU6g4?= =?Windows-1252?Q?W/lBHA5vttYYZ5dxLGeZk0Rb/NKaWcJ5as7crAZrauGfgNIribr/JyJI?= =?Windows-1252?Q?AOtS99KeVcmnaQTkUpbz1CPe5PZucQ95NFOZDfAKtzvbffJBrxS3VuJb?= =?Windows-1252?Q?dweVLhZGk5OpjSqIyuRFZJPl505+Zf8SqphKXQPCQY0Cfhzbcw/FHuaZ?= =?Windows-1252?Q?PPscNc0RYmnIIDGyxdGAW/0lShQGa19tw3eqH6xoNIGZDLpdHICJnf9A?= =?Windows-1252?Q?88kXvUXZXIMPXl5oGwi7sZ7dV7xrDpu6FEBorgf02Cn9p10ajZvfJP+7?= =?Windows-1252?Q?jU1ZWc0Vcr4EuYbzE1IsdjOWgnbLmNavoyTp5v4cAkUauDPgClIs47hn?= =?Windows-1252?Q?l5ssC9+xnThenoZaOhucTx47RPjp9DtE5MNXVkv01V5zq96r/95L01nq?= =?Windows-1252?Q?BmXd3m+OoiSREtHE3LYV1KUXdEo8elJRC462YpFaLGjOzqarYvSLp4fj?= =?Windows-1252?Q?sI/XP7TC6CQJqo+/h7FH7zss+sWc7RYRIpQJvaq0t9UOXhTyTE2rcU3o?= =?Windows-1252?Q?cEaiJzUl39OEkW3gFzjH5cvZ5d2P4o9CpT8INIBGpG8528x59nU677r1?= =?Windows-1252?Q?uIYqvawSF3mozi0QIAxY1dUdk8XeXFdrIVDNOt3Qphb6qq9S36hVysqB?= =?Windows-1252?Q?GHq4eAIHloVML0ZbWRtG+La7sE2/y7530loIZuYjyAGtlSR48dVL60rO?= =?Windows-1252?Q?I3lBc8qZZv+dRCzEW7WVNMcSjDKUmIomym4gxYuu7p9FOGIDXKD6scuU?= =?Windows-1252?Q?cf+VRrcEHEuKWWOKiAM1GRfhUXGZ498uS6uxVFmYefuvcjXDNl1tzbSf?= =?Windows-1252?Q?peBY1/N/1uPIs/8m8dF8reKR7BH/aq4cArrJE4qcERdF4ccB0zmwtXzm?= =?Windows-1252?Q?FmtrXFBYpPDn9XywF0jrC2Rm9BBkspsiGhMYW+meqi/uXzzaEDWN0bMk?= =?Windows-1252?Q?VSu88cD5CKB9HZvRf1bNGK+xgDuN4qHgvo6BvLWhOjtWLCQ8k7YUptiF?= =?Windows-1252?Q?GxyawbZaeEBhjmGcSP634SDe+EcIKrkMuObKjf9y6yTpYyNn1iCvz0Rh?= =?Windows-1252?Q?/sn9/Zwvd4COqxv4YQj1CLu8/jxLjxEiICBeHjUZJQ232qEReDRgap+W?= Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dc4deac-84c9-497f-0962-08d8f95f118d X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 00:49:58.1032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hFLz9AaiqjVgNdQvvK0ExPGvrIuzfRyRF6Wr23P0PVUEd6gPBNQnMtUxkusbI/vma+QzDf1L4pc+viG6AwNOiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5243 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, I agree with the "ifcvf" name, as there might be more than one driver in a = single driver dir. Thanks, Xiao > -----Original Message----- > From: Xu, Rosen > Sent: Tuesday, April 6, 2021 5:48 PM > To: Thomas Monjalon ; Wang, Xiao W > > Cc: dev@dpdk.org; Richardson, Bruce ; > Hemant Agrawal ; Ajit Khaparde > ; Griffin, John ; > Trahe, Fiona ; Jain, Deepak K > ; Raveendra Padasalagi > ; Vikas Gupta > ; John W. Linville ; > Chas Williams ; Min Hu (Connor) > ; Zhang, Tianfei ; Nipun > Gupta ; david.marchand@redhat.com > Subject: RE: [PATCH v2 3/3] drivers: align log names >=20 > HI Thomas, >=20 > I'm ok, if you replace pmd.afu.ipn3ke with pmd.net.ipn3ke. Thanks your > reminder. >=20 > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Tuesday, April 06, 2021 17:31 > > To: Xu, Rosen ; Wang, Xiao W > > > > Cc: dev@dpdk.org; Richardson, Bruce ; > > Hemant Agrawal ; Ajit Khaparde > > ; Griffin, John ; > > Trahe, Fiona ; Jain, Deepak K > > ; Raveendra Padasalagi > > ; Vikas Gupta > > ; John W. Linville ; > > Chas Williams ; Min Hu (Connor) > ; > > Zhang, Tianfei ; Nipun Gupta > > ; david.marchand@redhat.com > > Subject: Re: [PATCH v2 3/3] drivers: align log names > > > > Hi Rosen, > > > > You already gave your ack in previous version, no need to re-ack. > > Instead, please give your opinion and explanation as requested below. > > We want to replace pmd.afu.ipn3ke with pmd.net.ipn3ke. > > The use of AFU in the driver is not clear. > > > > Xiao, we need your opinion as well about ifcvf vs ifc name. > > > > > > > > The log levels are configured by using the name of the logs. > > > > Some drivers are aligned to follow a common log name standard: > > > > pmd.class.driver[.sub] > > > > Some "common" drivers skip the "class" part: > > > > pmd.driver.sub > > > > > > > > Two drivers have exceptions to be clarified: > > > > pmd.vdpa.ifcvf instead of pmd.vdpa.ifc > > > > pmd.afu.ipn3ke instead of pmd.net.ipn3ke > > > > > > > > Signed-off-by: Thomas Monjalon > > > > Acked-by: Bruce Richardson > > > > Acked-by: Rosen Xu > > > > Acked-by: Xiao Wang > > > > Acked-by: Hemant Agrawal > > > > Acked-by: Ajit Khaparde > > [...] > > > Acked-by: Rosen Xu > > > >