From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48332A04B5; Tue, 27 Oct 2020 03:01:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D4C11E2B; Tue, 27 Oct 2020 03:01:50 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id E94801D9E for ; Tue, 27 Oct 2020 03:01:47 +0100 (CET) IronPort-SDR: jid5MK73bF3DBbTfwEidEp2iwQgdaMC3UGJ8uqHUHyl5l64cWIojjVQ4sKpBWUymdjh6pAwc32 tIbAW312kyfw== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="167233468" X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="167233468" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2020 19:01:45 -0700 IronPort-SDR: ZlUsrirxDnZ7EBL9x5uA9KIWiMLjfek4MaFPx5agOgZFGC6ebNQCv/lSLtz205H3KK0zhT0+pd oYIOB+mcIctw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,422,1596524400"; d="scan'208";a="394310742" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 26 Oct 2020 19:01:45 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 19:01:44 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 26 Oct 2020 19:01:44 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 26 Oct 2020 19:01:44 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.58) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 26 Oct 2020 19:01:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ROA4O40nPb3NpwKQh9bAbIgvk4gluDzkOTSTdm5doYpgEWLxx6atu7h+jFGkpGvnxgd0+o/26IX57Gzv54EmykAZ9v4+S2MdaucCECEBJoHTCKw4kRDXTUb3N0uqAzbnGo+dKhTDiFfOminLwx630CU81ygrYBmbjnzpRtFXLIHs36pmbry0tmb+yjKn3KdxR6oLfNl/rQ8KFbxwid8VqZbC8ljzD8xRVPom0lRIewokJYzMbAuqAas4F0A9a69oc66/7RJDrOU6a8/MsGT3NZ5Ox0IeVeevypXU9y2Cm2A7znWfPCL4iMSL7zKfICexYCwuXTbL13O2lZdEI5izxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bfyShTDFqLV8RxtjBxdlRWiKOK5HK+jdZxHZ7Zs2xXY=; b=isc3f6w1pAeX0fJnC6PUYq+Y+/wnGzQ0C3W+Ob3/WbpeJNtFwIv+rukGuCwOIIbTaSKLh/j2r8+gB37HAnhw0z2EP3gY80XnreV1I6PrEFjJcZ5PRL2t+FedHg9H/05h6+AcZsxsizIoScRmsBJ16UHRZ5KUf4K7ctPQDZJFZQzeNqmnxV/uTGKEbv3L6rqQg7SXPAx8D4870w0zjR5/MTLYasd0AwfhVvuULYqeaAVYe8r1uUkLlAoDf2r+2jSzR2VV9Q+Hsud8irx//J20JE9N2cqIpypImOSmrEb3lFR0LtHV8sl8OGFGjEEVaNr1KDNlAzpN9CII9xYCcs9TRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bfyShTDFqLV8RxtjBxdlRWiKOK5HK+jdZxHZ7Zs2xXY=; b=PaGPJodBHMpn136YVpIdc3eoHIIP4BQiG1+1ongA5q5kPq8bUJgkdddA2F/qr28ZjeCqQgapwJ7CZ1fwdycLNW7aF/wl/VyfAOJOc/XwqV1uIqoz9Z2xpvJ2xwpp+7lHzknFTxpBgP4/J5cdvBWoMhOy2R4HM6tRZkyOiv82ZTo= Received: from BN8PR11MB3795.namprd11.prod.outlook.com (2603:10b6:408:82::31) by BN6PR11MB1585.namprd11.prod.outlook.com (2603:10b6:405:d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.22; Tue, 27 Oct 2020 02:01:27 +0000 Received: from BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae]) by BN8PR11MB3795.namprd11.prod.outlook.com ([fe80::e4a8:91ab:e032:b8ae%5]) with mapi id 15.20.3477.029; Tue, 27 Oct 2020 02:01:27 +0000 From: "Wang, Haiyue" To: Thomas Monjalon , "dev@dpdk.org" CC: "Yigit, Ferruh" , "david.marchand@redhat.com" , "Richardson, Bruce" , "olivier.matz@6wind.com" , "andrew.rybchenko@oktetlabs.ru" , "akhil.goyal@nxp.com" , "Doherty, Declan" , Ankur Dwivedi , Anoob Joseph , "Guo, Jia" , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , "Nicolau, Radu" , Ray Kinsella , Neil Horman Thread-Topic: [PATCH v2 05/15] security: switch metadata to dynamic mbuf field Thread-Index: AQHWq+ZImlxBQhGGUkGJDv0f+hRbXamqrvPQ Date: Tue, 27 Oct 2020 02:01:27 +0000 Message-ID: References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-1-thomas@monjalon.net> <20201026222013.2147904-6-thomas@monjalon.net> In-Reply-To: <20201026222013.2147904-6-thomas@monjalon.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 65614221-fe7b-42cd-71d9-08d87a1c3756 x-ms-traffictypediagnostic: BN6PR11MB1585: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t3BgxoItzaSKTAY0lHMXA8raHmstyibzzfKxY61KfhfXme43M2PQszw5wqSoyBn94Y8S1ZMv0hGK8k0BkFNAO8rfHDuPNOTQPs5DBg5IeiH65MEf2mPJL+1TB+JzYBPfD24eIOxjOdYm90LCFwWLK9uLy664bKiz5S2tL7qZ9ilMu4Vh48rdTqxxE6Jc8eGAw9ptCcCRFtSmkHs9uiwTPXrIUb3T5ajQg8q+mmCT5FyxvXKK6ioyTharCRXSXjFcOLhp2HSHBUXH9DX2wF+jpVkOrZ4DKMACYQqyMprHw+7sNsLQs+/AE7zf0FHnmM8/iOgqk/EOYmJDVGfxtWBJ+w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR11MB3795.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(396003)(136003)(39860400002)(66446008)(52536014)(55016002)(66946007)(478600001)(71200400001)(5660300002)(8936002)(66556008)(66476007)(64756008)(83380400001)(76116006)(86362001)(15650500001)(186003)(316002)(8676002)(2906002)(7696005)(110136005)(4326008)(54906003)(53546011)(33656002)(7416002)(6506007)(9686003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 8eCCBdaaDtlGhzJyqeugizL4K0tpjC+0xdMqfnmFb/Xkif1SfQ6TX2E/YcAJkXb/T1mihPtiInm+q6x04qC379PEUW4Zjth63g2wi2fM3Z6Ywp4FwzegjoKLPxwtyw+B5AeEQhbRBrT+r/UGCIYfeneD2Q77Mpe+wBnna9Hh6Bkm4zwQGZ6kSvTnYw0KapXO80R9duRzsdTZXP6nadKBOm8UNNFqmD4z8fzj5KF4RFpWZ3kkkEhxEv8eZEubhdSaQOqd+UNtxxkwZSp5h1jyuYgt0PuWVbCRTog9XbqqxQuHsqQgG8P0Fm8CuDSGULh2UtiOkpIVkbCg58Yrb/wvNHXmPzkSsiR8H7ko9TFUe8CtGVtURvnKH2DNMLh0MLw/QkddTzDbXDGzy4TYaITD3Ox0PdQe1SMvqG6BHrLYlvr0I7E5uPXlykRkHZVl8YwlzjO+51W8KSLITzAZjsBFN9hoVeYw8qJi9F5nFk4e0+RILYuN8mqaqz9Xii3SF8XGzXYrcvFkyD7G3GXGLbOxGN5HT1LZIFV0nOi1ZgqRdue9wLLM/BM6zlJZMcmHKzkPUy+wCu6+Iz2gb5gPS5p9oUgpkFzaIVybA288MX1nHUEOa79EfUmOasQnf92ISEREI55pTa38snTH+X1kuhyBIA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR11MB3795.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65614221-fe7b-42cd-71d9-08d87a1c3756 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 02:01:27.7221 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TJRzQCGTs7RYK8LkmpNYz7/B5r4fjSlOX228clkgxx97skfrJDLMHD1XuIqhv417PvQ+9VVyELr7T07l/NsU8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1585 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 05/15] security: switch metadata to dynamic mbuf field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, October 27, 2020 06:20 > To: dev@dpdk.org > Cc: Yigit, Ferruh ; david.marchand@redhat.com; Ri= chardson, Bruce > ; olivier.matz@6wind.com; andrew.rybchenko@ok= tetlabs.ru; > akhil.goyal@nxp.com; Doherty, Declan ; Ankur Dw= ivedi ; > Anoob Joseph ; Guo, Jia ; Wang, Ha= iyue ; > Jerin Jacob ; Nithin Dabilpuram ; Kiran Kumar K > ; Nicolau, Radu ; Ray Ki= nsella ; Neil > Horman > Subject: [PATCH v2 05/15] security: switch metadata to dynamic mbuf field >=20 > The device-specific metadata was stored in the deprecated field udata64. > It is moved to a dynamic mbuf field in order to allow removal of udata64. >=20 > Signed-off-by: Thomas Monjalon > --- > doc/guides/prog_guide/rte_security.rst | 9 +++--- > drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 5 ++- > drivers/net/ixgbe/ixgbe_ipsec.c | 5 ++- > drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++-- > drivers/net/octeontx2/otx2_ethdev.h | 1 + > drivers/net/octeontx2/otx2_ethdev_sec.c | 5 ++- > drivers/net/octeontx2/otx2_ethdev_sec_tx.h | 2 +- > drivers/net/octeontx2/otx2_rx.h | 2 +- > examples/ipsec-secgw/ipsec-secgw.c | 9 +++--- > examples/ipsec-secgw/ipsec_worker.c | 12 ++++--- > lib/librte_security/rte_security.c | 22 +++++++++++++ > lib/librte_security/rte_security.h | 32 +++++++++++++++++++ > lib/librte_security/rte_security_driver.h | 3 ++ > lib/librte_security/version.map | 3 ++ > 14 files changed, 96 insertions(+), 20 deletions(-) >=20 For ixgbe PMD, Acked-by: Haiyue Wang But I feel that 'rte_security_dynfield' name is too generic, can it be more specific about what the field is used for ? Like below ;-) #define RTE_SECURITY_DEV_METADATA(m) \ RTE_MBUF_DYNFIELD((m), \ rte_security_dev_metadata_offset, \ RTE_SECURITY_DEV_METADATA_TYPE *) > +/** > + * Get pointer to mbuf field for device-specific metadata. > + * > + * For performance reason, no check is done, > + * the dynamic field may not be registered. > + * @see rte_security_dynfield_is_registered > + * > + * @param mbuf packet to access > + * @return pointer to mbuf field > + */ > +static inline RTE_SECURITY_DYNFIELD_TYPE * > +rte_security_dynfield(struct rte_mbuf *mbuf) > +{ > + return RTE_MBUF_DYNFIELD(mbuf, > + rte_security_dynfield_offset, > + RTE_SECURITY_DYNFIELD_TYPE *); > +} > -- > 2.28.0