From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8BDFA04EF; Mon, 2 Dec 2019 20:13:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 879008F96; Mon, 2 Dec 2019 20:13:18 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 428A95681 for ; Mon, 2 Dec 2019 20:13:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 11:13:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,270,1571727600"; d="scan'208";a="208192977" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 02 Dec 2019 11:13:15 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Dec 2019 11:13:15 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Dec 2019 11:13:14 -0800 Received: from NAM05-CO1-obe.outbound.protection.outlook.com (104.47.48.55) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 2 Dec 2019 11:13:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUwmodNUPaZVQ7dyiKekdstQQrVcY+QBbA5iDpnjBu2riufumxrrRAMMNze/a1VroHQ2Zti4yoFXbjM9zhrwYQgBFV0S/eq0KbQOcwkyILpDiS6z2piEECAWyp7bsFRnJNNHOnI9d+7IqulbIzYrTrvde05biyV+0bxdcozZCQenxFGXA3hdjTxpsjuMx3lAIYtPyl4w4HyS0RWjgoKwdurJvpJqbzuQCYWn0djrNvGTFzJiF/tOF2czum7E9AejcN5V5QVoXKHFHl4qRw7n7Za+dL4Kft9o5allxjVtHtUsB9grnhHfRg0us/DdZBFVhvlbXz5/sKWvnvb3HSwCDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEB7F4Kxe+1Zo1rf9+XiRRSRSV18BBjEwekE6DWWKE4=; b=m3C87nO1H9jCCnUaeK9uB9vd0Du0vYaRi7Mh5l7J+nvoQoEUm0vtiCGvCz9B4QcKUantNOmW45RaiZkT04uCjf9yh/XeHXb7geEj0K7rbeq6vak5BXGDNxh1kmT+XWWXDwvpwYK7cAKMCjzeuDb6rSIcUHWSyAFnlD/CruXViQMyI/afbVxbXhAoWMa6In89GdhQIA+3BuVHiJ29sRa0maebP6uP7ZRXLe5bwUV+n2N8gsQkbaVIrvcKpnMg355bHnGUFi80DWOPXaCEY/+EsL0E1AOpaXteOI7ySV8J9PYih5pnznG9E2TAvBgSUb2my1g6im+s7sCSJpYQpMrr1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEB7F4Kxe+1Zo1rf9+XiRRSRSV18BBjEwekE6DWWKE4=; b=l3ADCsOpABy2pvNiQr4SxXKRybk3Mr1VclmjUSDG3JTS3VEIusrkQ35MVT2BoIHCCvHyFAaHdUY0Me/TqeRPvDzw7oXOhlUBTBYXKIGh6W/hq/kmmlys7gtG389avnNJcO+oSmSdzeVqpx061xgTycmAzJRJOOjoSHZIGdaCpgc= Received: from BN8PR11MB3828.namprd11.prod.outlook.com (20.178.220.87) by BN8PR11MB3649.namprd11.prod.outlook.com (20.178.219.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.20; Mon, 2 Dec 2019 19:13:13 +0000 Received: from BN8PR11MB3828.namprd11.prod.outlook.com ([fe80::703d:649c:b713:8011]) by BN8PR11MB3828.namprd11.prod.outlook.com ([fe80::703d:649c:b713:8011%7]) with mapi id 15.20.2495.014; Mon, 2 Dec 2019 19:13:13 +0000 From: "Stillwell Jr, Paul M" To: "Ye, Xiaolong" , "Xing, Beilei" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Ye, Xiaolong" , "Rusinski, Mateusz" Thread-Topic: [dpdk-dev] [PATCH 52/69] net/i40e/base: exposing missing LED functionality Thread-Index: AQHVqOd7YZp2DOvAREG68mV/WRk+PaenNwhw Date: Mon, 2 Dec 2019 19:13:13 +0000 Message-ID: References: <20191202074935.97629-1-xiaolong.ye@intel.com> <20191202074935.97629-53-xiaolong.ye@intel.com> In-Reply-To: <20191202074935.97629-53-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTcyZjlkMDgtYjBkNC00Y2Q2LWFkNjEtN2I2OTBjOWMyOWJmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieDI4Vm1QZWI3Qkl6dUJCQTFoVWt6bEFXZUo4RTJRVzJGQWxTTFRzZ1BrMHBJcnFQWVJ5RDVyODBVeFUxTGxJOCJ9 dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [134.134.136.208] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 370588fb-ca7c-4fcc-3453-08d7775bad6c x-ms-traffictypediagnostic: BN8PR11MB3649: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:346; x-forefront-prvs: 0239D46DB6 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(39860400002)(346002)(396003)(376002)(136003)(189003)(199004)(13464003)(6116002)(8936002)(54906003)(6636002)(86362001)(66066001)(66446008)(316002)(99286004)(64756008)(110136005)(33656002)(52536014)(66556008)(66476007)(5660300002)(478600001)(76176011)(14444005)(2906002)(26005)(81156014)(74316002)(3846002)(446003)(11346002)(25786009)(102836004)(7736002)(7696005)(14454004)(6436002)(256004)(55016002)(9686003)(4326008)(53546011)(107886003)(76116006)(6506007)(305945005)(81166006)(6246003)(229853002)(186003)(66946007)(71200400001)(71190400001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN8PR11MB3649; H:BN8PR11MB3828.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1iAo8V4Z6ofy3WpA7vufWGJUOpvHWGgFtBy6aAMuxZgUNxuyn9XfJB1ZxjwVFO8BrxiBN0iXnbRSDelgaiTZ8y0yT3zneMMQ85j45t2/phlDI8xrA+sqsVnWLdxphe4KWV9eRfDaGl8QeFFlsDxJOcR/Jwz5/eljXtAn80in1+iVbOsbTz2JxNit7aL3BhfuawzVUXf09tGLubt1grvPjrJtPr1tE78gpCIFHzHfEsIQjO29BLh/U6Q8SI/M6X3P2CfTXUu3v39as0/+DgBt3cr+Sf2d3F75Zz3pHp88Hs3w48pgjEmEo3EryKZLmxdHb0TLA9A/iepA0ipEBlmDXUlQShNOsdJ7RPBnJgKkAaHsXbMgYcLr32uwvm2kI72uFkhrtQWKnWl5GG6I0prxKdIR030R3CMds4scPKifbBTD/+ufveNxnePI7RDrzLgd Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 370588fb-ca7c-4fcc-3453-08d7775bad6c X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2019 19:13:13.0963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Srd492tgvhf7Wl/3Kt03pRN4hyFRT3f/EBNlQYpkHbh2odITnl4S8cQs6v1RY1iG4/tnIrFw9R36B5NnmI0KSCrSSq0q/6x/I1eaoPt6juQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3649 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 52/69] net/i40e/base: exposing missing LED functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" NACK, this code is not properly stripped and should not be released externa= lly. Additionally, the commit message shouldn't mention anything about wrap= ping the code so if you want to include this you will need to re-write the = commit message to make sense without mentioning wrapping the code. Paul > -----Original Message----- > From: dev On Behalf Of Xiaolong Ye > Sent: Sunday, December 1, 2019 11:49 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; Rusinski, Mateusz > > Subject: [dpdk-dev] [PATCH 52/69] net/i40e/base: exposing missing LED > functionality >=20 > The previous code had the LED code wrapped such that, it was static to th= e > file and not usable outside of it. It is now available. >=20 > Signed-off-by: Rusinski > Reviewed-by: Kirsher Jeffrey T > Reviewed-by: Michael Alice > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/base/i40e_common.c | 10 ++++++++++ > drivers/net/i40e/base/i40e_prototype.h | 7 ++++++- > 2 files changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/base/i40e_common.c > b/drivers/net/i40e/base/i40e_common.c > index c655f3359..aebbd6004 100644 > --- a/drivers/net/i40e/base/i40e_common.c > +++ b/drivers/net/i40e/base/i40e_common.c > @@ -6950,8 +6950,13 @@ enum i40e_status_code > i40e_blink_phy_link_led(struct i40e_hw *hw, > * @led_addr: LED register address > * @reg_val: read register value > **/ > +#ifndef LINUX_SUPPORT > +enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 > led_addr, > + u32 *reg_val) > +#else > static enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 > led_addr, > u32 *reg_val) > +#endif > { > enum i40e_status_code status; > u8 phy_addr =3D 0; > @@ -6979,8 +6984,13 @@ static enum i40e_status_code > i40e_led_get_reg(struct i40e_hw *hw, u16 led_addr, > * @led_addr: LED register address > * @reg_val: register value to write > **/ > +#ifndef LINUX_SUPPORT > +enum i40e_status_code i40e_led_set_reg(struct i40e_hw *hw, u16 > led_addr, > + u32 reg_val) > +#else > static enum i40e_status_code i40e_led_set_reg(struct i40e_hw *hw, u16 > led_addr, > u32 reg_val) > +#endif > { > enum i40e_status_code status; > u8 phy_addr =3D 0; > diff --git a/drivers/net/i40e/base/i40e_prototype.h > b/drivers/net/i40e/base/i40e_prototype.h > index 65a5d3658..1b132b9b1 100644 > --- a/drivers/net/i40e/base/i40e_prototype.h > +++ b/drivers/net/i40e/base/i40e_prototype.h > @@ -73,7 +73,12 @@ enum i40e_status_code i40e_led_get_phy(struct > i40e_hw *hw, u16 *led_addr, > u16 *val); > enum i40e_status_code i40e_blink_phy_link_led(struct i40e_hw *hw, > u32 time, u32 interval); > - > +#ifndef LINUX_SUPPORT > +enum i40e_status_code i40e_led_get_reg(struct i40e_hw *hw, u16 > led_addr, > + u32 *reg_val); > +enum i40e_status_code i40e_led_set_reg(struct i40e_hw *hw, u16 > led_addr, > + u32 reg_val); > +#endif > enum i40e_status_code i40e_get_phy_lpi_status(struct i40e_hw *hw, > struct i40e_hw_port_stats *stats); > enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw, u32 > *tx_counter, > -- > 2.17.1