From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CB7BA00C5; Wed, 2 Feb 2022 12:04:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6299240DF4; Wed, 2 Feb 2022 12:04:20 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2065.outbound.protection.outlook.com [40.107.243.65]) by mails.dpdk.org (Postfix) with ESMTP id F024F40688 for ; Wed, 2 Feb 2022 12:04:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IP1kb4Pzn4Yj4PVWA4kaMUfc05WfBlIHnI4fseCeQ3yTXTPRhrbxBcYsI9FyyIK8CAUqY6OHcHrGQORNgpBF6hIeEw7JL+BW9hJX/NnHgjo9Lp2tYXe/7vVUnO2wXSOwAzfiBpEvldZdSPmP3l9ldv0v4DguCBUdZ7XDch+jdf+Gml9o9uTS7Q6ozHwKViUhV0a5gsWBSjyTeFccdDFmCdd6nb/6ZYo7pnDpUjvdlwGkoCQO8cCo07GfdCniWSPGh+nPZ5WG8yymKO7VTeIsivnsGNX5j0J7RtQjmsVjJ1n3cXHzkb7/i9SXjLqM7I/Bb4AV+ahG/OPh1xuIuYlY/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pgwnQ86ZoXZgAeN7XOVgSeE/6TnqhnLyFPkSYHtgDiM=; b=mpC4drsFajq3m9PJ3hzGl4va6+Tn3VY3+3aSxK+XAM3iB91nHVdPNo0teKrsyNx9bKB2amUbouqASeytT5z0jm6cu5wD0IgpRTFdN6Hgs/LrRWnXAUafFyodbx1Hz1vOS59PxqinxvSlS6pkOddedcv/oHXSaL3AzX7OndCDXNo++4MzOooinvGTymzItVTXKwWzkp28B67yn4Euvzcmg5aJ3hblDX0csGF3fQm7Bvidla67Z/RPW2RjGlDXyMrQkO5aDL0aVRpzjXXh1Q43H/xVljo2YFiUotOTyJ7yy2FoKAx2yJgYeGrmzCj4vhcSfaaIbbDMK6Oz7wmay0AGYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pgwnQ86ZoXZgAeN7XOVgSeE/6TnqhnLyFPkSYHtgDiM=; b=tIfy0Q/x0pzQYjMcR3JXm0GgrXKbNDZKUT+sBlvxevVS+eWdY3mk1Q0iTR+aGgUCU9HL2lci/OBKiAUg/oKJUzZ/xw/RmY1Ygp+RUe8EnEu0YydF4o4gF5N0KonFf/sqWLZi/m8GOpQ89e4xC/yGittCXzD+h/EBcQKDRHfXz019c6SFKQHOiMq6n7HvFTGxoQFZm2W6LSGxMMszU8EOHQtFqOm59TuK73jPwoO7zUn+RfzCe9OSJdO3vaPEwLdUi6FQFx4Qym7257372kpco7Tin4PvmT3XJ9YF07f0pLmeab+u9Tuh0ojvAd/Vin7+v+Fo01juTqtb/7STKsj7gA== Received: from BN8PR12MB2899.namprd12.prod.outlook.com (2603:10b6:408:6b::20) by MN2PR12MB4551.namprd12.prod.outlook.com (2603:10b6:208:263::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Wed, 2 Feb 2022 11:04:17 +0000 Received: from BN8PR12MB2899.namprd12.prod.outlook.com ([fe80::40a9:d53f:32c4:d726]) by BN8PR12MB2899.namprd12.prod.outlook.com ([fe80::40a9:d53f:32c4:d726%5]) with mapi id 15.20.4951.012; Wed, 2 Feb 2022 11:04:17 +0000 From: Dmitry Kozlyuk To: "dev@dpdk.org" Subject: rte_devargs_parse Thread-Topic: rte_devargs_parse Thread-Index: AdgYIsva2Ku7Ec9gRTekfi6EUxCE9Q== Date: Wed, 2 Feb 2022 11:04:17 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0a4b4110-1729-4b10-2b85-08d9e63bc19f x-ms-traffictypediagnostic: MN2PR12MB4551:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 79u/wvRU2soznYxAqZFlual3jyUO8Es9e+bnPAqJDM17puy35TZDEnzXsTVeGsrMON9X6RM6EGp6M6GMA+iq2MXhuBI7zClXa7uY8UziYK+WAWkr7RJUrX1TM231DBLNUKPZ7Fvp+xL6f2KGb2INe7JBikOM+p+hWXhOysYXAkbNpXuo8LSkZ2cVDl9oUpr2/iOU2GvxdXbVNhpw9SbSbkxzM0Y9xltbScI9gsIho+aawZoZRTTBc9GtoF0vsx8EBffMzY3WlD2liXfBZwkxRCBPzFxZud6DNykCqr/GTPx4k/xe2ojMQrtmh95qMbY2jE0GMZwJGKVBV+Z0NtQlh/BmjpLZcpXdZQ0+7MEpbFFP9TTM2bAjmaSaXsfmrj8ueSA/44QVlAZXXgiK51tHh+VPP+UMKHEKXvL0x2zDVcuD8Jn0BJMG1T4F+xNAYHbkPcV6hRAH8Q/sJjCdHz0zQR23vLJamvLg6TUChqU/Nl0uAEuQajadABuIi1TNTwj9aKQGagA6VQ5DELIHPckHQj3OHjY+//RhuwPgL/xBDkqubRdsgcNDPvkhEaTAIzf3B40x5xjBeUoeNGiLr3w848Q6T3zSakJRZ97Py2qyDWsxSgFRHlPB9ArYDVtnG4DbO8XtqZk1YXMYIS48zIFV1pWSqSdWxjO489JLxbtgdusduErahyAWMLfzlQzbnPqBZ2PEp48QOL5315sAnjx+CQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN8PR12MB2899.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(71200400001)(186003)(52536014)(508600001)(38100700002)(26005)(7696005)(5660300002)(9686003)(38070700005)(316002)(83380400001)(7116003)(86362001)(76116006)(66446008)(66556008)(6506007)(4744005)(6916009)(8936002)(8676002)(122000001)(66946007)(2906002)(64756008)(66476007)(55016003)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I2zRrQMCNR+z6yOEVup/rVIh4AoN3onnT5+oFGPlr3GUBsqjoYzAgty4KQzb?= =?us-ascii?Q?+CCvRMydc2wKBi5x52mR0AGZ5qUhOu13jiNkUhGKLpdn3JjsaGvlJ+JSsgu2?= =?us-ascii?Q?RbO2u3L4wzUPskRyfmLYbW4TE3l9gMUz4dNy/RrdPl/ZAvygUv9AomfBob/d?= =?us-ascii?Q?2Dg/5U+QAWmIRHVTgtqYxXIXidoll6EX4pzaO/TB1w7BdgsVlATUr6qBXmy4?= =?us-ascii?Q?DvYlS2J437SJrBGoY+aKtt6BCCpGIioEQ957IGPr2sJYDWHAWEPo1XbedKiX?= =?us-ascii?Q?zirjcSm5xeXr3t2MdTucydqC/iiu3CQJAAiCHzyLKlJMLL6jpnxS3ml/uQcZ?= =?us-ascii?Q?BkFTDji9TQtggYylMR/lnnwKUzGEEw565JhYHPI+NMkDZzBDkFf9RHxxR6YX?= =?us-ascii?Q?qoSUe/AawFIBmzy7m6jyN/S3khcQu+BCxzgMD7suAwymEUqWSdm10mtjqi5n?= =?us-ascii?Q?HGvrZgH7alq1pE1RghWw+4a2n6aVF7Ww2DZfiLQlUiuv11z3LXqU6xchogbA?= =?us-ascii?Q?f1DuSnrofQWu6P+/SyuGPl9y8xkGcq5lJUnlMcgw2DSbXVD6Ux6/m6bnN7EW?= =?us-ascii?Q?nAc+TlrEAg2wShJAJ9rsV5u6Zp3F6Ec1Ba6Wyfty0gF+OL5JClFxnfQOdo5q?= =?us-ascii?Q?nAiq0GLPysPd8zafWkZAOe9knEgSTpLBj1gj8yI3JBouyrpr9t0kRhCpudyd?= =?us-ascii?Q?/AXfXmlKwXUkzgMOlkuI9mVQZ/PZdw/IcY83RfuH3Lnd4oQIXPVhm95cFM4F?= =?us-ascii?Q?n4XYWqXHMdJWXpA1PtxOVhcUOb71BN/we+HAy7bvGPDWxY5+hKaVaZg7mi3t?= =?us-ascii?Q?Y9OjReulfywTskAQwwYwPmc6Y4lqJDLeBSZKQ0rgK0yn+iMelpgRGa6NWjBz?= =?us-ascii?Q?8D6xrlYRH6XNXgG1JWNVWpk8StXv0K4G85+VZAV1Wch9vhrpzDj74M1i7+mP?= =?us-ascii?Q?seHfkhR3JU7F/aLlquib/o47GuwArjHHK3lvK3R8gWVxIFWMixaHcRt+o6WB?= =?us-ascii?Q?QTuDVA1djAaR6cr1xa5l85x2IBeU70N1+BEkfkuvsn6KOwpQX6cvomKeosPO?= =?us-ascii?Q?7msy6LMyh4FoaEbH3gWVkNTt+LlXMUyroBGcZkNphJzM4/em+lCGyaZQQfoX?= =?us-ascii?Q?zojVcb+NWOxTuYic7VsD65I81R6fJIikGVbwQosXaubCROiskNSSbIZDsSwo?= =?us-ascii?Q?iSpq9xu1gBb5F4dYV5k3iFwD3NN9Fd7DB33bbQjtAs/OzWdUui7gZv2/iGun?= =?us-ascii?Q?5edo+Dgj3+CIjlBKC20R16O1fVvvoVy6ODAkTMb9pajHweqWiFvCTSLE/2JL?= =?us-ascii?Q?MlQ4vsgCHbp0h38vR53wmmmE9Wgv9ULDrnEemyCrR0ZxugXG6+fZml7U0/CV?= =?us-ascii?Q?O9LBa3CIydHV9+/dNm+xopUjkbhgws3znmwRBycaqYpK1DzFuc4Nxqx6WPoq?= =?us-ascii?Q?VHUG7klRUOTAUIXDy8vRx5LPUieLVlHDjWWOACzx+Hg4g2/Hxhj+xmV1tEN+?= =?us-ascii?Q?ACIMS2yzMssTKGpJPwQWNv3bb/DG30fObYs4BlSz0fGVcvzIuO/0xdFZL184?= =?us-ascii?Q?NM9RJGSbvdLZgY8wx18x2XYWqJ9uJ6lmCQOoPtA6yajhbs3qY6VKvaN0D+ho?= =?us-ascii?Q?3g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2899.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a4b4110-1729-4b10-2b85-08d9e63bc19f X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2022 11:04:17.4122 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SGoqr7zwX3D9G5UXLbMdzSB9LhgbbqGHhdZyqeW1DDfMGDSnfVq32R3kZ2Bt72zFl41yM6rWaLYx+Gn1OidY0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4551 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, /** * Parse a device string. * * Verify that a bus is capable of handling the device passed * in argument. Store which bus will handle the device, its name * and the eventual device parameters. * * [SNIP] * * @param da * The devargs structure holding the device information. * * [SNIP] */ int rte_devargs_parse(struct rte_devargs *da, const char *dev); It is unclear from this description that "da" is not only filled, but also used as an input, and if it is not initialized or at least zero-filled, the function will crash. "Holding the device information" is not helpful, because it doesn't say it's a pre- or post-condition, or what must be filled on input (if everything, why parse at all?). In test_devargs.c, test_valid_devargs_cases() zero-fills "da", but test_invalid_devargs() does not, which is probably wrong. Is the function intended to work this way? What use case is covered by calling it with initialized "da"?