DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rakesh Kudurumalla <rkudurumalla@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>
Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails
Date: Tue, 24 May 2022 05:39:10 +0000	[thread overview]
Message-ID: <BN8PR18MB2482303D51C7EA940F358E52CFD79@BN8PR18MB2482.namprd18.prod.outlook.com> (raw)
In-Reply-To: <BN8PR18MB248249A85C30BEB56B7D203CCFC69@BN8PR18MB2482.namprd18.prod.outlook.com>

ping

> -----Original Message-----
> From: Rakesh Kudurumalla
> Sent: Monday, May 9, 2022 3:32 PM
> To: 'Thomas Monjalon' <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Cc: 'stable@dpdk.org' <stable@dpdk.org>; 'dev@dpdk.org'
> <dev@dpdk.org>; 'david.marchand@redhat.com'
> <david.marchand@redhat.com>; 'ferruh.yigit@intel.com'
> <ferruh.yigit@intel.com>; 'andrew.rybchenko@oktetlabs.ru'
> <andrew.rybchenko@oktetlabs.ru>; 'ajit.khaparde@broadcom.com'
> <ajit.khaparde@broadcom.com>
> Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are
> full and Tx fails
> 
> Hi Thomas Monjalon,
> 
> Same behavior is observed in cnxk driver as well.
> Can we please get this patch merged ?
> 
> Regards,
> Rakesh
> > -----Original Message-----
> > From: Rakesh Kudurumalla
> > Sent: Monday, February 14, 2022 10:27 AM
> > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob Kollanukkaran
> > <jerinj@marvell.com>
> > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > ajit.khaparde@broadcom.com
> > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > queues are full and Tx fails
> >
> >
> >
> > > -----Original Message-----
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > Sent: Tuesday, February 1, 2022 1:15 PM
> > > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Rakesh
> > > Kudurumalla <rkudurumalla@marvell.com>
> > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > ajit.khaparde@broadcom.com
> > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if
> > > queues are full and Tx fails
> > >
> > > octeontx2 driver is removed
> > > Can we close this patch?
> > Same behavior is observed with cnxk driver, so we need  this patch
> > >
> > >
> > > 01/02/2022 07:30, Rakesh Kudurumalla:
> > > > ping
> > > >
> > > > > -----Original Message-----
> > > > > From: Rakesh Kudurumalla
> > > > > Sent: Monday, January 10, 2022 2:35 PM
> > > > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> > > Kollanukkaran
> > > > > <jerinj@marvell.com>
> > > > > Cc: stable@dpdk.org; dev@dpdk.org; david.marchand@redhat.com;
> > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > ajit.khaparde@broadcom.com
> > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang
> > > > > if queues are full and Tx fails
> > > > >
> > > > > ping
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Rakesh Kudurumalla
> > > > > > Sent: Monday, December 13, 2021 12:10 PM
> > > > > > To: Thomas Monjalon <thomas@monjalon.net>; Jerin Jacob
> > > > > > Kollanukkaran <jerinj@marvell.com>
> > > > > > Cc: stable@dpdk.org; dev@dpdk.org;
> david.marchand@redhat.com;
> > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > > ajit.khaparde@broadcom.com
> > > > > > Subject: RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid
> > > > > > hang if queues are full and Tx fails
> > > > > >
> > > > > >
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > Sent: Monday, November 29, 2021 2:44 PM
> > > > > > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com>; Jerin
> > > > > > > Jacob Kollanukkaran <jerinj@marvell.com>
> > > > > > > Cc: stable@dpdk.org; dev@dpdk.org;
> > david.marchand@redhat.com;
> > > > > > > ferruh.yigit@intel.com; andrew.rybchenko@oktetlabs.ru;
> > > > > > > ajit.khaparde@broadcom.com
> > > > > > > Subject: Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid
> > > > > > > hang if queues are full and Tx fails
> > > > > > >
> > > > > > > 29/11/2021 09:52, Rakesh Kudurumalla:
> > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > 22/11/2021 08:59, Rakesh Kudurumalla:
> > > > > > > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > > > > > > > 20/07/2021 18:50, Rakesh Kudurumalla:
> > > > > > > > > > > > Current pmd_perf_autotest() in continuous mode
> > > > > > > > > > > > tries to enqueue MAX_TRAFFIC_BURST completely
> > > > > > > > > > > > before starting the
> > > > > test.
> > > > > > > > > > > > Some drivers cannot accept complete
> > > > > > > > > > > > MAX_TRAFFIC_BURST even though
> > > > > > > > > rx+tx
> > > > > > > > > > > > desc
> > > > > > > > > > > count
> > > > > > > > > > > > can fit it.
> > > > > > > > > > >
> > > > > > > > > > > Which driver is failing to do so?
> > > > > > > > > > > Why it cannot enqueue 32 packets?
> > > > > > > > > >
> > > > > > > > > > Octeontx2 driver is failing to enqueue because
> > > > > > > > > > hardware buffers are full
> > > > > > > > > before test.
> > > > > > >
> > > > > > > Aren't you stopping the support of octeontx2?
> > > > > > > Why do you care now?
> > > > > > >  yes we are not supporting octeontx2,but this  issue is
> > > > > > > observed in cnxk driver ,current patch fixes the same
> > > > > > > > >
> > > > > > > > > Why hardware buffers are full?
> > > > > > > > Hardware buffers are full because number of number of
> > > > > > > > descriptors in continuous mode Is less than
> > > > > > > > MAX_TRAFFIC_BURST, so if enque fails , there is no way
> > > > > > > > hardware
> > can drop the Packets .
> > > > > > > > pmd_per_autotest application evaluates performance after
> > > > > > > > enqueueing
> > > > > packets Initially.
> > > > > > > > >
> > > > > > > > > > pmd_perf_autotest() in continuous mode tries to
> > > > > > > > > > enqueue MAX_TRAFFIC_BURST (2048) before starting the
> test.
> > > > > > > > > >
> > > > > > > > > > > > This patch changes behaviour to stop enqueuing
> > > > > > > > > > > > after few
> > > > > retries.
> > > > > > > > > > >
> > > > > > > > > > > If there is a real limitation, there will be issues
> > > > > > > > > > > in more places than this test program.
> > > > > > > > > > > I feel it should be addressed either in the driver
> > > > > > > > > > > or at ethdev
> > > level.
> > > > > > > > > > >
> > > > > > > > > > > [...]
> > > > > > > > > > > > @@ -480,10 +483,19 @@ main_loop(__rte_unused void
> > > *args)
> > > > > > > > > > > >  			nb_tx = RTE_MIN(MAX_PKT_BURST,
> > > num);
> > > > > > > > > > > >  			nb_tx = rte_eth_tx_burst(portid, 0,
> > > > > > > > > > > >
> > > 	&tx_burst[idx],
> > > > > > > nb_tx);
> > > > > > > > > > > > +			if (nb_tx == 0)
> > > > > > > > > > > > +				retry_cnt++;
> > > > > > > > > > > >  			num -= nb_tx;
> > > > > > > > > > > >  			idx += nb_tx;
> > > > > > > > > > > > +			if (retry_cnt == MAX_RETRY_COUNT)
> > > {
> > > > > > > > > > > > +				retry_cnt = 0;
> > > > > > > > > > > > +				break;
> > > > > > > > > > > > +			}
> > > > > > >
> > > > > > >
> > > >
> > > >
> > >
> > >
> > >
> > >


  reply	other threads:[~2022-05-24  5:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210720124713.603674-1-rkudurumalla@marvell.com>
2021-07-20 16:50 ` [dpdk-dev] " Rakesh Kudurumalla
2021-10-19 10:19   ` Rakesh Kudurumalla
2021-10-29  7:18     ` Rakesh Kudurumalla
2021-11-12 11:32   ` [dpdk-stable] " Thomas Monjalon
2021-11-22  7:59     ` [EXT] " Rakesh Kudurumalla
2021-11-22  8:58       ` Thomas Monjalon
2021-11-29  8:52         ` Rakesh Kudurumalla
2021-11-29  9:13           ` Thomas Monjalon
2021-12-13  6:40             ` Rakesh Kudurumalla
2022-01-10  9:04               ` Rakesh Kudurumalla
2022-02-01  6:30                 ` Rakesh Kudurumalla
2022-02-01  7:44                   ` Thomas Monjalon
2022-02-14  4:56                     ` Rakesh Kudurumalla
2022-05-09 10:01                       ` Rakesh Kudurumalla
2022-05-24  5:39                         ` Rakesh Kudurumalla [this message]
2022-05-25  8:02                           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN8PR18MB2482303D51C7EA940F358E52CFD79@BN8PR18MB2482.namprd18.prod.outlook.com \
    --to=rkudurumalla@marvell.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).