From: Sunil Kumar Kori <skori@marvell.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM offload flags
Date: Tue, 16 Jul 2019 06:28:17 +0000 [thread overview]
Message-ID: <BN8PR18MB2691AE38438CED0B35EA2E14B4CE0@BN8PR18MB2691.namprd18.prod.outlook.com> (raw)
In-Reply-To: <BYAPR18MB2424CC6814478D785D457B90C8CE0@BYAPR18MB2424.namprd18.prod.outlook.com>
Regards
Sunil Kumar Kori
>-----Original Message-----
>From: Jerin Jacob Kollanukkaran
>Sent: Tuesday, July 16, 2019 11:12 AM
>To: Thomas Monjalon <thomas@monjalon.net>; Sunil Kumar Kori
><skori@marvell.com>
>Cc: dev@dpdk.org; Konstantin Ananyev <konstantin.ananyev@intel.com>
>Subject: RE: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove PKT_TX_IP_CKSUM
>offload flags
>
>> -----Original Message-----
>> From: Thomas Monjalon <thomas@monjalon.net>
>> Sent: Tuesday, July 16, 2019 3:35 AM
>> To: Sunil Kumar Kori <skori@marvell.com>; Jerin Jacob Kollanukkaran
>> <jerinj@marvell.com>
>> Cc: dev@dpdk.org; Konstantin Ananyev <konstantin.ananyev@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] lib/librte_ip_frag: Remove
>> PKT_TX_IP_CKSUM offload flags
>>
>> 15/07/2019 10:17, Sunil Kumar Kori:
>> > Current patch is part of following patchset
>> > http://patches.dpdk.org/patch/53475/
>> > which is missed to be merged into upstream because of accepted
>> > version of this patch does not contain this change.
>> >
>> > Accepted patchset is given below:
>> > http://patches.dpdk.org/patch/56202/
>> >
>> > Patchset is already reviewed and acked on maillist. Also
>> > corrersponding release notes are updated.
>> [..]
>> > --- a/lib/librte_ip_frag/rte_ipv4_fragmentation.c
>> > +++ b/lib/librte_ip_frag/rte_ipv4_fragmentation.c
>> > - out_pkt->ol_flags |= PKT_TX_IP_CKSUM;
>> > out_pkt->l3_len = sizeof(struct rte_ipv4_hdr);
>>
>> Jerin, what happened? A part of the patch was missing?
>
>Yes. It was my bad. On rebase to top of tree, due to rename of ipv4_hdr to
>rte_ipv4_hdr and similar, Those patches need to be manually rebased.
>
>> Is this patch really required?
>
>Yes.
>
>> If this patch is required, the commit log must be changed.
>
>Yes.
Next version is updated for this patch after modifying the commit message.
>
>>
prev parent reply other threads:[~2019-07-16 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 8:17 Sunil Kumar Kori
2019-07-15 22:05 ` Thomas Monjalon
2019-07-16 5:41 ` Jerin Jacob Kollanukkaran
2019-07-16 6:28 ` Sunil Kumar Kori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN8PR18MB2691AE38438CED0B35EA2E14B4CE0@BN8PR18MB2691.namprd18.prod.outlook.com \
--to=skori@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).