From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74B8BA0555; Wed, 19 Feb 2020 11:22:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B00674C81; Wed, 19 Feb 2020 11:22:52 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id C36B0397D for ; Wed, 19 Feb 2020 11:22:51 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01JALQdS003128; Wed, 19 Feb 2020 02:22:51 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=9kpwrEsllF0mrlvokJjnvFreYCT2rnIRu3G2Diragng=; b=D2YNmnF4teKsjlH5EzeCuqFtBb1gZvJdeahpGAERu8AMeeOpysRHzvxiTqtYiSf6I14O 3jqB9EfSzLWwdO1QpiBqNXYzsLQt4EMTybPSKVHcSIB7trPQNlVZsO6eDTmglCLG97V6 a7v6XdJBd9abixoOJbQCZwdo6+P7DDA/MQbbHhEtuUGBMMzSm3Se0LzU8nh/VM7qxouI hOzJ8eH/ugryapV9LZ4MD7WJs0eBfvc52sY96HTHhphk07o4Jrsf3w1WuY9WgAU05SvR cBq3kti24a8xg7koLKeBxDLlFWAAzlpFXSPR9upSypWEUh2KLftHHIGtfOiL/9Z+bSBl Ug== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2y8ubv1n1a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2020 02:22:51 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 Feb 2020 02:22:48 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 19 Feb 2020 02:22:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XiY2pyB9V7VCNy7ktrZbBm82Rum39pupQjsPdzsKk35AMw5rmLai/Fa0QztH/cnV6l8RWxH6eBqfeOMaid0qf3Aj+XD+ukH5sJvvy4tWRWgEbd1MF2xS774/qOf3W8ZPtJu5f5xGrWaNVj4pNsflxl+2iwuP582Bm3pY/CPlzHZwgzWKBfFB0XPRJAUWFza82Wu7aMSF32yl+mE5sQRwk1MwzWVHxVfiQSmtJIes8+FkkWApY+ezsNl0yKCGnQtsxH/vuQVbLCkvf/yFOQxIsNtIyg2VhWZEq33dKAik1hkezuWSbHbh4Apx3NDL/pbxUjJ0VISHmfBzBqubXVzapg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9kpwrEsllF0mrlvokJjnvFreYCT2rnIRu3G2Diragng=; b=gplzKZIsPYmmhimBtMY/UEGq/gyj8MolPBo0BEHpKuiGIIwA38upOfqsWOVm9nB3sET/hqtOQA0IlorJsFUOL6zZpDK/+edNTtAct6zzKIYrbZQltbqjLovBA+kwt57hxcPqN0DX9raBd/Lh2tAwMgo7F4tWT1KM2xA5x67BTdJAf3NzOxBjFJH1RIh0uC1QbAy4NgKtdUgSQdT9yvEJfxS9vrxSuPooG3yOgBg9STpj7hteq4XM8pcvC2txSL5yVGJhyXZ9mQAg85bj6Ouv/EpEbhOevPR9vSSNt1uGuhL0niN3If9UOB9gJhYx36PIARhJM4vM6oYimgn28vEJrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9kpwrEsllF0mrlvokJjnvFreYCT2rnIRu3G2Diragng=; b=WDUQ4oH/0q5gRa15qaesV4+PsdB66/EkaaN2OdmAc2lkYCThCdAkcwU+3way7AWjDlkwnspbx1KBpEAF6ibW9HoWaixYEPjXjuMFsevo5ViBkCXxCRXh4c2PZO53y7xYrZh2Uu4zQqyvCY9+t2PhGmd6bwiqvuzWasYvcRnJllc= Received: from BN8PR18MB2868.namprd18.prod.outlook.com (20.179.74.155) by BN8PR18MB2930.namprd18.prod.outlook.com (20.179.76.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Wed, 19 Feb 2020 10:22:47 +0000 Received: from BN8PR18MB2868.namprd18.prod.outlook.com ([fe80::4566:5087:ce98:8fec]) by BN8PR18MB2868.namprd18.prod.outlook.com ([fe80::4566:5087:ce98:8fec%7]) with mapi id 15.20.2729.032; Wed, 19 Feb 2020 10:22:47 +0000 From: Anoob Joseph To: Fan Zhang , Akhil Goyal CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Anoob Joseph , Marko Kovacevic , David Marchand Thread-Topic: [PATCH v2] examples/fips_validation: fix incorrect string for CT length Thread-Index: AQHV5kabrLDro1tyoEeSraSB85/FNqgiUBDg Date: Wed, 19 Feb 2020 10:22:46 +0000 Message-ID: References: <1582019075-7932-1-git-send-email-anoobj@marvell.com> <1582021872-8173-1-git-send-email-anoobj@marvell.com> In-Reply-To: <1582021872-8173-1-git-send-email-anoobj@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1022caf-8e61-4673-fc9a-08d7b525aa3c x-ms-traffictypediagnostic: BN8PR18MB2930: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0318501FAE x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(39860400002)(376002)(346002)(396003)(189003)(199004)(54906003)(4326008)(2906002)(186003)(478600001)(53546011)(33656002)(52536014)(5660300002)(55236004)(110136005)(71200400001)(6506007)(55016002)(7696005)(8676002)(81166006)(81156014)(9686003)(26005)(76116006)(86362001)(64756008)(66476007)(316002)(66946007)(8936002)(66446008)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR18MB2930; H:BN8PR18MB2868.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9bAAtgF29AHWna/cE+4+/9cZ80ZshXzc+LDdqZk23CKoY98bXBzMWxAPn8rYd3IQZqnWJ83clqkx3mBu4yHwm0qD7MiZGB3QHZPHmq8+okSnN6kBVQFR52ieIsdqmLEhhyQbPGn0h2xtCbAM0cyQo0sf2BUo+K3iOn2wm3JW6Oxz3Jadf86hI/acBPGWxrHGai3k5Y5s6NCk0WLzMTVAvNw4JiuLGqyopiI5Oj506fvqMoyxANFI3IbLJtYSB+AaCT3dq+sDgw1S6bB5DSBEgW7usc/uo8xab9M/+TvZzFLhiqa//IuAn702iQxo30dHWUv0wE0j4J6dn5W2EpsD8CrU7JwVICoL3ZSGLYeYzmx6psbFs2Jan6ulHsvNUYA2s7pHNJEtxs0kkYfNeeTUc5VYHcPguMl5jgJcJrXKVWEbptmUEflQIogvWBNGMuwB x-ms-exchange-antispam-messagedata: hFHZ692vpIl7q/ArzSg18ahCNEfvXQZ2FIA9msNiFLRfv2/KApdszGy8ZmfBYUnATtisO26os8oiCI+cIvRNfoo+78NVtJcqJk+ceI9/d0+d34XGYIaQlbTO+ZPdqfuCkZQZzTFNP7Y11s1dzO3EwQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d1022caf-8e61-4673-fc9a-08d7b525aa3c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2020 10:22:47.0055 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GtkD5K/dAhJFxitqN7hZv3tN2ut8UpHo1AZYJq1IouHeUpbkp5cU2s+A6AzJil/jThhTuGm/IofRIwQFelSaww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2930 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-02-19_02:2020-02-19, 2020-02-19 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2] examples/fips_validation: fix incorrect string for CT length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Fan, Akhil, Can you review this patch? Without this change, the app would not work for = AES-GCM decrypt. Thanks, Anoob > -----Original Message----- > From: Anoob Joseph > Sent: Tuesday, February 18, 2020 4:01 PM > To: Marko Kovacevic ; Akhil Goyal > ; David Marchand > Cc: Anoob Joseph ; Fan Zhang > ; Narayana Prasad Raju Athreya > ; dev@dpdk.org > Subject: [PATCH v2] examples/fips_validation: fix incorrect string for CT > length >=20 > The NIST test vectors use the string 'PTlen' to denote text lengths in ca= se of > encrypt & decrypt operations. So the same string need to be used while > parsing PT and CT. >=20 > Fixes: 2adb3b4e7e54 ("examples/fips_validation: fix AES-GCM cipher length > parsing") >=20 > Signed-off-by: Anoob Joseph > --- >=20 > v2: > * Fixed incorrect fixes tag >=20 > examples/fips_validation/fips_validation_gcm.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/examples/fips_validation/fips_validation_gcm.c > b/examples/fips_validation/fips_validation_gcm.c > index bc2d37d..47576e9 100644 > --- a/examples/fips_validation/fips_validation_gcm.c > +++ b/examples/fips_validation/fips_validation_gcm.c > @@ -19,7 +19,6 @@ > #define PTLEN_STR "PTlen =3D " > #define AADLEN_STR "AADlen =3D " > #define TAGLEN_STR "Taglen =3D " > -#define CTLEN_STR "CTlen =3D " >=20 > #define COUNT_STR "Count =3D " > #define KEY_STR "Key =3D " > @@ -47,7 +46,10 @@ struct fips_test_callback gcm_interim_vectors[] =3D { > {KEYLEN_STR, parser_read_uint32_bit_val, &vec.aead.key}, > {IVLEN_STR, parser_read_uint32_bit_val, &vec.iv}, > {PTLEN_STR, parser_read_uint32_bit_val, &vec.pt}, > - {CTLEN_STR, parser_read_uint32_bit_val, &vec.ct}, > + {PTLEN_STR, parser_read_uint32_bit_val, &vec.ct}, > + /**< The NIST test vectors use 'PTlen' to denote input text > + * length in case of decrypt & encrypt operations. > + */ > {AADLEN_STR, parser_read_uint32_bit_val, &vec.aead.aad}, > {TAGLEN_STR, parser_read_uint32_bit_val, > &vec.aead.digest}, > -- > 2.7.4