From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A579A0C4A; Wed, 14 Jul 2021 05:40:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 174BF40140; Wed, 14 Jul 2021 05:40:28 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id E30B24003E; Wed, 14 Jul 2021 05:40:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="210258019" X-IronPort-AV: E=Sophos;i="5.84,238,1620716400"; d="scan'208";a="210258019" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2021 20:40:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,238,1620716400"; d="scan'208";a="505068914" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 13 Jul 2021 20:40:24 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 20:40:23 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 13 Jul 2021 20:40:23 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 13 Jul 2021 20:40:23 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 13 Jul 2021 20:40:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHQS4DRRqrYfjVTLaayoBnZ5SvcsE6KQHCnw7ACVqEQSJQUVltyVbncujpIXUuiM+CnxMEhsjzkfPJH1ZAiVRip2MQWAnaONRgRLjM469OhhQFB3ErorE4EBbPUcFhd/CGZD/G5TzFiORIg4HJxagYuRzNGC5ssL8QoJyg0xohTpADiTQioRe4GFakif3Bv/7yYzo4sgzKVflKSd7kXHTLkq4P0bfVKNstajOgoYIBG7M9rD6N7rPwCvianF5KiTyRerEZVDGQRe1SXbwZYEuCkQ/z1OCGGWlU9U3b4E0l3m+Mh9KEEJbshh/k91v/ohNb/DQHcgC54KU0o/Fbr8vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FblPqkPcMCbF+lGQI35dQ1yB7qPN37v1d4RNBd+ehb0=; b=RAPBhv3HpIypUcNoiNXxlmly4HmxseWktvxqNmaYp3gZQ0nXnTuqNFk9TGV+zKo9hZDHpqa5Z1OXpkLpoXxQb/lgoZ2d55rzToA2NJ28unQTU0hzOYhQSjApiZeXHBwG0bYNW55Cd9ytFsQSCh0DW//KnH38sWUHq9/zD75EHEYi4CW9gJ4sMEdY5tl4UDzgeRG0FSonvD1zVcFdCrSX5zx2yHIg7+BcsIhHrQzKjfiMNVZeDHX5YUGYHcEQGjsEIuwubvZFaY3hFhGIKQJPprSDFfeTiXwAtHRlVLBbJ1Olc8LBmWJwpK9li3HYn08vn4H0GyZIPWRF/Re3Y4+kAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FblPqkPcMCbF+lGQI35dQ1yB7qPN37v1d4RNBd+ehb0=; b=Yb0HORDV48t/iUe2F6vNI3hcZGvqkM9XL7eqBt00BN1zMxJCnVpJyn+9l3FBhPr3LKiSv7xqsDLbNppoEW73qM5wa46d1Dl9XQuZqZPxZCiGFmbrMU/1PfUaZX7Cr4s/iCzYR55Gi/E04l+EITa83RC182UWeh3GCvuY2DsPQPE= Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by BN6PR11MB3858.namprd11.prod.outlook.com (2603:10b6:405:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Wed, 14 Jul 2021 03:40:19 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::79a3:c273:504e:ace2%7]) with mapi id 15.20.4308.027; Wed, 14 Jul 2021 03:40:19 +0000 From: "Zhang, Tianfei" To: "Hussin, Mohamad Noor Alim" , "Xu, Rosen" CC: "dev@dpdk.org" , "Huang, Wei" , "stable@dpdk.org" Thread-Topic: [PATCH v2] ifpga/base/meson: fix looking for librt Thread-Index: AQHXbZIJFrY6LAwi+k+DwrQdWAKDl6ssUm1QgAHCSRCAANhcAIAS+l+g Date: Wed, 14 Jul 2021 03:40:19 +0000 Message-ID: References: <20210630092613.70647-1-mohamad.noor.alim.hussin@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 593032e0-ce9f-4c4f-872c-08d946791a69 x-ms-traffictypediagnostic: BN6PR11MB3858: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zALMhm2TI5C1RDlAxKMrKuxaXACbbTR+u2mdbHV494zQD5d8GCCrEVXfzz84NIV7mhKhAdG6yBPiv2qCUJkHcZahwGkoRhcf8OXvekACdlRJ57TYA4Yj+qWT65fA76nBHlUp/PoVuvlGUSNUhY8kDcNL2QLDZvAAhyobeV5Vqf0pbME8Q11CEdzmkxihSSlOmUPpwvdrf1H0e3jaMWpviFWBn41z+nihXBk7UyslWnaKr7G0ptF5mBYpJ4JBh5WxwryLWptNTNO/vh7SVtTWy6rOx/fz13OB1uwSuxurQJPY8/mjPx3Cjt5oplymDwraQTA94l1GLhXTeJ4XoekyMSC6xvEhLnn9Vml52nU7XpSR4UHnGn9tDuTW60tsdr0ef0s8vR2FrDXWqbQvEftmcQgGzg04WjnlYHxun3IM0hF7+GRepBxwnxhlnnJtxhWdGNSpioEPxc0AWeLFGAMAudBBipLBwbbhS79O4RhKkMHstsLf6z3hNTZPak4em/A0k0IC/Al24AKXPk6ICfK4yEUuSKVGht708ZMN9Q0YejoIgSa13zw82ypZPy8csbLrFz8cTif+j2Cx80TfxO83ZsLlZEzayzAuGVwu1UZwpkm41lbfidgN3fM/slyYlkdI7Fl3z45sJ6a8f0xHEtK0ZZMPBZyP6/jpaZSwiykMOwcmxyrEQWP14NAsbtbCGi/suwYXitu2KskmrUNbev5fXA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5483.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(136003)(396003)(39860400002)(376002)(9686003)(54906003)(64756008)(7696005)(66476007)(66446008)(66946007)(55016002)(71200400001)(86362001)(186003)(52536014)(38100700002)(76116006)(83380400001)(5660300002)(478600001)(66556008)(122000001)(450100002)(2906002)(53546011)(110136005)(316002)(8936002)(6506007)(33656002)(6636002)(8676002)(4326008)(26005)(38070700004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?eEF5VGNWc0laNGhtRDNsSkw0Q09kMk1icTBXMmNFZmRIL1JvSElDekdr?= =?iso-2022-jp?B?SXhyR0FYT2NlbDZ2dkthazdLQ0J4NWNXL0N3MWpmZDhLK1BIamRTWDM5?= =?iso-2022-jp?B?QlBaVDlENzZQejdmRThlekhnak5jYzd2Qlc2WDFzK04vMjkxMU9JbmNC?= =?iso-2022-jp?B?WGNySFdhdmtGTElrdytadTFXaVREMlZseHFzMDFTVkZ1U2Nqd3F5bGNO?= =?iso-2022-jp?B?bHhRcFg0U1VOdHcxUFV1bnBSdlRRbUZJbWJPMitZZ0dwUFFHZ2lmaFBN?= =?iso-2022-jp?B?U3lRbnI3bDRpSGpiV3ZvWnNHbXhTSTE3MXNKNlo0TDlqYmg2eklEZHFv?= =?iso-2022-jp?B?VGlubXlXaW1zamdNeEZEckhILzBISC9pWloxUTduVGYxQjhmWG1jRmFz?= =?iso-2022-jp?B?N285MjlvVWhJbjdwNjdXSThFbjJNeVM2bFZjNUtuZnQ0ZWtkRERTNk56?= =?iso-2022-jp?B?bVRXdzh1cUJBZDdUUWxUbEh4ZzgvYkFJUTFUNHVLSGZQeW5CT0x2NDlN?= =?iso-2022-jp?B?cG52bGp0YmdETVBCOWFCTW5sRzR6bU5SelY2bUxYaG00ZkxKOEQvVVNo?= =?iso-2022-jp?B?SFBIMnZjT0NDUXZROVlQNUg4akpiL1RGd3grSHgyb3NUQzNJM3QwMUk4?= =?iso-2022-jp?B?c1JoM05NNlR0MXBzSUdTS3k0NkMwSzhhcDZxaVJxRVlUejZjaDF4UUI5?= =?iso-2022-jp?B?djhvS0VYNlQ1TE9Nc0RHdU0zSjdOR01JdVFoQ3ZZTlRWOWQ5ZFZFNkdX?= =?iso-2022-jp?B?cDRLcUVNTE5hclRzZ3kvbjhwWkFlZm9zS0JnZFdhOWVEdUxkeGRuRjNE?= =?iso-2022-jp?B?YnozSmIvR3VDUG9aOHozUU03djRzN0x1TU80bEtVMDhiTUV6UjRGdHhF?= =?iso-2022-jp?B?UVJIVTNyVXR6N1B2UXEvUEFnazRWRTdHc3cxcHhZaFdOUTVIOXo0cE5n?= =?iso-2022-jp?B?bEl2OVdFdnZHK2hwcExaV0htQkd6VGpjZU42M01QRi9DTmZjVkF1eFVi?= =?iso-2022-jp?B?a2hRYm42YjA3S1ByVDB4TTc1aTZQU05jUWdBTHp0WDNFa3BBN2loNDhK?= =?iso-2022-jp?B?bHdIZGhaOVVrcS9Seko1dlpEK0VoVW45MkJ4bXhSaFhwQXh4LzVuSldN?= =?iso-2022-jp?B?K2oyQ3BCOEp4U05mb3dKanRLSWdMdXI2YkYydEdvaEVlK3NIU2M5SkQw?= =?iso-2022-jp?B?cmtWc1BON01weTlIT3pzMUZpbmdSN1ozM1VDcWFPNnpOQWgreXlNTThP?= =?iso-2022-jp?B?OW84bW15M1FwZ1gyRVFDUzArb1l3Q1dUOWxZMjVoTDQveWNnUlNyb0ds?= =?iso-2022-jp?B?MUp1UEJQV3lLOUQ4U0tUTitOTnRoU0dTK0ZiYmVyN0hKNlJYS3M5THVt?= =?iso-2022-jp?B?Vy8rdUg4K0pUeXlPOTNmUGZvL2FtR1dPYmc1VjcweU02ZG1XQ1BqVlQv?= =?iso-2022-jp?B?N3lORmJlTTVoeWUzdW01cWN5ZVJlYWxSNmdOWkI2U2VyMnVyVTZrWlFv?= =?iso-2022-jp?B?RXJVNGRiN1BTeTVXcXFnK2pwbklsMmMwaVYvVkJxSUhrTENOUGtXTEo5?= =?iso-2022-jp?B?S0dtV244cEl0R3JuTUJubXRvbktNMTRqcGp0Wk5oMUNGUWo2NEJoZVhn?= =?iso-2022-jp?B?VVFPakVFWWdzcllKSjNBZy9QRzZBa0xsUzB3VzZDOGFQL0c2L1VvalhW?= =?iso-2022-jp?B?bG5teDRSYldNczVGcGozZlRIK2F5ZzNreERHczRGZkI5QThhZVRMaWx0?= =?iso-2022-jp?B?U0dVSWJIUGRUalpIUlNwTnhsZU1OL0JjcTNCKzFxM2xYNGo0THlnTUFm?= =?iso-2022-jp?B?QVVscnlQc05TdkdORjVGMWh6TXJjcmtnNXpZeW41bGw2WlBwZENPL0Zj?= =?iso-2022-jp?B?NzBnY2dLVVVqbWVPWHVlazdSVlNoTTJMV1BTaHhFaVExa1JZYU1tRGpR?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 593032e0-ce9f-4c4f-872c-08d946791a69 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 03:40:19.6322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1yyDkDDmGS9EAYKIkrpO49B/3qEKgmAW/i88YmwG0dOpaXio5aX2YnErFBPYAC6/8KJQLNX4GsebZgqbm6qYaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB3858 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Tianfei, >=20 > To reproduce this, assume using Ubuntu 20.04. > 1. Install libfdt (It will include ifpga driver from drivers/raw/ifpga/ba= se) > $ sudo apt-get install libfdt-dev > 2. configure DPDK library > $ meson build > 3. check libdpdk.pc file in build/meson-private/libdpdk.pc. It will inclu= de path > to librt.so without this patch. I have checked the libdpdk.pc and got the different between with and withou= t this patch. Without this patch, there are a full path for librt.so in libdpdk.pc. With = this patch, it provide "-lrt" in libdpdk.pc. This patch looks good for me. Acked-by: Tianfei Zhang >=20 > Regards, > Alim Hussin >=20 > -----Original Message----- > From: Zhang, Tianfei > Sent: Thursday, July 1, 2021 9:19 PM > To: Xu, Rosen ; Hussin, Mohamad Noor Alim > > Cc: dev@dpdk.org; Huang, Wei ; stable@dpdk.org > Subject: RE: [PATCH v2] ifpga/base/meson: fix looking for librt >=20 >=20 >=20 > > -----Original Message----- > > From: Xu, Rosen > > Sent: 2021=1B$BG/=1B(B6=1B$B7n=1B(B30=1B$BF|=1B(B 18:03 > > To: Hussin, Mohamad Noor Alim ; > > Zhang, Tianfei > > Cc: dev@dpdk.org; Huang, Wei ; stable@dpdk.org > > Subject: RE: [PATCH v2] ifpga/base/meson: fix looking for librt > > > > CC Tianfei, who is maintainer. > > > > > -----Original Message----- > > > From: Hussin, Mohamad Noor Alim > > > > > Sent: Wednesday, June 30, 2021 17:26 > > > To: Xu, Rosen > > > Cc: dev@dpdk.org; Hussin, Mohamad Noor Alim > > > ; Huang, Wei > > > ; stable@dpdk.org > > > Subject: [PATCH v2] ifpga/base/meson: fix looking for librt > > > > > > Finding with "librt" keyword would give the output with full path of > > > librt such as > > > /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/librt.so > > > instead of -lrt in libdpdk.pc pkg-config file. > > > > > > Assume find_library() will prepend "lib", thus remove "lib" from "lib= rt" > > > keyword. The output will shows as -lrt. > > > > > > This will cause an issue when compile DPDK app with static library > > > as the path of librt has been hard-coded in the libdpdk.pc file. >=20 > How to reproduce this issue? >=20 > > > > > > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in > > > multi- > > > process") > > > Cc: wei.huang@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Mohamad Noor Alim Hussin > > > > > > --- > > > drivers/raw/ifpga/base/meson.build | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/raw/ifpga/base/meson.build > > > b/drivers/raw/ifpga/base/meson.build > > > index 8d27c6021..ce592a13a 100644 > > > --- a/drivers/raw/ifpga/base/meson.build > > > +++ b/drivers/raw/ifpga/base/meson.build > > > @@ -27,7 +27,7 @@ sources =3D [ > > > > > > rtdep =3D dependency('librt', required: false) if not rtdep.found() > > > - rtdep =3D cc.find_library('librt', required: false) > > > + rtdep =3D cc.find_library('rt', required: false) > > > endif > > > if not rtdep.found() > > > build =3D false > > > -- > > > 2.17.1