From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FCCDA00C3; Thu, 23 Jun 2022 07:52:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 434174280C; Thu, 23 Jun 2022 07:52:23 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id A89844069C; Thu, 23 Jun 2022 07:52:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655963542; x=1687499542; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=YWA7KKObjDpHWfGV6qUrWp/wZMqgOp2kIRF2yT1Q+ak=; b=Th72m7dzoZmAwTBoLLuXGFzh1ACQ7EK84O2EDZk0pgxljCgtanlIg+Vs BE7+TbkrFawJwaA4G4xFNi3gb8GFRuA13vThy/9iU9HdfV8zCWHhcHUhD jI+3Jl58uyBozxae9LNY8Zxz2FCIMT/7Jbh/NkC/w9h/NjGqhzcNxl+ZZ zh/88rdrt7ZklqwrEdP2N2Gw4YvpxlFxWd038Ve3oGdyZ418jysftbUcg sRcCoFyVtYFvFoR4vcX58CP0Kwg/QEmATABIO/dJk4519/AAPQAUTbN/o QjwvkJUN2ehMM9+AYSO1+M59supJcK2Y0rZ638HArTs4E9h/qIrCkuwkY Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10386"; a="263665783" X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="263665783" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2022 22:52:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,215,1650956400"; d="scan'208";a="730702243" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 22 Jun 2022 22:52:19 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 22 Jun 2022 22:52:17 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 22 Jun 2022 22:52:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 22 Jun 2022 22:52:14 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 22 Jun 2022 22:52:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hadgz7vYKGdWCAQCZQ5eD2cZSWkW+FC/G+H36qemBHMRDml0WToItptMdNGcarB31szucttQ+kwIr/bYNPbsb+LN6NOFlFERWtiP+5Fzty66jcmXg54PK4ZuiAfnO9RJSAYiFD8XMeM65qU/5JM97lZnYRKQ0YafCfZOxfmBlxN/ijD82QT2LlhZrX1Y7HOt9GmPWL200E0RQ27X642SZTtcTuHoKJMzg/rmJuhhQGddrL/55xEzkehlXvJW6SZl11IZqPDKZI9GGtTbFu4pgvd/X+jyEW9edRQZ2gUnL9dPTQ8TVd8uQqzIimiZv9dT08ZYy+UTbMb+oUeJEIFTwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DfhmTe7Gg7QkvipDUlQLBqHIxC2lVkzxb8S2VSFaWLM=; b=gEra+7y9RdYU7OKxdssTpnIZwIZGpXWhx7EnUF9ZVfeHHjWsYobhdIJtMu7YFbJo38O61U1REFfD70nMoQf4HuccIRepcplFSc0UdSc63uziwXwhq+iNPZhIkIxK+X9R3StA7GTDHT9k5XUZWLry1aOqK/kP6f3Y+3Xf5HDyZ010NiXwR2tXzd/l9aiE/Oc6ZG7VoZe+XMwa7tmN8MLl1QB8a7ZKpTfYKHQw8oEIXXWZtWtnZFhQJT12TXik7u+yG5iedAjSGHQ/xypD15784uSe+hhcnDEdPxc6Bqs2iN6z2C/1bB29YP8VBMOXHfjP3WJtrH7KKH0ntnphEbl2sQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5483.namprd11.prod.outlook.com (2603:10b6:408:104::10) by DM5PR11MB1547.namprd11.prod.outlook.com (2603:10b6:4:a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.16; Thu, 23 Jun 2022 05:52:11 +0000 Received: from BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10]) by BN9PR11MB5483.namprd11.prod.outlook.com ([fe80::a113:c892:d94:dd10%7]) with mapi id 15.20.5353.022; Thu, 23 Jun 2022 05:52:11 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "thomas@monjalon.net" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" CC: "stable@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" Subject: RE: [PATCH] raw/ifpga: avoid potential integer overflow Thread-Topic: [PATCH] raw/ifpga: avoid potential integer overflow Thread-Index: AQHYhq3Z44ZXWDrQP0CjAtzHptTg6q1cfVyw Date: Thu, 23 Jun 2022 05:52:11 +0000 Message-ID: References: <1655953900-26199-1-git-send-email-wei.huang@intel.com> In-Reply-To: <1655953900-26199-1-git-send-email-wei.huang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fe500ad-87d5-49af-be84-08da54dc841c x-ms-traffictypediagnostic: DM5PR11MB1547:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OtgfAOyjvNRaAM8H6K4DmcKOMm6MNZwWkYI6HWEm2tvtdDu9ZR4L20kaaXHbujxWW82YZMIPJvQEkdDwNIZuPmtcwYImZKOrbVytQ8fuK7KKeLDJfhh7scGZ7GgsIj1R+DlzvHnnLY9AuZhJvdnUajqVJfw/6eUMosIxk38sOEi2xqKvPHG57qFNAJgbqXs8chN/hJxVcDYO9BD48YXlmwkk5dFkHvppQetqQoBivuqKF8R7JvANjJ41V7Yjq1ZeBak4RdghfFj+WeespMMDSof5FrUPOdkNlENG6UWf2rKifeafDjsVwa8Q2a3mQcsZlzF1Vfubh/Fra75wJMihhu4sxnlLk+oA250Cyw1SnbcJWnQ12YGXEJMIe+ad4bmM1CtW9KAuzAppUzJB0Gsybkk70TdjKOkrYC39a1dvz4BWv/+Vlg0UNhy56mDteL3FFEeInsWMN70bHz5xejJrTfh8rtXU/huebFwr5xmRqcoolKv1d9XKXz/aa14t0uwgQh14BRS42AGeBbo/hrQTlx/ST4OKyIVmU4Do3qC9SxAflmIurLSnbeyG44KGYEqRtIZJBWeKnrX1XYLsj5yN6ual2lYFDYf6rp0dwEYLfiYW6EVghnDXLjUUzWudD7oPZQpliAIStsqAJ3OOi0NTsvqFeNdtqKt1iAcbbBm2ej4MBRGz2Ct6e2/5fi+wtX1hNcikJHUNi4sNYGgNOaA+J6GGY+tFj1n8YsbANm9pC0xY60IziOxhgQ1W89dw2rEwtEFxDHvTifdOCtQ1OlTZoQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5483.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(136003)(376002)(346002)(396003)(39860400002)(5660300002)(54906003)(71200400001)(66476007)(66446008)(110136005)(122000001)(316002)(55016003)(186003)(66556008)(478600001)(52536014)(2906002)(66946007)(76116006)(8936002)(4326008)(64756008)(33656002)(83380400001)(38070700005)(41300700001)(9686003)(8676002)(6506007)(7696005)(53546011)(107886003)(38100700002)(86362001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: zEEnBp/VeqUBYl9zqA0humZuj+p+w3UWfK2FZEoSrHd2dzyLitAiSXt7kxCqnW5C5wiySUglg/ks37yP/QYH/GHbrObe+9qcEmRLbQJ+8CZpNpQf3ySCiaLg26RKgSHO9O837fSC45fJZGih8lZXkEBVdtPKFWffS0KxIP3R8eWdrq7Atrlcwbkrwb+DkKAVQWh1YnQHTu1IpAoG5EnpMBg/zAYGxyzeVPTywfY1W5sFb4I7tMBfLuQpjlD7ol+PKl4+8chbXrN3FilWVpKP617WWjzBytPvre+skDHGtU5q4/bkbwOHiIk/EsVlZO/nvVHbPoIFUfO1um0P06TAafgfn03z/NZ6l/tAhcJFhcTkfwXcPJI5+P1nAfdjj6QxxvF5rO5pyG7kS+cb4a4/ARtoRU6samv1lcovZtPzT+WxbniokEFuxRCf1fH75mLI1fszp4YOlrolscUWlIuVGtIcRh9P4RXtsaQbmjpoFFOJqj7qvXAHvNjweiq67gFAxx/U7FQZmIy/T00objdRsF+LN/aZcIoWKK0H3hH37MMcBfNHTINsXgl5aY3GKa4aPrDnnX0dfF2Bv6Ta31WrghPkqjcgZRKe8ZlMQxgEVkw+QYe5rSgiugNitTmNQ2lhR+8HBEQypIdAurE76JJCcnPTFC+bU/z6Fga9JUflppi/j9MH6CEGsvizf4s90aaey1AolPT26arjl7uxJyDzOzfejfgF9xmc5hhzPeR406m79DM8Ve1TNj8SjWO4JpZwAV0OOIh8rGF0DHhAnrs4cGrG07F2vBEjcWs6MhSGIi8pPO6dkMzYMPvMUvj9EUHXHQYY03oKzjl3uqwDKKD1cQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5483.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fe500ad-87d5-49af-be84-08da54dc841c X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2022 05:52:11.1578 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: frv6iQ9ztLMBds1iDOhcxNHssXHIYzAH2q5Fxz/NC22eSBzZMp9jW5i4Ya5Ky4dJKqgPrtNYhg92B7hlLJqNEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1547 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Huang, Wei > Sent: Thursday, June 23, 2022 11:12 AM > To: dev@dpdk.org; thomas@monjalon.net; nipun.gupta@nxp.com; > hemant.agrawal@nxp.com > Cc: stable@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH] raw/ifpga: avoid potential integer overflow >=20 > Expression "tx_chunks * ctx->dma_buf_size" in dma_fpga_to_fpga() is evalu= ated > using 32-bit arithmetic, which would overflow potentially. Change tx_chu= nks to > type "uint64_t" to avoid such issue. >=20 > Coverity issue: 379203 > Fixes: 7d63899a5c19 ("raw/ifpga: add N3000 AFU driver") >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/afu_pmd_n3000.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ifpga/afu_pmd_n3000.c > b/drivers/raw/ifpga/afu_pmd_n3000.c > index 8708164..5120df5 100644 > --- a/drivers/raw/ifpga/afu_pmd_n3000.c > +++ b/drivers/raw/ifpga/afu_pmd_n3000.c > @@ -1158,7 +1158,7 @@ static int dma_fpga_to_fpga(struct dma_afu_ctx > *ctx, uint64_t dst, uint64_t src, > uint64_t count_left =3D count; > uint64_t dma_chunks =3D 0; > uint64_t offset =3D 0; > - uint32_t tx_chunks =3D 0; > + uint64_t tx_chunks =3D 0; > uint64_t *tmp_buf =3D NULL; > int ret =3D 0; >=20 > @@ -1213,7 +1213,7 @@ static int dma_fpga_to_fpga(struct dma_afu_ctx > *ctx, uint64_t dst, uint64_t src, > offset =3D tx_chunks * ctx->dma_buf_size; > count_left -=3D offset; > IFPGA_RAWDEV_PMD_DEBUG("0x%"PRIx64" --> 0x%"PRIx64 > - " (%u...0x%"PRIx64")", > + " (%"PRIu64"...0x%"PRIx64")", > src, dst, tx_chunks, count_left); > tmp_buf =3D (uint64_t *)rte_malloc(NULL, ctx->dma_buf_size, > DMA_ALIGN_BYTES); > -- > 1.8.3.1 It looks good for me. Acked-by: Tianfei Zhang