From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3DAEA0556; Mon, 17 Oct 2022 10:40:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7F884021D; Mon, 17 Oct 2022 10:40:25 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id E3796400D7 for ; Mon, 17 Oct 2022 10:40:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665996024; x=1697532024; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FMEdfU/7J6ta8QgUIm1j086P0slNOSoy0bVZW0Lgfds=; b=VOspLb38tbvY3qma+8cutIyrLUCqPT+nw4SQh3ex/lTzHDj0vPXA5nT9 qWF8iQqa+iQo0FeWTjusejbtZ8DtGfdklYHeSNtFKqW6Io1A/xbHFAX+5 QJMN7DyQedgaqTVWbhBwkORyx8+I+QP+P58QW+JOjB5RhPMh6NtiD0doQ NOpOuN1DFlJr8KvKu1NUjWe4zV+UpgnLGs02scE7ZbPt1QpolpLHThnVK HUKM9Zw/XLmnP49ESZFjdHK1UEXVxFaXIuD9cI9XVMrC/YEryYcPAzzLr 5Uyq3CYgV9p7x/V1M2Bmsih3ZIFmLxpUTlHakBZ2slPIxxGJXVl0tTsrM A==; X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="285468114" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="285468114" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2022 01:40:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10502"; a="628220270" X-IronPort-AV: E=Sophos;i="5.95,191,1661842800"; d="scan'208";a="628220270" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 17 Oct 2022 01:40:22 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 17 Oct 2022 01:40:22 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 17 Oct 2022 01:40:22 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.173) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 17 Oct 2022 01:40:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktB2f9u5P6KPx1O5jhv9FTQ+hAFfY6A+ebmm3lNhcT4yHijbHelippl+Tyg7SCAUpqxKCUNhm3JHGibXq44DoWNqnfQ/T6wAqaCehgGR5eLe0F4F7PKtBL3W8I2uTIeGYgYfCPwjPZ4fVbZZIFNB7dZ3jontaJsRJNbe9JQH+MO9WmkQlj4aF+znO1z8uZw3hJGXDVQfEW9eDFj2LETaeAeius+cfQHFOLuQBZakHY9/Sg0Lh+7shVWNSEFvqcsRK4ow75kmVhpldGDWnvGO2OEDnMfQyWXBwslTzCCwNPDYT2Gt9LyyuXr9hoYyAzrQoqtWL+Yp/JVa6KS7nfEuVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MqZW3AJHPcesZDcC1BsFozVsGU8n2wk2bj5qOf9qFnU=; b=cSC/DzXkcyJ5MdfpzA9ruG+BSytdPKq2yWcV/640A5YMNSRMSre5L0USQSjnKYTmpcBc37/hKmDP2tJsV+jWJmQpdi2DbNHjJ83fy/7piKPwhZfK6LsPFIF/Efjf78b03xD4pkOVtXnb0oWgTW7JyXQWGOEk8QmSISehmboMeWIiULjRu4RCopc0Si8FHBjTLFVSBrab1DYLSqbouiIxGnAK16+zJnYEANqDa0EDj7y1JhWM3MSllLtczLTyf06qDmxtHa6bmBe9QUbAB3At9k9QZRRZGyhXdDvp1Z31luLvMuvqMs0pirEyviSHLMCQ9LtiEEnoP8RS7jYgnVkCIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5513.namprd11.prod.outlook.com (2603:10b6:408:102::11) by CY8PR11MB6987.namprd11.prod.outlook.com (2603:10b6:930:55::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.32; Mon, 17 Oct 2022 08:40:19 +0000 Received: from BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::3c7a:969:b3de:26b2]) by BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::3c7a:969:b3de:26b2%7]) with mapi id 15.20.5723.033; Mon, 17 Oct 2022 08:40:19 +0000 From: "Ding, Xuan" To: "Wang, YuanX" , "Yang, Qiming" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Tang, Yaqi" Subject: RE: [PATCH] net/ice: fix the judgment order of buffer split Thread-Topic: [PATCH] net/ice: fix the judgment order of buffer split Thread-Index: AQHY4gDHxHNH6VP7M0yLXHRdHMN13K4SQ0GQ Date: Mon, 17 Oct 2022 08:40:18 +0000 Message-ID: References: <20221017160021.773879-1-yuanx.wang@intel.com> In-Reply-To: <20221017160021.773879-1-yuanx.wang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5513:EE_|CY8PR11MB6987:EE_ x-ms-office365-filtering-correlation-id: 4f34fe5c-3cb3-4649-395d-08dab01b38bf x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8XJXCcumYai2UCyYSEToNYbht+Po4F2dDw6tAbInSxftzBKNvOrLkcgvC35LkcMAvClMdILFxWwjQRyFjkp9J5/JqVCM1pYPy1944Sg2YO9cgNuo0Zwvkg485xlxRK8us1et6fF7vYxVLRvi+TAYRS7x8qQLDYkTgoholdm4ZUEj8qzbyRyXoneEaCUA99SylGn7wV6QGzCa9kturp17ezdH4Dp1d9IcocjxV0o9WPO1Kbo7xssUormx27tUX+R1HXmEOnlkCI6tIDWZBFVXyp0LABM/6X73RXb5xOgcWPD9nHg8ND8hGUs0QDZUNzvo+CAAt06q1Srlj7z7M2Z8D320iEDuYENizIA3xmVeqGwH4Y5JgIo5uVj0hW1exJzi39EsQpz+bArwdDzfIL5Ks6GLSoKN+YKQSeZ8TjQ/xrh5rMi00+AHR1dzAXjx80FBlZ7rsdwHs2qI3ZZJlG5OxVvoL+zkU60FnguAyJW3LB+apVVH5oL7fUJdYE3IF07nUs0U7KTshLZovFGcB+EZCcaFUotmmx97Iac1IbdYzHmUzZhUnG2YFqKRqxXE3CXoqVZpzT5PsE4sYok4vcsxAcVZ+gD45jI+PCoGugOXk8uc9geAP7otPnt9tdGmJqxmcj98LEX+G44xxkAjoCGrw8CWM7CsQye3jrPbM5rSz1D8IioCheBlEniMTsO8zbbPlbMyJ7YBRNGyEru9Q+oT2Gme84CqIJfl0Wlz0ctcpOA6Ol9wkCQNHvzqHbXaI1P2qxIW4ezs6juIkOP8vMZw8g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5513.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(376002)(39860400002)(346002)(136003)(366004)(396003)(451199015)(38070700005)(82960400001)(86362001)(38100700002)(83380400001)(55016003)(122000001)(33656002)(316002)(54906003)(107886003)(478600001)(71200400001)(110136005)(6636002)(41300700001)(26005)(6506007)(8936002)(7696005)(52536014)(53546011)(9686003)(5660300002)(66446008)(66476007)(66556008)(66946007)(8676002)(64756008)(76116006)(4326008)(186003)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?au/zeJxj8rgXE/yS0VxJ1M/fPX/srRiPlnSGPI6SujN16v0R1Uf4qAPw2ziR?= =?us-ascii?Q?qWFAVjn+XLW1g9oHpbQAOnKNN+fvOrKu72FjdrtI4wH6xOk12jbl9n/qA1HL?= =?us-ascii?Q?63QQS9LxvPKx+7tvIHFptLeT+8YYvrunTaT4satGafxOWsaPO964Me882vwp?= =?us-ascii?Q?TTDQ14uqQF66tX6k+2RrjLBpC0dAkA/yZhSbeq/zp98tkzb3GvzKqx9H35o1?= =?us-ascii?Q?Au2WxH4kAStEabHB30ClIijwLhyMUJ0UhqbfHwCe8VcKOXgHv+RbhTNHP5hV?= =?us-ascii?Q?tBFZNW3xxrBRlh2rJnYSn1fG9HNt/gvRmvnfnDbWD8NIQTAWD5oKEJ1yF2dg?= =?us-ascii?Q?iQshkLfTshVfaYDlww7YEV71hQmS8RYeg7qeoPec3dxQLFJJe5nQAVLkjUV8?= =?us-ascii?Q?iW9/C9hz1V5PBZrXljnar8m5FxQG3HniLZh/rJG3Cg/Qdf1fmgtw0x+Qd05r?= =?us-ascii?Q?GozmKKSFdz5/NtTT+WQ5jnFRjNW1QMMk75zUQlp2QjFBQZbyDFaKQSbt9a3D?= =?us-ascii?Q?WbBY8X92rPmsW1Re2hef/kHI5q483RIxyJDfRDm99HXZuRCQ+bquuYvGxgLH?= =?us-ascii?Q?iIn0JBgJ5XbQHvAKBaIzoG9OQu5RP5xXJ8cXE+ZlCIQEkCT5PRM9+QW5xBEe?= =?us-ascii?Q?Bofq8Oue4YYLTXYqhvC2JP1x7+7a/JAPE9GKkt4FPJ4rIUAcsiLKOcMRG6GO?= =?us-ascii?Q?qDw4bUrt2NsqmWqrrzQNTmywCBBWLNlRdMk031AdeBTpJguFYgY3UgpFkYhC?= =?us-ascii?Q?+V4NYh3qX0DnhWi67vgWgecicJgHSQXUj+EeV3vx8WjsqnamQgmhAbXn0kUa?= =?us-ascii?Q?TDuZqsAg1lz5rilH6ru5KUDCa16zP2hQin/PWuwueX2Nh0I8to4o2n1WJPaD?= =?us-ascii?Q?TIvKwSxpJzHNckH92c/tb51ApoMegPR/Z+W+386IDLOh4MrZJHYbNMVmeXBw?= =?us-ascii?Q?6/39QvHujFf8LlPb1FyHbdr3zNPI+AmgR+uIUEKE/qlQMFa0m+8PsQMnzOv3?= =?us-ascii?Q?ix8pezcOpIVEAy0Xyphe+FykDk/FrVtNkTCKYtBfg9hgY21anSJVEBgg2fQA?= =?us-ascii?Q?ddpYS8chmSoFKL/2Awoxundb/fBprgal271WNiZhDNnjzPPrG0Y/mnKtGe8r?= =?us-ascii?Q?8w3ZVk3JetJpqhhyCZmeOIHGYnwelImaz47kJ4njUqwQKwbTyecTh5RgJp+m?= =?us-ascii?Q?AMvebty1lf6qyQNY2q44wllzozM0unNAcZ38i8WnzVFA4WoiN6M+ZS5guxWe?= =?us-ascii?Q?HuNzaA5JDy7kgqpn4C2kFPnIgceqPVxTVOZ/vdUea4xg0I/nqOjRMFhqJ918?= =?us-ascii?Q?ENJyuY5mx2mxe8ieYwKtKxqpezDQvfWVLZW0lmyApWGpv50eBozBGTJo1nBS?= =?us-ascii?Q?eBQ7wNxruOUnmpUS6jOLLelG/L+U34BHFr+y50cQ7M4fK2st0EZSVmd0v78H?= =?us-ascii?Q?OzFsLPiQgMbDn2lN+TZ39EiOaUFVfCjSw4kMb8QR6/opSAbsA7NHqNVdPN6H?= =?us-ascii?Q?dDZbjP8VeW5zGsglsT9II9pjYxk0aB9YAkjxsLWtpPCOJ2LS7eL6/wpLHnOC?= =?us-ascii?Q?kIM7puK8HZK9RH0pDKCIDYgDzs2zrtVN8Qhpl6PU?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5513.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f34fe5c-3cb3-4649-395d-08dab01b38bf X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2022 08:40:18.8851 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BHPAQvB0ZRXWME96XEYYfNlCiVPyhPAJIQJzfM9xbNVdRjcfcwTPb8AHvq6XoSRfmruIXGuJT0fN6RFz82kuZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6987 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Yuan, > -----Original Message----- > From: Wang, YuanX > Sent: Tuesday, October 18, 2022 12:00 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Ding, Xuan ; Tang, Yaqi > ; Wang, YuanX > Subject: [PATCH] net/ice: fix the judgment order of buffer split >=20 > proto_hdr defines a bit mask of the protocol sequence as RTE_PTYPE_*, The > last RTE_PTYPE* in the mask indicates the split position. >=20 > To get the split position from hdr_proto, the order of judgement should b= e The hdr_proto here should be proto_hdr? Thanks, Xuan > from inner to outer layer, so for tunneling packets the tunnel header sho= uld > be placed at the end of the judgement condition. >=20 > Fixes: 629dad3ef325 ("net/ice: support buffer split in scalar Rx") >=20 > Signed-off-by: Yuan Wang > --- > drivers/net/ice/ice_rxtx.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c inde= x > 953ff217df..7a2d5829c0 100644 > --- a/drivers/net/ice/ice_rxtx.c > +++ b/drivers/net/ice/ice_rxtx.c > @@ -324,13 +324,6 @@ ice_program_hw_rx_queue(struct ice_rx_queue > *rxq) > goto set_hsplit_finish; > } >=20 > - switch (proto_hdr & RTE_PTYPE_TUNNEL_MASK) { > - case RTE_PTYPE_TUNNEL_GRENAT: > - rx_ctx.dtype =3D ICE_RX_DTYPE_HEADER_SPLIT; > - rx_ctx.hsplit_1 =3D > ICE_RLAN_RX_HSPLIT_1_SPLIT_ALWAYS; > - goto set_hsplit_finish; > - } > - > switch (proto_hdr & RTE_PTYPE_INNER_L4_MASK) { > case RTE_PTYPE_INNER_L4_TCP: > case RTE_PTYPE_INNER_L4_UDP: > @@ -358,6 +351,13 @@ ice_program_hw_rx_queue(struct ice_rx_queue > *rxq) > goto set_hsplit_finish; > } >=20 > + switch (proto_hdr & RTE_PTYPE_TUNNEL_MASK) { > + case RTE_PTYPE_TUNNEL_GRENAT: > + rx_ctx.dtype =3D ICE_RX_DTYPE_HEADER_SPLIT; > + rx_ctx.hsplit_1 =3D > ICE_RLAN_RX_HSPLIT_1_SPLIT_ALWAYS; > + goto set_hsplit_finish; > + } > + > PMD_DRV_LOG(ERR, "Buffer split protocol is not supported"); > return -EINVAL; >=20 > -- > 2.25.1