From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DC1DA0543; Tue, 21 Jun 2022 10:56:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD7DD4069C; Tue, 21 Jun 2022 10:56:48 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id B225E40151 for ; Tue, 21 Jun 2022 10:56:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655801806; x=1687337806; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=L2alCeFYIB1iSa24n1ptK2rF0kunwlfKl6c4Kv1y08U=; b=G/56thUjrFOSia1v2sC8WwdXu3spTDZrceDAqKJjHKagIp85oinJ87II nvL0DR0K2jggugAQg4jyEVaFL3D3ZUZkGpXVs6B73k+cv+whP/IBc12N+ N8H5V/x9+hwT42GzQX+ExgjBIpqi1n0qB3cDsBZtY2FZoAe7BAVGp6pxf dQnxrajcbf3jcVgYls8otsmhF+qQCM4yvbkJ8WdQU5tduROmtHwESwHtx ndDD1UUuensA0t6z7fCFGat4OkQd5/uJJUM8lsB6BtQ00NXJN0mUjVBpI o5ilIRyqmN0yWFCqAV9eANWkg8d6s54GS9rore8BhjmeL4ADxoPeti3OV A==; X-IronPort-AV: E=McAfee;i="6400,9594,10384"; a="344061107" X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="344061107" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2022 01:56:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,209,1650956400"; d="scan'208";a="833482340" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 21 Jun 2022 01:56:45 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 01:56:45 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 21 Jun 2022 01:56:44 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 21 Jun 2022 01:56:44 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 21 Jun 2022 01:56:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HAJntif9YcUAtf/mWNvK8+dnxEJOToj246lH0Q9Wb5WEEhIGZ8ubEf9uRkLb31gDZHXaOUqL9xAwEi+4VgtRxFEfZylnxzNpGi5uwzzTEYAqcCkjMUuntmjQNDBFbUb4iKkyZsTBj8citlFlZ2HuFviyG2Q9J2OACVQ3gbzLvkuEHU/BK2a+hsYF4NWn3XUCSfZypOb5oaPS21Q6gUxyX0GXsyioYeL0MAbBoQeWM2n0ZLE2qx8YM/QSJKIwsr18I/r7A7hS4FU+w6lIiLZnTViop0gEMwhndsUvJ1wf9htp/4pMk+W9Rm4hMS/BD/GvYcLwsvNURyovIjY/XGCabw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=85cjoSiX/G6hoe5tcGcyDD8eLIgbfoJcVtua7h9MFq0=; b=LwfJJCAPxw2DXoacMxmZL6FOgnL4/vZ9h8r/Q+IpQMOjXUESKbp2S54Naf/a1uAtNdbiXa7kimtSNy+Tj4EipJdX/UJfmUiung3Eogr/BHeVYyqUVRyp+H+dyoaPUMG6pWVIvj/x24zKIVAJSHBNYTDFjZ6Jj9im4/KJacDG/wP7m6HJAPm+/Fi7mMbDceqm3xBemr1j/GitnKzG01kZP19ikIIU+i4Yq55g278QJqHa/h+9uRtvwtbSm65DGATmmd+f3c1lXgJTP5CHtzaZrDvAKrlREkbkcjJMUU/P52wng39LkBsIIsKOLV02BgmuLb8XxWrHifjush4fJAIRgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5513.namprd11.prod.outlook.com (2603:10b6:408:102::11) by PH7PR11MB6450.namprd11.prod.outlook.com (2603:10b6:510:1f5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.18; Tue, 21 Jun 2022 08:56:43 +0000 Received: from BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::31c6:2ec8:2f71:42da]) by BN9PR11MB5513.namprd11.prod.outlook.com ([fe80::31c6:2ec8:2f71:42da%2]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 08:56:42 +0000 From: "Ding, Xuan" To: "andrew.rybchenko@oktetlabs.ru" CC: "thomas@monjalon.net" , "Li, Xiaoyun" , "ferruh.yigit@xilinx.com" , "dev@dpdk.org" , "Zhang, Yuying" , "Zhang, Qi Z" , "jerinjacobk@gmail.com" , "stephen@networkplumber.org" , "Wu, WenxuanX" Subject: RE: [PATCH v9 0/4] add an api to support proto based buffer split Thread-Topic: [PATCH v9 0/4] add an api to support proto based buffer split Thread-Index: AQHYfxM9QlFt1v3AWES5FVz5fSBR4a1ZmCLA Date: Tue, 21 Jun 2022 08:56:42 +0000 Message-ID: References: <20220303060136.36427-1-xuan.ding@intel.com> <20220613102550.241759-1-wenxuanx.wu@intel.com> In-Reply-To: <20220613102550.241759-1-wenxuanx.wu@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5d41c144-da56-4913-2ca8-08da5363f67b x-ms-traffictypediagnostic: PH7PR11MB6450:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UuDFWmjU66idUI5WjGQ3hTyVowyw2kNa2uNF5BUnt33o3c0Q+lUYVdShlvaRkZoIz+9Wis9K5G/EiqkoWr7u0B0pjlDCsJISdMcXWIy+OlRcSD0DI2g+TVeKd+FqW1khKsHZfqmoMPGyJHb4V0pZFFVOn6GhDlReEpidTErcLUiVlhmPqRftyPUPCnbOu2VYAkNpuFsk9xyxkjuPP3YPVn9at82BpGtBdEVEk9GcZCcsiqLQFjKBF+LdQumv+DD8Ps7rZqYG+lkFTDF9hO/CJlY02km9PoMP3Jgs8FK0aReUXIfKMUISaRGs8SPRy88EQo5Y6s/y4N9BJkIIjcxL8LgbHHCig3LNNvIxhwBwcNlK1f/5eT8LOHPme9u3aTww2B/vN7t+G6yW0zyRAGStBT6l/sicmkVqd4I5dEg8D6Rr37joK6sifFWA8BRIok8y2CR6WPvqqSecTe/csPSCEyTdGpddJ7C1NjjfQ7VZRzP2mL/goOSNQQJWzyHz3XPX+lcSifd4oyJis3JnO2RG1J7S4FXiYeHpA5AU6PCV006CSQnXbGGw2OOti1eMex2hyYb71glgVijflQtptSDVKYy35816XDWeCGhEcdMxNhScQguftahuJ2qll4cuzxZh/FkJjMS10pca+4wFmaXFe/nbGEkd1+VhGID1GqmPRsiEKM0h8xyEFvZIg03XEl9iDGVTZCty37KwpW5iwBOxhQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5513.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(396003)(366004)(346002)(39860400002)(376002)(6916009)(107886003)(33656002)(8676002)(4326008)(66946007)(122000001)(66446008)(54906003)(64756008)(82960400001)(66556008)(66476007)(55016003)(38070700005)(186003)(41300700001)(478600001)(316002)(38100700002)(26005)(6506007)(53546011)(7696005)(5660300002)(83380400001)(52536014)(76116006)(71200400001)(9686003)(86362001)(8936002)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kYJmvKVw5pKfrXvkSHfyW+iv2d9RrcW893tb/tik3TO2LzDxAmAXcTmCc/Ok?= =?us-ascii?Q?1gbxLXTsIJl4sC6/d+ubBguh3bYFIFfNARCTrLRM17sHYiX3UVHsw9X7JZ93?= =?us-ascii?Q?sFOznwbVYqXn+OOf4iRdiuDLlwkvDZjv2tUeEq7Rw2tjmL+RdgkvNB2A+Mc+?= =?us-ascii?Q?iQTZlQP9lhqcT8dpr9zB3uEpW15+Rs8Y3G70e4557Wgnt6Q62uery64L1m30?= =?us-ascii?Q?cCV9KNBwivkmt2J7bexsTiUh2fuMAA2cz8CYjA3Ywhukqnh4JER1Zcu0NWg5?= =?us-ascii?Q?s4HLMSkFi8zqenbc+i06L7CQOHIvuELI40EDv3wxc6vrQjtJ9AggNDWX0Mi4?= =?us-ascii?Q?uJvGHq6vDg6u3z9uty4PS7VWoamfUMuuWOoRsUFYGtIHmYLFITwvyIy6fOJk?= =?us-ascii?Q?l5K2U9XS9almr/li0HcisSikrAep1JOTC3a1grgz4ZasL23/ACz5+7j+zDN5?= =?us-ascii?Q?bnve1wTfp27O3zZGJSYYaCFFR5MI5bblmq23KzzPsGiBuSrjev+8U3xxA8+I?= =?us-ascii?Q?Ci585GzdEn15j500LhWnhxopUnBs9DXzY+TfqkL30hdu3Wtm6otS/0Jqy827?= =?us-ascii?Q?MTNtp4a7xUJrlNCXRVsI6xYG32DtWZIA11lljiYV9E6+4zE03N60ruIudopU?= =?us-ascii?Q?Y8Kf3vwgd7bno7ZqpT7BFryeWkwZK3a1mtKq/rf3TAVu7X0K+BiXTJ0DekAH?= =?us-ascii?Q?IVazRa0mdeIuYX1XATh+TGb68dU/3Xf5VNvVuJacUtCjPHJNTxWaq73ZllSN?= =?us-ascii?Q?RrRwU+RkomHT3kjnNQ0v6jT4enVIQmrI6Zbpdo4aQzhaQN7ydsaepksG2Td1?= =?us-ascii?Q?0kfakFhj1RxOShPABn/0BhCmUsEffWVkdoq0Wb5eZUwYo1TJnjSvvmURJavq?= =?us-ascii?Q?uCrgFdwE9r6QJ8V5WFWgRyoVI98u+AI2qWLAaAraA4JQP2+Uw2Ra/ooTAczu?= =?us-ascii?Q?Zp3bCZkBcePnp/FkWAmznOipVWjgNBpgnUzkXL0n544reNZwGHA281Ni4rEy?= =?us-ascii?Q?b1dVzH+jUnkJ7mreTbDjnGVKSsCiuRpS7eW2NgBZCOMHTlQMsM038UAF5cQ4?= =?us-ascii?Q?Xg2Fcu5a21sAgUUFAqtMvbsTj6loXa22ga8vt093KoXnJeIyG0mTuonM3m1E?= =?us-ascii?Q?jn7IxfOpoaRl3rS4ukqjThVvT2gcbNMY85NmKsc47zMg0cKtjlfBIGegyALs?= =?us-ascii?Q?kjNnTBn0FRNzlkWsi8dKgOcd+FiOert51YW668Ii0DNc41EEN+W7xrFW9k67?= =?us-ascii?Q?ptMy+7vgmOvK2Eai08+gN46ZrNtzXh1Z8oVj29n/ImLuKM+9r5ah+lMW+i4B?= =?us-ascii?Q?xxT2Fbcn5FIdTnaN8p5XMuXCcAEGwq2oa5MyEByu+AgS7A+AoMHamVLi1tfF?= =?us-ascii?Q?az0BKOf9TT0MV4FQH9HT3JkHnYHSxIIZnBEhZF1mzhhY+Gy7Nr0HnCssndJq?= =?us-ascii?Q?9oWLypwgQ5SKKPAXg54/bWctVxaJzEi5dECKKH3dkJZYhTGqntSiLJiPW9kx?= =?us-ascii?Q?7rW+HNB9V+QBd4913A1TXL0r12aXRoKJHM1l90ZZKrNup1PCM6oKLdm1HM2l?= =?us-ascii?Q?tg9qBTDfsIplan9krjd3sW/7t9hBglM4jljdT46nMuv634+Z0C0wyEwf/CNx?= =?us-ascii?Q?K3pUpaQR/s/vgen9BLNXdNJhIRsCGzVGsIdPgbjgfhQiHJZb+YLE3f05NroH?= =?us-ascii?Q?JVVQH2hEK6R7nEdbceWL2Sh0SJm3kwdKQIAxThUayc+hRuKnd5izZeK7mEA2?= =?us-ascii?Q?KE3CQuc0rw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5513.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d41c144-da56-4913-2ca8-08da5363f67b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2022 08:56:42.8000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QKGD09bGj+OycPZBkMkRscEdnYd1AfISZNPDryS8w6cOPgufnNbv8f8506he2LBZtLNNfB1aAHsCT+Z6aIAwLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6450 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Andrew, > -----Original Message----- > From: wenxuanx.wu@intel.com > Sent: Monday, June 13, 2022 6:26 PM > To: thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Li, Xiaoyun > ; ferruh.yigit@xilinx.com; Singh, Aman Deep > ; dev@dpdk.org; Zhang, Yuying > ; Zhang, Qi Z ; > jerinjacobk@gmail.com > Cc: stephen@networkplumber.org; Wu, WenxuanX > > Subject: [PATCH v9 0/4] add an api to support proto based buffer split >=20 > From: Wenxuan Wu >=20 > Protocol type based buffer split consists of splitting a received packet = into > several separate segments based on the packet content. It is useful in so= me > scenarios, such as GPU acceleration. The splitting will help to enable tr= ue > zero copy and hence improve the performance significantly. >=20 > This patchset aims to support protocol header split based on current buff= er > split. When Rx queue is configured with > RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT offload and corresponding protocol, > packets received will be directly split into different mempools. This protocol based buffer split patch series have been updated to v9. Sincerely thank you for the effort you put into this series. Hope to know your considerations about this series now. Do you think is it possible to get in 22.07? Or there are still some critic= al gaps need to be solved? Because we don't hope the same thing happens in 22.11. Thanks very much. Regards, Xuan >=20 > v8->v9: > * Introduce a new api rte_eth_supported_hdrs_get to retrieve supported > ptypes mask of a pmd to split. > * Fix header protocol split check. > * Support header protocol configuration of rxhdrs by default, e.g. > ipv4, ipv6, mac, inner_mac, outer_mac, l3, l4. > * Refine doc. >=20 > v7->v8: > * Refine ethdev doc. > * Fix header protocol split check. >=20 > v6->v7: > * Fix supported header protocol check. > * Add rxhdrs commands and parameters. >=20 > v5->v6: > * The header split deprecation notice is sent. > * Refine the documents, protocol header based buffer split can actually > support multi-segment split. > * Add buffer split protocol header capability. > * Fix some format issues. >=20 > v4->v5: > * Use protocol and mbuf_offset based buffer split instead of header split= . > * Use RTE_PTYPE* instead of enum rte_eth_rx_header_split_protocol_type. > * Improve the description of rte_eth_rxseg_split.proto. >=20 > v3->v4: > * Use RTE_ETH_RX_HEADER_SPLIT_NONE instead of 0. >=20 > v2->v3: > * Fix a PMD bug. > * Add rx queue header split check. > * Revise the log and doc. >=20 > v1->v2: > * Add support for all header split protocol types. >=20 > Wenxuan Wu (4): > ethdev: introduce protocol header API > ethdev: introduce protocol hdr based buffer split > app/testpmd: add rxhdrs commands and parameters > net/ice: support buffer split in Rx path >=20 > app/test-pmd/cmdline.c | 133 ++++++++++++++- > app/test-pmd/config.c | 75 +++++++++ > app/test-pmd/parameters.c | 15 +- > app/test-pmd/testpmd.c | 6 +- > app/test-pmd/testpmd.h | 6 + > doc/guides/rel_notes/release_22_07.rst | 2 + > drivers/net/ice/ice_ethdev.c | 38 ++++- > drivers/net/ice/ice_rxtx.c | 220 +++++++++++++++++++++---- > drivers/net/ice/ice_rxtx.h | 16 ++ > drivers/net/ice/ice_rxtx_vec_common.h | 3 + > lib/ethdev/ethdev_driver.h | 18 ++ > lib/ethdev/rte_ethdev.c | 61 +++++-- > lib/ethdev/rte_ethdev.h | 36 +++- > lib/ethdev/version.map | 3 + > 14 files changed, 582 insertions(+), 50 deletions(-) >=20 > -- > 2.25.1