From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A99141B86; Tue, 31 Jan 2023 03:28:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB84E40EF0; Tue, 31 Jan 2023 03:27:59 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2049.outbound.protection.outlook.com [40.107.237.49]) by mails.dpdk.org (Postfix) with ESMTP id 3416F40DFB for ; Tue, 31 Jan 2023 03:27:58 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=beay2t0lVlt/amVH2+mSRKvUpLFJaY8RV0kS2wpe3labnmZfct61/kzB3e6PqvLdgOUnVjXsFPs1FjVu3S4QRFzgj0BlctyFMh7XWojQw+gZy40k1f9UB2+fOW7KKeVpLs9caxQPbTEya8AvO5ZEu5WMtu/pesc+7zbNDftaXLWB1CcZ5/Cegp0Cm6MN3WPswJWaIlAu4IZsHl6G/UInXgQkLQ78JwGdzKarxjI7wosW4zBLa4gGksM3nHeKqzJJDCwLdbXvW5iguvjM+jKZWANwDEuhDx74mk5WzK0nxaM8Gcs0DF9bdS+1Ca8j/yy1tciIK9djZ4sT/Jbnpx95wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GmStGMjNMZYIv4QHdVdR+ArGcqwRAd0YsyjGvLGKFgs=; b=Gcbb4leqMBhSjeiL7c808nyTJo4aZ2rkhjAqtrzIkcyjQspbGmGnF5+xK6xh6ldjY0Pw8Yh/6w/4rDEpn75wdx0dgZYMZhcZcXAHrKEfJnzIudxLfJP6KU+LVkKrmN5/k+q/qAx0EI9WYdmhfih4yiGgKxQg8axS3j8l8zgEVY/FCYC58BdgT9aLTQVvSgwaD3qTol/MuK8nxcHHEG/VVoHBzXotrZpam75TDmKwxVLX5pYK/O2PRuNU6eHn7UcX8XL13ZWUFrNfAzhWjU9kKBZUrYl6c2yRb5/ATfUcCkvsvyAFVELAa0HJyQbxTWUWgn2fjUBF+2nT2GoNJ1p9jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GmStGMjNMZYIv4QHdVdR+ArGcqwRAd0YsyjGvLGKFgs=; b=D1ujJSGK/AD34JuuK4l/+th/qmIYGpxVnCq28B7CGU+T2+AuF1DAWZluFV7nW/Ocol0fWN8PX23n6nxVSR3W98icf5nQ/n5Acp8IsFGlSuHRMoGynx8aYLdjo7Eiq+jDmbheSOLaU14rXiL7qqGgsuO2W3RHCa+3+SavyWT5jYh1Sf9bRMzX5NEFpbNOeokv7HWmtcfYtAY98qML07KxUUEqK/fYjuV5qv0sh25CUkLa676C0RhK/arYZldIcFDbZkisu+pd8AuNS23bY322Gabi/98ZyvZeNIiEwWdoBFf9PJiqniHUwTBUtX8KErU5mIewRo7/gopXD5c8QWagOw== Received: from BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) by BL1PR12MB5380.namprd12.prod.outlook.com (2603:10b6:208:314::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 02:27:56 +0000 Received: from BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795]) by BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795%4]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 02:27:56 +0000 From: Rongwei Liu To: Stephen Hemminger CC: Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko , Olivier Matz , "dev@dpdk.org" , Raslan Darawsheh Subject: RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Topic: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Index: AQHZNF9etRydylFxuESS1WiqhsKrHa63LGkAgACgwsA= Date: Tue, 31 Jan 2023 02:27:56 +0000 Message-ID: References: <5da6632a-0976-dc1f-facb-f778c8aad8e6@oktetlabs.ru> <20230130035941.1495874-1-rongweil@nvidia.com> <20230130035941.1495874-2-rongweil@nvidia.com> <20230130084746.101226e2@hermes.local> In-Reply-To: <20230130084746.101226e2@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR12MB5273:EE_|BL1PR12MB5380:EE_ x-ms-office365-filtering-correlation-id: 7b1145fe-3101-4771-871a-08db0332c38d x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o9yB4fLC6AUVkmG3PGU+LPrwrEqKQJa1FRgBpTqTgslSgRMMadOjWia4ZaXVhxCh01yhZV6AJ4LaeiUpKTMUdQvwU10Gxk3DvI4yHbnNdV3VsgdIQ//cxqzNegVItg1Io/+ODs828I9vj2VSvjM9i0D6y+iY7Eavg4a+CWjCitYa5RjM0W1+QYie7NJuVCW+w5WtbtISVspYXbxSB9iyrohWVnCOa8DfWBcuEc6l0LYWKXzckzD1iNZmp0M6mrtpryJD1M7zCIxZxgE9o0g01L9aYVPHGsQ9162dU3v8vBPdm1vtc2IYZIH4oKw1Tq6d8DMK/Xx4WixkLXfarRlvr9PofgVP7FTjd19x6bAsPXqnCOZp3nr4ZO4oVgF9QM1wFYKxS1FkSfReMtMcXH1k2Vm38fJrBRcwpMqjyyG058fynrdvhEpfo78SQHt4njN8bTW/KIroUyYWu5OoOVrW6Ou/3seOWJoWeQQfDy4d0IoqMk5eMmSzRwto1T5PJv8hTqKsnh1BQd4WJ30mGX/3JDZXyhEj8PNbPHSO5gOIgVZibHNkvCNOJHbK6TD9taCIY9E+Pp61h7eR/8PsT68LrqE+pzU/Vkafkhz9CS7/hmYDSMBUnyFHqxYXj/Vr1ScJRzQl7vsuh4EwpnuC8drgH3MbxyRGs8VWBMTVKv3L6RVyx4XN+solsPJtwf/LNl1wvacIVdCZbk5O+4KUCRjUUg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5273.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199018)(71200400001)(7696005)(66476007)(6916009)(64756008)(66556008)(66446008)(76116006)(66946007)(55016003)(8936002)(4326008)(41300700001)(33656002)(8676002)(83380400001)(478600001)(54906003)(52536014)(86362001)(316002)(122000001)(2906002)(38100700002)(26005)(107886003)(5660300002)(38070700005)(53546011)(6506007)(186003)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BbTPFiepAeQLjnVAhX8sLtOOhRWsUJMAvdlMPn86wDHVGWaiJpRtgV7azsTK?= =?us-ascii?Q?/SN6tOuzCFLyLaRM16nF9UbI2hFrr/Cpo4wq5PVKhxes7v/9CwP1aDGXQ7K/?= =?us-ascii?Q?dXlMiDesUhKIxSdzXDfF4C9ODWgyEiLDoytADJckVthK7E4i54wFxJ8qAT9g?= =?us-ascii?Q?Qk/NjlgeQA67UMMGnzdhqFEVQWkwO8D2Sa04jQxlljxQZJ4svIGz7dYYx81o?= =?us-ascii?Q?kn4keLQdrOvJ9IfC2SFTeJOfNOH5dUhU7LbfgT31YsQIXPhuxB6/puS46niC?= =?us-ascii?Q?vAg198+ExeUdH6PBoBc+FL2HKGtPZHvH2hXZB4HCJYpMPklaXOOyJqSHGHw6?= =?us-ascii?Q?gLRV+d17hbAOqObn/5DsCMWUTN/+p1om7XEyv5po3nomblqUftX3OA79D3x2?= =?us-ascii?Q?D6dQBlG+A+gDXmyox7MUFx3hDd8d9GAawdzA4KKQNwrT56QgMQbOQU76kG3p?= =?us-ascii?Q?ctPn6ZtaTjhMQYpEYXHI2ah9M8EVgnrnlZaL3Tly0PWAG9kmyxXnYl0UUEV6?= =?us-ascii?Q?2pa5mCguIY78E/2XhzqKjLmsJINROftYSJ2W1UR1WWK6XSsnZ7d21u+6yUfl?= =?us-ascii?Q?BUyy8KUgB8jEabvl7dIBXIOjFDPkvlPP3LTS6eRVA08c1sLRh3szFvdORWjr?= =?us-ascii?Q?o6EqsPGFPlX8+X+P7+QTPYk1QoW7zvm1Pt2f3nvEUFTl8UhtohqXhkARPuE+?= =?us-ascii?Q?Uy/mtPrQ7LsmEb86xChl9+vJRL3X/ylQ1VGMFApd1SNbREeU4lWZYV8I1Z3v?= =?us-ascii?Q?2Sc81QSDCDiP5ZV6lX826lbbMGGQb9YJMZP0BkWsWL8QCMCUN9sNOy7qFOGe?= =?us-ascii?Q?SVJu8K9FHV/K9B+FZgekfqj8i1Qo015wcaKLUxNNdl+ZHgL+atC2S4MKS013?= =?us-ascii?Q?1a1+QynK7NBIsSWD8dXKtPzsZS5WDnnjfxSjdldqipFk2gU+FrpjkCS3HXaL?= =?us-ascii?Q?HGylegL4GJDi3uUxgD/HV4we1gcs/5P6f4qK1lkwC/r6nS84nO4KAUapwQ+5?= =?us-ascii?Q?kAc7p+eiXTj2slBgDTYOQbOFd2vLHfy+vilk1Eu/K6vlHbALewtFoYgfkM/I?= =?us-ascii?Q?5bRUi8jjwioXEwW+txoGOpZNl7WgRTjAzbRmRaayYUjHlKCsMqFz//0WrOtc?= =?us-ascii?Q?/idp6Gm4K39qjX+4QVx0erhgOk39aFl0l1hQ6WYPJCgE8EfBERdMSUBwpzul?= =?us-ascii?Q?BaFA2FaeD71DUDYd7L3zDaHpMGQ1yYta0Ym/Oolh56OE7Lt9ZxlkG5nSPreg?= =?us-ascii?Q?h0XccC0g03BrkM1ezyE/JOZeTLkN8yJIBPEkLDOvbrAZxm2nDyfraPoQ/KE5?= =?us-ascii?Q?NPWIfqjwpC2TwRv4rsURM1bzO/ww6045lu3+Un3Vomw6zqY/TJzMk9LRXaAj?= =?us-ascii?Q?WtO2N3CGCCUYpTZVyQKmZ89/jCbvDNH3xQ9cBUb/uhLZ6yE9nA2iOzVyYwK3?= =?us-ascii?Q?K3QauMKPFEZ44cXnOow6m2nlelO7gGnXF0arRZN6nQufqZiDqtxd29dHMN22?= =?us-ascii?Q?Y1KExZVg3LrMnCKpzI670VxnLNJgIbcWq/zJF9R98hyrpYKu8bzArCL9TzWg?= =?us-ascii?Q?cLCz1aC4kOfFfGx4n6h8V45QJU2K6mNsZMTG0vHe?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5273.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b1145fe-3101-4771-871a-08db0332c38d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 02:27:56.6033 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /QTg0JKCUAkU3ocXO3qsLPU7pxRma14cYEJXVf8eo3Z5rvhcqByfCags6p9zfBc0OR9acmccTJafeOkMnySxRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5380 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org HI Stephen BR Rongwei > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 00:48 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko > ; Olivier Matz ; > dev@dpdk.org; Raslan Darawsheh > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header > definition >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Mon, 30 Jan 2023 05:59:33 +0200 > Rongwei Liu wrote: >=20 > > > > +/** > > + * IPv6 Routing Extension Header > > + */ > > +struct rte_ipv6_routing_ext { > > + uint8_t next_hdr; /**< Protocol, next heade= r. */ > > + uint8_t hdr_len; /**< Header length. */ > > + uint8_t type; /**< Extension header typ= e. */ > > + uint8_t segments_left; /**< Valid segments numbe= r. */ > > + __extension__ > > + union { > > + rte_be32_t flags; > > + struct { > > + uint8_t last_entry; /**< The last_entry field= of SRH */ > > + uint8_t flag; /**< Packet flag. */ > > + rte_be16_t tag; /**< Packet tag. */ > > + }; > > + }; > > + __extension__ > > + rte_be32_t segments[0]; /**< Each hop IPv6 addres= s. */ >=20 > Use flex array rather than zero size. > Zero size arrays cause warnings with later compilers. Using flex array helps improve this network header definition but caused wa= rning in the rte_flow_item_** struct rte_flow_item_ipv6_routing_ext { struct rte_ipv6_routing_ext hdr; = = = =20 };=20 "invalid use of structure with flexible array member [-Werror=3Dpedantic]"