From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A53A641B88; Tue, 31 Jan 2023 04:24:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91D0A410E6; Tue, 31 Jan 2023 04:24:38 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 6C23540DFB for ; Tue, 31 Jan 2023 04:24:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y3lJEp+N/ZrNM2w0wRREhURiYDTZvt0s7fV7/owqtOX9vyKhd9UD0HFHh6GGMrpezBHDP0pTAFp9XViRVgt4hP59x3JgEHo/1UIiY4GEEz0WLQcItbWUnHIIun4kVX20TCHCT+/4to3hcBxlWlww+RyR//Lmq2pni8PV2FulKicwIcVNj2KMoR5nglzVFw1GTjcF8QGBgP/sRzuv1zZ2h0EwOFxR40nU4xSs/8VTtPbW2xpMsQxHQY7OX8fk1Aiu93OMmNqoE9Rau5h1ledV+vwA7GDy5TgyOU/wRtMQ+ZAJerVHnzfcrtOQ2Gpd6ZiETXqs3cxRLJ+0OClk9MNaqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CHqVWp5+06/y0M2LlnKWRGm+MCbTv+wuaeJ16Yw6w4I=; b=Hc6J3oULAYL5MnI8FUKdvtiJcSFP0qYAb/hBwIigsLnglg8KfKGEVaXhoursK99EN3f0k/gKG0wa1jdm/0+N25MyVL9DwV5YKmXjVEO0EDaH9y+ThukVbj7M4CV5clykMjq2lASo0Laf4Sf0ZQEmTYpeTPqUmMSTls2eyDOS6u9Wm36cvL1yl0vqi05CWBQKt/8zHEfC3hJe0J5ENRFmnl/N9WLKLu9b84BFgizy90Vc+b4O5QeBlt5cRGv9gCeELjyR6rQavFMAx8VtljBpd1T0g6ic3hTlcR4JlduD46otwL4embE1XbfIZfeyOnuM8YZpHhN8ciwNP9u5SFfPjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CHqVWp5+06/y0M2LlnKWRGm+MCbTv+wuaeJ16Yw6w4I=; b=HxyYnbtmhFnfkSrM6DU+cSRHkbxK2YbY6oAhsbq+9KnR/NbSBnXp7/lAU90ovWRzpUCG+J/e9ys/bDCD/3bCH88JvsKjuO/B/nXnHTW8fYL3Nt2fvnIIFKd2nQnzCWNz49yKWMxg3ZINI0OAgnLnczKxJOn+EftVPAU+xfkW2JmUs2MXhL5l8A7fb3P3JfAP8mRk7R9UMRb9Usm5jIvj3UtfxGkWrGTS5NisTxyWcP5FGMuNww58vV7A08Ej8SceL+mv/4OFrhyasZqxocO0bTQvHQkxEHv3rdbKdAmZRsugU4HkcKMl3omJfLYAwykhUmg3Yzpl5KtKH43uya0WLg== Received: from BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) by IA0PR12MB7697.namprd12.prod.outlook.com (2603:10b6:208:433::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 03:24:35 +0000 Received: from BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795]) by BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795%4]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 03:24:35 +0000 From: Rongwei Liu To: Stephen Hemminger , Andrew Rybchenko CC: Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Aman Singh , Yuying Zhang , Ferruh Yigit , Olivier Matz , "dev@dpdk.org" , Raslan Darawsheh Subject: RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Topic: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Index: AQHZNF9etRydylFxuESS1WiqhsKrHa632BwAgAADCUA= Date: Tue, 31 Jan 2023 03:24:35 +0000 Message-ID: References: <5da6632a-0976-dc1f-facb-f778c8aad8e6@oktetlabs.ru> <20230130035941.1495874-1-rongweil@nvidia.com> <20230130035941.1495874-2-rongweil@nvidia.com> <20230130190218.0f6b1b5c@hermes.local> In-Reply-To: <20230130190218.0f6b1b5c@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-Mentions: andrew.rybchenko@oktetlabs.ru X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR12MB5273:EE_|IA0PR12MB7697:EE_ x-ms-office365-filtering-correlation-id: 3e246cf3-4cca-4c98-43ec-08db033aad73 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xyPiJvtOkCGCX+Zie4bROq9Z72ICZrAAoDKWJq016obSkk4syVQUKZLHSrvls8j/JlTCOk48SYROYB5IZn8kbMlrhtWIDiXJwgsAx8QhGOBX99yuzIQx3lfKMpyKNgY1L9ansLgWV6A09lzBtOnA5HAcirXKnBBWuLWE6fUBlTOq1vH5JEwS2QssJP0VvXaqcnRz65hsj1Rb4L5E+AnowOuQbpZOxu7cBZp9AMWxwmgD5rFhX3phRopgAb50jv+hX/n5vXwW35UJYYXqpK0ZNSnW02lTgl32r+r/p9g854hR1+A3M15zDkLGEx5kMPE8wK/tMA6rWqS5UbkzXrLgJabty7v8Jj4NJEyWXx+y2mxIUlCdiB2INZkpjk1Ea2qnruRBfXSkiSQfa7/LzniRrG4zytzvbBLqSRT6m+VIoYKbDiElfEkyp/SvGtIDZvM8bgiCDfFkk6kU+2weBMgAZnYMqUdMcs95mZ4VeGmbB4g94WAuFa0/ajrSBJz7ThNg5XV2gMgL9hExYO5leMmHdzBkmdrb48ZGq/3NpX8pgQP/9uHGf2j3fyHJjg6RLfD34jhh+fspSV+1AFqtcpFmbG2rjm/v8SfGf13LJHe3P2csJYMcJ70itHiVyqybcHWF6FV41yZUdu1PHQnMkfWtKKY0H99VzJFMK1299c93WY/8KjDN+IfzTjopDfDD2Qon6N9FlXbISQZC+FIcpTeO3Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5273.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199018)(33656002)(66946007)(66476007)(66556008)(64756008)(66446008)(316002)(54906003)(110136005)(8676002)(4326008)(76116006)(41300700001)(8936002)(5660300002)(52536014)(86362001)(38100700002)(122000001)(38070700005)(107886003)(6506007)(53546011)(186003)(9686003)(26005)(71200400001)(83380400001)(55016003)(2906002)(7696005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ed2a9GwWWo55EGghISE3c3IjM76wpXzzeWM5FGMCK0TbqQ/fcIzTwlUJQoNV?= =?us-ascii?Q?RMr6n37rj4iKTpeG3ygcUb9LyPnaxfKtfxSPO4ziRFtWOobhD80ZjEXa85Lp?= =?us-ascii?Q?QJ+p/X9qRvGjVaVc5XDtgAwfa86CVYfZwsci1NOdU1MwBECVMMJCad8j8+vV?= =?us-ascii?Q?AaKLbbvu0MQzPRlETu1BxCF0WZiwG6lw3X/rCRe9wl67TUgpUMDgUYGzdUtk?= =?us-ascii?Q?9NF1Dzdc6EWAraBBF69DdIW0vpg9B1R95c5hiiMnPwTVO3KOzteqSeZBw04L?= =?us-ascii?Q?PXAGevmviui6JVws1P/sIa0AqnmnPqfeOM23fJ7LSwf0H7mBr34wKfohzlMG?= =?us-ascii?Q?ytb6D0Bo5ZyqjSCog3CsKbSY+jh6qWaHgfca2p9v5TV8SaPf+4wZBfYfmImT?= =?us-ascii?Q?944NUA8R0vgmcE6Qwx4FAas4yIpHnKwmBhECSe2+fkxfF0OUli1qQrm7+9he?= =?us-ascii?Q?4msquiu311+uhPXc5h0dpl3/+KmfeTTQ/2UrbeL7mzV2QeOFM+ifTNWAvC4R?= =?us-ascii?Q?ky/8hWRUmrLuoy9xFfj/pewK6P70RAbAxC1O/KN/g+65bRy2b3M9F+cvSvad?= =?us-ascii?Q?V/jPJtHbikfX8QofsK4cg5R/ggftkvtnWEWuyNiYDpJhfvf7vpTb80jcoNcq?= =?us-ascii?Q?nVGdwjks39O5IXvdfEA0pnl6iqDY7aAkED0Sk/UCJUu9oi5tOyLmlHR4q4Bu?= =?us-ascii?Q?m8pUfQFFEFefGe5adDX/ngF68JRhZQHLXxXq+0nxii4ztOVbPVsFbLOuORYY?= =?us-ascii?Q?K4bpSMM3xoyJu2UVQuPZ3ZzbLerFERYpP/XntgiTtuBonIRVYWlZiExWQsCu?= =?us-ascii?Q?VP7flh+lARN+3WP8t0+Jz4BMLo0hBf+cczKNiiZGHxHmoDy6h2T8pSt04jCO?= =?us-ascii?Q?gZkE/cd10MDIq+QWSWvU+xHUtAMmmlEAkCPNg1WGVhoIKciXIZ248tcQwhxY?= =?us-ascii?Q?ys/Cb1VYRsT77x96/Zi1Ay36iA/4sBEVLyIPkAFnShE1pIXudakscn+O9Zlm?= =?us-ascii?Q?86JpIudx4YhCpXwNRsiX88uvZtSE3bBTPRye9/v0f3wb0Uk7EJLxiuw3xd2x?= =?us-ascii?Q?0C5rxuq23d7pO0MyN7ow1l+KJRFMY5cIXM0mxiS6UYKhML6dAxd4R4fXy76X?= =?us-ascii?Q?AXKzE3pqdKaDaxxUm17t/El1mEHilGyZkHHmn8+ivba9MgRies2Dq6mmWpCU?= =?us-ascii?Q?VWc3K1IOSEFuOJNBoYPsxcUyYCyzwQ/qtDuqn3O81DZQlxSbL/ApPekQEcfJ?= =?us-ascii?Q?fckxuIEQnHkbdPsIXNoz30n6jPIvFG8AuusMpA3D9ioev1S7iwWrqwze5p8L?= =?us-ascii?Q?w6iaxGw+Srw78jYjSWCjkphBEGPGr8DFDvOd0SxaF+1WwQhjLV2NL9weMxmH?= =?us-ascii?Q?JnvhilmzvotGGbSKXUXmrywWlsMzYYdWlSdyAvYzVfYsTVVL3uz8lAuQo49v?= =?us-ascii?Q?KGBme/aASiCJYT617F8Fvp9Fjwbj/qUJ4L3DQ2NK9LXZnsSF5NlQt/O7Hpex?= =?us-ascii?Q?ROPywq7Z/GBPZ3M2HKL9jM1QkcQq2iKJ5iwGa/V8fY8Ihzx4F0hddC90M9Yl?= =?us-ascii?Q?4eg4A/73upD3Kc3oOB/lUsvDRn0DX+TNUnrsDhA+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5273.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e246cf3-4cca-4c98-43ec-08db033aad73 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 03:24:35.5431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sp6FAB/ejRQZQ5SmTM7yDpva78lvQ3LsjVu+ZwjQnySw0Gpbszus0vv4Kq4sECqRWkLTN6TZ7ATxnbA1TiKcVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7697 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Stephen BR Rongwei > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 11:02 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko > ; Olivier Matz ; > dev@dpdk.org; Raslan Darawsheh > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header > definition >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Mon, 30 Jan 2023 05:59:33 +0200 > Rongwei Liu wrote: >=20 > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this structure may change without prior notice > > + * > > + * RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT. > > + * > > + * Matches an IPv6 routing extension header. > > + */ > > +struct rte_flow_item_ipv6_routing_ext { > > + struct rte_ipv6_routing_ext hdr; }; >=20 > The problem with nesting a variable length structure inside another struc= ture > is not allowed. >=20 > The issue is that the applicaiton would have to pass a variable length st= ructure > in for the flow definition. The flow item is variable length for this typ= e? all the > others are fixed length. >=20 Yeah, segments_left is uint8 per definition. RFC doesn't set an upper limit= ation. It stands for intermediate routing nodes between src and dst nodes. > One option would be to get rid of the wrapper structure. Yeah, it works. @Andrew Rybchenko Can you share your preference here?