From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 585C741B88; Tue, 31 Jan 2023 04:20:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1167841138; Tue, 31 Jan 2023 04:20:34 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2040.outbound.protection.outlook.com [40.107.220.40]) by mails.dpdk.org (Postfix) with ESMTP id 8389840DFB for ; Tue, 31 Jan 2023 04:20:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=neCif08zHYIF58AxunhnkF5Xzujp6XrVBrP6pxeqpPMsNRKFS3gtDkQXYZ9JleG7UkREX0/bApVDc5mrOz4rh1lVjXUOAUSrunlgknpyrdH6f2/UqHWYhlUxvgwjXDWF4OLZTtnvnl8/QvJOBegCSRNuPbezKxx9fLJfcMAwsz/639SIYGgZp4T5qL/Ysts83UJquNmi5urvgu+jecsx3Erp1vnov0JuSLlL7wlldhsEFALA2iO29FYI2rcLThEP2KnklzffadOtBDgIE2LSWhfFCvf+NKfjrV2gf2Y+XiZQf0L/9p8Y+dlswnsPZNPi/7fO8ViBSjKGXv4lpRXnrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yB9+rSR3zU8pTFZSu4OSiX+tbtBNXsQUan05E3lHNxg=; b=jfBepESU7xPpg6kJ3HjKhTUrSar+ywYJ9yCH8du1/H5fglCUrmaSKi49CgovSXZ100oZ8+zE0JvZGCZ5KhzxfClRVMDWvaWPzCDRrCwSacs532YK0hVVpLPrgwB8G+U0Jcx39m2qsk2o5OHFE2Qf4N2NXPWVD/ZKiXqds3lqgv2kaFTnszgQMnWM0mpyhChAsG5DWKKeutNxiwht9JItbLczLtvlbIbFlT5G+m+ctrxhvx6ncWGEjx6bHszZCWZRs0PdjsAnyaiPzHq0b0GpHCpRaHexFEPCda2zajaMgZvVDoNzF0Z4AEJrXysUd4W95GV22jYHsi9i2MHzFCvPAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yB9+rSR3zU8pTFZSu4OSiX+tbtBNXsQUan05E3lHNxg=; b=CC6iTBGwjD83HRYGJUcflf5wmz5fZ6VYz5H04UY38aqCVscgwae2xWDPX/w9/N3ae7nn5ykvXxK9YsYjZf4/XEUiZqWKMs/l+82x2Wjk3iXAh/shFTJkv4r01kLzdVvunngcXyG9g04jjWVR0VI5eJLWQAo0NKr5Elit4TxVDSd4YlUnd60mxYT5x6zxIlHYbdgV+8noKYz0mq9f9dN5IBfturhcl05sivPD2vnUmQy63ceYp7jRiN7DP7bsyKUfRluqd4qzgxSf2WrCiDDFdgY+kl8ZPFKSFgFM9XN6CL+/bDZXYJ2Y8eqpoF3mDKFJQXmht8XWFx3EjzNsRMw5zg== Received: from BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) by IA0PR12MB7697.namprd12.prod.outlook.com (2603:10b6:208:433::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 03:20:27 +0000 Received: from BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795]) by BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795%4]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 03:20:27 +0000 From: Rongwei Liu To: Stephen Hemminger CC: Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Aman Singh , Yuying Zhang , Ferruh Yigit , Andrew Rybchenko , Olivier Matz , "dev@dpdk.org" , Raslan Darawsheh Subject: RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Topic: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Index: AQHZNF9etRydylFxuESS1WiqhsKrHa63LGkAgACgwsCAAAkmgIAABrsQ Date: Tue, 31 Jan 2023 03:20:27 +0000 Message-ID: References: <5da6632a-0976-dc1f-facb-f778c8aad8e6@oktetlabs.ru> <20230130035941.1495874-1-rongweil@nvidia.com> <20230130035941.1495874-2-rongweil@nvidia.com> <20230130084746.101226e2@hermes.local> <20230130185553.2b97153f@hermes.local> In-Reply-To: <20230130185553.2b97153f@hermes.local> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR12MB5273:EE_|IA0PR12MB7697:EE_ x-ms-office365-filtering-correlation-id: 49cb1cb2-ed87-4949-1a76-08db033a19ac x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7OZra3Ux62zZsko3Qi58GbEOL/LXDmZA/Y9OfilCbGZTWhl9TA2uE733L5qphnxkthfNrJ/lY4Wz4BDQzvZ2A5zruHaNEWuaqXzGonAuvY6XlBl/aRHq5CIfLNOkXQfRJEXGi/niOAZSE6MI6bRywsrEj1FJOurg+4OBe5CVodH56f57vho8t9b4RErVIXOU4hN+CotVtXXO2qtUnazJeqzbq0DLTicIMmb0sgtv8JQ4BbLCxgIJMhkJmiWb3uDhbvSl75kcDNkF54/0zvG4YNXknu1PqwUSWMXtmR9aZBBJ6qse0tU/WPbq2aiQe60WwQefIcd51mUEhGs7FaxX3AllgWc7zFrfz7cMdHdvE3A2ShjDO1I3YSoI+oKbp88yIpg1OUq1Pspo+0BLWhaJOXipCSfiaItNlDrNLM59Ui1XI1u7nozE9nlwZr2UFxpih5LzBieAdgYKJ8XY5F8wMPbtj8SFb/+iOMMvPIKU9ht2mHJ1PQqQsvspBIsDSNVTg0dbLu+jLq5pW9kvZHXRVx3eB33k7aQIGvNUXWoddCLZCEgCw529LX3PgBxAWgS0P0LvER5IDNPh9/W3VEWhP8RAfADdpm5rLoPJYGgEeyIy4hUO7xsmspW4AXSfzHGsY3v8kcbCnf3BGzbFNWQGHXWDOzlONollUe3h1T/0KnM//46Al+JdfGs+ZjxLGbDVAGG64VsaJkcivdIPgQaFJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5273.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(136003)(346002)(39860400002)(376002)(396003)(366004)(451199018)(33656002)(66946007)(6916009)(66476007)(66556008)(64756008)(66446008)(316002)(54906003)(8676002)(4326008)(76116006)(41300700001)(8936002)(5660300002)(52536014)(86362001)(38100700002)(122000001)(38070700005)(107886003)(6506007)(53546011)(186003)(9686003)(26005)(71200400001)(83380400001)(55016003)(2906002)(7696005)(478600001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DigqF3/zmy6hKbJA5PL7H6B9/kTAdL587dDSAX43OIq026WLekjr3SH+YpbQ?= =?us-ascii?Q?KOJDw7Y05VAv3LemUDofQavMNOrvxwEVtDalX3sb8D373ycgb11qUFYX+xa3?= =?us-ascii?Q?Z02JKJrZiQthasQFFwTSBi1NckKc3AU5THcgaHqbbLUBxKadOO7SlKGoyHBw?= =?us-ascii?Q?Xz2f9IJGmqSp8Ob0VOom2EI2wdrf7HoQR/RCRCM28mCtEgbBmwwF1ION0coH?= =?us-ascii?Q?SF8oJE+x+M2dFHUMPAgeOfeQmsTivlHNQiukrrpmYsEV6OUWItENj95gx8MH?= =?us-ascii?Q?TcGyvLgmJAHW0UmsyWr+0rwapLYZhb7mxy0GkzSTvUqN0W6jvfJ/Ik/2NJyP?= =?us-ascii?Q?0AWUjv4xUVejHfJR7yNNUhxKxtstXB5a2PmjIc55TzF7CGyObDFbQzfl9uOv?= =?us-ascii?Q?ydmn1XU4BbzDq+FzQeXjW13ZR/CJqRyVGqxUWzEjqQmpsN5xEUJIVBQ6bUbl?= =?us-ascii?Q?Ew2bHxCts/o2wCeqziDdeFAJK20TLztjwuO/zEO+bJ4zqv/XVgjWHfbCGfwg?= =?us-ascii?Q?hVqB2CDnopjUYIlrJTBok71QVxCWsyTQifMrsWd6kG/j6l9UfHUAeGu4a9Dd?= =?us-ascii?Q?Jhq1Aq6q1gfFWdEVqZWMig2XnshHJb7ESN/gimiZhQSMU+ifaHGAAi6so/o2?= =?us-ascii?Q?J5DpXk4tIQQFWgWBcxabUufMRpOnG0+eoQ51/TnUxuLiVa3x0ozypWxSDHR+?= =?us-ascii?Q?GTwpLcnrERgl0pxBnvFYp75Oa6cYnHvQPhJnhlLUx4ewMpZc8/8EoBk4lgut?= =?us-ascii?Q?TYHDg8dId6ISrA2oi9xQYCFfUFMaxlYP8L1nyfWHCbSgptnePwzzyickn36c?= =?us-ascii?Q?ZOQGQr5xDDZZSXCCZC2jOgL+pNcevBPnGoBSQ2JGDmMlxnBoIMKvYFQrK+pq?= =?us-ascii?Q?1gt383xcqsETQQW01S5QQWl5uAlWyNUTRhhWFcNDpNx7HS8fRSMSLVy4r6ie?= =?us-ascii?Q?GGjWYylh2+L7Fip7boK5rhQwc6Nu7rzBq8OZNclwa9FQ/Z7tY47JrqldH0qD?= =?us-ascii?Q?Cgtm2OhrVygNKn6ssv+ez2oPVuVO+GOlpMctmfNTMz5DW4V2dq5d0zwYGhJ5?= =?us-ascii?Q?dtjTnHrJrk82tp+ZHrAvY1axnPdWG5zdzFAY1unD7wa49qmN9S+Er8vDZdQV?= =?us-ascii?Q?NShFWLbVqQuz8NMXaRZZBepv0xL84L7/J2WbpL16LN6LdJ2i2cLGmXET0EM6?= =?us-ascii?Q?RFjC/xFn5BM74nrI2HCvsDp2AG27vTph8lSZdakiet0JAggxFvZoCR1aYpIg?= =?us-ascii?Q?l6w8ocZlqWm28NShNN5zhPYavYNRlcoS3hgFVUsLe8ZUpmjuUviIPmZxOqrT?= =?us-ascii?Q?cEZihaXwkdRk9OsD+Mi9rQt3/mhK+HcBPm+tr3RefUEua4F7rcjo7uoiJ077?= =?us-ascii?Q?o+UGwhNxzRT5CwHkDpjLqDmzuRWqKED2GX/1V8H3aqDZu6Eor9KqCFQuTkRf?= =?us-ascii?Q?YmeSeESqMNXacMi5qqO2/u7ISY1rZLFSwA9ti0Zf0lz+o4QKoEkf4556+fZ6?= =?us-ascii?Q?lzjXvzxB35EHwt27nOonC7ocExPte/SyqL08DRVEfNapAp+c53DkDdB+HSjf?= =?us-ascii?Q?gfSjrq+PRfTLiWgs4m2AZ/D5hPbDTS+N7VN95VmO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5273.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49cb1cb2-ed87-4949-1a76-08db033a19ac X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 03:20:27.6440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I7GVcemONwp9Q5AXa+HfROw0nr8u3RW9ZLW8OfdKZy/ZSANU/DRTFBDxyCvLoPhGxN/9Nh3TIl53mMvDlfbYiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7697 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org HI Stephen BR Rongwei > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, January 31, 2023 10:56 > To: Rongwei Liu > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Andrew Rybchenko > ; Olivier Matz ; > dev@dpdk.org; Raslan Darawsheh > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header > definition >=20 > External email: Use caution opening links or attachments >=20 >=20 > On Tue, 31 Jan 2023 02:27:56 +0000 > Rongwei Liu wrote: >=20 > > HI Stephen > > > > BR > > Rongwei > > > > > -----Original Message----- > > > From: Stephen Hemminger > > > Sent: Tuesday, January 31, 2023 00:48 > > > To: Rongwei Liu > > > Cc: Matan Azrad ; Slava Ovsiienko > > > ; Ori Kam ; NBU-Contact- > > > Thomas Monjalon (EXTERNAL) ; Aman Singh > > > ; Yuying Zhang ; > > > Ferruh Yigit ; Andrew Rybchenko > > > ; Olivier Matz > > > ; dev@dpdk.org; Raslan Darawsheh > > > > > > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension > > > header definition > > > > > > External email: Use caution opening links or attachments > > > > > > > > > On Mon, 30 Jan 2023 05:59:33 +0200 > > > Rongwei Liu wrote: > > > > > > > > > > > +/** > > > > + * IPv6 Routing Extension Header > > > > + */ > > > > +struct rte_ipv6_routing_ext { > > > > + uint8_t next_hdr; /**< Protocol, next h= eader. */ > > > > + uint8_t hdr_len; /**< Header length. *= / > > > > + uint8_t type; /**< Extension header= type. */ > > > > + uint8_t segments_left; /**< Valid segments n= umber. */ > > > > + __extension__ > > > > + union { > > > > + rte_be32_t flags; > > > > + struct { > > > > + uint8_t last_entry; /**< The last_entry f= ield of SRH */ > > > > + uint8_t flag; /**< Packet flag. */ > > > > + rte_be16_t tag; /**< Packet tag. */ > > > > + }; > > > > + }; > > > > + __extension__ > > > > + rte_be32_t segments[0]; /**< Each hop IPv6 ad= dress. */ > > > > > > Use flex array rather than zero size. > > > Zero size arrays cause warnings with later compilers. > > Using flex array helps improve this network header definition but > > caused warning in the rte_flow_item_** struct > rte_flow_item_ipv6_routing_ext { > > struct rte_ipv6_routing_ext hdr; }; "invalid use of structure > > with flexible array member [-Werror=3Dpedantic]" >=20 > Not sure, only Nvidia/Mellanox messes with pedantic This is caused by failsafe driver. In file included from ../drivers/net/failsafe/failsafe_ether.c:8: ../lib/ethdev/rte_flow.h:892:44: error: invalid use of structure with flexi= ble array member [-Werror=3Dpedantic] __extension__ struct rte_ipv6_routing_ext hdr; ^~~