From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A03E541B8D; Tue, 31 Jan 2023 10:18:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B83F40E28; Tue, 31 Jan 2023 10:18:37 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2040.outbound.protection.outlook.com [40.107.101.40]) by mails.dpdk.org (Postfix) with ESMTP id 9C08C40DFB for ; Tue, 31 Jan 2023 10:18:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hhWCR7txFuQv/IGKkOgocnEa/i5h3yARzXdMTzv6gFyou6sJzSF1fOEfMQMVW1wjHiCE0O6DLWwZZIdtF0/R6znBxqH8X7SGmvttDWHbNpbm+wcqzZdXw9Z1P86fn4YruHpvtQouARjM1LxFcorcUKyFTdzCxgkfnqI5sggx5gKBHPG1pmNbQCBOe5Liz2gOqqfRXuGvQLqINhnP2Zk0hfvlWtsLc3ggZH66lejxlWQ8B8/pS+l4pIMThCPXZaQl0zKOfGpHwCPaf84CTBC1OBKrmkE7oq1NIjvzB48JWsSJlFAVLpIpq4xXxhZ81XOkc5zNcA57xYMJ79lr8m+Y4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MJDav3tADWHZM7gONXvzvhbuC/dveMNbEOvjMST7ax8=; b=WI2fyrpmgkaZL3ucCDd05DYEjZ3qqtnSWeRyKiyvV34UQ6eXbzRPinIIumHlTb16QMl5xdO29RwKGt7y536OUqPr7DMf5vmzQ4hL+pqi814bfUzLoRL9AbCbTudNCQpCW/WcwHXZJBM5BWlIdM/GRccNXelyTLgPc4cjMiG5DRB0edZ8mDdsOPp+ZEI2C1YiiNoizysjF9SZVZMIWmK87/2zuy1DNXlMABhmxUT93ogjgia6T55SFqU1u6JIKHHKN6gOQu9IDVmoxSai26pm0679T7oB11uSJ3M34jMRucDL0to93j92PHvL3X+rD41UpHFn4rP1V8RPFV4sE2JHNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MJDav3tADWHZM7gONXvzvhbuC/dveMNbEOvjMST7ax8=; b=Ah/laLjnlE3xoFtm5pLNAyWZ7ECTwtCR1uyO7+lU1FKqnLZPNiM6i24Bn51BiJDeqTSLwEVJr6zVerFERIWIDvHVJCCrtQivj3ZilSXQo7YqHpQvH5FOKqjBHRS+LucNk9bsuZQ1mu67RORWVt8eG2GqabKNEUslpSGSC/sKtDtDaAmjM5ft0jIbUgShJ/bD2XM5wESGysoZprHoNK9tiysotnTbLuxhWvA587GymGAhZr8kSddiPuD+sLCPWzlhpthZD21UZ1dVOIE3cpxb+rMqQe3liJqkjjuwg1RvagiyD546VcaVECyxlmjtiVy2i1SIShJ/sfZY8y0a1lt8FA== Received: from BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) by SJ0PR12MB7081.namprd12.prod.outlook.com (2603:10b6:a03:4ae::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 09:18:33 +0000 Received: from BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795]) by BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::2296:10b9:2661:d795%5]) with mapi id 15.20.6043.038; Tue, 31 Jan 2023 09:18:32 +0000 From: Rongwei Liu To: Stephen Hemminger , Andrew Rybchenko CC: Matan Azrad , Slava Ovsiienko , Ori Kam , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Aman Singh , Yuying Zhang , Ferruh Yigit , Olivier Matz , "dev@dpdk.org" , Raslan Darawsheh Subject: RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Topic: [PATCH v3 1/8] ethdev: add IPv6 routing extension header definition Thread-Index: AQHZNF9etRydylFxuESS1WiqhsKrHa632BwAgAADCUCAAFMqgA== Date: Tue, 31 Jan 2023 09:18:32 +0000 Message-ID: References: <5da6632a-0976-dc1f-facb-f778c8aad8e6@oktetlabs.ru> <20230130035941.1495874-1-rongweil@nvidia.com> <20230130035941.1495874-2-rongweil@nvidia.com> <20230130190218.0f6b1b5c@hermes.local> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR12MB5273:EE_|SJ0PR12MB7081:EE_ x-ms-office365-filtering-correlation-id: f8ff69eb-b839-4496-8e18-08db036c1fa3 x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iPT21BFVnZECWMkjR99QO8nPK9dQXln0eb4cu/D0zpXxjOnidR7lhk6DS8UuN0Q/7KK/yFjr+VeSiQGr79zlqqcQLGLg0YDIALK40/R+crolVM5Vs7itbigbKNPG4tN0nNIMWY8zbJqbJ8ls7tGFQMCZxVL+Z2D1UI7Br74310cNjwmurGcuXF9v56jUldPUzQRgs3px94M4tGuccZ+KvCE73qbv1A5w8Io93pTM03yKsV9L83kVHjl4Xg/PBxchzx8Uerx5KwndijTCJnM5Y805BOGgCROVh8cYAzTwnqmEHEQhXMe1ZkPGcFTMgjXtPxVujkEQ49Ud4xA/YBC6G0kFxKtM+Rf+1XwZmKwLYGQwOiEbO4aBL2NgCeAv349iRsLSXJnDx5DTsUWu8CZ8+hch3ne52sLyekT14kKhEl5O1HOageK7lSxn5/c3P1hMEpjTvU5lw/pSE84uNdMDLogkS0oSL/s3gb7tyPyrbuyZZlbB2BwbYAF+Kq2vHsP/yXLCnhyJwSYm19hhzAbGnvFcRJvPX3xNmiqiD9iCItTPIserNF/vPKIs4yCGRHmYM8tcF6h/O0pDI59ZWSsHa2Pkn6+yB+KdnPcgroVFUl/1z755AjxRSoJSxYwhLxJtiQAVsn6s/DDuv7cAm/2FMwYZQeHcaiSGlPOdAsyIJYIFf6rSGiCOTci6vl07wdxgfs31FElVIVnkPc3IVYUQ0g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5273.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(396003)(366004)(376002)(136003)(346002)(451199018)(71200400001)(107886003)(316002)(110136005)(54906003)(7696005)(83380400001)(2906002)(33656002)(122000001)(38100700002)(6506007)(53546011)(4326008)(64756008)(66446008)(8676002)(76116006)(66476007)(66556008)(2940100002)(186003)(9686003)(478600001)(26005)(66946007)(41300700001)(55016003)(86362001)(52536014)(8936002)(38070700005)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GOS/gySpDiMgwS8WM0AfYB33c8lG1Butmd2mAG/KdO8Z8LPFVzxoNDxODhP6?= =?us-ascii?Q?SZgtHfYDKKSpq6o/GV7pnBo7hwmrdaNqtuiC1+8hdFR+R+9hm14ioI9l5QVR?= =?us-ascii?Q?7mW9LDeRxEpqa+tRIKeS6xfXyTOlnpp+AVyVEQwssps+LR7CV9PpX/c/9C68?= =?us-ascii?Q?M+/lAbdwLiAfhJIJpJz8cKFMZHTqWhfSdMVnuOc6SRO2D8346Y+nVZhXZK+b?= =?us-ascii?Q?S8hDMJPB+kX0wo5cih+nJwqsiasJf6iwiXk7IGN5p29XtJlAaIOV7/Cosg+8?= =?us-ascii?Q?eUPWnFSWcc1PuvcQV5KFjX33aTQlamixOgJ+kmEL4GzkV03Ws63s3X2zvyc0?= =?us-ascii?Q?opkt2mj9Z3yZcXarT+d1d0XbUhuzfocEYHhB1LLWn0PoQShXpZ1uhpzzFHHb?= =?us-ascii?Q?tTYnLMXrV0fgSYfRhXnVjJD13S8fgVtm1dohcoUjisxn3N8BBaoWwr56sbVe?= =?us-ascii?Q?Ap66ZA2KFP8M9wXM0OpQxCvOFXwCbj1jS0Tzj++2UCZRuJdkplH8//O7q+a6?= =?us-ascii?Q?LXbfBfsQPfZagia13fMSRzTnt+yz4orUhHl4c0znKtmQ8+ZB71jPFLicte4p?= =?us-ascii?Q?x06bk2kJzmUuoXZYlpBs1c9CbyTCCNI3vuhsSPxhXQ2ftjXrQizkzEB6HAdr?= =?us-ascii?Q?9B7udGDNJrInP4TKqgbsdC0L3tn35zoRHSt/nELuAMNppFI56PSVXLWsHQ+/?= =?us-ascii?Q?7O2ODV/H9MxMlMOuN6FUS1VceuKULv5Tgv5Lb0MHlJ9lIxXd64gkan4kGBJU?= =?us-ascii?Q?DiJs7WKydd+hVO3QU4LlTZqGXKCjthYxKrLsC5J2Ft81grmDcRQXx+kbzEo4?= =?us-ascii?Q?x4sDnAmOVFXTceJhkBeSHJ13EcDBAKUZfLMXIPY5Ca1ETJM+WTtruTGgooKa?= =?us-ascii?Q?5IUP5rq786v0tXEQ1JUhY9KSaFivQyoudSQbPW0JTQp3cpl0J2mlURLm6CZJ?= =?us-ascii?Q?CecLoAu4wq78YWeaDeLedKznQNQWF2vKKV8qV0vAtpLmLnlV7NqtG1g8Hafk?= =?us-ascii?Q?QWZ+FY/x+06buYteQVXS9dbJ8gn46/ozA6EGVd8LAL6Rn9qy8hylFm85Sbaf?= =?us-ascii?Q?pii+h6XBhc/5drVdjXOV8EVit9Kyec1gMNrWS0u/Wc4AJ3KhdqsaeSEmQZqd?= =?us-ascii?Q?+lL87zrF3p0lMiH5hQ1E4P8lKACNl1s22YFhqo3rShM/rmcrP+qsyCUT4WFF?= =?us-ascii?Q?8PQh6JS/7pHSqUZRcC64RSbXCbzeSlO2zKkxOKBCsb5OSQuaZHDmhWjL+DxW?= =?us-ascii?Q?e84ntJi37M2z8nc85qhaLiP90kMr9vOTNZkQqgewairWCC4CjcmqMpR6t1JE?= =?us-ascii?Q?qM2DXGPMPLdr0GUvB5IFhnhmLyFf1AJhtRJDZxq8XSI/ITQhUkZW3dNsRjnW?= =?us-ascii?Q?psU+myJkxvIFkjSpzJDjeMvsdpOn8xVyop3qN29+XxhMhjpTnYmG8xMIS2DD?= =?us-ascii?Q?nOnVxvQqaE5CP05H0KjAI1R6YZTUB75zCtgGhSUz6AV+uqqS5NTeNHFF7a0X?= =?us-ascii?Q?tjaNEFJVfzVn0K22/Si5tOadBt3gCbk5MI3/9WCsG7RETH0jPE0ABktk0Kso?= =?us-ascii?Q?jSvnly6z3czujTepYB+KUBeRAJTOJ8WERgPkbIMx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5273.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8ff69eb-b839-4496-8e18-08db036c1fa3 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2023 09:18:32.4583 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gVXDY0d3PLdUp9HAIz1YI7EXf5LYPe8Lz4dKvsv4XWZYaYLvnVVKzJS7rZUeAU0Uc88Pponqi0DoKhRbSNQgWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7081 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org HI Stephen: BR Rongwei > -----Original Message----- > From: Rongwei Liu > Sent: Tuesday, January 31, 2023 11:25 > To: Stephen Hemminger ; Andrew Rybchenko > > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; Aman Singh > ; Yuying Zhang ; > Ferruh Yigit ; Olivier Matz > ; dev@dpdk.org; Raslan Darawsheh > > Subject: RE: [PATCH v3 1/8] ethdev: add IPv6 routing extension header > definition >=20 > Hi Stephen >=20 > BR > Rongwei >=20 > > -----Original Message----- > > From: Stephen Hemminger > > Sent: Tuesday, January 31, 2023 11:02 > > To: Rongwei Liu > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon (EXTERNAL) ; Aman Singh > > ; Yuying Zhang ; > > Ferruh Yigit ; Andrew Rybchenko > > ; Olivier Matz > > ; dev@dpdk.org; Raslan Darawsheh > > > > Subject: Re: [PATCH v3 1/8] ethdev: add IPv6 routing extension header > > definition > > > > External email: Use caution opening links or attachments > > > > > > On Mon, 30 Jan 2023 05:59:33 +0200 > > Rongwei Liu wrote: > > > > > +/** > > > + * @warning > > > + * @b EXPERIMENTAL: this structure may change without prior notice > > > + * > > > + * RTE_FLOW_ITEM_TYPE_IPV6_ROUTING_EXT. > > > + * > > > + * Matches an IPv6 routing extension header. > > > + */ > > > +struct rte_flow_item_ipv6_routing_ext { > > > + struct rte_ipv6_routing_ext hdr; }; > > > > The problem with nesting a variable length structure inside another > > structure is not allowed. > > > > The issue is that the applicaiton would have to pass a variable length > > structure in for the flow definition. The flow item is variable length > > for this type? all the others are fixed length. > > > Yeah, segments_left is uint8 per definition. RFC doesn't set an upper lim= itation. > It stands for intermediate routing nodes between src and dst nodes. > > One option would be to get rid of the wrapper structure. > Yeah, it works. @Andrew Rybchenko Can you share your preference here? I want to propose "moving flex array" out of the "struct rte_ipv6_routing_e= xt " and present in " struct rte_flow_item_ipv6_routing_ext" Sounds good?