From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8D30425D1; Mon, 18 Sep 2023 14:17:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE2B34025D; Mon, 18 Sep 2023 14:17:32 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2076.outbound.protection.outlook.com [40.107.92.76]) by mails.dpdk.org (Postfix) with ESMTP id 1A90A4025C for ; Mon, 18 Sep 2023 14:17:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BxFuZsRaa7Ika+MmvfZVb1qXC2/TUlTRIEO5aFPL3U3zWUpDgkdm/w50mww/YWuWUNYb61a2+eDkL7/JZQ48/txQJXVj52BxyMKNYDq9rX5QjoI5V3VTE1VMlq5Fzq+GMkflX6c6a5HR+MBICvM3o6mhYiJ5+ktHnDYShY9hGMpEgHiovcyIliUG6Yq1L0nNyopvPHA5URqWJFHU21YQEDoJDGNOUCb5Oht0qRwJL+uIUJMX/qgu+L0unNeiA6N9Y5J6yP4UrpejfnzAuQ9sy8Wa9aRwZWTm53mqTOXdRRyuzlIckJm5fjpcpwhrwfgdY2xrLSSiJ6hKO8QaLiXXmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m8En8fnOB0zCj08UDxX/wWHKH5Wjyo0kY/k75Z2ku0A=; b=R4Vl1qZKEbp1KVxsqsgf5HSO/V8JRfmhrnrB58X4S3j/rzf8Jek4+LE87BdmPrFpu2OY0F+X4ReI37s5vLveI+OcFjww4L642rXtEOtgoXqwu1wrZDD+OoNqYOhUAQGLgn3eDam1/j6lz44+Hr+SqeDHETSwPmU8GX8Io5R59uD03OvTmACd1sNp8I3u+wHoFPROGkb6Am9jgUowTPHAbWhA/2dmhPSIxi1pIIm55ZILCnckU9k05M5hFKQepUFwfVYmd7SMfwSH9ApzBsQ+dBb4A7DwK/ybQYAhZphwJdskwNfrXy1I/yHpOso+6sNGlZZjci8MSfk2Mu45OICwpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m8En8fnOB0zCj08UDxX/wWHKH5Wjyo0kY/k75Z2ku0A=; b=WtAJf3/oPompIpHqRFZev0md3pXlTfTjiP4QvqiPgDIkFfGHrUroXUsvqvRbWcYu2G67b98Q7rnLhQM2RHA8v/99BfVkN8wX5pIFOOq6AqasJAmTP9/Hbog8cJUOm+LWIBPGxHCk0SRgr0p/xxMHRLxdZ8MztDltlwuEVPC1V0ZmBx5zr2ZlJvamvbHgLnomIhX7VfRq60cMIDNbz3E6XPAsdw+ztMI981lMZXjri3JHnFBZKF8CBsH/G+KWxceljcTK3A0m83dwF+Q76Z25RPNtY6qqpqy7QhTjEHeoKiLduvIqH8teVQdFqeNPs2XlzgNTCKoGXkamMqSA6fb86Q== Received: from BN9PR12MB5273.namprd12.prod.outlook.com (2603:10b6:408:11e::22) by CY5PR12MB6384.namprd12.prod.outlook.com (2603:10b6:930:3c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.24; Mon, 18 Sep 2023 12:17:29 +0000 Received: from BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::de5d:a135:6690:3360]) by BN9PR12MB5273.namprd12.prod.outlook.com ([fe80::de5d:a135:6690:3360%6]) with mapi id 15.20.6792.026; Mon, 18 Sep 2023 12:17:28 +0000 From: Rongwei Liu To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Raslan Darawsheh CC: "dev@dpdk.org" , Matan Azrad , Slava Ovsiienko , Ori Kam , Maayan Kashani Subject: RE: [PATCH v1] net/mlx5: add test for hot upgrade Thread-Topic: [PATCH v1] net/mlx5: add test for hot upgrade Thread-Index: AQHZh7kq6+rqY6tpKE+AMM8zmvu33a+dyGwAgINnOjA= Date: Mon, 18 Sep 2023 12:17:28 +0000 Message-ID: References: <20230516054137.1396922-1-rongweil@nvidia.com> <27670733.gRfpFWEtPU@thomas> In-Reply-To: <27670733.gRfpFWEtPU@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR12MB5273:EE_|CY5PR12MB6384:EE_ x-ms-office365-filtering-correlation-id: 667a8cae-df35-48d3-eca9-08dbb84139af x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YoLzve9YOu0AvDzjJPJytdQZqbv5XbQIU4fEu/U6ndEOmxHulMgL9ZVX8l7w9QRvXo0ObkKW3nn4qeafHja1I+UVo9GDFvC9GkEkWZ26zgWVw/uApr+c9fYrEGz83zYGw4yyXjC/MC9OYiwuWmlxL/uGDZJm7G7T10TWSzk+iDdayKHxvzjM2JCGfzh9JvFu2H1k09LSlbOasDKh8DAzECcEAq42yvWvcCp3k56Qau/dD6bYkp4JNZGv2+cDmMMtiu+HxWQ4LcN/sjkfEcX6yfCegh5IILLvA4hiHGA9nNJ2127lck42oflyzxY9q5QLUxttFkg9zxmR93M+kmqe4Dl7AmjObEMXZTZPB9j1ZpjELknDycOW+Uv4QJPTrxKR0wgpjp4bdAwsyIDrjRLjGStLWHIZY/kvrq7+ls7P5nAC8CPVuERxh2NkoaMHHZNRHK9XpzXyDvd2rY4K/6SiW7xO/0GBzeBACZUxVEzTI/j9JNwhKDzKWqIjDs/Yp8tfXfl6hUKeRqZabAnuHU0iKz7O7xVHxWNz1PK0XKX5xXWtV0xslFDSBtEIu0LAuwQb0u4MG7m2gEUhmrrf+nNC0ERBAaMUf0RVZLyd3Td6Yhqzw+sq8/jEvzCL8riKyAIg x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5273.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(376002)(396003)(366004)(346002)(451199024)(1800799009)(186009)(55016003)(5660300002)(6506007)(7696005)(53546011)(86362001)(54906003)(316002)(9686003)(66946007)(38070700005)(66476007)(66446008)(38100700002)(41300700001)(66556008)(64756008)(76116006)(71200400001)(478600001)(110136005)(6636002)(8936002)(52536014)(26005)(33656002)(2906002)(107886003)(122000001)(4326008)(8676002)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gxEvYIuAx5RznVTaW9ni3iKGmMo3VjCc+bNm0bS4IwCbRLChQnO5tmt5CxmD?= =?us-ascii?Q?+WoG4lj45IUOUxP+HU5PlkDA2CfoW0ApMPHdTCuQ6HgQYKCBJtM9p522/bcF?= =?us-ascii?Q?V2qi7fX9kekYPdbJ6YRFuWVyWEKNnObRZL4ZyQgKIEHIFrRB1mer4EznQGCe?= =?us-ascii?Q?ceQYQYwO3nAnkqnsOUvIVpyWam7VbESRMG9Zon2qzJri8r+g7N1MMRv0+o5i?= =?us-ascii?Q?YCO8kn3oCBQRpC1Z3iOJlAeM7XkQgKLcUncXkN3OihrUJEDv4aX/q4YGhBPm?= =?us-ascii?Q?hyk43GR/WQDtEcz+Nd0DtOoKwOkU6gpB7uBFh6bGNkJImP/5NvHVujBuzZWt?= =?us-ascii?Q?CBc9lv3UcvTjRLOugCrwf/jDJBi1Erb2zn8lMVwDM/2inbhyHjDzRq/NKsZJ?= =?us-ascii?Q?/GG5S9ixCFN0JzRlvZmItjyFfO8wX7MHfPmKQe5X8K7/zj6LwjksgzHpfNmY?= =?us-ascii?Q?KRlvOJaZesLty/m/KmnBFS30L51me8w54RFQEOKFqVzctFkfDp+yWnoE6z7U?= =?us-ascii?Q?xKLuMTG8GIDHIzKjimoZu6IznJFsH/auHz7NSxtTJBu8nlr4l8FYOJXcM6i+?= =?us-ascii?Q?uprNCe9zD+Wa/Hfo+FbxgH1G9hmYMK2XyA10Wt82lV7+7ibMRpgZf3PJL769?= =?us-ascii?Q?gJsQecIvIAllCVgjKHw76siHE2yRBF4A1uG3WEie9MNo1p+OZiAf0vQYu6zV?= =?us-ascii?Q?A2yrFiqkHzKMA7zfoszD2sZ0oci7WJFDsRXZEuz6YzcQ7BShw1dR5Zw4j89j?= =?us-ascii?Q?RSQhcLOALg82VGcSvi4ikpWalFC0SP3VKcPcsmx5DCMhT4yW1Y2OjpKm2IBX?= =?us-ascii?Q?ncJ72DP814JKNehkb5mslc7eeuMweHdH+h/GzBROQmZUAmOE6rJTAMzwTbzf?= =?us-ascii?Q?qMyeQOAT6jRUqQv/HFPhOf4NRAAWg8NwCXFDAAaiCCrB9yEq6P3injxPAzYt?= =?us-ascii?Q?f80ItYAJm96GCWASzanJWrgLy+y15qdz41z+bHnvTWM5UVcFz8Uc2MlD8sww?= =?us-ascii?Q?8pMsVDzBXlWoil64C7dOVHj/cdFbPDV4y7phgxzeX0wdDQX10wo5dkd+qTCV?= =?us-ascii?Q?zXCj5Bzw/ctDOXLg9py8IENO5Nt4I0cVgEmoGi9VKIsgL8LSMVIv1L0leWaV?= =?us-ascii?Q?qCkLgeoSVQ6uuq5fAmq8m8C8rFmcOvtqMXVFElrGY2gIc7/6GeMlvqpx9J/8?= =?us-ascii?Q?LSYUt4Vdmu+7rhq1k5tWHZaQ7qB80SDwCEIIikxi/nEUF13IKRw5WIVn9lVC?= =?us-ascii?Q?Nu4CbNub5swHr2183cRTqSzDT16HiFEvH4nAEwpxiBOc1TuO0eLGTXeuHIZL?= =?us-ascii?Q?8DLix3QEz9qZpFZzsgh12BUH0TCFQeFQu29e2P9FRTySnA+k2pIuBu4bs/3H?= =?us-ascii?Q?mEL7nObFYF3gkBMnusqs8EP2JyxOoMNLJsjvIOVHMIe/JlXgzCmXonWvDwjf?= =?us-ascii?Q?aYlJcS/KaoPNICCDLvsBv7L2DRVwA7q2SISH+OcWytkKgAvOqyBmdmcV69ec?= =?us-ascii?Q?VCWbjTMWIYD4S6P/FRjSm9lFi6+7z5ixneUi6IKIuIDAmR/u4TcQEuXIXbwv?= =?us-ascii?Q?QCWCmar8ePpDEF7QCAlkrDhjcltimNzeSBNA1eJe?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5273.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 667a8cae-df35-48d3-eca9-08dbb84139af X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2023 12:17:28.2790 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WLP2DAQBZeKRV/FVWzdOeAS/fHVTR36yM/qzigNI+WpztWzZnNfM2vRsxHAAAFfjB5XieqXJlr3sq3VtSaUXqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6384 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas: BR Rongwei > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, June 27, 2023 04:23 > To: Rongwei Liu ; Raslan Darawsheh > > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Maayan Kashani > > Subject: Re: [PATCH v1] net/mlx5: add test for hot upgrade >=20 > External email: Use caution opening links or attachments >=20 >=20 > 16/05/2023 07:41, Rongwei Liu: > > This patch adds testpmd app a runtime function to test the hot upgrade > > API. > > > > testpmd> mlx5 set flow_engine <0|1> (flag) > > 0 stands for active mode while 1 for standby mode. > > > > Signed-off-by: Rongwei Liu > > Acked-by: Viacheslav Ovsiienko > > --- > > --- a/doc/guides/nics/mlx5.rst > > +++ b/doc/guides/nics/mlx5.rst > > @@ -2057,3 +2057,13 @@ where: > > * ``sw_queue_id``: queue index in range [64536, 65535]. > > This range is the highest 1000 numbers. > > * ``hw_queue_id``: queue index given by HW in queue creation. > > + > > +Set Flow Engine Mode > > +^^^^^^^^^^^^^^^^^^^^ >=20 > The title is made as a sub-section of "port map external Rx queue", which > looks wrong. > Will change the "^^^^" to "~~~~", totally in parallel with " port map exter= nal Rx queue " > > + > > +Set the flow engine to active(0) or standby(1) mode with specific flag= s:: > > + testpmd> mlx5 set flow_engine <0|1> (flags) >=20 > It should be said it is for testing live migration. >=20 Sure. > Also the flags are not described. Should we pass an integer? >=20 There is information to describe mode, like active(0)/standby(1). Or we can change to this style: "mlx5 set flow_engine []" > > + > > +This command works for software steering only. > > +Default FDB jump should be disabled if switchdev is enabled. > > +The mode will propagate to all the probed ports. >=20 > For the reasons above, I prefer not pulling this patch in the main branch= . >=20 This command line is a good starting point to play with mlx5 live migration= feature. Keeping it is user-friendly per my view.