From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C5DFA0547; Thu, 22 Apr 2021 03:29:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2CB4140692; Thu, 22 Apr 2021 03:29:52 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2072.outbound.protection.outlook.com [40.107.237.72]) by mails.dpdk.org (Postfix) with ESMTP id B22DA40150 for ; Thu, 22 Apr 2021 03:29:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MvFomaWTzpr7tszBnQnMwNrSCUfCBEQREmtsX21+2iRf0h+lfRKcLOWFtLpN36Im/4g/OxLpcmaMeZDmWDbAa6+aIshJHnjbpzsm7K9LnkzZeIY+95wAgwBsYhZ7hHE5ZuzuAv2v2C9V5O+q71qCVlNHWGqJIJ/Q8wY/setif5NEd+w5sTOwywjzLj36tBY9iGfJ5eFa2KbI0amIvAYLKMExBnU5mnQp+ZqfKmz6Kiz3xa2AaQLDarbisnU7xsFn+63pM+w2cfvVuTzllVumO+p6xOytDUrhbykuofpVjNsyO2Mo3K0pvIrU8nygNI93w1swAcolD5YjAMuRXGf7zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yi7NNcwCNwl5mA2p0R15TX00hpgDE+gV3BdyDuvSMP0=; b=YFIHKQgTda25SqWGlmyi1IFxkpSCDVEJ1i5JojMl0SaQf9e4uLe/ncvRzP4y5PNeYSZUZ7JJRl2bWHTfmEMXjKHIIsACR015gTOqf5I+Vz+ojFOgydAFagS4IGCH1HxX9HR4pwsVo8Z7oxiIPqdFsiXr7TL0ApC8JsCc/IBEENLaYWfDTJO3IqgZzSB6me2/F9QIEC3r36CQmSjDw6xgFbqngxHRAiNtEHTf7YYjIeLV+V39IioYJeyF1q65Ql3TzqKE9pyQ1f0oRnlBACsKK5nRykLTiCRrV7FveQU89qtU7Cukl9ueeMcnnYcOB6Q3itonhMU9b5zRpMPeOeGU2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yi7NNcwCNwl5mA2p0R15TX00hpgDE+gV3BdyDuvSMP0=; b=DI/cj63NIiqVbZXXiIMUzoDIUDxvFFRIXCNK1FMtiNRjIZGWxXgMmFlGyeM/VxJo9XQWq+qbqRJr45DN2EltAX5uwbTgod0B8absMLN68fgWaC3WGYCLEwXs+WX8ZcNRfj0Itd6WPMcTiVUVy7/i/n9u6tIaz49rZ0+mb2IwerqnIFhTGhVrryLl8BursheQkLDcsy+8GehtgdX9cBM2RzJ5UiPjJtD74TYNuLjRKi7nsk1bEdLEer0+guTAzBaMrbd14JSnx8pEJolcntW4Ky79spvn/fJfntdce38T0evUAKA4h+iSqVXLM1di+xuZii6ar540HvgElsewETFcvw== Received: from BN9PR12MB5307.namprd12.prod.outlook.com (2603:10b6:408:104::5) by BN9PR12MB5209.namprd12.prod.outlook.com (2603:10b6:408:11a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Thu, 22 Apr 2021 01:29:48 +0000 Received: from BN9PR12MB5307.namprd12.prod.outlook.com ([fe80::61c8:2c29:916f:ecda]) by BN9PR12MB5307.namprd12.prod.outlook.com ([fe80::61c8:2c29:916f:ecda%7]) with mapi id 15.20.4065.020; Thu, 22 Apr 2021 01:29:48 +0000 From: Li Zhang To: NBU-Contact-Thomas Monjalon , "Jiawei(Jonny) Wang" CC: Matan Azrad , Ori Kam , Slava Ovsiienko , Shahaf Shuler , "ferruh.yigit@intel.com" , Wisam Monther , Xiaoyun Li , Jasvinder Singh , Cristian Dumitrescu , Andrew Rybchenko , Ray Kinsella , "dev@dpdk.org" , Raslan Darawsheh , Roni Bar Yanai , Asaf Penso , Haifei Luo Thread-Topic: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API Thread-Index: AQHXNe4k/hkq4sYQIkuLL9LZR54TAqq/YWuAgABgTCA= Date: Thu, 22 Apr 2021 01:29:47 +0000 Message-ID: References: <1618848506-37569-1-git-send-email-jiaweiw@nvidia.com> <1618927490-229267-1-git-send-email-jiaweiw@nvidia.com> <1618927490-229267-2-git-send-email-jiaweiw@nvidia.com> <23466981.2A24ZmSzZz@thomas> In-Reply-To: <23466981.2A24ZmSzZz@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [139.227.253.12] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bfd7f198-4de7-4e24-a73d-08d9052e1e09 x-ms-traffictypediagnostic: BN9PR12MB5209: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:530; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NJxmbgRvZfMXRQ5IMExq6fEByhB5ciZutMuTnuyesnUHwJzXGNurgSRXYRWJFkdONHtRx+oWiJK0tSAajm29FUivMOrUq2Y08PiPqg2cgC7o4Y0B78D14AA9/gzz641Rw91AtNjjg2bey+tGL9YPGYjKbTPtEs/GwGZYBzQuWWADSNc6tfZGZiNrTYOb90jGbXfZTNiDvZwF3ZUUyNDQO89kh1rHAMG+G2SJZb+5O2vy/N86CIETHyFn7tOXvcxwlmWTmUAz0EU9wTQ/beoMWDJk0SWfjQICdMaM3DF9Kt7wxUFLUxZL6GXcHipiolgNwiWIyygjelaOJNg9Z+pquNqoJpjO6Dl26Ggn2SvHyHvVt5go/3WJU4y8U/H5rmMkfJZxfk7gctIjzXJxuB/dRlaKs13HE5I0vPzhY/YL1v/WzxuqCGr6AKgEMw8lWacK6BcminzyIx8sxCnjIDouKIEX+7kMJGKLwfryiFmU85Uf25LNfqOGJ5ANaN2BERKS+QdIOAyxVPS7pNRF6MpBLPMtE14rnMSbGtiwVLi47mb4EJyuqs5aCTHeV8NNWSY73N8j58Wk7UYUDkvS5VfK0Owy7eFNjpwo4K+0I+rvqEk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR12MB5307.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(39860400002)(136003)(376002)(346002)(110136005)(6636002)(186003)(53546011)(64756008)(54906003)(7696005)(2906002)(83380400001)(33656002)(478600001)(122000001)(38100700002)(26005)(86362001)(5660300002)(52536014)(55016002)(6506007)(71200400001)(107886003)(9686003)(8936002)(66556008)(76116006)(8676002)(66446008)(66476007)(4326008)(66946007)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?b9A+XaMMyJYTFz7mR2OZYFE+VwwxCPky3XtcLiFFXCngyokz9r6r6H9T5kBx?= =?us-ascii?Q?8NxuWRbzkO0n6S5MGb75s25lRYtqpeo4eborKTWDdzrnA3O1lRxlm1eqpi9i?= =?us-ascii?Q?JZnEd/rB56dBKXjbFlfEpcaj9A8hSiNPROiq7viI7uXvbWSUadFTrVqlyigL?= =?us-ascii?Q?+eEvA0PI08ONWq40A05+MciE4JjQGXtTVoSsEWgpANr4etMTpRDxoqguNe07?= =?us-ascii?Q?aPfPHzl87xlBLEPHD60N/UCcFnpann2YxfR4ghpcxdRP3cf2H7xnS7noslg5?= =?us-ascii?Q?2fvMfCq9pryD8nSSi0jc1EFP6FbEyFcCZtw+KfWrID/ghWlUew/zRaNkENEP?= =?us-ascii?Q?uXmQw3JtOGMq7zlJMPLks8cGSqlE7iMtarkKHMg92GmocXJ2AVT5B15cIJmc?= =?us-ascii?Q?g/WpEgx+Hii60FLcrd8H3XGsTp/Lx2NIQc69sB9GwdvhQboo9/RsWwDY/YqB?= =?us-ascii?Q?Y23aGtSUJjwEV/cYeaX3tXQIgU0YcXux86S6fnpkBQ/mgFYPQh+xNsYyQ69l?= =?us-ascii?Q?z1FQcj7lq8yKxECwMA54Msg4bUtvEqVWQMljbuuaWMMgM70zsRnAE/om84Ee?= =?us-ascii?Q?1gBmMIOFfe9OQhuQVMvRea2XF3TaFWl9kyucUSFq6ZGFOi9aC8mRJAyhkTSF?= =?us-ascii?Q?z7jj6m/TER61fRifYjDksrIOO3hhuJlCvEGoMASOPwgldJ2e7CkGT5e1CJmb?= =?us-ascii?Q?ybelYgmJfxESNKypme+SWOgSQu/IRiaWnnEhpxifytuwpDR1gh+klJG8C+uF?= =?us-ascii?Q?mlossaM6KYTr3b5eyQWnQDZujrxHT2adDXk5moSm45qHwmxKR/2KzB0nZOww?= =?us-ascii?Q?5Ak9mUmSK3rxviJco+Xrqmecg+sKc+bCGBcfDyaWqJG8+Kn0SVBSJX5O8CO/?= =?us-ascii?Q?FlGR/ctUUU7e/69xClHanOvofK6WL0009DCacU4GuZuig9BS+69jphWpAZ9D?= =?us-ascii?Q?FwQnhTKcbmvxaSAS+1kNyPMMOwUDbOVmcoTpE/aP8/EzzZzRtnI/syQs/eLb?= =?us-ascii?Q?yVr3ZG4Ms6qHmjJXb0FGUbgymnFaZzl2Jn1y9Ap3i+66i2hoHD5P3A4Z+cLr?= =?us-ascii?Q?edE6zM0ExvRnQH5Owq2JHIqgpFxlqKQ9sBCtAm7Z/bzoCP2u2yjUiiswXUhW?= =?us-ascii?Q?PYDxHI/dm7HrGuq1eAyXDWk3pE4cEtcIHkRpOQNz6wHOYzR0gEfXclUvwqmN?= =?us-ascii?Q?2JWS8HsNFP4wTN1du3lf+5R3it6a7R01T2eCCj+6jfCeMWWhKvo2zocNEk0o?= =?us-ascii?Q?yIQjE+jKBrgBF1xmzDsOuTkWYC4vGrgoekr0kvK2LmaAEzNEqH7crduKMmEn?= =?us-ascii?Q?qIF3zhEig4zY0l6LqduSQpwd?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5307.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfd7f198-4de7-4e24-a73d-08d9052e1e09 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2021 01:29:47.8925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: n5GhQs1on8ZHczrFYmdHXtCGxqwi9QEUeXFvXcBJl4EVmTrGMCleiSxOGIrMWcBf X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5209 Subject: Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter policy API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Thanks for your comments. Since this patch already accepted, I will fix it in RC2. Regards, Li Zhang > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, April 22, 2021 3:44 AM > To: Jiawei(Jonny) Wang > Cc: Matan Azrad ; Ori Kam ; Slava > Ovsiienko ; Shahaf Shuler ; > ferruh.yigit@intel.com; Wisam Monther ; Xiaoyun Li > ; Jasvinder Singh ; Cris= tian > Dumitrescu ; Andrew Rybchenko > ; Ray Kinsella ; > dev@dpdk.org; Raslan Darawsheh ; Roni Bar Yanai > ; Asaf Penso ; Li Zhang > ; Haifei Luo > Subject: Re: [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined meter pol= icy > API >=20 > External email: Use caution opening links or attachments >=20 >=20 > 20/04/2021 16:04, Jiawei Wang: > > --- a/doc/guides/rel_notes/release_21_05.rst > > +++ b/doc/guides/rel_notes/release_21_05.rst > > @@ -244,6 +244,27 @@ New Features > > * Added support for crypto adapter forward mode in octeontx2 event a= nd > crypto > > device driver. > > > > + * deleted the port meter policer action command . > > + ``set port meter policer action (port_id) (mtr_id) (action_mask) > > + ...`` > > + * Added command to create meter policy. > > + ``add port meter policy (port_id) (policy_id) g_actions {action} > > + end y_actions {action} end r_actions {action} end`` > > + * Added command to delete meter policy. > > + ``del port meter policy (port_id) (policy_id)`` > > + > > +* **Updated meter API.** > > + > > + * ethdev: Deleted meter policer API to support policy API. > > + ``rte_mtr_policer_actions_update()`` > > + * ethdev: Added meter API to support pre-defined policy, rte_flow ac= tion > list per color. > > + ``rte_mtr_meter_policy_add()``, ``rte_mtr_meter_policy_delete()`` = and > > + ``rte_mtr_create_with_policy()`` > > + * ethdev: Removed rte_mtr_policer_action from rte_mtr_params > structures. > > + * ethdev: Added rte_mtr_meter_policy_params structures to support > policy API. > > + * ethdev: Added meter_policy_id into rte_mtr_params structures. > > + * ethdev: Removed policer_action_recolor_supported and > policer_action_drop_supported from rte_mtr_capabilities structures. > > + * ethdev: Added meter_policy_n_max into rte_mtr_capabilities structu= res. > > + * ethdev: Added RTE_FLOW_ACTION_TYPE_METER_COLOR in enum > rte_flow_action_type. > > + * ethdev: Added RTE_MTR_ERROR_TYPE_METER_POLICY_ID and > RTE_MTR_ERROR_TYPE_METER_POLICY_ID into rte_mtr_error_type. >=20 > What is this garbage? > Wrong place, wrong format, wrong everything. >=20 > I would like to see a bit more attention to details, especially in a rush= to close > the -rc1. >=20