From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A405A0C4B; Thu, 14 Oct 2021 19:31:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62FB640041; Thu, 14 Oct 2021 19:31:23 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id AF6C34003C for ; Thu, 14 Oct 2021 19:31:21 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19EDCrDt016907; Thu, 14 Oct 2021 10:31:19 -0700 Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) by mx0b-0016f401.pphosted.com with ESMTP id 3bpjk1a0cr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Oct 2021 10:31:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TDxInbC2VOr7KoO7/aHg8iLP7m3R295NUf3DJpgnvHmZpIbVR5Eftl/N7HLYPynQTL4Pym0FGhG1RHP2Q98+PXb7NdL8x77PJDqgP22jf1idG4V2qa4xeWNMmMcKIr4RZ6SB4rMU2dWenrQuLyL/QjEgwZmSXDetPggVCUAK4wzDBjRv426fpM9Lw1BIrWtpafR2TXOAPycoitnXXSziGW7TphLJEDxOdjwbVy35NmU0LrWEeto8u6H4REmC8LFT7Z02WyBfH2bz1/OuHFqRuAHomIPMDpH+QMQ4wh1QTg47xO+cgbzTOo5GZKHq9CQpECtA7574gWAol1qXuNbxow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LGG6UNOGMYzq51om60BiojWDl9IXspStgFZSHKYlhBM=; b=Y0dEB2sLFHo2DAI5Vj0lYgK0w3c4GdqJTbvFz8YY1uGnnGy5NqOnbw9OkP8FRfjUJxAwTRXiEN+4xnL+IKfEuNVVytE4wCyltKWe/xlnUWHg9HWwebd9RyFtv1rz+EfyH5t2TY116+qUzPaCJ4nIrnHKZdbgRpw42p4gN3ru0gDRHCaCXtGzeQqTglHDZ11MYtq7Sdt4V+OMb3LPbMtld28XSsiSg6JLveNPrbvpEI88CbXm+mCFY1a+4g+jv+cD2MStm1qHx3D1reHREzeEeSZtv5KmBDCcjT/bjEl/I7Zr8tXfWtQoRuRldGxE6o7osiYgygmh/8DJR0JF2SV/5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LGG6UNOGMYzq51om60BiojWDl9IXspStgFZSHKYlhBM=; b=Mt0022d3YsgeFL3YR6iXTQKhWYXNvmyB9L40T71OhgFzs7LXWk9BknrCJ5lvYR2ichQY7dL/TQEiiAnjE6eOWEJPLi9PyNN9d0XPSSSAt53Xa+RcbVBiqF5gTC7WCeXPzEchWkk1oi7eMq7lTzt0nlL9B7Qh/39m1GQXbr2pwXo= Received: from BN9PR18MB4204.namprd18.prod.outlook.com (2603:10b6:408:119::18) by BN6PR18MB1489.namprd18.prod.outlook.com (2603:10b6:404:12a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct 2021 17:31:17 +0000 Received: from BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1]) by BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1%8]) with mapi id 15.20.4608.016; Thu, 14 Oct 2021 17:31:17 +0000 From: Harman Kalra To: Dmitry Kozlyuk CC: "dev@dpdk.org" , Bruce Richardson , "david.marchand@redhat.com" , "mdr@ashroe.eu" Thread-Topic: [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle Thread-Index: AQHXueK5tXEeEFHYhkaplIscz5gxp6vRuZoAgAETzwA= Date: Thu, 14 Oct 2021 17:31:17 +0000 Message-ID: References: <20210826145726.102081-1-hkalra@marvell.com> <20211005121502.66964-1-hkalra@marvell.com> <20211005121502.66964-3-hkalra@marvell.com> <20211014035906.188f76da@sovereign> In-Reply-To: <20211014035906.188f76da@sovereign> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c9e76f5-da60-4622-22bf-08d98f386e16 x-ms-traffictypediagnostic: BN6PR18MB1489: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jzyS74lHZwH3t0FzsRhamKXzjEPlR0bNIGHcYdnesUMUaw8qBh3ZF64zo4z0X6aVRuQVypzh3VOV9w8J/35POui3OHqjojpH80us4wWAt3W0PKYGpMykXFQ6kiv6wvkEhsoLwOVYyalplJLfqIn6v0k5WGZIeirY4Gol8ze+kc55GimuoBFths74EhIFA1+jWFxt4k3P7IvIh75wPPcUPM7JcV49zIcsZ6q2rCQ8Le5cQk3YFeIHw08iKjwNurJZoKw66qlizoRXLuxMQiVqHQiO4bY+rsg3NhQerbzq9W512/ttUGDmJaVofmkQsKJZdpbODrX1pfAcLke1WBD+br7IEhhSGo7ObKJUKYLt/8QWZAh/NxGPngjfiT6TJqP9GsF+bBc+/3sIjxjZeXuBEoIwSypHMET4vvX+gKwPJQndgFCXyyyiRNs31m0Hk4Hul1yLz08QLkJHmZQEbDclUCwLR4qTdbMETpsmQMYg80X0a9pttkUj8uuwca4xqd7dBQNlH3Zzlc1+11E110m0aNXJ6PID6BxO9ywlylOwJtQPtuoTer/U8gcRzCqY2pzMm3C8jaY4XnPsPZT+vLsE1H0U8mQgPG1KKA4M1fod2K7900VlsWoqxSAbk21X06Mw+JXLbcVe34yq24hryosAf7BIAxmRhoUVcqv20AMMqVXYZrPC2KV2GJRfASmVstmTOqdJ1hlKqFIHQPpyFSdBtQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR18MB4204.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66446008)(64756008)(66946007)(7696005)(66556008)(53546011)(8676002)(5660300002)(71200400001)(76116006)(38100700002)(55016002)(122000001)(83380400001)(66476007)(2906002)(6916009)(4326008)(508600001)(52536014)(38070700005)(9686003)(86362001)(186003)(316002)(8936002)(33656002)(6506007)(54906003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?I6Y+dItjBDfbUJ2tgVxrkizN6v7rM0MeIub5OnW2r8uGJG1MOiSYsaDObxF3?= =?us-ascii?Q?q8/2tVa1H9rQ+fJaazu6ytWwysTdMnpTeyu0M60NJOvu4SKWgs0DkL2BexhU?= =?us-ascii?Q?UO7Yg3+oBjqYpaAnqi4FnMVJQron0yOXtnsccXbXR6YERQYJ0kNnp+CgDCgl?= =?us-ascii?Q?zfZo8oUwnbQaQqYTQ9qYxBw+waoNeZR0noUAfmHjnTKXvkxGTfqNBSshu+03?= =?us-ascii?Q?2onp0VWIwPBpC0Piv6Ax1frd0d0hJhw50bubOSTZOs+lOKbws0o3jH5gIgvL?= =?us-ascii?Q?3P1GJWr087q3+A2mJ7AuBnn6+U3F8jek/6hI31PcC1+uDFsKAenWkfs4bj30?= =?us-ascii?Q?5dz2WXlbSwfpZtyvpevMH+ZArDRjmVEyx2ex8LmVvWqL7H6id+6t+bkm0ESG?= =?us-ascii?Q?H7E2fsV4x4ObNTF2iNKgmRGwN7KjyLuOc1F+BWk429r6pXF50x8AViGgUfOA?= =?us-ascii?Q?iWe+amlev77iOUUYvYURqrUu1M9hHaN4kJ+4uKciVaLa2S7L9SiUAkR9c0Mz?= =?us-ascii?Q?zfqM+Jj5WQDuRTMkzQIjpr7RaDVcGp5+0EyElst1gne4jontZe5/fDwkM2Cx?= =?us-ascii?Q?LoNDFcXIKH5kPLABNpnYUvlE8uJ9FUbu1v4mRioMJohB7i0fLZGnCpIkAhl1?= =?us-ascii?Q?jreYdU9vJgEUc+SgPMedz9Jnmlix0RZP0svnrAFBLv9jGcxyROTtSsZWsL2V?= =?us-ascii?Q?FAjjiURs7kYKOj3iX1F2DrhfK3uqPehEkGQTT3IAXfkaDEEJ/rdFH2JaBvrp?= =?us-ascii?Q?1TopFxuQAeuqsq1EoNncvoVhgq+MqM7q3xu85Rj6wZ0SUOR1xx1ltc/dpb6B?= =?us-ascii?Q?RzWkzahd/tsvi8SYBxh25dTzwF5PpcoNvaREd1MZm4q1SxP5gzDocLkamlv7?= =?us-ascii?Q?6ZMHs9iwg1A/vQiiq8gqj3RFyhsbm0uxBW3Pyo984n4FhFl4Vs729Og3BTmt?= =?us-ascii?Q?k0fIzsZOJw7VTRyudcPKknTN22NbaOcYKBcF8MaE5+/vUofbzf1xDQC1h4Fw?= =?us-ascii?Q?gETa9KQuO6+Uw1DE394ul8ws5jSMUd1uHMihzbHyoD6hgVP8B22P9YjyJWew?= =?us-ascii?Q?YIV1IZCyYrE14vxwO9KUvBkSs4LGsVk2hGZRje5QuOaw6gnKsoMcqkHvIo8D?= =?us-ascii?Q?uFVKhtYKInVdjECheMC8Chk9c0Y4y++rsy8Bjt9/q3o2xXDgjVSS7cNbo/yK?= =?us-ascii?Q?ljfQh3RjVx5NFdncOtpslNvB2CvIqNMSx9PFRZVFciksIS66vjZf6SOsmsLA?= =?us-ascii?Q?0yz+cy7dmCKCA3eGvw2IY+JckCh3W+D9RN0/U+YqAHOVcjqLmgbgYUZUvg63?= =?us-ascii?Q?i9cX8ZfyAPm+mPYXzHKY75vh?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4204.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9e76f5-da60-4622-22bf-08d98f386e16 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 17:31:17.7013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x+bRGwOawzn3voAbV3eknTXYEL1qmKS/V6HqCgE4s13M/dKHp98nCNoEm6s6dD1qZXhoNLGbip+bkOnl1TBjxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR18MB1489 X-Proofpoint-ORIG-GUID: LMisrXAvB5yn-qDMavS2Ttdi90MVV5jT X-Proofpoint-GUID: LMisrXAvB5yn-qDMavS2Ttdi90MVV5jT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-14_09,2021-10-14_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Thursday, October 14, 2021 6:29 AM > To: Harman Kalra > Cc: dev@dpdk.org; Bruce Richardson ; > david.marchand@redhat.com; mdr@ashroe.eu > Subject: [EXT] Re: [PATCH v2 2/6] eal/interrupts: avoid direct access to > interrupt handle >=20 > External Email >=20 > ---------------------------------------------------------------------- > 2021-10-05 17:44 (UTC+0530), Harman Kalra: > > Making changes to the interrupt framework to use interrupt handle APIs > > to get/set any field. Direct access to any of the fields should be > > avoided to avoid any ABI breakage in future. >=20 > How is ABI breakage applicable to internal consumers? >=20 > This protects against fields renaming for sure, but convenience is arguab= le. > If EAL needs to add a EAL-private field to struct rte_intr_handle, it mus= t add > an accessor even though the field is likely OS-specific. > It would be simpler if the definition was in some private EAL header and > could be accessed directly by EAL code. Initially we thought to implement this way only i.e. defining rte_intr_hand= le inside internal headers but supporting out of tree drivers was one of the reason to go via this get= /set approach. All drivers internal and external should follow the same way, that was the intention.=20 Thanks Harman