Re: [dpdk-dev] [EXT] Re: [RFC 0/7] make rte_intr_handle internal

[Harman Kalra <hkalra@marvell.com>]

Hi Stephen

Thanks for your suggestion on RTE_ETH_DEV_INTR_RXQ .
Please see my comments inline.

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, October 5, 2021 9:38 PM
> To: Harman Kalra <hkalra@marvell.com>
> Cc: dev@dpdk.org
> Subject: [EXT] Re: [dpdk-dev] [RFC 0/7] make rte_intr_handle internal
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, 26 Aug 2021 20:27:19 +0530
> Harman Kalra <hkalra@marvell.com> wrote:
> 
> > This series makes struct rte_intr_handle totally opaque to the outside
> > world by wrapping it inside a .c file and providing get set wrapper
> > APIs to read or manipulate its fields.. Any changes to be made to any
> > of the fields should be done via these get set APIs.
> > Introduced a new eal_common_interrupts.c where all these APIs are
> > defined and also hides struct rte_intr_handle definition.
> 
> I agree rte_intr_handle and eth_devices structure needs to be hidden.
> But there does not appear to be an API to check if device supports receive
> interrupt mode.
> 
> There is:
>    RTE_ETH_DEV_INTR_LSC  - link state
>    RTE_ETH_DEV_INTR_RMV  - interrupt on removal
> 
> but no
>    RTE_ETH_DEV_INTR_RXQ  - device supports rxq interrupt
> 
> There should be a new flag reported by devices, and the intr_conf should be
> checked in rte_eth_dev_configure
> 
> Doing this would require fixes many drivers and there is risk of exposing
> existing sematic bugs in applications.
> 
> 

Yes, currently "intr_conf.rxq" is checked by respective drivers which supports queue interrupts and enable them if set.
But driver doesn't expose if they are capable of supporting rxq interrupts, just like LSC and RMV.

RTE_ETH_DEV_INTR_RXQ   should be introduces and set by capable drivers in " dev_info.dev_flags" and applications
like l3fwd-power which sets " intr_conf.rxq" should check this flag.

I will add this enhancement to my TODO list and will send it as a new series.

Thanks
Harman

> code
>