From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 431E6A0C47; Thu, 7 Oct 2021 12:57:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C248B407FF; Thu, 7 Oct 2021 12:57:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id D277340040 for ; Thu, 7 Oct 2021 12:57:09 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1977TLda011558; Thu, 7 Oct 2021 03:57:08 -0700 Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107]) by mx0a-0016f401.pphosted.com with ESMTP id 3bhvj2rsxw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Oct 2021 03:57:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JBkMlI7d6EjAQ+I/r7fAjE1sKzvS51bQhBnn8uA1cH7NzmchfpGd+95t1PK+s1VjKhOxwKPLfncbqxLozCzcZV0LWJMncjh+vzMQLU7WcfaatANIo30KNuStgZ4IUhLbH1riqhNinC/veWB2MsRtxRZZyY4yJg/pXzJJHRY0rulP2KY5KTm873vXAXRfW/DS+wCBUv24LUeuejYdCnU5EL1gaQ7HoDCjPW05RopN8my+xz4sni+ZTh+MWCJpR4Da0Kj1P1eG1WE4G9eKD1T+vbY+m1LpUFpauEnjhdtVkscAYWMsq3hpkqEH5Wyy7k/Wq/LzstUa04wwb/cWG0TLOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LU+GQA8XAdlVyvH2G5bHZN25jCPbmgEhoQVpGhKymw8=; b=Ysh+qdgYG5wKtynWuunVhy17IA8f/Eya6iygwba56NrwuwvaOMsF8Wq4PoPfGs38tK9cdKp64wFQ8J08QSTSDtM0EOW2NRYif/M97me+dHBT1e8BfX+CCNBN7xlf/tf5l3O7aYNOyEE31tppTjSozHqb8KI/8Y6PDmXVfzLyBKWMK/8a6N7jnNV58Jbj2na+i6QKKF8GTr+AfmEcgIGpbud1A+IxeOgGyqQYsfrxJslewWBV5OdHLLODdzta8bcShDbwBVdyfB4+FNQecee2+QF+VUuXQSN3dBAmL4OXS8Wa7/dSshV+dqce2dXpo6UuUx524YuD4fqsuGHqJQB1UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LU+GQA8XAdlVyvH2G5bHZN25jCPbmgEhoQVpGhKymw8=; b=SW8sMU8KQ0ESCQVHvL/sL4Yj5lgRMSeTW+oWy6kbkx996ioo7sM7Ugj1cAKMG5e+zgKQ0zEN+kGOAnuP0o+mJouMoFt0v1MhxkS/R2V8gy2GGXiYOVM5OccgjMXaKpxY7sh8zH49urqcoQ4Ov+JdengW0aNlG6eombeb8vqo0C0= Received: from BN9PR18MB4204.namprd18.prod.outlook.com (2603:10b6:408:119::18) by BN8PR18MB2755.namprd18.prod.outlook.com (2603:10b6:408:a4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Thu, 7 Oct 2021 10:57:05 +0000 Received: from BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1]) by BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1%8]) with mapi id 15.20.4587.020; Thu, 7 Oct 2021 10:57:05 +0000 From: Harman Kalra To: Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [RFC 0/7] make rte_intr_handle internal Thread-Index: AQHXmoq8zTfyhnWz/UCsLB0ZBsK2sqvE0TQAgALLNyA= Date: Thu, 7 Oct 2021 10:57:04 +0000 Message-ID: References: <20210826145726.102081-1-hkalra@marvell.com> <20211005090750.4d7329f1@hermes.local> In-Reply-To: <20211005090750.4d7329f1@hermes.local> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88bc6b2b-21dd-47fc-c332-08d98981331e x-ms-traffictypediagnostic: BN8PR18MB2755: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +WOKWlI0LfLzwij4zIjSavRjpI+Se+D2Md6cqL3gIR0OYqCO9MiQ3o5BYZB+BlkdRAx6LjdWuHnskNjnfxpuiFEPT9ki5+K4uvnCVCEWxjuiRX5Xi04oeBwjGtZw2rEYHlfDsrAuYK73TF8iQdqGOAm1cyUTf3EHe8B/UTQTiwd7w1T+xLBy9bx1wC0etR6JRITQEjtFTueok649vT0I+INjE0Bm5uWh94R+bhb6rVaeGMweoCHkUKqAKQTDkMtnPMU0o3nxVMhe+R4JihQZ9CITaJ4Qw0xUaaLC9zSM6F4bbZdgruDEH3fSP4IC27NM6qAwZfK+M6EKnbOyEljGdixD//w6IgN/+UYSnsfXrtEii37nZo8DDaf+Tx0GjSx/OG7FW60JHIxDKEOPezVFcOwaJJWqrgMQTq5KFznoBU+6zn+U1TIKaFpGdYix5yszrFN32eAR3st0V32Ovt/Gi+5ewwg/SER4wB5qgXBLC+tRmIQmTQYOxHCOduzXGr7OdRVDrCfoXAKgEIXKGWEoK05amtPsDqUG8MzSTtY0t6iiwuA5JEW5LB1hukNZLxlWOMGuOWu6BA5gsmCOlnLJZkj6DwPvj/TmDCFSrI5J+FrGCjcB3MGychgJ02HjKo3zF5I+dyzltH3Nq/WnPw90oSAy3JNXCR8aIIzofwOgwbiUGppOFRqXRhl3fLphTqb7RRigfwup9hpv2moV4tY6ww== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR18MB4204.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(7696005)(8676002)(6506007)(66946007)(66556008)(53546011)(9686003)(66446008)(508600001)(64756008)(5660300002)(66476007)(83380400001)(8936002)(33656002)(38070700005)(2906002)(122000001)(38100700002)(186003)(26005)(76116006)(6916009)(86362001)(55016002)(52536014)(4326008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5dUWhZRuH7M81UWU+Lqp1NEC9AF5Kqo18UrbZNWysb6f9JOIw+zIePjWZg79?= =?us-ascii?Q?Qwi7NhJ8HScKgZx0eaoGMo2SNIbzLxFD15lh4KLQv2JrYhBsCF0F5Bw5jFyO?= =?us-ascii?Q?Nx6RDJfAMf+OKOSE4pXQewijmAdMq7DWqu8LuOanPmm5D5Dr3HJMPfcJDJhx?= =?us-ascii?Q?OfOVi+R6bVyD6HOUbCkiZd4k2rKrQNm8JcP2lztOElBN0uj7q4/vw5mPfd9n?= =?us-ascii?Q?sWbpQW7fl05FcIXiqSWTfiS/J4UpEZ8hIqqJu33jU9cwaqVGr6lB1cXKK9s5?= =?us-ascii?Q?3d7EtE0SQCGQ43T49sA/8h5fZMHPVRFdLyJ2ZDGXdf9XcgyxINPRU82V2Opb?= =?us-ascii?Q?/xHXVvVIUXCTrCxOIV/E0Uu1G7SAGtiM2fjjvEJBcPncnS9ZHezMf/Ux1vNm?= =?us-ascii?Q?gk0Q/5zeO4l6b9S9EXGO3s0ZbGHehn6ZIcesJ/AloMNFXFuWrq3jBsOpn4eL?= =?us-ascii?Q?9/TEtEz/N401twJVzmIM+W6jPVb6bFV8wAGGfOlmX8JRYsYclX/DLJZCGkzT?= =?us-ascii?Q?WDtk3n2fBC5kbxkkiIqIWCiel6hNBUT+JKH5EdTusAhhjuu8ZbQ5Hc4CeUMd?= =?us-ascii?Q?H344tq4+uYdOXbWmyKQukyuzqT4frqQLVBuPXytXP5gioFjdc7AP50d4M5rz?= =?us-ascii?Q?j5Pho2q0yGWNznPK15f8qVmKtlPwQ14Gj+UVaufe3hAvVXJZVeltyc49TZGd?= =?us-ascii?Q?Y8T8RlbnRX3n5bs9VPsaVvPsPwK5gmlCsWUThhY6HJT3l7Qf4PoP5WdW8UqV?= =?us-ascii?Q?NbBQN0Y4qGJ+yK7WhPzS+PDjgKBBd6jH/TcTHl+JW0PPyPk3WNtTUe+woyve?= =?us-ascii?Q?jax1ebWfnXrgBOxtqvqD6ieOaqzaWJN56ugxQ4RVSav70Wo0OFPAWH6B5mUN?= =?us-ascii?Q?IzH6hizAdR+FmHhR0m/txfGBDYo/KZJUF+jQ3PRyJ1S/wmrtQy4aVMKGD0o3?= =?us-ascii?Q?Q3g/OOUYzkLxiCweU7859BZfKke1Nj/FPEyJ+dh8WDV4KcueO+8hJyl/jO2a?= =?us-ascii?Q?WdCih8TiZrhdg2VRkur7WHL1nyPdJjsBKkl2DdUqbm4/4+m5g9VitX/q/Uh9?= =?us-ascii?Q?Iw1fX7OlGflWAXoYLTj+TjPPWzhPfzUDKw3Ng611g01mcZcmWGdA2yq+YDP3?= =?us-ascii?Q?zkxVlOKh917dLD1UNXUHHK9E+CLRijX27n+sibUUxyB3c4k++bBtvA8ku9RJ?= =?us-ascii?Q?QmDq/Q5Vonu0W3E8KycCu0KNEX3Eg4MBsg9VPYW/jgZRFHvVQIbmbyLFV/0+?= =?us-ascii?Q?+BMBHe8/owQ7lrVrmdFjKVLm+w7lROysBYUPj0tOXx3E/TTfa8nG1BfTH0dt?= =?us-ascii?Q?0MYTSitWdUCz7E3yfyFxs0+l?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4204.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88bc6b2b-21dd-47fc-c332-08d98981331e X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2021 10:57:04.9592 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wJg7/u1Wjghc9XpVviLFR9DVEFNhXs2Smc7RbRBriVFbjKRYpLW/9Dsn5DkaS3MMiz99Oh2jlK4UHEFjpsAHRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2755 X-Proofpoint-ORIG-GUID: 1K4nwQ5vki83jZpzsAbywcyUOWc6p_9s X-Proofpoint-GUID: 1K4nwQ5vki83jZpzsAbywcyUOWc6p_9s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-07_01,2021-10-07_02,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] Re: [RFC 0/7] make rte_intr_handle internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen Thanks for your suggestion on RTE_ETH_DEV_INTR_RXQ . Please see my comments inline. > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, October 5, 2021 9:38 PM > To: Harman Kalra > Cc: dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [RFC 0/7] make rte_intr_handle internal >=20 > External Email >=20 > ---------------------------------------------------------------------- > On Thu, 26 Aug 2021 20:27:19 +0530 > Harman Kalra wrote: >=20 > > This series makes struct rte_intr_handle totally opaque to the outside > > world by wrapping it inside a .c file and providing get set wrapper > > APIs to read or manipulate its fields.. Any changes to be made to any > > of the fields should be done via these get set APIs. > > Introduced a new eal_common_interrupts.c where all these APIs are > > defined and also hides struct rte_intr_handle definition. >=20 > I agree rte_intr_handle and eth_devices structure needs to be hidden. > But there does not appear to be an API to check if device supports receiv= e > interrupt mode. >=20 > There is: > RTE_ETH_DEV_INTR_LSC - link state > RTE_ETH_DEV_INTR_RMV - interrupt on removal >=20 > but no > RTE_ETH_DEV_INTR_RXQ - device supports rxq interrupt >=20 > There should be a new flag reported by devices, and the intr_conf should = be > checked in rte_eth_dev_configure >=20 > Doing this would require fixes many drivers and there is risk of exposing > existing sematic bugs in applications. >=20 >=20 Yes, currently "intr_conf.rxq" is checked by respective drivers which suppo= rts queue interrupts and enable them if set. But driver doesn't expose if they are capable of supporting rxq interrupts,= just like LSC and RMV. RTE_ETH_DEV_INTR_RXQ should be introduces and set by capable drivers in "= dev_info.dev_flags" and applications like l3fwd-power which sets " intr_conf.rxq" should check this flag. I will add this enhancement to my TODO list and will send it as a new serie= s. Thanks Harman > code >=20