From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CBD9A0547; Tue, 19 Oct 2021 20:44:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88CC040142; Tue, 19 Oct 2021 20:44:28 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id E59FE4003E for ; Tue, 19 Oct 2021 20:44:26 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19JGSe5Z025440; Tue, 19 Oct 2021 11:44:23 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2172.outbound.protection.outlook.com [104.47.59.172]) by mx0a-0016f401.pphosted.com with ESMTP id 3bt1jtrmcs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Oct 2021 11:44:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DHcETSTA+jj+d8WyQy18H1vYfmnPtdYyCXaHYVW1IWAGZjsc+OrKgTzDiTmFuOlHxOlY9a2Ag3caaPKgw+TM5KC228FkXVYouQo/k+LDY9fmg+MsEuEkQbjZIsAgGjkkXunPnmnVOV3cHrzdEhjJsRNfS9aIHgEksMlbfALlhePiWmDMfDn6p419qHT14l83anb03QOWcisYBjGFWF94BtOeE26vR029+gB7kQBHCQJH1A9dIR6uQpk+7JuCCh5OaDzoFfTBaFY+6sEEwThLI6SXyWPuz3QU+gaWkdvN6ImyCN8dEA2XPscP64mEl37yIPQ0riDPoYjJuwAAw0uwfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zZfE9LGvycRaroTMqQvhaVrHpGL2m/WOvpkxpw/LVUk=; b=T6qcbe8sCbxc7MJWrKvLqyVuT8cZIAnAnpkbDXr4oqfYUw/w8W/xbsVOmfBiBJnr+wa5oWQg05FQvX3VWnO+r+pFyBUSvv2Rf49JhliomZsK3HsqpvKQBzgYuvIaPzGUOg64dCZlaUFntBnUaQyeVtucNGgiX82AhdpkAPMP41GOdorlqqH8LFKTQJz9Yg2t84doaNN+nUW9kjD0wgNrAlB1CxxMVE+v/wwZHDd9V74pkRti/6p1TnFxKCKfJ77OEk1j4p/6uXCQxnxDWQSHWdLX/+OOxaOtNtUBAssK27Do2rJ8DBaaUMnW9NSvoxFGczmwrGJ/IJAsVkeM86d5eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zZfE9LGvycRaroTMqQvhaVrHpGL2m/WOvpkxpw/LVUk=; b=ptwj2M0Xqrr/QH9zo19FCgnJcN+ogogM092x34qbpHJvKXOxkcbjsTo4U2TKqy+K3LrNCuyk9Ai1ryFxnEHTHoE2jnR6jiYOcGxeRhXLG1ctA1Xi/OjLUdqh+xdYy8YMeq+GhnZTqi4WbwPSBlRwNUYp9pfslO7mNBhscgEEDr0= Received: from BN9PR18MB4204.namprd18.prod.outlook.com (2603:10b6:408:119::18) by BN8PR18MB2531.namprd18.prod.outlook.com (2603:10b6:408:9f::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct 2021 18:44:22 +0000 Received: from BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1]) by BN9PR18MB4204.namprd18.prod.outlook.com ([fe80::29f4:8e3d:264f:26b1%8]) with mapi id 15.20.4628.015; Tue, 19 Oct 2021 18:44:22 +0000 From: Harman Kalra To: Harman Kalra , Dmitry Kozlyuk CC: "dev@dpdk.org" , Thomas Monjalon , Ray Kinsella , "david.marchand@redhat.com" Thread-Topic: [EXT] Re: [PATCH v3 2/7] eal/interrupts: implement get set APIs Thread-Index: AQHXxGKdt5yz0m35OkaI3v43YB1ftqvZUFwAgACvZYCAAKgvsA== Date: Tue, 19 Oct 2021 18:44:21 +0000 Message-ID: References: <20210826145726.102081-1-hkalra@marvell.com> <20211018193707.123559-1-hkalra@marvell.com> <20211018193707.123559-3-hkalra@marvell.com> <20211019010740.232a6d24@sovereign> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ebe0beb2-792d-46e7-33c5-08d993307765 x-ms-traffictypediagnostic: BN8PR18MB2531: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: plnEh0PUeXrCYWPlGTT7q4j7Ihn5DNRleMmwqzmWkh5sx204nwzXni3BdvC4j1G8MNNRvZIpV8G1AUK5sSHrOxgQRvCyIRA7UAVvSHyu7atZNUOV9XBedinyrBG9a4PwdrY0b5uWaQHG66pWX70ihWA3LQ1yZVqpqat34Qbc9RyFL+IfpWIA1+g/FViFJwgp+7+wv854POtc6S0XyZd1Mz1H9t8BBSBzO1/X9d9lcpLL8YlvfB6HAY613qxO59rrEhAN3n1svx4waWRdWItl8AwVc/IZayQe7m8aA3VUtVHSVZlGhE0lFU65LNEecD12r1kuHTzTwnvbtTGtYEd1UZ2u+NBFE+sTV+LaM8k96GSgdHx+dWdXcGDpKCb1wPHJ+NpgnjGSRdZ2fh983mo1xjXUjWV7MfrSU2VDJTuz5xsgg2l3aEixM59M77fRMYJAiaJeDeuROUgULxGkmQWj1IjX+zXPrcss72iJWUutAMwZvDZ2GlRzHg32b2K59j11OROb6wZ72ItWnBXsKqVd7UtN7cJRDABLjxfzoa/YLbaVSMKdSww8idwBVmD6XnkqujAn0g/vnDrhx5cGnPZU9jQxj2qnWdO1H6W74bnsicNzJUZ2GOJeH+51DIuQ2OmT/0UAh3CKAM0MYd2RoZjn2WOKyfD8afJYBdEvDF/f1U8a7rECFlUjqhvj3rj77ugYuX1JwlNOCrlFItPQS2tOCA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR18MB4204.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(5660300002)(110136005)(26005)(33656002)(7696005)(64756008)(53546011)(86362001)(6506007)(508600001)(66946007)(66446008)(66476007)(54906003)(52536014)(122000001)(83380400001)(38070700005)(9686003)(38100700002)(4326008)(316002)(55016002)(66556008)(8936002)(76116006)(186003)(8676002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?G9Iip0H2DWQ4BxCj/Dw2LR9xk0kl+ZkUMw/gaM/+L09lMJiKpFQ1d2hpuo64?= =?us-ascii?Q?1kkbpYTLSN4J1NhmwgXYE/CphM0grEa7+ZGmQMbEaALagPvqNt4xH6Nbqeg9?= =?us-ascii?Q?QpkPbi7YC4G4AE/72L7xrHQa0GPSZ/yYgroJS8ecva+g3EmcG6rQ5gcx9kML?= =?us-ascii?Q?U+39Kj/W86doDQ9VacFhh+FUOUMpNX3+adSRK+BDRzo3I+jv6l4y25yGHiMF?= =?us-ascii?Q?kQC4Lgw8gd/9+scHHosH1/lTXsswIG/miztTpNqPpJIJyoGn7OSdnzuO3Y5M?= =?us-ascii?Q?FYh5nLbFo+wNJhEPJBQo3PiX0Ujtptol3aDVXrXr+dPgbwnVXyDfGpbRKIiW?= =?us-ascii?Q?cXrayvmAZxCgIW6/UP25/G40P1oMbCL2iD7gsrxFXDyuY4ugJb44oUjmNRxu?= =?us-ascii?Q?jAQ5eaoNUtplW0kVXJpNkcqLkaYtuh/w1VzSMvzH7SoyD3xQvX4XiaOcFRP1?= =?us-ascii?Q?erCt1CCsuhRA8EgwpT9Az4Lev9OyZfSGxktVU7CtuFCrlqg5Tf+o2+Tlg5Om?= =?us-ascii?Q?HGZxzMplRV+kiKIR4utyiU7pTFCREkSR+TzUmsX3+OIWPgGjb2gc7y3G9AkZ?= =?us-ascii?Q?O5VUcJrSUm/GK4g7hiFriihWL2aW6Kd8w2FPENioNcVku+yEZwGmgF88ueyZ?= =?us-ascii?Q?vTCpe/yC1Igwk/03geEL4qzlghla/+vraVashGueJNRMaf8WOzz7YwukGGig?= =?us-ascii?Q?d+hInqxvW0kQoSVq2+u8vwzY9u0LKOgPQaOpzicGlpaC1DTWpJS2M/+IFL9Q?= =?us-ascii?Q?MVdTeJZrZLDdYl9pP7Gt3+2Ja4e5TfLvJBreyAE6NLI8TnZu1iG0I8cY+WGo?= =?us-ascii?Q?0/CjxLYX6Fj3jtULlhGy6svexrc47CTcdg7a970v6Az1ZN0AX7FSNSv4OhI8?= =?us-ascii?Q?fWNL8Gt77b15S4ZPTfdyWvQo7dLyazbDQwn0Q03pABKIx3kvD/4VRIBDdkGN?= =?us-ascii?Q?hdYXAdhmc5z9PTTxSzpjx/ipGAZgJCaIF7RXyA/q1mf+AqTNIc9hvZG7VAWM?= =?us-ascii?Q?oJBZT7NYWaCjkrqSkbwiiFx72El2VCJu5LyD2D0katbRfPJiUWNDoM56LrIb?= =?us-ascii?Q?ULbEbG5YTGsNfeUpmqP5QKPLd99ZACAN/hBmQ/Dt20r9i+0aopy0J0Deg8Tx?= =?us-ascii?Q?GUK5eW06VEKp07u79ASFzEpTND1lEhhQJKqXxDEisjJVMBEOCD31Hn/rPAhT?= =?us-ascii?Q?gPY1MBhpcl0y4Vr5aAfda6r3awWtDyRBLXrCaKDKsKge17bP43iTvToe+Vlk?= =?us-ascii?Q?My444OokxguiIJoq8v2g3hHuQ3paZyuqHGOpwo4ws5EF3o0yWMSdkabciKVy?= =?us-ascii?Q?dhfG6nZc7IFc+M3fbHaLvqST?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR18MB4204.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ebe0beb2-792d-46e7-33c5-08d993307765 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 18:44:21.8279 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: taP5G2bL22qnuQ0InewhqyPmvROM2g98rErmdp6C0vWK07Cgh0XWEMmshOWSUP77qfJxC7hlbJJzzjg27ndeyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR18MB2531 X-Proofpoint-GUID: lqapWXMdK8rlsyQFvMHK0xCtA1U1lLGj X-Proofpoint-ORIG-GUID: lqapWXMdK8rlsyQFvMHK0xCtA1U1lLGj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-19_02,2021-10-19_01,2020-04-07_01 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 2/7] eal/interrupts: implement get set APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Harman Kalra > Sent: Tuesday, October 19, 2021 2:21 PM > To: Dmitry Kozlyuk > Cc: dev@dpdk.org; Thomas Monjalon ; Ray Kinsella > ; david.marchand@redhat.com > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 2/7] eal/interrupts: implemen= t > get set APIs >=20 [...] > > > + > > > + nb_intr =3D RTE_MIN(src->nb_intr, intr_handle->nb_intr); > > > > Truncating copy is error-prone. > > It should be either a reallocation (in the future) or an error (now). >=20 > Actually in patch 6, I have made lot of changes to this API wrt nb_intr, = where > efds/elist arrays are reallocated based on src->nb_intr and make > intr_handle->nb_intr equal to src->nb_intr. I think those changes can be > moved from patch 6 to patch 2. Hi Dmitry, I have addressed all your comments in V4, kindly review. Regarding this particular comment, I have not made any changes as I already explained in my previous reply that patch 6 takes care of realloc based on = nb_intr, I thought those changes can be moved from patch 6 to 2, but it's not possib= le because till patch 5, arrays efds, elist are kept as static arrays to avoid build b= reakage. While in patch 6 I made these arrays as pointers and dynamically allocated memory fo= r them. Thanks Harman [...] >=20 > > > > > + memcpy(intr_handle->efds, src->efds, nb_intr);