From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0135.outbound.protection.outlook.com [65.55.169.135]) by dpdk.org (Postfix) with ESMTP id 26F38C51C for ; Wed, 29 Jul 2015 09:44:58 +0200 (CEST) Received: from BY1PR03MB1339.namprd03.prod.outlook.com (10.162.109.21) by BY1PR03MB1340.namprd03.prod.outlook.com (10.162.109.22) with Microsoft SMTP Server (TLS) id 15.1.225.19; Wed, 29 Jul 2015 07:44:56 +0000 Received: from BY1PR03MB1339.namprd03.prod.outlook.com ([10.162.109.21]) by BY1PR03MB1339.namprd03.prod.outlook.com ([10.162.109.21]) with mapi id 15.01.0225.018; Wed, 29 Jul 2015 07:44:55 +0000 From: Xuelin Shi To: "Ananyev, Konstantin" , Thomas Monjalon Thread-Topic: [PATCH v4] enforce rules of the cpu and ixgbe exchange data. Thread-Index: AQHQv5tLCbvfrnx8iUaGvowOOZ9N8p3vbvyAgAAG+wCAAq77wA== Date: Wed, 29 Jul 2015 07:44:55 +0000 Message-ID: References: <1437029134-25191-1-git-send-email-xuelin.shi@freescale.com> <2152064.QkQ5mbgbrx@xps13> <2601191342CEEE43887BDE71AB97725836A68E5D@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725836A68E5D@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none; x-originating-ip: [199.59.226.141] x-microsoft-exchange-diagnostics: 1; BY1PR03MB1340; 5:C5kxG04ToKimGH/hdMn3kzNosU/yw0JwW/KUvIvfwv/M8emvl6A73FKgGZIxsBy9Dplfkp9lYf5pIYUF1YSeQM65c6NZRdFmpejFWy9bLusFo17A0ggwjg9Ne7Jy7Lu4MYZ2g4wID9ykoPyByYhddg==; 24:Ezk+FBwy94axzSnziG+E7b28pg2W4QQTyJz3mB2+pIn8y9oGcHbfSWBa/2x37ng4QRQALyRIAMx/bwwUdyAXIEtVbwEEIWJcdLHQOMeYr5s=; 20:S9WYaOACZ8tmjTFxIzaBglnbJB1zlhnFiGUY7p7ZbMa80MDdTAwfgSXr6l9qB3/Bv7a5Xs3Xsh0HT+d326OeDA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR03MB1340; by1pr03mb1340: X-MS-Exchange-Organization-RulesExecuted x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(5005006)(3002001); SRVR:BY1PR03MB1340; BCL:0; PCL:0; RULEID:; SRVR:BY1PR03MB1340; x-forefront-prvs: 0652EA5565 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(377424004)(51914003)(13464003)(377454003)(2900100001)(54356999)(46102003)(5003600100002)(62966003)(76576001)(50986999)(40100003)(33656002)(19580395003)(5002640100001)(74316001)(2656002)(92566002)(2950100001)(87936001)(102836002)(77156002)(76176999)(106116001)(86362001)(19580405001)(15975445007)(77096005)(5001960100002)(189998001)(66066001); DIR:OUT; SFP:1102; SCL:1; SRVR:BY1PR03MB1340; H:BY1PR03MB1339.namprd03.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2015 07:44:55.8479 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1340 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4] enforce rules of the cpu and ixgbe exchange data. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 07:44:58 -0000 Hi Thomas & Konstantin, Thanks for the review and the comments are addressed by http://www.dpdk.org= /dev/patchwork/patch/6653/ Best Regards, Xuelin Shi > -----Origina Konstantin l Message----- > From: Ananyev, Konstantin [mailto:konstantin.ananyev@intel.com] > Sent: Monday, July 27, 2015 22:43 > To: Thomas Monjalon > Cc: Shi Xuelin-B29237; dev@dpdk.org > Subject: RE: [PATCH v4] enforce rules of the cpu and ixgbe exchange data. >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Monday, July 27, 2015 3:18 PM > > To: Ananyev, Konstantin > > Cc: xuelin.shi@freescale.com; dev@dpdk.org > > Subject: Re: [PATCH v4] enforce rules of the cpu and ixgbe exchange > data. > > > > A quick review of this long pending patch would be great. > > Thanks >=20 > Well, it doesn't compile: >=20 > /local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c: > In function =E2ixgbe_rx_scan_hw_ring=E2: > /local/kananye1/dpdk.org-ixgbevfix2- > tst1/drivers/net/ixgbe/ixgbe_rxtx.c:1114:4: error: implicit declaration > of function =E2rte_le_to_cpu16=E2 [-Werror=3Dimplicit-function-declaratio= n] > pkt_len =3D rte_le_to_cpu16(rxdp[j].wb.upper.length) - > ^ > /local/kananye1/dpdk.org-ixgbevfix2- > tst1/drivers/net/ixgbe/ixgbe_rxtx.c:1114:4: error: nested extern > declaration of =E2rte_le_to_cpu16=E2 [-Werror=3Dnested-externs] >=20 >=20 > Should be rte_le_to_cpu_16(), I believe. >=20 > And checkpatch.pl complains on it: >=20 > WARNING: line over 80 characters > #151: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1133: > + > + rte_le_to_cpu_32(rxdp[j].wb.lower.lo_dword.data)); >=20 > ERROR: code indent should use tabs where possible > #170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147: > +^I^I^I ^I rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$ >=20 > WARNING: please, no space before tabs > #170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147: > +^I^I^I ^I rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$ >=20 > total: 1 errors, 2 warnings, 192 lines checked >=20 > Apart from that, looks harmless :) >=20 > Konstantin >=20 > > > > 2015-07-16 14:45, xuelin.shi@freescale.com: > > > From: Xuelin Shi > > > > > > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) 2. cpu > > > fill data to ixgbe must use rte_cpu_to_le_xx(...) 3. checking pci > > > status with converted constant. > > > > > > Signed-off-by: Xuelin Shi