From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0046.outbound.protection.outlook.com [104.47.36.46]) by dpdk.org (Postfix) with ESMTP id D79F71B297 for ; Thu, 18 Jan 2018 13:54:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=4hqkwWXAMdfbl+34gg77+hR5lFA4ASINLHP4RjyqtCk=; b=nKsP+aPVzw062Q+FNQF34tccctVxKAMrwyxUdD6LTXFW7si9jZW4TscbCqD62B+Ww/Sq1gY3ZnZQSWOhgUk0mPCUBGzC9cmCN6FTRXqihoRu9MrKZkmOYlpBjNHuWOvjP5rGrJc4bfhz0MQnKOc/f8XgOtozFszy2iyrBZzoUOo= Received: from BY1PR0701MB1111.namprd07.prod.outlook.com (10.160.104.21) by CY1PR0701MB1993.namprd07.prod.outlook.com (10.163.141.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.407.7; Thu, 18 Jan 2018 12:54:01 +0000 Received: from BY1PR0701MB1111.namprd07.prod.outlook.com ([fe80::e040:3b79:6671:b66a]) by BY1PR0701MB1111.namprd07.prod.outlook.com ([fe80::e040:3b79:6671:b66a%14]) with mapi id 15.20.0407.012; Thu, 18 Jan 2018 12:53:59 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , "dev@dpdk.org" CC: "Challa, Mahipal" , "Athreya, Narayana Prasad" , "pablo.de.lara.guarch@intel.com" , "Gupta, Ashish" , "Sahu, Sunila" , "Jain, Deepak K" , Hemant Agrawal , Roy Pledge , Youri Querry , Ahmed Mansour Thread-Topic: [RFC v3 1/1] lib: add compressdev API Thread-Index: AQHTdc0Olvrvx8Spo02l2PHMHF7TgqN5vSMg Date: Thu, 18 Jan 2018 12:53:58 +0000 Message-ID: References: <1511542566-10455-1-git-send-email-fiona.trahe@intel.com> <1513360153-15036-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: <1513360153-15036-1-git-send-email-fiona.trahe@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; CY1PR0701MB1993; 7:uG3+nGPCkdMNPHuxqJ460/u2En4i8X4lBVF+rR8m6ubUS2VOnUQ6bK3w67CEUFenuttpy10m1jvMVqRoA2l+x5YjvybR6aE0o8Mk7heZWAhMTVM2fqttYvsYDyj75hQdZ/0IzrNUqrVkKFd62hh/mrvI5eiv4dds66kiXBj+jSbtVLhm9x+n9LySgdWFaQlVXWm69GcstDMkYsN3UJP5+Wo3EzguLyfreXN4mYH2kRpYvrIJlgYkkbd1L0d6yPQP x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(376002)(39860400002)(39380400002)(189003)(199004)(13464003)(316002)(66066001)(2501003)(81166006)(2900100001)(55016002)(5250100002)(5660300001)(8936002)(54906003)(8676002)(81156014)(9686003)(8656006)(6246003)(74316002)(6436002)(97736004)(3280700002)(3660700001)(110136005)(7736002)(229853002)(305945005)(68736007)(53546011)(14454004)(6506007)(33656002)(59450400001)(55236004)(4326008)(106356001)(2906002)(25786009)(76176011)(7696005)(102836004)(99286004)(105586002)(86362001)(72206003)(53936002)(26005)(3846002)(6116002)(2950100002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1993; H:BY1PR0701MB1111.namprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-correlation-id: c000618b-ccc9-42be-c8a9-08d55e728ae7 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534125)(4602075)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:CY1PR0701MB1993; x-ms-traffictypediagnostic: CY1PR0701MB1993: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231023)(2400061)(944501161)(3002001)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:CY1PR0701MB1993; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:CY1PR0701MB1993; x-forefront-prvs: 05568D1FF7 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: u6POFKe+fm1V52w8UgTOT/F/lX4XEoaS93uYXbhYTvlAiR00zm4wmLNAjO+inpQsFr1X18Gokh3OR+fmSH753A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: c000618b-ccc9-42be-c8a9-08d55e728ae7 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2018 12:53:59.0334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1993 Subject: Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jan 2018 12:54:05 -0000 Hi Fiona=20 While revisiting this, we identified few questions and additions. Please se= e them inline. > -----Original Message----- > From: Trahe, Fiona [mailto:fiona.trahe@intel.com] > Sent: 15 December 2017 23:19 > To: dev@dpdk.org; Verma, Shally > Cc: Challa, Mahipal ; Athreya, Narayana > Prasad ; > pablo.de.lara.guarch@intel.com; fiona.trahe@intel.com > Subject: [RFC v3 1/1] lib: add compressdev API >=20 > Signed-off-by: Trahe, Fiona > --- //snip > + > +int > +rte_compressdev_queue_pair_setup(uint8_t dev_id, uint16_t > queue_pair_id, > + uint32_t max_inflight_ops, int socket_id) [Shally] Is max_inflights_ops different from nb_streams_per_qp in struct rt= e_compressdev_info?=20 I assume they both carry same purpose. If yes, then it will be better to us= e single naming convention to avoid confusion. Also, is it optional API? Like Is this a valid use case?: dev_configure() --> dev_start() --> qp_start() --> enqueue/dequeue() --> qp= _stop() --> dev_stop() --> dev_close()? //snip > + > +#define RTE_COMPRESSDEV_PMD_NAME_ARG > ("name") > +#define RTE_COMPRESSDEV_PMD_MAX_NB_QP_ARG > ("max_nb_queue_pairs") > +#define RTE_COMPRESSDEV_PMD_SOCKET_ID_ARG ("socket_id") > + [Shally] Need to define argument macro for max_nb_session_per_qp and max_nb= _streams_per_qp as well > + > +static const char * const compressdev_pmd_valid_params[] =3D { > + RTE_COMPRESSDEV_PMD_NAME_ARG, > + RTE_COMPRESSDEV_PMD_MAX_NB_QP_ARG, > + RTE_COMPRESSDEV_PMD_SOCKET_ID_ARG > +}; [Shally] Likewise, array need to be updated with other mentioned two argume= nts > + > +/** > + * @internal > + * Initialisation parameters for comp devices > + */ > +struct rte_compressdev_pmd_init_params { > + char name[RTE_COMPRESSDEV_NAME_MAX_LEN]; > + size_t private_data_size; > + int socket_id; > + unsigned int max_nb_queue_pairs; [Shally] And this also need to be updated with max_nb_sessions_per_qp and m= ax_streams_per_qp=20 //snip Thanks Shally