From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0102.outbound.protection.outlook.com [207.46.100.102]) by dpdk.org (Postfix) with ESMTP id 3F6AC5586 for ; Sat, 7 May 2016 02:14:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qlgc.onmicrosoft.com; s=selector1-qlogic-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=wV/B2K1ONnCnY9+EtUd1FeoOkOA1HIFHhZtNlZbu064=; b=CU7SnWvoDkzLlCk70WuA/yoLz2OTQ6ASejRCxCPK/L2lg/razYKrPR2j3UFkXGUoNkWHvMjqqIZ6nRkIN0L82kDfcNDYGU78PFhVtYvPBi94xOAnRn8wOGqqYOqC0J//enIHK8+Hg2F9ii3Ml5nBkrgloxaf4MOsGODFRDhSqro= Received: from BY1PR11MB0151.namprd11.prod.outlook.com (10.160.202.149) by SN1PR11MB0909.namprd11.prod.outlook.com (10.164.25.27) with Microsoft SMTP Server (TLS) id 15.1.485.9; Sat, 7 May 2016 00:14:23 +0000 Received: from BY1PR11MB0151.namprd11.prod.outlook.com ([10.160.202.149]) by BY1PR11MB0151.namprd11.prod.outlook.com ([10.160.202.149]) with mapi id 15.01.0485.011; Sat, 7 May 2016 00:14:23 +0000 From: Rasesh Mody To: Bruce Richardson CC: "dev@dpdk.org" , Dept-Eng DPDK Dev , Harish Patil Thread-Topic: [dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get Thread-Index: AQHRpcc4T4Rr/LevbEqUNLtcC1tx5Z+sAMaAgACd8zA= Date: Sat, 7 May 2016 00:14:23 +0000 Message-ID: References: <1462340302-25683-1-git-send-email-rasesh.mody@qlogic.com> <1462340302-25683-2-git-send-email-rasesh.mody@qlogic.com> <20160506144709.GC8880@bricha3-MOBL3> In-Reply-To: <20160506144709.GC8880@bricha3-MOBL3> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=qlogic.com; x-originating-ip: [2601:646:8104:7df0:add7:a8a9:f571:b6ce] x-ms-office365-filtering-correlation-id: a0eac9f1-e539-4177-895f-08d3760c8b40 x-microsoft-exchange-diagnostics: 1; SN1PR11MB0909; 5:yXmifEbk9+fJ74NEtMt8ibCag7luNqecXITqrV5h0a0gl7XV4T+145ITgsoYIBHIfG5m3FpVCAzv4ilFTQNUJpr3rDBkVvItBOMW4NvVxocP6BdLEuPL9xWMXivY/C43SbNoEmIHI6IlqVA9iY6mew==; 24:M61wa3cX8/gFJ0AQ7coinVYm30VxSQ66HfNlMjbSYwSYGMb0Te3/4/6vNEgNgxs/QlYaScGt4H1RBrzsE9a1MVE+PMQM6kU7OZF2QnVW2l0=; 7:sOzAq9z8kNTP/HfUDD765reob8RNIFW+KkyJ+K8ktbPAGJUtncufPGKQWgB3ajKZv4SPiAEhNEKsMH2r7QcLf2JiM9mzD4XxSXCRyfSXNSledXTD5HOqr6lAJG1sElpW9mguIkU8wgSUBx71WKC6wu7dn3yMx9cYkIZ/52wZBYgqV/7Xp3YnesToZtePnKrC; 20:yGCOcv/41McvrF3tuneomOQyC01VgrajTf5o16H6Qks5k/7zNKv62BcIBcx/XQ81eKaR+gOT8zi2aEj4QkbnbKzZceIgMEiqNvvz8ahM5ItBKAyDhXx2+WxiBxlSHFq7W0hGIszqvQqQ3X4lbw9fhIWN+IGumd6tcO8dvebjkrg= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR11MB0909; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:SN1PR11MB0909; BCL:0; PCL:0; RULEID:; SRVR:SN1PR11MB0909; x-forefront-prvs: 09352FD734 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(24454002)(377454003)(1220700001)(86362001)(102836003)(122556002)(33656002)(4001430100002)(6116002)(92566002)(2950100001)(2900100001)(586003)(5008740100001)(5002640100001)(74316001)(5003600100002)(77096005)(87936001)(3280700002)(110136002)(107886002)(2906002)(189998001)(76176999)(11100500001)(54356999)(4326007)(9686002)(50986999)(8936002)(3660700001)(81166005)(10400500002)(106116001)(5004730100002)(99286002)(19580395003)(76576001)(3826002); DIR:OUT; SFP:1102; SCL:1; SRVR:SN1PR11MB0909; H:BY1PR11MB0151.namprd11.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: qlogic.com X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2016 00:14:23.4663 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 0d68a1f9-1490-4d0e-8767-a87dab3ef2ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR11MB0909 Subject: Re: [dpdk-dev] [PATCH v4 2/3] bnx2x: enhance stats get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2016 00:14:26 -0000 > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > Sent: Friday, May 06, 2016 7:47 AM >=20 > On Tue, May 03, 2016 at 10:38:21PM -0700, Rasesh Mody wrote: > > Enhance the stats_get() routine to display drop counters under imissed > > counter. > > Added extended stats get support to provide additional info. > > Encorporated review comment to rename some of the stats. > > > > Signed-off-by: Rasesh Mody > > Signed-off-by: Harish Patil >=20 > Again this seems to me like it should be two patches rather than one. A f= irst > patch as a fix for the drop counters and then a second patch to add the x= stats > functionality. > > Regards, > /Bruce We shall split this patch into an enhancement and a bug fix. =20 Thanks! Rasesh