> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Wednesday, April 23, 2025 9:01 PM
> To: edwin.brossette@6wind.com
> Cc: dev@dpdk.org; olivier.matz@6wind.com; didier.pallard@6wind.com;
> lauren.hardy@6wind.com; Devendra Singh Rawat
> <dsinghrawat@marvell.com>; Alok Prasad <palok@marvell.com>;
> stable@dpdk.org
> Subject: [EXTERNAL] Re: [PATCH 2/5] net/qede: fix bad sanity check on Rx
> queue release
> 
> On Tue, 22 Apr 2025 17: 51: 40 +0200 edwin. brossette@ 6wind. com wrote: >
> From: Edwin Brossette <edwin. brossette@ 6wind. com> > > As per the rte_mbuf
> API: the driver is responsible of initializing all > the required fields. This
> ZjQcmQRYFpfptBannerStart Prioritize security for external emails:
> Confirm sender and content safety before clicking links or opening attachments
> <https://us-phishalarm-
> ewt.proofpoint.com/EWT/v1/CRVmXkqW!tO3Z1f8UAnVatG-
> 9ub1azhlXOoqqvdVa2NGs146PaCzt5I1OZmqvjWYIEBzLlqf3wHpb0a3UlSO8Py2t
> m0U$>
> Report Suspicious
> 
> ZjQcmQRYFpfptBannerEnd
> On Tue, 22 Apr 2025 17:51:40 +0200
> edwin.brossette@6wind.com wrote:
> 
> > From: Edwin Brossette <edwin.brossette@6wind.com>
> >
> > As per the rte_mbuf API: the driver is responsible of initializing all
> > the required fields. This is not done at qede alloc, meaning there can
> > be garbage data in mbufs memory, although this garbage data should be
> > overwritten when the mbufs are used. Since a sanity check is done when
> > freeing the queues, its possible some remaining garbage data causes a
> > panic when trying to release the queues if some mbufs are being
> > processed.
> >
> > Use rte_pktmbuf_raw_free() instead of rte_pktmbuf_free() as the sanity
> > check is more relaxed.
> >
> > Fixes: 2ea6f76aff40 ("qede: add core driver")
> > CC: stable@dpdk.org
> 
> Patch looks fine, but DPDK is trying to follow the inclusive naming guidelines.
> The term "sanity check" is on the not allowed list.
> 
> I will reword the commit message.

I will wait for next version with this fix.

@Devendra Singh Rawat @Alok Prasad Please review this series. I am planning to merge next version in next week.




> 
> https://urldefense.proofpoint.com/v2/url?u=https-
>3A__inclusivenaming.org_word-2Dlists_tier-2D2_sanity-
> 2Dcheck_&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=1DGob4H4rxz6H8uIToz
> GOCa0s5f4wCNtTa4UUKvcsvI&m=LCVRTeR2PgdHSbOJP9MjCM9h0sZ_33FUs4ox
> nlqJOIWbNhI01OIvorgdTnNQJtrZ&s=zsvx54N2PbMxHZ7Y_zO1uP_QviEQoQDcv
> 0Iak-rJzEk&e=